[{"id":30501,"web_url":"https://patchwork.libcamera.org/comment/30501/","msgid":"<87o76fc911.fsf@redhat.com>","date":"2024-07-30T13:19:06","subject":"Re: [PATCH v2 0/3] Fix misleading error messages","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Milan Zamazal writes:\n\n> At least with software ISP, \"errors\" that have actually no influence on\n> regular libcamera operation may be reported. This is confusing for\n> users, especially in cases when there are other, real errors. Let's improve the given log messages a bit.\n>\n> Changes in v2:\n> - The order of the patches swapped, to put the easier change first.\n> - An empty line, as requested by Laurent, added.\n> - Added a trivial patch to unify the IPAProxy::configurationFile argument\n> name in the declaration and definition.\n> - Added a new optional argument to IPAProxy::configurationFile for a\n> fallback file, which solves the error/warning problem there.\n\nOK or is there a better suggestion?\n\n> Milan Zamazal (3):\n> libcamera: simple: Log a missing sensor in a better way\n> libcamera: ipa_proxy: Unify configurationFile argument name\n> libcamera: ipa_proxy: Report a missing configuration as a warning\n>\n> include/libcamera/internal/ipa_proxy.h | 4 +++-\n> src/libcamera/ipa_proxy.cpp | 22 +++++++++++++++++----\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 5 ++---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++-------\n> src/libcamera/pipeline/simple/simple.cpp | 4 +++-\n> src/libcamera/software_isp/software_isp.cpp | 5 ++---\n> 6 files changed, 30 insertions(+), 19 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8F5EC323E\n\tfor ;\n\tTue, 30 Jul 2024 13:19:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9D43263374;\n\tTue, 30 Jul 2024 15:19:14 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0357E61994\n\tfor ;\n\tTue, 30 Jul 2024 15:19:12 +0200 (CEST)","from mail-wr1-f69.google.com (mail-wr1-f69.google.com\n\t[209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-314-WoDEqhvXNz2vpuVejz-7Iw-1; Tue, 30 Jul 2024 09:19:09 -0400","by mail-wr1-f69.google.com with SMTP id\n\tffacd0b85a97d-3685e0df024so2318845f8f.0\n\tfor ;\n\tTue, 30 Jul 2024 06:19:09 -0700 (PDT)","from nuthatch (nat-pool-brq-t.redhat.com. [213.175.37.10])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-36b367fc39esm14697367f8f.50.2024.07.30.06.19.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 30 Jul 2024 06:19:06 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"PbNfHgVV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1722345551;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=VAkuZty8NMc4WJa7Tt+eoi5qUX0LnhvDUWjZENrO4xY=;\n\tb=PbNfHgVVxPWWSilE6ZCukSFyLQc/ZWat/Ts5Z2LfPQNS1J4br3QplQh1Bf0Ln4puIVm2De\n\tVeJ38LgMnQtgsyPAREmg4rpyA1/e1poG+QA9GAaJDk9wl/JHwHtPO830F5LIJAn95WLUaA\n\tuj4QsdRrzyvz1tE0TKwXXEjEIXjkzjQ=","X-MC-Unique":"WoDEqhvXNz2vpuVejz-7Iw-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1722345548; x=1722950348;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=VAkuZty8NMc4WJa7Tt+eoi5qUX0LnhvDUWjZENrO4xY=;\n\tb=UbuSMkc7hUZhhUNnObVnZPatf5zXj53t+XHCISyMpUN41hJYPJx+zfEuoDwWJnHDGs\n\tZ2oLJRfcEaDYVJGYV4kkZ+N8DE6ixdbwIJSptOsmtFSPoJLGcQvCyHjnTbkn9y2XV/Lb\n\t7RH4GafI5Lob2RE+TGj9LYEMzc9nErNrzyQAxO555t8PysH9ncLmgE2dFxeyAOSoO39Q\n\tCcP0Quj6dPcqC1Zs7XN63cFxy3m6wJBUTpPIXEuwhGnerWJT9381pSIews7fx4gGBaa1\n\tHDdQikEYUZ/ss80cFMg8I1By3iUHtENA302AX79HJzmB2aVJ5P8b0BqObHx0jSfbjv1Q\n\tdh5Q==","X-Gm-Message-State":"AOJu0YwXEM1srZP56IyuQyc3Y6u4RIni78s1DXdqQLJTLv0aGX47sC8R\n\thEz+f8tNUkXGf5TN7GB9eZPqBb19ji/FqquapAK96rITtPf2fBe+HkSEloZxjABzHq7RDWti+mu\n\t9xwxtnR/I2PnLNrucmQVX4d/I9CzIRp4E64lmGTlwMzTQEARtKeFSnQp7JRa+nwE6sbRPlInaFb\n\tlB/UY=","X-Received":["by 2002:a5d:5501:0:b0:368:3895:67d6 with SMTP id\n\tffacd0b85a97d-36b5cee1f55mr8285793f8f.20.1722345547987; \n\tTue, 30 Jul 2024 06:19:07 -0700 (PDT)","by 2002:a5d:5501:0:b0:368:3895:67d6 with SMTP id\n\tffacd0b85a97d-36b5cee1f55mr8285775f8f.20.1722345547604; \n\tTue, 30 Jul 2024 06:19:07 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IGk5ObsE4uin2iM5+G4iJF5PjzfQBvBkMffF++rTC4ymIYmxGF2EZEtk/+qj+JOJeOtUuaBnA==","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Kieran Bingham , Laurent Pinchart\n\t","Subject":"Re: [PATCH v2 0/3] Fix misleading error messages","In-Reply-To":"<20240708123803.1006689-1-mzamazal@redhat.com> (Milan Zamazal's\n\tmessage of \"Mon, 8 Jul 2024 14:38:00 +0200\")","References":"<20240708123803.1006689-1-mzamazal@redhat.com>","Date":"Tue, 30 Jul 2024 15:19:06 +0200","Message-ID":"<87o76fc911.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]