{"id":20378,"url":"https://patchwork.libcamera.org/api/covers/20378/?format=json","web_url":"https://patchwork.libcamera.org/cover/20378/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240625062327.50940-1-umang.jain@ideasonboard.com>","date":"2024-06-25T06:23:23","name":"[v3,0/4] libcamera: rkisp1: Plumb the ConverterDW100 converter","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/20378/mbox/","series":[{"id":4414,"url":"https://patchwork.libcamera.org/api/series/4414/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4414","date":"2024-06-25T06:23:23","name":"libcamera: rkisp1: Plumb the ConverterDW100 converter","version":3,"mbox":"https://patchwork.libcamera.org/series/4414/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/20378/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5F47CBD87C\n\tfor ;\n\tTue, 25 Jun 2024 06:23:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0C836654AC;\n\tTue, 25 Jun 2024 08:23:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5B0FF619D5\n\tfor ;\n\tTue, 25 Jun 2024 08:23:33 +0200 (CEST)","from fedora.local (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 516E9BEB;\n\tTue, 25 Jun 2024 08:23:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"F50Pgwcw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719296591;\n\tbh=1uh8XZRIiTndbQ+FIYK646lpPhc2waUlHf85Iu33oeE=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=F50PgwcwBAvpjpbKBlOz+Q+HaIaemhpL/rp6HGDBn722K8rLKv+CwhgCZhDusVx+C\n\tKToNv1RyQPGOi9BGY6GMyXbhO8j9/I0PNwzZyS4TGxkXaNXXWgJFgGTjwHkNNZtlxL\n\tqZnI4n78EQFN/V7B+a/gw/bhXp8H0tczsEHDlrk4=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"Umang Jain ","Subject":"[PATCH v3 0/4] libcamera: rkisp1: Plumb the ConverterDW100 converter","Date":"Tue, 25 Jun 2024 11:53:23 +0530","Message-ID":"<20240625062327.50940-1-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.44.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This series intends to support i.MX8MP DW100 dewarper in rkisp1 pipeline\nhandler. It is modelled as Converter (inherited from V4L2M2MConverter)\nand has a helper to support scaler crop control. The converter acts\nas a base for now, additional development around dewarping capabilites\nand support in simple pipeline-handler [1] can be added on top as\nfocused tasks.\n\nPatch 1/4 prepares the rkisp1 pipeline handler to register controls\nfor the camera, outside of the IPA. The ConverterDW100 will let us support\nscaler crop - which will be registered as one of the camera controls.\n\nPatch 2/4 is also a prepartory patch to accept scaler crop rectangles\nfor the converter_v4l2_m2m on each stream.\n\nPatch 3/4 adds a ConverterDW100 class inheriting from\nconverter_v4l2_m2m. This provides a scaler crop setting helper.\n\nPatch 4/4 finally plumbs the ConverterDW100 in the rkisp1 pipeline handler.\nIf the scaler crop control is found set in the request, it is applied\non the dewarper.\n\nThis series is based on top of [2]\n\nTesting:\n--------\nThe series is tested on i.MX8MP and cam utility, by setting scaler crop\ncontrol via capture script with IMX283 attached to isp0.\n\nChanges in v3:\n- Base on top of [2]\n- Model dewarper class as converter, so can be used with Simple\n pipeline-handler/ISI\n\nChanges in v2:\n- Fix raw capture configuration, disable dewarper in that case\n\n[1]: Supporting the ConverterDW100 is simple pipeline handler should be\neasy, adding the compatibles string and registering the converter with\nREGISTER_CONVERTER(). However, for testing the\ni.MX8MP -> ISI -> ConverterDW100 (dewarper) requires me to have a YUV\nsensor attached, which I have not abled to source it yet. Once I source\nit, I will test the ConverterDW100 on simple pipeline handler (I don't\nexpect any issues there but still..) and prepare a integration patch.\nI hope this doesn't act as blocker for the series.\n\n[2] [PATCH v4 0/4] libcamera: converter: Replace usage of stream index by Stream pointer\n\nUmang Jain (4):\n libcamera: rkisp1: Prepare for additional camera controls\n libcamera: converter_v4l2_m2m: Support crop selection\n libcamera: converter: Add DW100 converter class\n libcamera: rkisp1: Plumb the ConverterDW100 converter\n\n .../internal/converter/converter_dw100.h | 26 +++\n .../internal/converter/converter_v4l2_m2m.h | 5 +\n .../libcamera/internal/converter/meson.build | 1 +\n src/libcamera/converter/converter_dw100.cpp | 56 ++++++\n .../converter/converter_v4l2_m2m.cpp | 27 +++\n src/libcamera/converter/meson.build | 1 +\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 171 +++++++++++++++++-\n src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 12 +-\n src/libcamera/pipeline/rkisp1/rkisp1_path.h | 14 ++\n 9 files changed, 302 insertions(+), 11 deletions(-)\n create mode 100644 include/libcamera/internal/converter/converter_dw100.h\n create mode 100644 src/libcamera/converter/converter_dw100.cpp"}