[{"id":30066,"web_url":"https://patchwork.libcamera.org/comment/30066/","msgid":"","date":"2024-06-25T06:27:48","subject":"Re: [PATCH v4 0/4] libcamera: converter: Replace usage of stream\n\tindex by Stream pointer","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hello,\n\nThe v3 of the series was tested by Andrei for SoftISP (and myself as well)\n\ngit-pw didn't collect the T-b tag (probably because it was sent against \nthe cover letter) so for records..\n\nTested-by: Andrei Konovalov # sm8250 RB5\n\nOn 24/06/24 7:18 pm, Umang Jain wrote:\n> The v4l2_converter_m2m and simple pipeline handler are adapt to\n> use the new interface. This work roped in software ISP as well,\n> which also seems to use indexes (although it doesn't implement converter\n> interface) because of a common conversionQueue_ queue used for\n> converter_ and swIsp_.\n>\n> Patch 1/4 and 2/4 drop redundant validation of outputs std::map<>.\n>\n> Patch 3/4 renames private class V4L2M2MConverter::Stream to\n> V4L2M2Mconverter::V4L2M2MStream\n>\n> Patch 4/4 replaces the stream index usage from converter interface and\n> soft isp.\n>\n> ---\n> Tested with mxc-isi running software isp on i.MX8MP platform\n> ---\n>\n> changes in v4:\n> - Emplace V4L2M2MStream stream only after configure() succeeds.\n> (trivial shuffle of ordering of the call).\n> - Collect R-b tags\n>\n> Changes in v3:\n> - Fix issue while running soft-isp\n> - Fix missing Doxygen changes\n>\n> changes in v2:\n> - Split out patches 1/4 and 2/4 to tackle validation/sanity check\n> - Rename V4L2M2MConverter::Stream to V4L2M2Mconverter::V4L2M2MStream\n>\n> Umang Jain (4):\n> converter: converter_v4l2_m2m: Rectify streams sanity check\n> libcamera: software_isp: Drop unnecessary sanity check\n> converter: converter_v4l2_m2m: Rename private Stream class\n> libcamera: converter: Replace usage of stream index by Stream pointer\n>\n> include/libcamera/internal/converter.h | 5 +-\n> .../internal/converter/converter_v4l2_m2m.h | 13 +--\n> .../internal/software_isp/software_isp.h | 5 +-\n> src/libcamera/converter.cpp | 6 +-\n> .../converter/converter_v4l2_m2m.cpp | 79 ++++++++++---------\n> src/libcamera/pipeline/simple/simple.cpp | 14 ++--\n> src/libcamera/software_isp/software_isp.cpp | 26 +++---\n> 7 files changed, 73 insertions(+), 75 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F190DBDB1D\n\tfor ;\n\tTue, 25 Jun 2024 06:27:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 18402654AB;\n\tTue, 25 Jun 2024 08:27:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7DA04619D5\n\tfor ;\n\tTue, 25 Jun 2024 08:27:53 +0200 (CEST)","from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CC02BBEB\n\tfor ;\n\tTue, 25 Jun 2024 08:27:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uBKs35yF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719296851;\n\tbh=0o3OMuUPScjUAnZ43bR6jnEKuqIqo6KktuY+uFGj4VU=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=uBKs35yF0lm+lY2MKDSnTKMnuQGds+ZWgksb5i2dytlOoTbDhRlZ0e1JsemRP0Iqs\n\tkFEIJ8uMXoogvnbSBWf6ysnU7gZ+jfft2pFl2fkhxMvmnPi+mGN+z2T9xSY+rJHvYw\n\tlHnTFW+Xc/TYB88jCpldLQ+rRZB2aZ2t8obT7dNg=","Message-ID":"","Date":"Tue, 25 Jun 2024 11:57:48 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v4 0/4] libcamera: converter: Replace usage of stream\n\tindex by Stream pointer","To":"libcamera-devel@lists.libcamera.org","References":"<20240624134859.171969-1-umang.jain@ideasonboard.com>","Content-Language":"en-US","From":"Umang Jain ","In-Reply-To":"<20240624134859.171969-1-umang.jain@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]