{"id":20362,"url":"https://patchwork.libcamera.org/api/covers/20362/?format=json","web_url":"https://patchwork.libcamera.org/cover/20362/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240624134859.171969-1-umang.jain@ideasonboard.com>","date":"2024-06-24T13:48:55","name":"[v4,0/4] libcamera: converter: Replace usage of stream index by Stream pointer","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/20362/mbox/","series":[{"id":4412,"url":"https://patchwork.libcamera.org/api/series/4412/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4412","date":"2024-06-24T13:48:55","name":"libcamera: converter: Replace usage of stream index by Stream pointer","version":4,"mbox":"https://patchwork.libcamera.org/series/4412/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/20362/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 95DB1BD87C\n\tfor ;\n\tMon, 24 Jun 2024 13:49:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6CE8B654AA;\n\tMon, 24 Jun 2024 15:49:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0CD45654A1\n\tfor ;\n\tMon, 24 Jun 2024 15:49:14 +0200 (CEST)","from fedora.local (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 758917E0;\n\tMon, 24 Jun 2024 15:48:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"X/+8DFre\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719236932;\n\tbh=a2AtqDOSGSRlihyt38xMu0ak6m3Y447vB4UuVHMistY=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=X/+8DFreuuSQ2X7VCusAV1VgR7HgbTjXvvmm2DH7x+NfO9gGTl3oOS8JYTXxOCQGK\n\tDR8timB5TBbePozesF9kOAKe3kxhi749BKGCrJy6vznqN25+TnFpJkl5mq6PFH7Xil\n\tI5GskC9PbJsAxDqfx+C5PRHYJBm7+pnpVcWzocwo=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"Umang Jain ","Subject":"[PATCH v4 0/4] libcamera: converter: Replace usage of stream index\n\tby Stream pointer","Date":"Mon, 24 Jun 2024 19:18:55 +0530","Message-ID":"<20240624134859.171969-1-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.44.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The v4l2_converter_m2m and simple pipeline handler are adapt to\nuse the new interface. This work roped in software ISP as well,\nwhich also seems to use indexes (although it doesn't implement converter\ninterface) because of a common conversionQueue_ queue used for\nconverter_ and swIsp_.\n\nPatch 1/4 and 2/4 drop redundant validation of outputs std::map<>.\n\nPatch 3/4 renames private class V4L2M2MConverter::Stream to\nV4L2M2Mconverter::V4L2M2MStream\n\nPatch 4/4 replaces the stream index usage from converter interface and\nsoft isp.\n\n---\nTested with mxc-isi running software isp on i.MX8MP platform\n---\n\nchanges in v4:\n- Emplace V4L2M2MStream stream only after configure() succeeds.\n (trivial shuffle of ordering of the call).\n- Collect R-b tags\n\nChanges in v3:\n- Fix issue while running soft-isp\n- Fix missing Doxygen changes\n\nchanges in v2:\n- Split out patches 1/4 and 2/4 to tackle validation/sanity check\n- Rename V4L2M2MConverter::Stream to V4L2M2Mconverter::V4L2M2MStream\n\nUmang Jain (4):\n converter: converter_v4l2_m2m: Rectify streams sanity check\n libcamera: software_isp: Drop unnecessary sanity check\n converter: converter_v4l2_m2m: Rename private Stream class\n libcamera: converter: Replace usage of stream index by Stream pointer\n\n include/libcamera/internal/converter.h | 5 +-\n .../internal/converter/converter_v4l2_m2m.h | 13 +--\n .../internal/software_isp/software_isp.h | 5 +-\n src/libcamera/converter.cpp | 6 +-\n .../converter/converter_v4l2_m2m.cpp | 79 ++++++++++---------\n src/libcamera/pipeline/simple/simple.cpp | 14 ++--\n src/libcamera/software_isp/software_isp.cpp | 26 +++---\n 7 files changed, 73 insertions(+), 75 deletions(-)"}