{"id":20187,"url":"https://patchwork.libcamera.org/api/covers/20187/?format=json","web_url":"https://patchwork.libcamera.org/cover/20187/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240603111259.54321-1-hdegoede@redhat.com>","date":"2024-06-03T11:12:56","name":"[v3,0/3] libcamera: dma_buffer_allocator: Add support for using udmabuf to alloc dma-buffers","submitter":{"id":102,"url":"https://patchwork.libcamera.org/api/people/102/?format=json","name":"Hans de Goede","email":"hdegoede@redhat.com"},"mbox":"https://patchwork.libcamera.org/cover/20187/mbox/","series":[{"id":4352,"url":"https://patchwork.libcamera.org/api/series/4352/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4352","date":"2024-06-03T11:12:56","name":"libcamera: dma_buffer_allocator: Add support for using udmabuf to alloc dma-buffers","version":3,"mbox":"https://patchwork.libcamera.org/series/4352/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/20187/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9B900BD87C\n\tfor ;\n\tMon, 3 Jun 2024 11:13:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 53A88634B2;\n\tMon, 3 Jun 2024 13:13:06 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 299FE61A3B\n\tfor ;\n\tMon, 3 Jun 2024 13:13:04 +0200 (CEST)","from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-413-rM0mOmPJOm2dX5zuTxKm5g-1;\n\tMon, 03 Jun 2024 07:13:01 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5CE961C0512B\n\tfor ;\n\tMon, 3 Jun 2024 11:13:01 +0000 (UTC)","from x1.localdomain.com (unknown [10.39.193.39])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id A5CEE28E3;\n\tMon, 3 Jun 2024 11:13:00 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"V/o69XQs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1717413183;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=z+rguGAvFAMsef6YUaV+Q/8DonQY95ApezL9ucuCKS8=;\n\tb=V/o69XQswvviRsfsth9o/54ucgSWAv2M6ajTqKvM13exXMoV1XdThICgluYeyNLoDFVvet\n\tFGzF4dK/r1sc36GL3oe3IljgO4xewznoz42Ioaf+9mKPFxU6fPJgPuZA0lhQV/Gzgc8muE\n\t7FoO6mSWsyXfwdgPOS194z7HA7N1LGw=","X-MC-Unique":"rM0mOmPJOm2dX5zuTxKm5g-1","From":"Hans de Goede ","To":"libcamera-devel@lists.libcamera.org","Cc":"Maxime Ripard , Milan Zamazal , \n\tHans de Goede ","Subject":"[PATCH v3 0/3] libcamera: dma_buffer_allocator: Add support for\n\tusing udmabuf to alloc dma-buffers","Date":"Mon, 3 Jun 2024 13:12:56 +0200","Message-ID":"<20240603111259.54321-1-hdegoede@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.11.54.5","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi All,\n\nHere is v3 of my patch-series to add /dev/udmabuf dma-buffer allocation\nsupport. This is based on: https://patchwork.libcamera.org/patch/18922/\n\nChanges in v3:\n- Rebase on top of latest master which includes Milan's \"[PATCH v6 0/5]\n Software ISP levels cleanup\" series and Laurent's \"[PATCH 0/3] libcamera:\n Update to the new upstream subdev routing API\" series\n- Drop include/linux related patches (included in Laurent's merged series)\n- Wrap comments and error message logging at 80 chars\n- Style fixes to some comments\n- Drop the unnecessary checking of the created dma-buf size\n\nChanges in v2:\n- New patch: Add linux/udmabuf.h to libcamera's local kernel headers\n- New patch: Rename DmaHeap class to DmaBufAllocator\n- libcamera: DmaBufAllocator: Support allocating from /dev/udmabuf :\n - Reword the commit message\n - Add a new DmaBufAllocator::DmaBufAllocatorFlag::UDmaBuf type for udmabuf\n - Drop unnecessary size != size check\n - Reword log messages to be more like the DMA heap alloc path\n - Move UniqueFD(ret) up so as to not leak the fd on errors\n-New patch: software_isp: Allow using dma-buffers from /dev/udmabuf\n\nI did not push out a branch for this to libcamera-softisp because\nof fdo gitlab maintenance. Note CI was happy with v2 and I see no reason\nwhy v3 would be different.\n\nRegards,\n\nHans\n\n\nHans de Goede (3):\n libcamera: Rename DmaHeap class to DmaBufAllocator\n libcamera: DmaBufAllocator: Support allocating from /dev/udmabuf\n libcamera: software_isp: Allow using dma-buffers from /dev/udmabuf\n\n .../libcamera/internal/dma_buf_allocator.h | 42 ++++\n include/libcamera/internal/dma_heaps.h | 38 ---\n include/libcamera/internal/meson.build | 2 +-\n .../internal/software_isp/software_isp.h | 4 +-\n src/libcamera/dma_buf_allocator.cpp | 233 ++++++++++++++++++\n src/libcamera/dma_heaps.cpp | 165 -------------\n src/libcamera/meson.build | 2 +-\n src/libcamera/pipeline/rpi/vc4/vc4.cpp | 4 +-\n src/libcamera/software_isp/software_isp.cpp | 6 +-\n 9 files changed, 285 insertions(+), 211 deletions(-)\n create mode 100644 include/libcamera/internal/dma_buf_allocator.h\n delete mode 100644 include/libcamera/internal/dma_heaps.h\n create mode 100644 src/libcamera/dma_buf_allocator.cpp\n delete mode 100644 src/libcamera/dma_heaps.cpp"}