[{"id":29616,"web_url":"https://patchwork.libcamera.org/comment/29616/","msgid":"<171658795743.1014213.3441694843509292687@ping.linuxembedded.co.uk>","date":"2024-05-24T21:59:17","subject":"Re: [PATCH v3 0/5] Software ISP levels cleanup","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2024-05-23 12:26:51)\n> This is a cleanup of black level and color gain handling in software\n> ISP. It fixes omission of black level subtraction in white balance\n> computation and moves color lookup tables computations out of\n> debayering. The latter also serves as a preparation for bringing\n> software ISP algorithms closer to common libcamera algorithm handling,\n> in future patches.\n\nTesting this series on Lenovo X13s has some oddity at startup.\n\nVideos with before and after can be found at - https://photos.app.goo.gl/jWvqK5nNBBpdNqNK8\n\nMilan, have you seen such corruption/overflow in your testing?\n\n--\nKieran\n\n\n> \n> Changes in v3:\n> - Casting an uint8_t value to unsigned int when logging it. \n> \n> Changes in v2:\n> - stdint.h include moved from black_level.cpp to black_level.h.\n> - Removed meaningless multiplication in black level subtraction.\n> - Removed local variable scoping block.\n> - Added a comment about subtracting black level for auto white balance.\n> - A code snippet related to black level subtraction moved to the right\n> patch.\n> - Dropped the patch moving TODO #13 to a source code comment.\n> - Added a patch to use float rather than uint8_t gains in color lookup\n> tables passed to debayering.\n> \n> Milan Zamazal (5):\n> libcamera: software_isp: Use a specific integer type for black level\n> libcamera: software_isp: Honor black level in AWB\n> libcamera: software_isp: Move color mappings out of debayering\n> libcamera: software_isp: Remove DebayerParams::kGain10\n> libcamera: software_isp: Pass color lookup tables as floats\n> \n> .../internal/software_isp/debayer_params.h | 19 +++--\n> src/ipa/simple/black_level.cpp | 2 +-\n> src/ipa/simple/black_level.h | 5 +-\n> src/ipa/simple/soft_simple.cpp | 76 ++++++++++++++-----\n> src/libcamera/software_isp/TODO | 13 ----\n> src/libcamera/software_isp/debayer.cpp | 28 +++----\n> src/libcamera/software_isp/debayer_cpu.cpp | 53 +++++--------\n> src/libcamera/software_isp/debayer_cpu.h | 13 ++--\n> src/libcamera/software_isp/software_isp.cpp | 4 +-\n> 9 files changed, 109 insertions(+), 104 deletions(-)\n> \n> -- \n> 2.42.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 20ADBBD87C\n\tfor ;\n\tFri, 24 May 2024 21:59:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B6D69634AC;\n\tFri, 24 May 2024 23:59:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0204261A49\n\tfor ;\n\tFri, 24 May 2024 23:59:20 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 53783524;\n\tFri, 24 May 2024 23:59:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Cj9O2xFu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1716587946;\n\tbh=E+3csVyOccIgG/So1KOUykOj2w6oWMN9+C8yzou0GAY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Cj9O2xFu0y7Ouv53YLZs4CgBM3eRr5fjlvGNGEMBl3fvNSviyIfxYbmlQZKse0kb2\n\tf5e9uF2hARmMlm9brjCPZeaL8uimP/njlxPfHt5r5P11v5iCvPDpf7SQ1Xgq/9ptfM\n\t36ap1zkoycUcGMvsHYIbUcDgl4TVrAoJK6r864NY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240523112656.559150-1-mzamazal@redhat.com>","References":"<20240523112656.559150-1-mzamazal@redhat.com>","Subject":"Re: [PATCH v3 0/5] Software ISP levels cleanup","From":"Kieran Bingham ","Cc":"Milan Zamazal ,\n\tAndrei Konovalov ,\n\tLaurent Pinchart ","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Date":"Fri, 24 May 2024 22:59:17 +0100","Message-ID":"<171658795743.1014213.3441694843509292687@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]