[{"id":29568,"web_url":"https://patchwork.libcamera.org/comment/29568/","msgid":"<171620772364.2248009.10411982693165947181@ping.linuxembedded.co.uk>","date":"2024-05-20T12:22:03","subject":"Re: [PATCH v2 0/4] libcamera: rkisp1: Plumb i.MX8MP DW100 dewarper","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Umang Jain (2024-05-19 12:56:18)\n> This series intends to support i.MX8MP DW100 dewarper in rkisp1 pipeline\n> handler.\n> \n> Patch 1/4 prepares the rkisp1 pipeline handler to register controls\n> for the camera, outside of the IPA. The dewarper will let us support\n> scaler crop - which will be registered as camera controls.\n> \n> Patch 2/4 is also a prepartory patch to accept scaler crop rectangles\n> for the converter_v4l2_m2m on each stream.\n> \n> Patch 3/4 adds a base RkISP1Dewarper class inheriting from\n> converter_v4l2_m2m. This provides a scaler crop setting helper.\n> \n> Patch 4/4 finally plumbs the dewarper in the rkisp1 pipeline handler.\n> If the scaler crop control is found set in the request, it is applied\n> on the dewarper.\n> \n> The series is tested on i.MX8MP and cam utility, by setting scaler crop\n> control via capture script.\n\nPresently this series fails CI with some compile errors picked up by\nclang:\n\nhttps://gitlab.freedesktop.org/camera/libcamera/-/jobs/58928404\n\n\n> \n> Additional development:\n> ----------------------\n> \n> Initially when I developed, I added support to load a dewarp config file\n> via environment variables which then can be used to set\n> V4L2_CID_DW100_DEWARPING_16x16_VERTEX_MAP control. However, it has\n> needs adhoc development to support v4l2 compound controls (which\n> also I tried) but ultimately I failed to test, if this control was\n> really working for me. Hence, I decided to send this series without\n> that development and hope it can be done on top of this.\n\nI would expect that such topics were likely covered when Xavier last\nlooked at this:\n\n https://patchwork.libcamera.org/project/libcamera/list/?series=3477&archive=both&state=*\n\nThat was back in 2022, but I think it would be beneficial if you could\ntry to apply that series and take a look.\n\n--\nRegards\n\nKieran\n\n\n\n> \n> Changes in v2:\n> - Fix raw capture configuration, disable dewarper in that case\n> \n> Umang Jain (4):\n> libcamera: rkisp1: Prepare for additional camera controls\n> libcamera: converter_v4l2_m2m: Support crop selection\n> libcamera: rkisp1: Add base class DW100 dewarper\n> libcamera: rkisp1: Plumb through RkISP1Dewarper\n> \n> .../internal/converter/converter_v4l2_m2m.h | 5 +\n> .../converter/converter_v4l2_m2m.cpp | 26 +++\n> src/libcamera/pipeline/rkisp1/meson.build | 1 +\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 165 +++++++++++++++++-\n> .../pipeline/rkisp1/rkisp1_dewarper.cpp | 38 ++++\n> .../pipeline/rkisp1/rkisp1_dewarper.h | 25 +++\n> src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 12 +-\n> src/libcamera/pipeline/rkisp1/rkisp1_path.h | 14 ++\n> 8 files changed, 275 insertions(+), 11 deletions(-)\n> create mode 100644 src/libcamera/pipeline/rkisp1/rkisp1_dewarper.cpp\n> create mode 100644 src/libcamera/pipeline/rkisp1/rkisp1_dewarper.h\n> \n> -- \n> 2.44.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 98A5DBDE6B\n\tfor ;\n\tMon, 20 May 2024 12:22:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C06776346B;\n\tMon, 20 May 2024 14:22:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 709FD61A58\n\tfor ;\n\tMon, 20 May 2024 14:22:06 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F21F2593;\n\tMon, 20 May 2024 14:21:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BuA6AnXb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1716207715;\n\tbh=+HK46WqyXnD/JfURc1D2A6Z1UQiUxHbw4836LCnaqls=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=BuA6AnXbf0URG25K8A3Mqqe5un+xWQtCRrlB1uvoa8/4EGaatKZRJCcoy05OHpS3q\n\tYNUsGm1NYFjRj7JhvsECBsBnm9H40/v3rqbgMg5L2uzU+DYj+O7rYlIhEswPfTtkma\n\tdW//xA8sOjMV90pzBRGn7NgZiTIkAkSGX/EtBPu0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240519115622.32170-1-umang.jain@ideasonboard.com>","References":"<20240519115622.32170-1-umang.jain@ideasonboard.com>","Subject":"Re: [PATCH v2 0/4] libcamera: rkisp1: Plumb i.MX8MP DW100 dewarper","From":"Kieran Bingham ","Cc":"Umang Jain ","To":"Umang Jain ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 20 May 2024 13:22:03 +0100","Message-ID":"<171620772364.2248009.10411982693165947181@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]