[{"id":282,"web_url":"https://patchwork.libcamera.org/comment/282/","msgid":"<20190111122455.GC30160@bigcity.dyn.berto.se>","date":"2019-01-11T12:24:55","subject":"Re: [libcamera-devel] [PATCH 0/3] test: media_device: Add link\n\thandling test","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2019-01-11 12:09:53 +0100, Jacopo Mondi wrote:\n> Hello,\n> this three patches add test for handling links on the VIMC media graph.\n\nI agree with the comments Kieran made a part from that on the test code \nitself fell free to add\n\nReviewed-by: Niklas Söderlund \n\n> \n> Jacopo Mondi (3):\n> test: media_device: Make MediaDeviceTest a MediaDevicePrintTest\n> test: media_device: Add link handling test\n> test: media_device: Use foreach iterator\n> \n> test/media_device/media_device_link_test.cpp | 188 ++++++++++++++++++\n> ...e_test.cpp => media_device_print_test.cpp} | 31 ++-\n> test/media_device/meson.build | 15 +-\n> 3 files changed, 213 insertions(+), 21 deletions(-)\n> create mode 100644 test/media_device/media_device_link_test.cpp\n> rename test/media_device/{media_device_test.cpp => media_device_print_test.cpp} (79%)\n> \n> --\n> 2.20.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 492BF600CC\n\tfor ;\n\tFri, 11 Jan 2019 13:24:57 +0100 (CET)","by mail-lj1-x243.google.com with SMTP id s5-v6so12738683ljd.12\n\tfor ;\n\tFri, 11 Jan 2019 04:24:57 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tn8-v6sm17087885lji.90.2019.01.11.04.24.55\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 11 Jan 2019 04:24:55 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=XGc46+l8NN9SHGhA4NjMHNa0rnbFgN4lDdipUkKPrwc=;\n\tb=QlJ+X+JsvZ4SPjQOdvqTzPJxw1bSDuyaqYf2TM3f3lYz1jd2KgUjh5OS4PtwAEKgOa\n\t8q8M9VmML+yNlbgJhOnGcALUalH0St1L6M3Eh5fruu6AqlDeEQg4WVVJP2FfkHsK+v5B\n\tcgtBDi7O7LYjd81ekxSMWKGh59n1qpOzBU9nKbAIXoSORqkg3lWluXmu7a2Y+XR7BUhB\n\tSpTUWa0vtZYsiXARy0lspVLZ5+Yt6J1zB2tctfaqXaTHYvjDuGVWKovW1IPwqRqAKkGG\n\teiGpaGiMQoZFZC5MmdQrGpZHGaBUEvQs5T6rkI6cl7UxwVnHAhocJe0OgKpF7S8b96qW\n\tRDnw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=XGc46+l8NN9SHGhA4NjMHNa0rnbFgN4lDdipUkKPrwc=;\n\tb=fk4s5TvTX8oeIqgicSPluXZBQ3dkUOcWodNjeJO9U1OPMy9vcp24PXYPmKPnusToz6\n\thO/l//CG9Q33d4cc+fQ4MBEROZTRbBfO60Ubt0nqbvUu2HJ2Is0dJipGIf2ETXsNiwwb\n\t4Y2hdHrBBvq7Pkfxm2CPQsjrUUBZVPtzvdn9KgrSfT43pe+/lhB7neiC//7MhHn7SRZ4\n\tzGhEm1I+Xu3iW7hP3uTusJozhmuIH8hTmdJrgnj3C2iNfhsuXmt2TMr4UO+uIvK8Ln3W\n\tAfhhvEv8GdLMOkTo0/lBev8drOUVk4rbmzo+4Cozl/e9sFXz9lXE1kN82Yyy/VY00fh5\n\tv3zw==","X-Gm-Message-State":"AJcUukfX3jtDr80+tP3v6t6sxbuM4BwBnuDW6kRKW82Ofbb4sCVVGnJK\n\t1JUbFRBiSanH8mNV3AzaZ+IORoZjfrk=","X-Google-Smtp-Source":"ALg8bN7YY8PEAafvWexfPE8X7RxVWKmxJqkXtaL4E5RqtGp8SgYoyng5DAPe5PqC77OurSbeb1xYDA==","X-Received":"by 2002:a2e:9b84:: with SMTP id\n\tz4-v6mr8360460lji.93.1547209496369; \n\tFri, 11 Jan 2019 04:24:56 -0800 (PST)","Date":"Fri, 11 Jan 2019 13:24:55 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190111122455.GC30160@bigcity.dyn.berto.se>","References":"<20190111110956.14812-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190111110956.14812-1-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 0/3] test: media_device: Add link\n\thandling test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 11 Jan 2019 12:24:57 -0000"}}]