[{"id":29523,"web_url":"https://patchwork.libcamera.org/comment/29523/","msgid":"<8734qliwaj.fsf@redhat.com>","date":"2024-05-13T15:08:52","subject":"Re: [PATCH v2 0/5] Software ISP levels cleanup","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Milan Zamazal writes:\n\n> This is a cleanup of black level and color gain handling in software\n> ISP. It fixes omission of black level subtraction in white balance\n> computation and moves color lookup tables computations out of\n> debayering. The latter also serves as a preparation for bringing\n> software ISP algorithms closer to common libcamera algorithm handling,\n> in future patches.\n>\n> Changes in v2:\n> - stdint.h include moved from black_level.cpp to black_level.h.\n> - Removed meaningless multiplication in black level subtraction.\n> - Removed local variable scoping block.\n> - Added a comment about subtracting black level for auto white balance.\n> - A code snippet related to black level subtraction moved to the right\n> patch.\n> - Dropped the patch moving TODO #13 to a source code comment.\n> - Added a patch to use float rather than uint8_t gains in color lookup\n> tables passed to debayering.\n\nHi Laurent,\n\ndo you plan to take a look what else may be missing?\n\nThanks,\nMilan\n\n> Milan Zamazal (5):\n> libcamera: software_isp: Use a specific integer type for black level\n> libcamera: software_isp: Honor black level in AWB\n> libcamera: software_isp: Move color mappings out of debayering\n> libcamera: software_isp: Remove DebayerParams::kGain10\n> libcamera: software_isp: Pass color lookup tables as floats\n>\n> .../internal/software_isp/debayer_params.h | 19 +++--\n> src/ipa/simple/black_level.cpp | 2 +-\n> src/ipa/simple/black_level.h | 5 +-\n> src/ipa/simple/soft_simple.cpp | 76 ++++++++++++++-----\n> src/libcamera/software_isp/TODO | 13 ----\n> src/libcamera/software_isp/debayer.cpp | 28 +++----\n> src/libcamera/software_isp/debayer_cpu.cpp | 53 +++++--------\n> src/libcamera/software_isp/debayer_cpu.h | 13 ++--\n> src/libcamera/software_isp/software_isp.cpp | 4 +-\n> 9 files changed, 109 insertions(+), 104 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6454DBDE6B\n\tfor ;\n\tMon, 13 May 2024 15:09:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 93D7661A64;\n\tMon, 13 May 2024 17:09:09 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 51C7761A5E\n\tfor ;\n\tMon, 13 May 2024 17:09:08 +0200 (CEST)","from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n\t[209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-343-jhkkVU_vOuGBbeH6IceSQg-1; Mon, 13 May 2024 11:08:54 -0400","by mail-wm1-f69.google.com with SMTP id\n\t5b1f17b1804b1-4200ef4fb81so10152005e9.1\n\tfor ;\n\tMon, 13 May 2024 08:08:54 -0700 (PDT)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-41fccfe1574sm158716705e9.48.2024.05.13.08.08.52\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 13 May 2024 08:08:52 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"euRNWe21\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1715612947;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=ot1Dr7nH7SZdT9sgPS7xu0YIVlQcZzVgsKDijysZWaI=;\n\tb=euRNWe21Lz67H7jFYWM5ZRWm564e+cx7bup01iiflomeknlQ3h+2UuJyJDG6jEo8gTQvT5\n\tpvuHcSeILSWcAY8TlorTX33ruJKgDjZrzQL0ZmQpP1cPBPzcUBCBfzUxx8ahrKO7L/1BZ/\n\tUoQp+uDgL01OqC72+KbcKQ25XPRvfLk=","X-MC-Unique":"jhkkVU_vOuGBbeH6IceSQg-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1715612934; x=1716217734;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=ot1Dr7nH7SZdT9sgPS7xu0YIVlQcZzVgsKDijysZWaI=;\n\tb=fj2kRqSLmeC1K9xHjXZFEtSH79LhydnrCyzPcIR5rTxmrm/sCk8izvQLBEjCwfgNKH\n\tVhLER4QdpwDNt5K3AUipQLfvRSu/kpHxwAJMBEb7TnwT6bc552PfqZbVuXfaMAHbluHx\n\to4haQ7D+mIecmtWoIzo4rDG7fxaahdEeQVEna/JghyXHKQBYTHfK93QlleFn5vaJT3dc\n\tpb1/7Sb24oRVJ3PYpNqW01UesyJqEVwpFbuEEYBn2Yp+s+St2s04PjKIV+2OXtbYPCt4\n\tm2MFr+lNquZGvkawLMr1hpXQUscGWUmWhKG8fKYKz0iwqQSUyP2o7peb09A2awWHGVoD\n\tXYOw==","X-Gm-Message-State":"AOJu0YyU+TPGFI7KkezfoayGDIreMJ8AC9v2kDo/acnmR99Gvm8uG27i\n\tvKmWd5yP7wS8k0s4LWlwmHAG4lmapWl6dJHinitxsOk9VJYvoIrHNuRNopEwUUEeO09ZoTnnM0V\n\t++1NUQ9AIHGb8rWjSpu61ux7p7NgD8cKjAfGmWm60LMMSUBtCM6OZzdn4s2aoRNAtdoFknFk=","X-Received":["by 2002:a05:600c:3104:b0:41b:ed36:e055 with SMTP id\n\t5b1f17b1804b1-41feaa300a1mr99644265e9.7.1715612933692; \n\tMon, 13 May 2024 08:08:53 -0700 (PDT)","by 2002:a05:600c:3104:b0:41b:ed36:e055 with SMTP id\n\t5b1f17b1804b1-41feaa300a1mr99644055e9.7.1715612933310; \n\tMon, 13 May 2024 08:08:53 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IFgkHGMB1kJqDGKfWLa4xQLkqLZF3cArhNYCL5nSlWGK+F3m1hUCrLxgZ5EHQjeL4Rxm1wC3g==","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Laurent Pinchart ","Subject":"Re: [PATCH v2 0/5] Software ISP levels cleanup","In-Reply-To":"<20240430173430.200392-1-mzamazal@redhat.com> (Milan Zamazal's\n\tmessage of \"Tue, 30 Apr 2024 19:34:25 +0200\")","References":"<20240430173430.200392-1-mzamazal@redhat.com>","Date":"Mon, 13 May 2024 17:08:52 +0200","Message-ID":"<8734qliwaj.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]