[{"id":29457,"web_url":"https://patchwork.libcamera.org/comment/29457/","msgid":"<20240508154627.GA22295@pendragon.ideasonboard.com>","date":"2024-05-08T15:46:27","subject":"Re: [PATCH 0/3] Minor AGC fixes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Dan,\n\nOn Thu, Apr 18, 2024 at 01:46:29PM +0100, Daniel Scally wrote:\n> This series just addresses some of the things that came up in review for the\n> centralised AGC series but which I thought would be better to fix on top (since\n> they should happen regardless of that series)\n> \n> Dan\n> \n> Daniel Scally (3):\n> ipa: ipu3: Refer to integration time instead of shutter speed\n> ipa: rkisp1: Refer to integration time rather than shutter speed\n\nThere are now other occurrences of shutter in the exposure mode helper.\nCould you rename them to integration time too ?\n\n> ipa: ipu3: Use a Y histogram instead of green\n> \n> src/ipa/ipu3/algorithms/agc.cpp | 27 ++++++++++++++-------------\n> src/ipa/ipu3/algorithms/agc.h | 4 ++--\n> src/ipa/ipu3/ipa_context.cpp | 8 ++++----\n> src/ipa/ipu3/ipa_context.h | 4 ++--\n> src/ipa/ipu3/ipu3.cpp | 8 ++++----\n> src/ipa/rkisp1/algorithms/agc.cpp | 4 ++--\n> src/ipa/rkisp1/ipa_context.cpp | 8 ++++----\n> src/ipa/rkisp1/ipa_context.h | 4 ++--\n> src/ipa/rkisp1/rkisp1.cpp | 8 ++++----\n> 9 files changed, 38 insertions(+), 37 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 62BBEBDE6B\n\tfor ;\n\tWed, 8 May 2024 15:46:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2D68861A73;\n\tWed, 8 May 2024 17:46:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C276361A73\n\tfor ;\n\tWed, 8 May 2024 17:46:35 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7E794FD6;\n\tWed, 8 May 2024 17:46:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"T3C9KL2l\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1715183192;\n\tbh=irvL1JOkG8O8J3TgTVc3aesHTd09Ho7YOLAQGVuJ46Q=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=T3C9KL2lCbv5hVDekri8rRkuNAMYsovLCkv7CD1V5b0tIKq3S4Zo8y3rKhdC+EWTI\n\tD4m62YgxsR4PYdIfIXJ1UnjPfisOIvpFfxo/Ni34jbC8+dfoqb8n0WxSCa7vS16ufG\n\tmuyJ3CXX6znsl6u0E+XOoWsD/zhSGa43G65lzx2U=","Date":"Wed, 8 May 2024 18:46:27 +0300","From":"Laurent Pinchart ","To":"Daniel Scally ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 0/3] Minor AGC fixes","Message-ID":"<20240508154627.GA22295@pendragon.ideasonboard.com>","References":"<20240418124632.652163-1-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240418124632.652163-1-dan.scally@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29461,"web_url":"https://patchwork.libcamera.org/comment/29461/","msgid":"","date":"2024-05-08T20:49:19","subject":"Re: [PATCH 0/3] Minor AGC fixes","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Laurent\n\nOn 08/05/2024 16:46, Laurent Pinchart wrote:\n> Hi Dan,\n>\n> On Thu, Apr 18, 2024 at 01:46:29PM +0100, Daniel Scally wrote:\n>> This series just addresses some of the things that came up in review for the\n>> centralised AGC series but which I thought would be better to fix on top (since\n>> they should happen regardless of that series)\n>>\n>> Dan\n>>\n>> Daniel Scally (3):\n>> ipa: ipu3: Refer to integration time instead of shutter speed\n>> ipa: rkisp1: Refer to integration time rather than shutter speed\n> There are now other occurrences of shutter in the exposure mode helper.\n> Could you rename them to integration time too ?\n\n\nYup, will do\n\n>\n>> ipa: ipu3: Use a Y histogram instead of green\n>>\n>> src/ipa/ipu3/algorithms/agc.cpp | 27 ++++++++++++++-------------\n>> src/ipa/ipu3/algorithms/agc.h | 4 ++--\n>> src/ipa/ipu3/ipa_context.cpp | 8 ++++----\n>> src/ipa/ipu3/ipa_context.h | 4 ++--\n>> src/ipa/ipu3/ipu3.cpp | 8 ++++----\n>> src/ipa/rkisp1/algorithms/agc.cpp | 4 ++--\n>> src/ipa/rkisp1/ipa_context.cpp | 8 ++++----\n>> src/ipa/rkisp1/ipa_context.h | 4 ++--\n>> src/ipa/rkisp1/rkisp1.cpp | 8 ++++----\n>> 9 files changed, 38 insertions(+), 37 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5325EC3226\n\tfor ;\n\tWed, 8 May 2024 20:49:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 79B2563437;\n\tWed, 8 May 2024 22:49:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8BE5961A73\n\tfor ;\n\tWed, 8 May 2024 22:49:22 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 44096FD6;\n\tWed, 8 May 2024 22:49:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"o0V9PX8y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1715201359;\n\tbh=6Gw7PGbLcIecZFyAbcn1OQ9Tg5qu2l/BjaDxxqUDzf8=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=o0V9PX8y1PPrUf5lQ5o6JxEkXr1qzbJeS4lgZzXFwXQWlF92kPP3Rv/ydGqs6rPbv\n\tfTb/SkmOCXWvyaGWWdjfBsIVt/C/soks4S4hyn3qEGifOVVLt2U5z5OqsPk/uXFaHB\n\tzbBS7J7TnO6+C3OXecUwpeTYHd6/FSVogsPUAazg=","Message-ID":"","Date":"Wed, 8 May 2024 21:49:19 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 0/3] Minor AGC fixes","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20240418124632.652163-1-dan.scally@ideasonboard.com>\n\t<20240508154627.GA22295@pendragon.ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20240508154627.GA22295@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]