[{"id":29207,"web_url":"https://patchwork.libcamera.org/comment/29207/","msgid":"<171291206917.2108906.9981868762347350599@ping.linuxembedded.co.uk>","date":"2024-04-12T08:54:29","subject":"Re: [PATCH 0/5] ipa: rkisp1: Improve AGC (plumbing)","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Paul Elder (2024-04-05 15:47:24)\n> This series depends on v1 of \"Centralise Agc into libipa\", and \"ipa:\n> Move Pwl from Raspberry Pi to libipa\".\n> \n> This series adds support in the rkisp1 IPA for:\n> - reading histogram weights (metering modes) from tuning file\n> - setting digital gain\n> - expands luminance target from a scalar value to piecewise linear\n> function, controlled by lux\n> - plumbs controls for setting metering mode, exposure mode, constraint\n> mode, and frame duration\n> \n> While at it, there is a fixup for Dan's series \"Centralise Agc into\n> libipa\". Dan, I suppose you could pick it up and squash it into your\n> series. I have it here so just so that I don't forget about it.\n> \n> This series breaks the rkisp1 pipeline since it'll complain about\n> non-existant tuning files. There's a series coming imminently to address\n> that (though it'll only add a tuning file for imx335).\n\nThat will then break a fair few existing users who don't yet have tuning\nfiles.\n\nI know RPi prefer to halt rather than continue with an untuned file, but\nI think at least temporarily until we get tuning files in for /currently\nsupported/ cameras we should allow falling back to an uncalibrated\ntuning file.\n\nPersonally I would still prefer to fall back to an uncalibrated with a\nwarning in the general case, but I'm fine if we align with the RPi style\nto fail the pipeline if we don't have a tuning file /when/ we have\ntuning files for currently supported cameras, otherwise I don't think\nthe breakage is fair\n\n--\nKieran\n\n\n\n> \n> Paul Elder (5):\n> ipa: rkisp1: agc: Read histogram weights from tuning file\n> ipa: rkisp1: agc: Add digital gain\n> fixup: ipa: rkisp1: Remove bespoke Agc functions\n> ipa: libipa: agc: Change luminance target to piecewise linear function\n> ipa: rkisp1: agc: Plumb mode-selection and frame duration controls\n> \n> src/ipa/ipu3/algorithms/agc.cpp | 5 +-\n> src/ipa/libipa/agc.cpp | 22 +++-\n> src/ipa/libipa/agc.h | 7 +-\n> src/ipa/rkisp1/algorithms/agc.cpp | 179 +++++++++++++++++++++++---\n> src/ipa/rkisp1/algorithms/agc.h | 11 ++\n> src/ipa/rkisp1/algorithms/algorithm.h | 2 +\n> src/ipa/rkisp1/ipa_context.h | 7 +\n> src/ipa/rkisp1/rkisp1.cpp | 12 ++\n> 8 files changed, 213 insertions(+), 32 deletions(-)\n> \n> -- \n> 2.39.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3AB35C3213\n\tfor ;\n\tFri, 12 Apr 2024 08:54:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 82B9A63352;\n\tFri, 12 Apr 2024 10:54:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E2AE16333E\n\tfor ;\n\tFri, 12 Apr 2024 10:54:32 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 43F1FA12;\n\tFri, 12 Apr 2024 10:53:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"l+PpioSb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1712912029;\n\tbh=/o0UZ7gZFmrLebigqcSq4BSRtzFUTMGcZwnRqhM8sO8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=l+PpioSbBq5/4SQeYdKml99J1/4xzYKn04lqXqRBjqdirzpmEuBjfWo+zejF+eJOY\n\twekKKKjwm9WjsAsec26/encO85SaCCIBhf3Zq840FT5xHBoiChaL5xtld/BXLO3c7h\n\t6XGJXVAssJ6ANpg8oANdoSIBpfJt8uQPtq1VuqB4=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240405144729.2992219-1-paul.elder@ideasonboard.com>","References":"<20240405144729.2992219-1-paul.elder@ideasonboard.com>","Subject":"Re: [PATCH 0/5] ipa: rkisp1: Improve AGC (plumbing)","From":"Kieran Bingham ","Cc":"Paul Elder ","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 12 Apr 2024 09:54:29 +0100","Message-ID":"<171291206917.2108906.9981868762347350599@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]