{"id":19850,"url":"https://patchwork.libcamera.org/api/covers/19850/?format=json","web_url":"https://patchwork.libcamera.org/cover/19850/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240405144729.2992219-1-paul.elder@ideasonboard.com>","date":"2024-04-05T14:47:24","name":"[0/5] ipa: rkisp1: Improve AGC (plumbing)","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/19850/mbox/","series":[{"id":4251,"url":"https://patchwork.libcamera.org/api/series/4251/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4251","date":"2024-04-05T14:47:24","name":"ipa: rkisp1: Improve AGC (plumbing)","version":1,"mbox":"https://patchwork.libcamera.org/series/4251/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/19850/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB218C0DA4\n\tfor ;\n\tFri, 5 Apr 2024 14:47:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1774063334;\n\tFri, 5 Apr 2024 16:47:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 10E1D61C29\n\tfor ;\n\tFri, 5 Apr 2024 16:47:45 +0200 (CEST)","from pyrite.hamster-moth.ts.net (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1205CC8A;\n\tFri, 5 Apr 2024 16:47:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DPFdQNrX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1712328426;\n\tbh=J1vihiExcWWwy1Cw2H7HNCRTqc7pUAhAmANetrCthVk=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=DPFdQNrXffHSGM3K2LfpzhVViah8+0MPWptsWErY0KWcfZSGB2fjnkh/91VCEHoVu\n\tkac9nBGC4V0BrKF4u+8mFSaGHh1U+Yeb2pSPCBZgSMgNQnlpEwwOUlUhbRrxToq/iH\n\t1WET+D+vpYPRBEKMxMdxhIzDPnUPhUTZmCBXTR2w=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Cc":"Paul Elder ","Subject":"[PATCH 0/5] ipa: rkisp1: Improve AGC (plumbing)","Date":"Fri, 5 Apr 2024 23:47:24 +0900","Message-Id":"<20240405144729.2992219-1-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.39.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This series depends on v1 of \"Centralise Agc into libipa\", and \"ipa:\nMove Pwl from Raspberry Pi to libipa\".\n\nThis series adds support in the rkisp1 IPA for:\n- reading histogram weights (metering modes) from tuning file\n- setting digital gain\n- expands luminance target from a scalar value to piecewise linear\n function, controlled by lux\n- plumbs controls for setting metering mode, exposure mode, constraint\n mode, and frame duration\n\nWhile at it, there is a fixup for Dan's series \"Centralise Agc into\nlibipa\". Dan, I suppose you could pick it up and squash it into your\nseries. I have it here so just so that I don't forget about it.\n\nThis series breaks the rkisp1 pipeline since it'll complain about\nnon-existant tuning files. There's a series coming imminently to address\nthat (though it'll only add a tuning file for imx335).\n\nPaul Elder (5):\n ipa: rkisp1: agc: Read histogram weights from tuning file\n ipa: rkisp1: agc: Add digital gain\n fixup: ipa: rkisp1: Remove bespoke Agc functions\n ipa: libipa: agc: Change luminance target to piecewise linear function\n ipa: rkisp1: agc: Plumb mode-selection and frame duration controls\n\n src/ipa/ipu3/algorithms/agc.cpp | 5 +-\n src/ipa/libipa/agc.cpp | 22 +++-\n src/ipa/libipa/agc.h | 7 +-\n src/ipa/rkisp1/algorithms/agc.cpp | 179 +++++++++++++++++++++++---\n src/ipa/rkisp1/algorithms/agc.h | 11 ++\n src/ipa/rkisp1/algorithms/algorithm.h | 2 +\n src/ipa/rkisp1/ipa_context.h | 7 +\n src/ipa/rkisp1/rkisp1.cpp | 12 ++\n 8 files changed, 213 insertions(+), 32 deletions(-)"}