[{"id":29000,"web_url":"https://patchwork.libcamera.org/comment/29000/","msgid":"<171085302579.1676185.6551506200975943072@ping.linuxembedded.co.uk>","date":"2024-03-19T12:57:05","subject":"Re: [PATCH v6 00/18] libcamera: introduce Software ISP and Software\n\tIPA","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2024-03-19 12:35:47)\n> Here is v6 of the patch-set to add Software ISP support\n> to libcamera / to the simple pipeline-handler.\n> \n> Changes in v6 vs v5:\n> - [06/18] libcamera: software_isp: Add SwStatsCpu class\n> Resolved a rebase conflict in meson.build.\n> - [16/18] libcamera: Add \"Software ISP benchmarking\"\n> Fixed a trivial typo (Stefan).\n> - [17/18] libcamera: software_isp: Apply black level compensation\n> A comment style adjusted (Kieran).\n> A common value extracted into a variable.\n> \n> git branch for this v6 patch set:\n> https://gitlab.freedesktop.org/camera/libcamera-softisp/-/commits/SoftwareISP-v09\n\nAnd full CI pipeline visible at:\n - https://gitlab.freedesktop.org/camera/libcamera-softisp/-/pipelines/1131390\n\n--\nKieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4FCBEBD160\n\tfor ;\n\tTue, 19 Mar 2024 12:57:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7964762CAB;\n\tTue, 19 Mar 2024 13:57:10 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 919EE62CAA\n\tfor ;\n\tTue, 19 Mar 2024 13:57:08 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A8DB4480;\n\tTue, 19 Mar 2024 13:56:41 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Zma2a0t/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1710853001;\n\tbh=8iVL+53Hjc3su4Ua3XxNv2QZ7bz2XfMXSaRAyz9KkVY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Zma2a0t/pULj3uo4FcAHU0uBv7iJdrFFYJdEzQtRj7P3HIbdg//Uo6++TbhvO/Sws\n\t5ZSk4++sb4cn0C+cMpCyafo3YblmAXT2n4saZuo6yGgvQ0vxLUvQZIAIUrybjl+6Fk\n\tdS4oE30HrrGGxtOdZeZZkzVnV2abGmkEztaWXvRU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240319123622.675599-1-mzamazal@redhat.com>","References":"<20240319123622.675599-1-mzamazal@redhat.com>","Subject":"Re: [PATCH v6 00/18] libcamera: introduce Software ISP and Software\n\tIPA","From":"Kieran Bingham ","Cc":"Milan Zamazal ,\n\tAndrey Konovalov ,\n\tBryan O'Donoghue ,\n\tMaxime Ripard , Pavel Machek ,\n\tHans de Goede ","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Date":"Tue, 19 Mar 2024 12:57:05 +0000","Message-ID":"<171085302579.1676185.6551506200975943072@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29138,"web_url":"https://patchwork.libcamera.org/comment/29138/","msgid":"<87il0zh75c.fsf@redhat.com>","date":"2024-04-02T19:54:55","subject":"Re: [PATCH v6 00/18] libcamera: introduce Software ISP and Software\n\tIPA","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Laurent,\n\nthank you for your thorough review of the patches. I plan to post v7 on\nWednesday. I responded to your comments where I had some doubts, I believe I\naddressed the rest in some ways (but I may have missed something).\n\nRegards,\nMilan","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 00150BD16B\n\tfor ;\n\tTue, 2 Apr 2024 19:55:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3E8DD6334D;\n\tTue, 2 Apr 2024 21:55:03 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BD26763334\n\tfor ;\n\tTue, 2 Apr 2024 21:55:01 +0200 (CEST)","from mail-ej1-f71.google.com (mail-ej1-f71.google.com\n\t[209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-668-aCTdo19WOZS503K_7_dYYQ-1; Tue, 02 Apr 2024 15:54:58 -0400","by mail-ej1-f71.google.com with SMTP id\n\ta640c23a62f3a-a46bae02169so15302566b.1\n\tfor ;\n\tTue, 02 Apr 2024 12:54:58 -0700 (PDT)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tf19-20020a17090631d300b00a46a27794f6sm6805073ejf.123.2024.04.02.12.54.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 02 Apr 2024 12:54:56 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"ITu2+LmN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1712087700;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=hB/Op4Ct9pkjHEr/UpO/3QT2/im3x7zfzLeHBXMlnEo=;\n\tb=ITu2+LmNfp4FsraUPNJ6EnhKTx0+3/ev0CqErv4joVdtJ1jKYZrQOOGc7M+TEi3mnaNVdP\n\t9vXjlNzTaMTETg4634QzTw6oUxrdVfvxfSw/iVn1ReCWeOaiuugS/f6B40mr0y3hXjcpYZ\n\t5hoE7Pb6U5K+7cRXm+1jvQLQBCMwJ/M=","X-MC-Unique":"aCTdo19WOZS503K_7_dYYQ-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1712087697; x=1712692497;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=hB/Op4Ct9pkjHEr/UpO/3QT2/im3x7zfzLeHBXMlnEo=;\n\tb=lA7TNMrOLfwx8wVVMfq1fNEVP6ddN+x99mj7GGyxzqg4PD+t+Jmp0AOSmMDzLDVoJT\n\tO93tMQEtcGyFCwdjfpeSL2JqL3OR+JnJCnnweiSyIiEMt4quUc3tFGt+O8ddYUWVB/7D\n\t6el/qWwXJO6dl2YQSGNOiFGgpha+dyIbJ5wedRY7VJHprjFSKu3cXtvF6195f45Ukjlo\n\tvoEbMXootp1Z1sYsAHSvPy+ai7u13kLPe6h9wMABLMVQAkFXKLJPH27DKJzB1RfYKycz\n\t+JyYy+aeDAAqueBkgj5UNTMUaW3c+yCSpX7FwjsPre6FL/cclD+IXlwdu6gvzZIHYbEe\n\t6nGQ==","X-Gm-Message-State":"AOJu0YzHRsjhfQ4ICRDUYmSSEzNBsfykNC8kriAnf88HCqUk0aOIV+IM\n\tHLAuIQieeHocVzIgDpRq40sOjv+xFwLLmBdYL1z4N3f77P9OEp9IR+uTBQWFqIfuRtnCftINQ0o\n\tMyI37EPH1Fkt9fXWHBmSno6dGlHms/wJdxp40YlpUDgGM7WvWwUEFJAHtTXT9m5H5a4Ef/2A=","X-Received":["by 2002:a17:906:33ce:b0:a4e:8da0:8646 with SMTP id\n\tw14-20020a17090633ce00b00a4e8da08646mr454495eja.29.1712087697258; \n\tTue, 02 Apr 2024 12:54:57 -0700 (PDT)","by 2002:a17:906:33ce:b0:a4e:8da0:8646 with SMTP id\n\tw14-20020a17090633ce00b00a4e8da08646mr454482eja.29.1712087696913; \n\tTue, 02 Apr 2024 12:54:56 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IHrjSTQhvQrsjFVitEy6cvwCjxlwhOhBJSK19fz/RZnlbB8SxXChmUDMx4Lgrf3wYxChNxauw==","From":"Milan Zamazal ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, Andrey Konovalov\n\t, Bryan O'Donoghue\n\t, Maxime Ripard , Pavel\n\tMachek , Hans de Goede , Kieran\n\tBingham ","Subject":"Re: [PATCH v6 00/18] libcamera: introduce Software ISP and Software\n\tIPA","In-Reply-To":"<20240319123622.675599-1-mzamazal@redhat.com> (Milan Zamazal's\n\tmessage of \"Tue, 19 Mar 2024 13:35:47 +0100\")","References":"<20240319123622.675599-1-mzamazal@redhat.com>","Date":"Tue, 02 Apr 2024 21:54:55 +0200","Message-ID":"<87il0zh75c.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]