{"id":19737,"url":"https://patchwork.libcamera.org/api/covers/19737/?format=json","web_url":"https://patchwork.libcamera.org/cover/19737/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240319105403.4045592-1-paul.elder@ideasonboard.com>","date":"2024-03-19T10:54:01","name":"[0/2] ipa: rkisp1: Fix histogram","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/19737/mbox/","series":[{"id":4229,"url":"https://patchwork.libcamera.org/api/series/4229/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4229","date":"2024-03-19T10:54:01","name":"ipa: rkisp1: Fix histogram","version":1,"mbox":"https://patchwork.libcamera.org/series/4229/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/19737/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 042C2BD160\n\tfor ;\n\tTue, 19 Mar 2024 10:54:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0D68D62CAA;\n\tTue, 19 Mar 2024 11:54:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F5DB61C61\n\tfor ;\n\tTue, 19 Mar 2024 11:54:28 +0100 (CET)","from pyrite.hamster-moth.ts.net (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 39D02480;\n\tTue, 19 Mar 2024 11:53:59 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uWuXri/g\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1710845641;\n\tbh=Kua3xTlZq8tPxnaGhXQLMQn6XUNJMSKrxTxeJ2CX760=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=uWuXri/gFphI9PBgF5mJfmzkKmq+1k5dslvLpB9Yta1XVnkcw3oM9eaK2kJBsgRf6\n\ti/uCqVJp1RwhSvI3QaarVLnhxeMzaZBaQ8MN0rU8KlfMPiAGprlEIr0W9FxDwsl7YE\n\tecGtOJlaWroJtTt+tZG9ZFsD90Wb3RzNVAfhAg3Q=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Cc":"Paul Elder ","Subject":"[PATCH 0/2] ipa: rkisp1: Fix histogram","Date":"Tue, 19 Mar 2024 19:54:01 +0900","Message-Id":"<20240319105403.4045592-1-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.39.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This patch series fixes the histogram usage for rkisp1. The lower 4 bits\nshould be ignored.\n\nPersonally I feel like this should be fixed in the kernel... but I have\na feeling it would count as a uapi change and be rejected so we're\nfixing it here in libcamera instead.\n\nPaul Elder (2):\n ipa: libipa: histogram: Add rshift parameter to constructor\n ipa: rkisp1: agc: Fix histogram construction\n\n src/ipa/libipa/histogram.cpp | 5 +++--\n src/ipa/libipa/histogram.h | 2 +-\n src/ipa/rkisp1/algorithms/agc.cpp | 2 +-\n 3 files changed, 5 insertions(+), 4 deletions(-)"}