{"id":19656,"url":"https://patchwork.libcamera.org/api/covers/19656/?format=json","web_url":"https://patchwork.libcamera.org/cover/19656/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240311123234.32925-1-jacopo.mondi@ideasonboard.com>","date":"2024-03-11T12:32:28","name":"[v2,0/4] libcamera: Replace IPU3/RkISP1FrameInfo","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/19656/mbox/","series":[{"id":4211,"url":"https://patchwork.libcamera.org/api/series/4211/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4211","date":"2024-03-11T12:32:28","name":"libcamera: Replace IPU3/RkISP1FrameInfo","version":2,"mbox":"https://patchwork.libcamera.org/series/4211/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/19656/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A93D1BD1F1\n\tfor ;\n\tMon, 11 Mar 2024 12:32:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B951262C88;\n\tMon, 11 Mar 2024 13:32:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B29D61C7C\n\tfor ;\n\tMon, 11 Mar 2024 13:32:44 +0100 (CET)","from localhost.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1F9D6C85;\n\tMon, 11 Mar 2024 13:32:23 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OUBI+BSZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1710160343;\n\tbh=UvS7UH3thTTr1V2bXuQ82vfckUda1WGvtLfDlItBx+g=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=OUBI+BSZRXHiV2tTYDmMx3gQ2YPVHOIJc8lzq5o8H95/aQyORR8QtdWtgSlrwVWdS\n\tw4DO3sxHmBZS0g9YtRg/HYxZWMCDlZyKh8Cc5fkTPsqLlWonoI7hF/GvNiv/3+TL+1\n\tqheb7RUhDJWlafwLDkceuxE3fj4is/HocOUlL5e0=","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v2 0/4] libcamera: Replace IPU3/RkISP1FrameInfo","Date":"Mon, 11 Mar 2024 13:32:28 +0100","Message-ID":"<20240311123234.32925-1-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.43.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"v1->v2:\n- Squash patches 2 and 3 in a single one\n- Maintain the existing behaviour for queueing RAW frames to the RkISP1 IPA\n- Minor changes to the IPU3 patch as suggested by Dan\n\nPipeline:\nhttps://gitlab.freedesktop.org/pinchartl/libcamera/-/pipelines/1124683\n\nThe RkISP1 and IPU3 pipeline have custom classes that provide the\nfollowing features:\n\n- Associate a stat, params and (optionally) a raw buffer with the id used\n to communicate between the pipeline handler and the IPA\n- Associate a completed buffer with the Request it belongs to\n\nThe same functionalities can be obtained by extending the Request::Private\nclass with a per-pipeline derived implementation that tracks buffers and ids\nreducing code duplications.\n\nJacopo Mondi (4):\n libcamera: Allow pipeline to provide a Private request\n libcamera: rkisp1: Replace usage of RkISP1FrameInfo\n libcamera: ipu3: Replace IPU3FrameInfo\n libcamera: ipu3: Return Raw buffers on error\n\n include/libcamera/internal/pipeline_handler.h | 5 +-\n include/libcamera/request.h | 3 +-\n src/libcamera/camera.cpp | 8 +-\n src/libcamera/pipeline/ipu3/frames.cpp | 143 -------\n src/libcamera/pipeline/ipu3/frames.h | 67 ----\n src/libcamera/pipeline/ipu3/ipu3.cpp | 215 +++++++----\n src/libcamera/pipeline/ipu3/meson.build | 1 -\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 359 +++++++-----------\n src/libcamera/pipeline_handler.cpp | 38 +-\n src/libcamera/request.cpp | 15 +-\n test/camera/statemachine.cpp | 12 -\n 11 files changed, 328 insertions(+), 538 deletions(-)\n delete mode 100644 src/libcamera/pipeline/ipu3/frames.cpp\n delete mode 100644 src/libcamera/pipeline/ipu3/frames.h\n\n--\n2.43.2"}