[{"id":28878,"web_url":"https://patchwork.libcamera.org/comment/28878/","msgid":"<170972952572.252503.1308982536118865562@ping.linuxembedded.co.uk>","date":"2024-03-06T12:52:05","subject":"Re: [PATCH 0/2] Add 14-bit Bayer format support","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Nick,\n\nQuoting Nick Hollinghurst (2024-03-05 11:01:34)\n> The following patches add 14-bit Bayer formats in v4l2_subdevice\n> and enable 14-bit embedded data parsing in the RPi IPA.\n> \n\nIt seems these patches don't apply directly as they report SBGGR16_1x16\nin the context, which isn't upstream yet.\n\nI'll handle the merge and apply already with the tags. Looks like\nsomeone needs to handle the 16bit formats separately.\n\n--\nKieran\n\n\n> Nick Hollinghurst (2):\n> libcamera: v4l2_subdevice: Add 14-bit Bayer formats\n> ipa: rpi: cam_helper: Extend embedded data parsing to RAW14 modes\n> \n> src/ipa/rpi/cam_helper/cam_helper_imx708.cpp | 2 +-\n> src/ipa/rpi/cam_helper/md_parser_smia.cpp | 11 +++++++----\n> src/libcamera/v4l2_subdevice.cpp | 4 ++++\n> 3 files changed, 12 insertions(+), 5 deletions(-)\n> \n> -- \n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 08AE7C0F2A\n\tfor ;\n\tWed, 6 Mar 2024 12:52:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2145962871;\n\tWed, 6 Mar 2024 13:52:10 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ADAC562867\n\tfor ;\n\tWed, 6 Mar 2024 13:52:08 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ED048BD1;\n\tWed, 6 Mar 2024 13:51:50 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WIQ6gisg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709729511;\n\tbh=ITDle4/9wfCgeLcGNletm5vsSvtZuBdxpNpRuMArGUE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=WIQ6gisg7/rAK8GzsOZO3/Pi9RQryqQobHF21hMFl3wLJWle3mR9oal3In6/hexQd\n\tB3D/ZKvL3iy7cVxuQYp8m0521vsMFy6lsqcotmKiP1uoFK9vibv3uUdPdN6/voM2V5\n\tg1IP2qmu9CA1b7Neci13Wf9prJw0I73b9YnSiJto=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240305110136.3624-1-nick.hollinghurst@raspberrypi.com>","References":"<20240305110136.3624-1-nick.hollinghurst@raspberrypi.com>","Subject":"Re: [PATCH 0/2] Add 14-bit Bayer format support","From":"Kieran Bingham ","To":"Nick Hollinghurst ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 06 Mar 2024 12:52:05 +0000","Message-ID":"<170972952572.252503.1308982536118865562@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Nick Hollinghurst ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28888,"web_url":"https://patchwork.libcamera.org/comment/28888/","msgid":"","date":"2024-03-06T16:33:00","subject":"Re: [PATCH 0/2] Add 14-bit Bayer format support","submitter":{"id":130,"url":"https://patchwork.libcamera.org/api/people/130/","name":"Nick Hollinghurst","email":"nick.hollinghurst@raspberrypi.com"},"content":"Hi Kieran,\n\nOn Wed, 6 Mar 2024 at 12:52, Kieran Bingham\n wrote:\n>\n> Hi Nick,\n>\n> Quoting Nick Hollinghurst (2024-03-05 11:01:34)\n> > The following patches add 14-bit Bayer formats in v4l2_subdevice\n> > and enable 14-bit embedded data parsing in the RPi IPA.\n> >\n>\n> It seems these patches don't apply directly as they report SBGGR16_1x16\n> in the context, which isn't upstream yet.\n>\n> I'll handle the merge and apply already with the tags. Looks like\n> someone needs to handle the 16bit formats separately.\n\nThank you -- I based it from the Raspberry Pi branch and I forgot to\ncheck for applicability!\n\n>\n> --\n> Kieran\n>\n>\n> > Nick Hollinghurst (2):\n> > libcamera: v4l2_subdevice: Add 14-bit Bayer formats\n> > ipa: rpi: cam_helper: Extend embedded data parsing to RAW14 modes\n> >\n> > src/ipa/rpi/cam_helper/cam_helper_imx708.cpp | 2 +-\n> > src/ipa/rpi/cam_helper/md_parser_smia.cpp | 11 +++++++----\n> > src/libcamera/v4l2_subdevice.cpp | 4 ++++\n> > 3 files changed, 12 insertions(+), 5 deletions(-)\n> >\n> > --\n> > 2.30.2\n> >\n\n Nick","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4112DBD160\n\tfor ;\n\tWed, 6 Mar 2024 16:41:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A46226286D;\n\tWed, 6 Mar 2024 17:41:26 +0100 (CET)","from mail-ed1-x530.google.com (mail-ed1-x530.google.com\n\t[IPv6:2a00:1450:4864:20::530])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C307E62867\n\tfor ;\n\tWed, 6 Mar 2024 17:41:24 +0100 (CET)","by mail-ed1-x530.google.com with SMTP id\n\t4fb4d7f45d1cf-56657bcd555so8964713a12.3\n\tfor ;\n\tWed, 06 Mar 2024 08:41:24 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"ND8J41oj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1709743284; x=1710348084;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=cvGpzNozOIMxxFlg40eKQKir68zcE/5lljBsYu/2I0c=;\n\tb=ND8J41ojR8jq4rAlaAepr4LRHdUyvm2IoN1LzrG8ixHAGz+3G03t38yTSh78u8Ir0r\n\tLv6RwgeK3Q9OF2aMbbsCZnhq55a6mJJzH9mKppd5amH0D6fRI7bFTmkAZERFJ1Wt6PDa\n\tdKF3J6LZfUvVqR5g+8FX+8jjZJ7iEOJ+8DOufmZm5FqrsWQn0x8QAcS2Po9TMw3L3rpF\n\tfBhwwi1BDvgI6rlnLi3Uoa71APqtKIcHq7yjwK/agpZVVanuh/ZDoQ6Z0VC1apxTkgYg\n\tExQYoqrrEirlxunL0IVeDWGYTLC/AvD338aCbWaBHoVHSivqsQTEW8yunOw3q4P1nyxV\n\tq6Pw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1709743284; x=1710348084;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=cvGpzNozOIMxxFlg40eKQKir68zcE/5lljBsYu/2I0c=;\n\tb=UjlxWzBbrmI6JtTUKHVAIXCxwT1RZoS3eg/ULQouQvPlIiXl0op9n4UeFyDMp1vf0P\n\tFko+u1/cHM14qBq+l0LAwV1CA6Oi5Px4lJnwSyiXEpUvXgeOBd6tD9UVkIYktXytuI46\n\th3OisH8ZhMTLFQlm8QiOo3dTtO5v713uWwpHhyuk+ZqBpbHx3yPvcIDaORAPl5e7ONWc\n\t8P+UkqSC4CmlMTic8Z57ABGOtfgkhiWdxS/OK51Je1ZmMr4Zxr1+/xgZYs2Ga7AjL9Eo\n\t/Uk6TzLclIzQ6AilfsG8fwFjZblkoQHtFntLiH9yyf/mv5iT2nXiOTYCZQ/BdEGzNRyb\n\tBv5A==","X-Gm-Message-State":"AOJu0YzcELVrsXEHUxJ3QQ+tbMrXta6ucfLMGew24VO4cfW7tbGZrsha\n\th+8Cl/QIn5jRENlYsZaJcXWBkJ+kiezed3SpKtYePdSxk9SmHFnXNLl6stTkPIRe5/KvMu5r8mA\n\t9J0A7ZnmfEoTo01KnUhbbk/V65i2CTwSUALwkGdhsB6RkWcFt","X-Google-Smtp-Source":"AGHT+IEMUR2CKCMa2nQmzqll6OAXs5VE+pRHqI8W0dFM3jokiz1eroruibxrcaEP1n6ksSISxNu33PLX1KCS9XPd5nA=","X-Received":"by 2002:a05:6512:3d8d:b0:513:57fe:97b8 with SMTP id\n\tk13-20020a0565123d8d00b0051357fe97b8mr4100757lfv.26.1709742792993;\n\tWed, 06 Mar 2024 08:33:12 -0800 (PST)","MIME-Version":"1.0","References":"<20240305110136.3624-1-nick.hollinghurst@raspberrypi.com>\n\t<170972952572.252503.1308982536118865562@ping.linuxembedded.co.uk>","In-Reply-To":"<170972952572.252503.1308982536118865562@ping.linuxembedded.co.uk>","From":"Nick Hollinghurst ","Date":"Wed, 6 Mar 2024 16:33:00 +0000","Message-ID":"","Subject":"Re: [PATCH 0/2] Add 14-bit Bayer format support","To":"Kieran Bingham ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]