[{"id":28843,"web_url":"https://patchwork.libcamera.org/comment/28843/","msgid":"<170962114834.566498.16457465540143434482@ping.linuxembedded.co.uk>","date":"2024-03-05T06:45:48","subject":"Re: [PATCH v1 0/1] Add environment variable to order pipelines match","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Julien,\n\nQuoting Julien Vuillaumier (2024-03-04 18:18:15)\n> \n> Hello,\n> \n> There is currently no way to configure the order used by the CameraManager\n> to select the pipeline handlers to match devices from the DeviceEnumerator.\n> That is a limitation when multiple pipeline are compiled in, capable of\n> handling the devices of the platform. In that case, user can not specify\n> the pipeline that will bind to the devices and handle the cameras.\n> \n> This change adds an environment variable, optionnaly initialized with an\n> ordered list of candidate pipelines that CameraManager shall use to match\n> the devices. When the variable is not set, CameraManager behavior is\n> unchanged: every registered pipeline is selected in turn to attempt device\n> matching. \n> \n> Using that variable, user has the option to explicitly select the pipeline\n> or the subset of available pipelines that CameraManager shall consider\n> for matching.\n\nThis indeed is a problem to solve. This looks like a good way to handle\nit, I think it's an indication that we need a libcamera configuration\nfile soon though, which would let these magic environment controls be\nset from either a config file or overridden by the environment.\n\nI have also wondered about setting 'prioirities' to pipeline handlers,\nsuch as making the simple pipeline handler a low priority handler, but\nthat doesn't solve individual cases for instance if that was the\npreferred choice, so I think we do need some explicit control from the\nusers environment.\n\n--\nKieran\n\n \n> Thanks\n> \n> \n> Julien Vuillaumier (1):\n> libcamera: camera_manager: Add environment variable to order pipelines\n> match\n> \n> Documentation/environment_variables.rst | 5 +++\n> src/libcamera/camera_manager.cpp | 51 +++++++++++++++++++++----\n> 2 files changed, 48 insertions(+), 8 deletions(-)\n> \n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9FB24BD160\n\tfor ;\n\tTue, 5 Mar 2024 06:45:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E443F6286F;\n\tTue, 5 Mar 2024 07:45:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F72061C83\n\tfor ;\n\tTue, 5 Mar 2024 07:45:51 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ABDA1CC8;\n\tTue, 5 Mar 2024 07:45:34 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Dtd6OTno\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709621134;\n\tbh=Md2IInltCkR8rIcnWrytkxuMHDptXXtBJWH6OyoJYDg=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Dtd6OTnoIIZ8frbkGtvC83RaDCKvqt2yKebOC16j2NDlu2e1MG7K/h/V+6xNau0wD\n\tq5cAZjsei2R641sezpa/hTvCxSKj+Wh4GW0VZZh+7448k/Huxzrz9yD26yCzK5VNtN\n\tuAIHZFjbKPQsho2+en5d3vRxfFfnq7Va0bFVDcxc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240304181816.2361334-1-julien.vuillaumier@nxp.com>","References":"<20240304181816.2361334-1-julien.vuillaumier@nxp.com>","Subject":"Re: [PATCH v1 0/1] Add environment variable to order pipelines match","From":"Kieran Bingham ","To":"Julien Vuillaumier ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 05 Mar 2024 06:45:48 +0000","Message-ID":"<170962114834.566498.16457465540143434482@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28891,"web_url":"https://patchwork.libcamera.org/comment/28891/","msgid":"<8960e9a9-b534-405d-b018-5b63c3c4726c@nxp.com>","date":"2024-03-06T17:57:45","subject":"Re: [EXT] Re: [PATCH v1 0/1] Add environment variable to order\n\tpipelines match","submitter":{"id":190,"url":"https://patchwork.libcamera.org/api/people/190/","name":"Julien Vuillaumier","email":"julien.vuillaumier@nxp.com"},"content":"Hi Kieran,\n\nOn 05/03/2024 07:45, Kieran Bingham wrote:\n> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button\n> \n> \n> Hi Julien,\n> \n> Quoting Julien Vuillaumier (2024-03-04 18:18:15)\n>>\n>> Hello,\n>>\n>> There is currently no way to configure the order used by the CameraManager\n>> to select the pipeline handlers to match devices from the DeviceEnumerator.\n>> That is a limitation when multiple pipeline are compiled in, capable of\n>> handling the devices of the platform. In that case, user can not specify\n>> the pipeline that will bind to the devices and handle the cameras.\n>>\n>> This change adds an environment variable, optionnaly initialized with an\n>> ordered list of candidate pipelines that CameraManager shall use to match\n>> the devices. When the variable is not set, CameraManager behavior is\n>> unchanged: every registered pipeline is selected in turn to attempt device\n>> matching.\n>>\n>> Using that variable, user has the option to explicitly select the pipeline\n>> or the subset of available pipelines that CameraManager shall consider\n>> for matching.\n> \n> This indeed is a problem to solve. This looks like a good way to handle\n> it, I think it's an indication that we need a libcamera configuration\n> file soon though, which would let these magic environment controls be\n> set from either a config file or overridden by the environment.\n> \n> I have also wondered about setting 'prioirities' to pipeline handlers,\n> such as making the simple pipeline handler a low priority handler, but\n> that doesn't solve individual cases for instance if that was the\n> preferred choice, so I think we do need some explicit control from the\n> users environment.\n\nAssigning priorities to pipelines would be an option indeed, if \npriorities can be reconfigured at runtime to select the desired \npipeline(s). Though an ordered list seems to give the same flexibility \nand be slightly easier to handle.\n\nUsing config file would also be a convenient way of specifying the \npipelines to select. It could come at some point in addition to the \nenvironment variable, for instance to setup a static pipeline \nconfiguration for a platform. The environment variable would still \nremain a convenient option for engineering and testing though.\n\nThanks,\nJulien\n\n\n> \n> --\n> Kieran\n> \n> \n>> Thanks\n>>\n>>\n>> Julien Vuillaumier (1):\n>> libcamera: camera_manager: Add environment variable to order pipelines\n>> match\n>>\n>> Documentation/environment_variables.rst | 5 +++\n>> src/libcamera/camera_manager.cpp | 51 +++++++++++++++++++++----\n>> 2 files changed, 48 insertions(+), 8 deletions(-)\n>>\n>> --\n>> 2.34.1\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AB9E3C0F2A\n\tfor ;\n\tWed, 6 Mar 2024 17:57:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F0EF462867;\n\tWed, 6 Mar 2024 18:57:43 +0100 (CET)","from EUR02-AM0-obe.outbound.protection.outlook.com\n\t(mail-am0eur02on20601.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:2606::601])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A8D0061C8F\n\tfor ;\n\tWed, 6 Mar 2024 18:57:42 +0100 (CET)","from AM9PR04MB8147.eurprd04.prod.outlook.com\n\t(2603:10a6:20b:3e0::22)\n\tby AM9PR04MB8907.eurprd04.prod.outlook.com (2603:10a6:20b:40a::22)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.39;\n\tWed, 6 Mar 2024 17:57:40 +0000","from AM9PR04MB8147.eurprd04.prod.outlook.com\n\t([fe80::3fdf:4cf8:d542:1b49]) by\n\tAM9PR04MB8147.eurprd04.prod.outlook.com\n\t([fe80::3fdf:4cf8:d542:1b49%4]) with mapi id 15.20.7362.019;\n\tWed, 6 Mar 2024 17:57:40 +0000"],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"RGi6jfJv\";\n\tdkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=nxp.com;"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n\tb=hnQdS+EbRUlU/RbnpOhV8gBwk4cYYeH6ZBI+2ARVmbfIAK8U++fhgn7z7smee6+Abh0lgtVybcHGlIUMuh1NyDPkmg60/mPOL3/scoRi6y824VL4zpsgJvnK4jGcJtj6jQKwf7lC+xHWtNb6wvy0ZrMHFIK7t1mdmt0b9bTnY1LHO/t37Bhe39Y4wceB+5+/u8nC4UH16NC2WKyZs28RppdGSBiaIxtPpVmnBxT+HlSIvTSzvxo7jRjzugD+D8siqlnTUIX1nRm6kOoX16yEHOFWwbgG1F1qlF+pd7iWhC+/z48DUDDhk328K2ObkC5B0g66o75ntxeglGClxprEXA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector9901;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=77hDI7LVxI/yOCiffbmQ6dPbCRCGPBq6FX83nqRQYw4=;\n\tb=ftAY18RKF+s5MKkV3d8fY/om90ZUaET9eN41NMv7qAjHDxNjvwzn7QQRUyrNzJG9SBSXeCFi9NdvlfZaYSgkCone4ojPEGx5njyG8B0pgcaBY/GSe2PbhKMjVCY4QmgBhW2oUHbL+z4kw04VDcO2Ykb4/wAnbcAWb8aUR61m0vw66+SolLwFN1MnAZxLqFUsa46uJ9VzavsAItK2Yht+INm+RdWYbtVhEqTLIctrEcBcklqinUF655WJq5Wumw4GePJQGMTMEwEcre9ECZpIHhZBUGoY+ih/a1zbJbUmgDTUBJc0wIcxAW8OfLCbh38GyiCo/m04TlPp9c0k2Z00SQ==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com;\n\tdkim=pass header.d=nxp.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=77hDI7LVxI/yOCiffbmQ6dPbCRCGPBq6FX83nqRQYw4=;\n\tb=RGi6jfJvY2vaWSHUcOKNLkoNEaDSQEMQdWgI83hqHTFuCMhJO86s4SzlCLBBGH5ohwM3MyPNAzAn4FBADDFkB/DEVR40Gg1bpFaggxZ8o4C1njUFJuidoQt7KHdl1XUG6hCnKY7piJVoYbMIBAvCEm/DLeTcqml5QRYbgf5FsJs=","Message-ID":"<8960e9a9-b534-405d-b018-5b63c3c4726c@nxp.com>","Date":"Wed, 6 Mar 2024 18:57:45 +0100","User-Agent":"Mozilla Thunderbird","Subject":"Re: [EXT] Re: [PATCH v1 0/1] Add environment variable to order\n\tpipelines match","Content-Language":"en-US","To":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20240304181816.2361334-1-julien.vuillaumier@nxp.com>\n\t<170962114834.566498.16457465540143434482@ping.linuxembedded.co.uk>","From":"Julien Vuillaumier ","In-Reply-To":"<170962114834.566498.16457465540143434482@ping.linuxembedded.co.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"AS4P190CA0069.EURP190.PROD.OUTLOOK.COM\n\t(2603:10a6:20b:656::15) To AM9PR04MB8147.eurprd04.prod.outlook.com\n\t(2603:10a6:20b:3e0::22)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"AM9PR04MB8147:EE_|AM9PR04MB8907:EE_","X-MS-Office365-Filtering-Correlation-Id":"4c900f6c-d4d8-406a-dcbb-08dc3e06ea60","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;","X-Microsoft-Antispam-Message-Info":"KsDnksbw6xtFbkSCJDjgg59XkD3T5NajulBNpZVqYJmqPRAqvxQB4Hm4uSv7Z4Uyp+kcwJ3gHYgYMgzjU10oYEaGrcWHIZbplWf/HP3Fk13Rh6g++geP8itJAZuJdnVPESiIgrmauSJXZ37k35BNQFvIkB8tfEiWdf4/1vu4yWrTuxBadkpF1ZhYmnoOLyoWji/1BVOL9Kzo9nrPYLHqzeNpJDP2Kof6HTsbow4RPckA3raI6xDgfTLokFC5hnfG4kwyuenDuZSwyhAsja+g+OZtFiBzcdWsZiSJm3r+LL8P+P3q0z46GnpFofp9TNY87477BFav1b+5wV62yc9/Ln+7jT0rbqTlR35FVOdBm1sDx8mVldJp3ykKfafAhiZEKKQtPn7DAlbZiDvf2BQYByrnySUHpqbuHn5XGp+HqbiLF0D1pPsg9K69f5BvsI30mNNb9uduNKRx6N6bkGdJvIThLWuBaro82KwIITYrrtPy+TjG4q1SvWfobWXJetaTMZ3f5gGBFKxGeDxSu4YmaxBnVT1c/lsiC7GMY/QCWjz7x5DhNj6QzLBrKx26T5dhJ8kqlelR55TQfQR6nzDAZhKh7ipofjKAYn4/CXD6cPbp48yED3q7tKcDwKg/evFOfZaAeK4vHawLl3qG5YHYB7c2OCUD/LHpiuM6SjRRPdU=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:AM9PR04MB8147.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230031)(376005); DIR:OUT; SFP:1101; ","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?EwiesiViLVu4plkBeakH8YLd4?=\n\t=?utf-8?q?kdgT9SnE4/uBLe3bZ3vh585Zh/Ip1O/PRFVOZE+iyv1BtijCcU5JzuGg?=\n\t=?utf-8?q?2TnRR9FPgYRt7qV/djgTTBSTh9ziAYNakLROyTcNrlRIi4OyBJvevJZ7?=\n\t=?utf-8?q?1XXJ3QRKoziWtWej6/iP+SP5lbFlGR1o2hQ4Tzih7jIW0lVwlpDqOP0x?=\n\t=?utf-8?q?pmHvke6uRSpkFN2tXsbhbcfRAfd7lJJuv+OUUdOFGG+7VG86zbarkptD?=\n\t=?utf-8?q?xgjHW1qwTKqj8WVvTk1orxQk1tQe5KBDnKmhclA/aH8PmU2T+gu90dFi?=\n\t=?utf-8?q?E2TurwR0BM7n+OMxH7vhZUGZiCYFiX36ZHZk0D8sHpaJk9VP0WXU46ys?=\n\t=?utf-8?q?jdUtVPlzpHk+CmAO2Si9fOp0C9OTnttOwv2u8GpiBf1L2g46T4wbKFJ9?=\n\t=?utf-8?q?K0RnA8l7+SuAk2dGNBtAMcqrQWsg/XKbAzuOtfHQ+nPg5CNSHVD+JI4J?=\n\t=?utf-8?q?EU0VrI0SWUG6rQiUUOZUO3oipEfVZqcPLtRvOdgT+stARSCi52nw9rnV?=\n\t=?utf-8?q?VO5AScOZm8sRa6ssEw4FJ/XiWRRqEQV9Uw4TwDuha54EaxkLjl7HQV8O?=\n\t=?utf-8?q?IGSZ5PzmhvTu8KoIzZcElngF71K9gcHbjzC+MDFhV+1xxUjDtUarCoeG?=\n\t=?utf-8?q?qs13p2Ivfdrh2BFnz+PTP5uhFhfGOUKsQyjVoQoJKhCS5VTO5C22m4No?=\n\t=?utf-8?q?PD3TBU527NeBz+TPSToLtlc8hRlfsGckvc6VVzqUm+ZZ1yP5qRecEPta?=\n\t=?utf-8?q?gvP+uC8cUNWVMtsZMOrI4Ck5Vk7N0+MXkOXPSzu+Qtx9Ff6TAT+a2OZc?=\n\t=?utf-8?q?JBWYwRGfyGp2x384PX9hw1RIj4wymFvpSPwyhhdNbDzRlih/BXuPDu0Q?=\n\t=?utf-8?q?7Y/90f7aCtmjfUWUNFCE27BpD72PyTfaUEJctHnxupMjN7gm3xKlEMuJ?=\n\t=?utf-8?q?UG6NivImvHPnUdwvi1XrHQOhaJDk7MHXuvyuTCmP1+65B80O7Y9bLjz7?=\n\t=?utf-8?q?m31Zb5lymMnCuAtFUxJ4IPQIFuRfVrUEAT7x6+QTdD/HGOLl0IWIEngq?=\n\t=?utf-8?q?iKkvxE6ZUrpr5800Y/Vjdf/sjw5xd3I73X6IpJdD0l5zmn28Ul19gv5Y?=\n\t=?utf-8?q?62nCTvaRzgtA3F5jS531Is3992F5l1zX7wKM5DXT0aL6ixaI5J9bbYo8?=\n\t=?utf-8?q?Gd7dbBO3vwH6TOBJKa0Iv67Az7PbGT2zQE9SThW/ExoyjrraILL0Uxmn?=\n\t=?utf-8?q?7GwYCR/SC4T9aiKYIxmeRW+sNPsPgm+DGmRQpXFO3D56mOPQYtZ11DMP?=\n\t=?utf-8?q?zqPCs8uZNwb08MnwvF3pm0LCPW3CgGOhQR8EEYCgVVa3D3SsQzCvejzG?=\n\t=?utf-8?q?J73isq22rR3mCNh99puyhB831lQfrXG5iZNNRd/TYNSRvLXyyHv10/Hm?=\n\t=?utf-8?q?HWwGNgEzsG6Jmfqa+zMP5Qi/ZohLClftnEB1Y1p1KI1dRzvPH8WqQZEB?=\n\t=?utf-8?q?jiEbFYNmNiiiApcFtTzS5r3LB2YuzXWV4dUTqmqePaTrDIwgAfFwWudn?=\n\t=?utf-8?q?uV/nzSPMJVryDJX0oiuCau2iUjIj128f6ldoRV1S9Ygmqbb/c2GUdBAu?=\n\t=?utf-8?q?I//wpkUkAiTl2l0e5OhRdMasX3BmdbDlq7+DgeNWOq1bV/UVw6EWOOAa?=\n\t=?utf-8?q?jeC2LbNY8u+4FG6TGadlRylnNnYQw=3D=3D?=","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"4c900f6c-d4d8-406a-dcbb-08dc3e06ea60","X-MS-Exchange-CrossTenant-AuthSource":"AM9PR04MB8147.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"06 Mar 2024 17:57:40.3635\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"LrPioJ/5OqsCNg+rnWurjIauyrMGOXOIHKPkD3DyF6aba9LMcXr5lCWa1IrOmjY4II92SKC6b8LdyPSoPyK0ZM7rGxJ463UfW2asVVKqrsg=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AM9PR04MB8907","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]