[{"id":2652,"web_url":"https://patchwork.libcamera.org/comment/2652/","msgid":"<20190913170555.GA6193@localhost.localdomain>","date":"2019-09-13T17:05:55","subject":"Re: [libcamera-devel] [PATCH 0/4] Fix udev device enumerator with\n\tV4L2 M2M devices","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Thu, Sep 12, 2019 at 11:03:26PM +0300, Laurent Pinchart wrote:\n> Hello,\n> \n> The latest rework of the udev device enumerator to support delayed\n> device initialisation broke V4L2 M2M support, as it assumes that a\n> device node belongs to a single entity. As I'm guilty of having missed\n> that during review, here's a patch series to fix it.\n\nThank you for the fix :)\n\n> The first three patches are drive-by cleanups, while the real fix is in\n> patch 4/4.\n\nThey all look good to me.\n\nFor all patches,\nReviewed-by: Paul Elder \n\n> Laurent Pinchart (4):\n> libcamera: device_enumerator: Move lookupDeviceNode() to child classes\n> libcamera: device_enumerator_udev: Delay device node lookup\n> libcamera: device_enumerator_udev: Avoid double list lookup\n> libcamera: device_enumerator_udev: Support entities sharing device\n> nodes\n> \n> src/libcamera/device_enumerator.cpp | 13 --\n> src/libcamera/device_enumerator_sysfs.cpp | 11 ++\n> src/libcamera/device_enumerator_udev.cpp | 116 ++++++++++++------\n> src/libcamera/include/device_enumerator.h | 2 -\n> .../include/device_enumerator_sysfs.h | 2 +-\n> .../include/device_enumerator_udev.h | 27 +++-\n> 6 files changed, 113 insertions(+), 58 deletions(-)\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4108360BD9\n\tfor ;\n\tFri, 13 Sep 2019 19:06:03 +0200 (CEST)","from localhost.localdomain (unknown [96.44.9.94])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 75414325;\n\tFri, 13 Sep 2019 19:06:02 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1568394362;\n\tbh=9/BIEqtuU5IJY1U3Jthg7ZqWfO46wkjYjWbbfnXbweg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=e1AV8ajj9BwlMhGIK9Vjcq4JYFtI/VIi3h4jtRMcl4yV/WBbc0wmlKezgNQSN4Ss8\n\t9Mn32pkQgYRIUp8+8tNixYJIFefnOzQ7TPWcx0IEEDls4OeMPygiZINX7Mb1v7RMfR\n\t3BNzZENkFaTueDamDJwR8tDmFKUq11ssgpIacp3s=","Date":"Fri, 13 Sep 2019 13:05:55 -0400","From":"Paul Elder ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190913170555.GA6193@localhost.localdomain>","References":"<20190912200330.19004-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20190912200330.19004-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 0/4] Fix udev device enumerator with\n\tV4L2 M2M devices","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 13 Sep 2019 17:06:03 -0000"}}]