{"id":19477,"url":"https://patchwork.libcamera.org/api/covers/19477/?format=json","web_url":"https://patchwork.libcamera.org/cover/19477/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240212153532.179283-1-dan.scally@ideasonboard.com>","date":"2024-02-12T15:35:27","name":"[0/5] Remove RkISP1FrameInfo class","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/?format=json","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/19477/mbox/","series":[{"id":4166,"url":"https://patchwork.libcamera.org/api/series/4166/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4166","date":"2024-02-12T15:35:27","name":"Remove RkISP1FrameInfo class","version":1,"mbox":"https://patchwork.libcamera.org/series/4166/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/19477/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B647DBDE17\n\tfor ;\n\tMon, 12 Feb 2024 15:35:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC66262807;\n\tMon, 12 Feb 2024 16:35:44 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7500A61CB6\n\tfor ;\n\tMon, 12 Feb 2024 16:35:43 +0100 (CET)","from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B5FE2D8;\n\tMon, 12 Feb 2024 16:35:41 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Fp4b7QaY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1707752141;\n\tbh=4GHKDGusIwVaM05g22b85HXhcK/Lj8qo+ILzaWKGSKU=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Fp4b7QaY3Lb2u5AxQg3cqfgrIgpvf4+X4Zvljzz8B74rVIr7Tr6oUTsy3OKgrzVEx\n\txVCgL5rTcbOzRj3/lLgQ7UqVkuAmhE16cFicXMQ2S8eLjG/H5zxvHJu9LTsMr9Pmhy\n\t+4NC0nKvjqh8gqfchuSe8XPUSB6Vqij4rtT50KOc=","From":"Daniel Scally ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH 0/5] Remove RkISP1FrameInfo class","Date":"Mon, 12 Feb 2024 15:35:27 +0000","Message-Id":"<20240212153532.179283-1-dan.scally@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello all\n\nThe RkISP1FrameInfo class exists (at least so far as I understand things) to\nkeep track of when a Request can be completed by tracking the status of the\nvideo, stats and parameters buffers. I don't see that the class is really\nnecessary for the job, so this series represents an attempt at removing it and\nre-factoring the functionality of its methods out to elsewhere in the pipeline\nhandler.\n\nThanks\nDan\n\nDaniel Scally (5):\n libcamera: rkisp1: Make tryCompleteRequest() params agnostic\n libcamera: rkisp1: Standardise frame number tracking\n libcamera: rkisp1: Switch IPA slots to use bufferId not frame\n libcamera: rkisp1: Switch tryCompleteRequest() to use Request *\n libcamera: rkisp1: Remove RkISP1FrameInfo\n\n include/libcamera/ipa/rkisp1.mojom | 4 +-\n src/ipa/rkisp1/rkisp1.cpp | 4 +-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 327 ++++++-----------------\n 3 files changed, 91 insertions(+), 244 deletions(-)"}