[{"id":28503,"web_url":"https://patchwork.libcamera.org/comment/28503/","msgid":"<20240122074001.GG4378@pendragon.ideasonboard.com>","date":"2024-01-22T07:40:01","subject":"Re: [libcamera-devel] [PATCH v2 0/3] apps: qcam: Port to Qt 6","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Neal,\n\nThank you for the patch.\n\nOn Sun, Jan 21, 2024 at 05:39:52PM -0500, Neal Gompa via libcamera-devel wrote:\n> Open source Qt 5 has been effectively end of life since the release\n> of Qt 6, and Qt 6 has current LTS releases now.\n> \n> This change ports qcam to Qt 6.2 and drops some of the baggage related\n> to Qt 5 that is no longer applicable.\n> \n> Additionally, a couple of patches are included to update documentation\n> references from Qt 5 to Qt 6.\n\nI'll give this a try, I'm currently installing Qt 6, which is taking a\nbit of time as I'm running Gentoo :-) It seems that Debian bookworm and\nbullseye-backports both carry Qt 6, so we should be fine from that point\nof view.\n\n> === Changelog ===\n> \n> v2: Bump Meson to v0.63 for Qt6 module\n> \n> v1: Initial patch set\n> \n> Neal Gompa (3):\n> apps: qcam: Port to Qt 6\n> libcamera: base: signal: Update Qt documentation link to Qt 6\n> Documentation: Update Qt documentation links to Qt 6\n> \n> .../guides/application-developer.rst | 2 +-\n> Documentation/guides/pipeline-handler.rst | 2 +-\n> README.rst | 2 +-\n> meson.build | 2 +-\n> src/apps/qcam/meson.build | 45 ++++++-------------\n> src/libcamera/base/signal.cpp | 2 +-\n> 6 files changed, 18 insertions(+), 37 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A170BC323E\n\tfor ;\n\tMon, 22 Jan 2024 07:40:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DAB1361D2D;\n\tMon, 22 Jan 2024 08:39:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ECF8A61D2D\n\tfor ;\n\tMon, 22 Jan 2024 08:39:57 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EC27B221;\n\tMon, 22 Jan 2024 08:38:44 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1705909199;\n\tbh=8Np1144Iy+iMxzbBnWmBGU4+43j/QcvNXeGUAsbGb1w=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=i2oM8RKtmdLZTgEkPsTJEQ/XNIjR2IiTZQyaWE3ug+rvJUihZS7AwuFDIgugGAym6\n\t+kc0WJWIdu7VUGAg1OEU2u0jACJFo+7xmEH8+QC/FJUlzTL65Ws8wXhrhrkfDtePJG\n\teXwwLWcFrX28wzy2qsryMe5OQBYFysLnfUwqGTWeBujwC8A0DinY7vH8hxgl0GqdqI\n\tH+zr7GL84VJddIfTHUN6Y6k4RFcXS5PDjEQWgIiXoQ4GVGe4pLBvYCEn2fWBMtwHhV\n\tyEEJOLCKw5YUusPn+4ZB1e+tfbI/IeG9s5gkAsWsGVybT8DlBPtbjytu+WeDgwPQI7\n\tAUP8J/DjEXzuA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705909125;\n\tbh=8Np1144Iy+iMxzbBnWmBGU4+43j/QcvNXeGUAsbGb1w=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jqJisCgGwV/5Pvna9x9Cik9zFOPm5ApBuZIyaJOkRppeZc9TPgxik3trbl6DQV5ZS\n\tD56BID9r0IHlPz8NA2a2bzrL94jREmHBvTbRR5pRHl1B4NzptpepPsdtS5JR7B/wE1\n\t0qd0uc8L1NSUS0EJT8bvHqG2whTFN4bFL//HTsII="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"jqJisCgG\"; dkim-atps=neutral","Date":"Mon, 22 Jan 2024 09:40:01 +0200","To":"Neal Gompa ","Message-ID":"<20240122074001.GG4378@pendragon.ideasonboard.com>","References":"<20240121224052.1049989-1-neal@gompa.dev>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240121224052.1049989-1-neal@gompa.dev>","Subject":"Re: [libcamera-devel] [PATCH v2 0/3] apps: qcam: Port to Qt 6","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28510,"web_url":"https://patchwork.libcamera.org/comment/28510/","msgid":"<20240122095211.GL4378@pendragon.ideasonboard.com>","date":"2024-01-22T09:52:11","subject":"Re: [libcamera-devel] [PATCH v2 0/3] apps: qcam: Port to Qt 6","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Jan 22, 2024 at 09:40:01AM +0200, Laurent Pinchart via libcamera-devel wrote:\n> On Sun, Jan 21, 2024 at 05:39:52PM -0500, Neal Gompa via libcamera-devel wrote:\n> > Open source Qt 5 has been effectively end of life since the release\n> > of Qt 6, and Qt 6 has current LTS releases now.\n> > \n> > This change ports qcam to Qt 6.2 and drops some of the baggage related\n> > to Qt 5 that is no longer applicable.\n> > \n> > Additionally, a couple of patches are included to update documentation\n> > references from Qt 5 to Qt 6.\n> \n> I'll give this a try, I'm currently installing Qt 6, which is taking a\n> bit of time as I'm running Gentoo :-) It seems that Debian bookworm and\n> bullseye-backports both carry Qt 6, so we should be fine from that point\n> of view.\n\nI gave this a quick try on Gentoo, and qcam seems to compile and run. It\nis however not displaying icons in the toolbar. Have you noticed that ?\n\n> > === Changelog ===\n> > \n> > v2: Bump Meson to v0.63 for Qt6 module\n> > \n> > v1: Initial patch set\n> > \n> > Neal Gompa (3):\n> > apps: qcam: Port to Qt 6\n> > libcamera: base: signal: Update Qt documentation link to Qt 6\n> > Documentation: Update Qt documentation links to Qt 6\n> > \n> > .../guides/application-developer.rst | 2 +-\n> > Documentation/guides/pipeline-handler.rst | 2 +-\n> > README.rst | 2 +-\n> > meson.build | 2 +-\n> > src/apps/qcam/meson.build | 45 ++++++-------------\n> > src/libcamera/base/signal.cpp | 2 +-\n> > 6 files changed, 18 insertions(+), 37 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2C58AC323E\n\tfor ;\n\tMon, 22 Jan 2024 09:52:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2C32162945;\n\tMon, 22 Jan 2024 10:52:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B8F51628AD\n\tfor ;\n\tMon, 22 Jan 2024 10:52:07 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 99395221;\n\tMon, 22 Jan 2024 10:50:54 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1705917129;\n\tbh=xhw9IEp7DSoMtASQqyQxulgg1mdsbNNf88OplM66szQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=LJ2vitWOb5Gyxz6ihZKeqSBm/WrF26IXKDUXe62aqC1pDXw+G0/oVRg0a9vR5XXll\n\tK3cn9cFjI7ZdRKZIt6haJj1SdDCwl0J6SoNyAZa3r0uEMbxN/lkwRSXuGZn20aKsDU\n\tsAB1nlg1lu7wVVMsa+zTYV2DbPC1/GYmBO5Awgqy/jRzqlEAaUm2mrbElqo+zy4aCk\n\t1gDTk/QWGi9Kweox5L28qSf2nJe5V4PdsWFhH+y6HWBqJ/1wlZkvW4i3vcZDx373WO\n\tjrePBmkrpZjsbyPHLyOZ9eSZQKRk6kvb7D95qrkS0JJVd19Jjajf8Z+KVI2+/He/4T\n\tMQboExs2SP8NA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705917054;\n\tbh=xhw9IEp7DSoMtASQqyQxulgg1mdsbNNf88OplM66szQ=;\n\th=Date:From:To:Subject:References:In-Reply-To:From;\n\tb=VeVlKmQPpVaG1Jm3fUv03tHijzdYgMMgy3SjUuhhJ6m6LdhhnnD/XQzHu6znZmqjt\n\t/RF5jXsrbf5fiYp+GG8GOcYLvzkEXqz5nGPx+udnwtxmzynEUmpT8+bNbC8ilfdpMW\n\t0g6h+PolIc8z9tl6IkPG2vORfPBMBTy9HF4flmro="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VeVlKmQP\"; dkim-atps=neutral","Date":"Mon, 22 Jan 2024 11:52:11 +0200","To":"Neal Gompa ,\n\tlibcamera-devel ,\n\tWim Taymans ","Message-ID":"<20240122095211.GL4378@pendragon.ideasonboard.com>","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240122074001.GG4378@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240122074001.GG4378@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 0/3] apps: qcam: Port to Qt 6","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31126,"web_url":"https://patchwork.libcamera.org/comment/31126/","msgid":"<20240909130750.GI15491@pendragon.ideasonboard.com>","date":"2024-09-09T13:07:50","subject":"Re: [libcamera-devel] [PATCH v2 0/3] apps: qcam: Port to Qt 6","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Neal,\n\nI realized today that the gles rendered in qcam is broken :-( Reverting\nback to qt5 works for me, so it's related to this patch series. Could\nyou please test ('qcam -r gles') and investigate ?\n\nOn Sun, Jan 21, 2024 at 05:39:52PM -0500, 📷-dev wrote:\n> Open source Qt 5 has been effectively end of life since the release\n> of Qt 6, and Qt 6 has current LTS releases now.\n> \n> This change ports qcam to Qt 6.2 and drops some of the baggage related\n> to Qt 5 that is no longer applicable.\n> \n> Additionally, a couple of patches are included to update documentation\n> references from Qt 5 to Qt 6.\n> \n> === Changelog ===\n> \n> v2: Bump Meson to v0.63 for Qt6 module\n> \n> v1: Initial patch set\n> \n> Neal Gompa (3):\n> apps: qcam: Port to Qt 6\n> libcamera: base: signal: Update Qt documentation link to Qt 6\n> Documentation: Update Qt documentation links to Qt 6\n> \n> .../guides/application-developer.rst | 2 +-\n> Documentation/guides/pipeline-handler.rst | 2 +-\n> README.rst | 2 +-\n> meson.build | 2 +-\n> src/apps/qcam/meson.build | 45 ++++++-------------\n> src/libcamera/base/signal.cpp | 2 +-\n> 6 files changed, 18 insertions(+), 37 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A6F1C324C\n\tfor ;\n\tMon, 9 Sep 2024 13:07:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4DF31634EE;\n\tMon, 9 Sep 2024 15:07:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BB840634EB\n\tfor ;\n\tMon, 9 Sep 2024 15:07:53 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(213-229-8-243.static.upcbusiness.at [213.229.8.243])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6DA133DA;\n\tMon, 9 Sep 2024 15:06:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IoKJV/OO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725887197;\n\tbh=CfRnWXcHpAieFDPpEHBXktZ0KWdedLAY48Ao08nnY54=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IoKJV/OO5gSBUj/2JKFcWizOUkNuLjhQnx1qS7eBppOfnGZykpdqosGuUezBITjNv\n\tjYtSbF0epmHMMKMwRCRSOd6+FaJYUGKWBVKypMGmG4DwEadIXSSc/yqspSxbSUgOFo\n\tFPLcNFvzycTgcN333PA1HWAntuRiDVLaBAsq+XIM=","Date":"Mon, 9 Sep 2024 16:07:50 +0300","From":"Laurent Pinchart ","To":"Neal Gompa ","Cc":"libcamera-devel ,\n\tWim Taymans ","Subject":"Re: [libcamera-devel] [PATCH v2 0/3] apps: qcam: Port to Qt 6","Message-ID":"<20240909130750.GI15491@pendragon.ideasonboard.com>","References":"<20240121224052.1049989-1-neal@gompa.dev>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20240121224052.1049989-1-neal@gompa.dev>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31135,"web_url":"https://patchwork.libcamera.org/comment/31135/","msgid":"<172589840086.2319503.4579803717873138641@ping.linuxembedded.co.uk>","date":"2024-09-09T16:13:20","subject":"Re: [libcamera-devel] [PATCH v2 0/3] apps: qcam: Port to Qt 6","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-09-09 14:07:50)\n> Hi Neal,\n> \n> I realized today that the gles rendered in qcam is broken :-( Reverting\n> back to qt5 works for me, so it's related to this patch series. Could\n> you please test ('qcam -r gles') and investigate ?\n\nI just tested this and have the following backtrace on Fedora Rawhide...\n\n(gdb) bt\n#0 0x0000ffffce368b3c in void st_update_array_templ<(util_popcnt)2, (st_fill_tc_set_vb)0, (st_use_vao_fast_path)1, (st_allow_zero_stride_attribs)0, (st_identity_attrib_mapping)0, (st_allow_user_buffers)0, (st_update_velems)1>(st_context*, unsigned int, unsigned int, unsigned int) () at /lib64/libgallium-24.2.1.so\n#1 0x0000ffffce0f9484 in st_prepare_draw () at /lib64/libgallium-24.2.1.so\n#2 0x0000ffffce294384 in _mesa_draw_arrays.part.0 () at /lib64/libgallium-24.2.1.so\n#3 0x0000000000454934 in QOpenGLFunctions::glDrawArrays (this=0x722d60, mode=6, first=0, count=4) at /usr/include/qt6/QtGui/qopenglfunctions.h:709\n#4 0x000000000045438c in ViewFinderGL::paintGL (this=0x722d30) at ../../src/apps/qcam/viewfinder_gl.cpp:823\n#5 0x0000fffff74e2f00 in QOpenGLWidgetPrivate::render() () at /lib64/libQt6OpenGLWidgets.so.6\n#6 0x0000fffff5dceecc in QWidget::event(QEvent*) () at /lib64/libQt6Widgets.so.6\n#7 0x0000fffff5d6ea18 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () at /lib64/libQt6Widgets.so.6\n#8 0x0000fffff6f71d58 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () at /lib64/libQt6Core.so.6\n#9 0x0000fffff5dc598c in QWidgetPrivate::sendPaintEvent(QRegion const&) () at /lib64/libQt6Widgets.so.6\n#10 0x0000fffff5ddba1c in QWidgetRepaintManager::paintAndFlush() () at /lib64/libQt6Widgets.so.6\n#11 0x0000fffff5dcf64c in QWidget::event(QEvent*) () at /lib64/libQt6Widgets.so.6\n#12 0x000000000043af30 in MainWindow::event (this=0x7c0440, e=0xffffd40042c0) at ../../src/apps/qcam/main_window.cpp:177\n#13 0x0000fffff5d6ea18 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () at /lib64/libQt6Widgets.so.6\n#14 0x0000fffff6f71d58 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () at /lib64/libQt6Core.so.6\n#15 0x0000fffff6f76068 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () at /lib64/libQt6Core.so.6\n#16 0x0000fffff7272fd4 in postEventSourceDispatch(_GSource*, int (*)(void*), void*) () at /lib64/libQt6Core.so.6\n#17 0x0000fffff48d0b94 in g_main_context_dispatch_unlocked.lto_priv () at /lib64/libglib-2.0.so.0\n#18 0x0000fffff49341d0 in g_main_context_iterate_unlocked.isra () at /lib64/libglib-2.0.so.0\n#19 0x0000fffff48d2264 in g_main_context_iteration () at /lib64/libglib-2.0.so.0\n#20 0x0000fffff7272658 in QEventDispatcherGlib::processEvents(QFlags) () at /lib64/libQt6Core.so.6\n#21 0x0000fffff6f7f694 in QEventLoop::exec(QFlags) () at /lib64/libQt6Core.so.6\n#22 0x0000fffff6f7ac3c in QCoreApplication::exec() () at /lib64/libQt6Core.so.6\n#23 0x0000000000439a24 in main (argc=3, argv=0xffffffffeeb8) at ../../src/apps/qcam/main.cpp:87\n(gdb) quit\nA debugging session is active.\n\n--\nKieran\n\n\n> \n> On Sun, Jan 21, 2024 at 05:39:52PM -0500, 📷-dev wrote:\n> > Open source Qt 5 has been effectively end of life since the release\n> > of Qt 6, and Qt 6 has current LTS releases now.\n> > \n> > This change ports qcam to Qt 6.2 and drops some of the baggage related\n> > to Qt 5 that is no longer applicable.\n> > \n> > Additionally, a couple of patches are included to update documentation\n> > references from Qt 5 to Qt 6.\n> > \n> > === Changelog ===\n> > \n> > v2: Bump Meson to v0.63 for Qt6 module\n> > \n> > v1: Initial patch set\n> > \n> > Neal Gompa (3):\n> > apps: qcam: Port to Qt 6\n> > libcamera: base: signal: Update Qt documentation link to Qt 6\n> > Documentation: Update Qt documentation links to Qt 6\n> > \n> > .../guides/application-developer.rst | 2 +-\n> > Documentation/guides/pipeline-handler.rst | 2 +-\n> > README.rst | 2 +-\n> > meson.build | 2 +-\n> > src/apps/qcam/meson.build | 45 ++++++-------------\n> > src/libcamera/base/signal.cpp | 2 +-\n> > 6 files changed, 18 insertions(+), 37 deletions(-)\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CBA46BF415\n\tfor ;\n\tMon, 9 Sep 2024 16:13:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 00AF2634EE;\n\tMon, 9 Sep 2024 18:13:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 874F4634EB\n\tfor ;\n\tMon, 9 Sep 2024 18:13:24 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 22AA55A4;\n\tMon, 9 Sep 2024 18:12:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uttUAXIu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725898328;\n\tbh=/iQaDOHDT8I1zX/VNFabi1uoUwZA9GDjTXxbArcaXmg=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=uttUAXIuHzpjxv7zZq6JxbOKrICgF2wqve5AaFsOjFVAF5jZaJ+5Fupqwl5wDQR1n\n\tc9eviDVYfp9S42Sbn3udEBcVO4UYID3Dp3nRuF6VQ+nGSxB1xFQwtHoEGFlnaL2nuI\n\tvPda23HHtM7WtFlFAhn+Zp0qpuRtDgJlqZeXnE/A=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240909130750.GI15491@pendragon.ideasonboard.com>","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240909130750.GI15491@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 0/3] apps: qcam: Port to Qt 6","From":"Kieran Bingham ","Cc":"libcamera-devel ,\n\tWim Taymans ","To":"Laurent Pinchart ,\n\tNeal Gompa ","Date":"Mon, 09 Sep 2024 17:13:20 +0100","Message-ID":"<172589840086.2319503.4579803717873138641@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31136,"web_url":"https://patchwork.libcamera.org/comment/31136/","msgid":"<20240909162142.GB2144@pendragon.ideasonboard.com>","date":"2024-09-09T16:21:42","subject":"Re: [libcamera-devel] [PATCH v2 0/3] apps: qcam: Port to Qt 6","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Sep 09, 2024 at 05:13:20PM +0100, Kieran Bingham wrote:\n> Quoting Laurent Pinchart (2024-09-09 14:07:50)\n> > Hi Neal,\n> > \n> > I realized today that the gles rendered in qcam is broken :-( Reverting\n> > back to qt5 works for me, so it's related to this patch series. Could\n> > you please test ('qcam -r gles') and investigate ?\n> \n> I just tested this and have the following backtrace on Fedora Rawhide...\n> \n> (gdb) bt\n> #0 0x0000ffffce368b3c in void st_update_array_templ<(util_popcnt)2, (st_fill_tc_set_vb)0, (st_use_vao_fast_path)1, (st_allow_zero_stride_attribs)0, (st_identity_attrib_mapping)0, (st_allow_user_buffers)0, (st_update_velems)1>(st_context*, unsigned int, unsigned int, unsigned int) () at /lib64/libgallium-24.2.1.so\n> #1 0x0000ffffce0f9484 in st_prepare_draw () at /lib64/libgallium-24.2.1.so\n> #2 0x0000ffffce294384 in _mesa_draw_arrays.part.0 () at /lib64/libgallium-24.2.1.so\n> #3 0x0000000000454934 in QOpenGLFunctions::glDrawArrays (this=0x722d60, mode=6, first=0, count=4) at /usr/include/qt6/QtGui/qopenglfunctions.h:709\n> #4 0x000000000045438c in ViewFinderGL::paintGL (this=0x722d30) at ../../src/apps/qcam/viewfinder_gl.cpp:823\n> #5 0x0000fffff74e2f00 in QOpenGLWidgetPrivate::render() () at /lib64/libQt6OpenGLWidgets.so.6\n> #6 0x0000fffff5dceecc in QWidget::event(QEvent*) () at /lib64/libQt6Widgets.so.6\n> #7 0x0000fffff5d6ea18 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () at /lib64/libQt6Widgets.so.6\n> #8 0x0000fffff6f71d58 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () at /lib64/libQt6Core.so.6\n> #9 0x0000fffff5dc598c in QWidgetPrivate::sendPaintEvent(QRegion const&) () at /lib64/libQt6Widgets.so.6\n> #10 0x0000fffff5ddba1c in QWidgetRepaintManager::paintAndFlush() () at /lib64/libQt6Widgets.so.6\n> #11 0x0000fffff5dcf64c in QWidget::event(QEvent*) () at /lib64/libQt6Widgets.so.6\n> #12 0x000000000043af30 in MainWindow::event (this=0x7c0440, e=0xffffd40042c0) at ../../src/apps/qcam/main_window.cpp:177\n> #13 0x0000fffff5d6ea18 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () at /lib64/libQt6Widgets.so.6\n> #14 0x0000fffff6f71d58 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () at /lib64/libQt6Core.so.6\n> #15 0x0000fffff6f76068 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () at /lib64/libQt6Core.so.6\n> #16 0x0000fffff7272fd4 in postEventSourceDispatch(_GSource*, int (*)(void*), void*) () at /lib64/libQt6Core.so.6\n> #17 0x0000fffff48d0b94 in g_main_context_dispatch_unlocked.lto_priv () at /lib64/libglib-2.0.so.0\n> #18 0x0000fffff49341d0 in g_main_context_iterate_unlocked.isra () at /lib64/libglib-2.0.so.0\n> #19 0x0000fffff48d2264 in g_main_context_iteration () at /lib64/libglib-2.0.so.0\n> #20 0x0000fffff7272658 in QEventDispatcherGlib::processEvents(QFlags) () at /lib64/libQt6Core.so.6\n> #21 0x0000fffff6f7f694 in QEventLoop::exec(QFlags) () at /lib64/libQt6Core.so.6\n> #22 0x0000fffff6f7ac3c in QCoreApplication::exec() () at /lib64/libQt6Core.so.6\n> #23 0x0000000000439a24 in main (argc=3, argv=0xffffffffeeb8) at ../../src/apps/qcam/main.cpp:87\n> (gdb) quit\n> A debugging session is active.\n\nThis patch fixes the crash:\n\ndiff --git a/src/apps/qcam/viewfinder_gl.cpp b/src/apps/qcam/viewfinder_gl.cpp\nindex 9d2a69600db1..789a45f3e314 100644\n--- a/src/apps/qcam/viewfinder_gl.cpp\n+++ b/src/apps/qcam/viewfinder_gl.cpp\n@@ -809,6 +809,8 @@ void ViewFinderGL::doRender()\n\n void ViewFinderGL::paintGL()\n {\n+\tvertexBuffer_.bind();\n+\n \tif (!fragmentShader_)\n \t\tif (!createFragmentShader()) {\n \t\t\tqWarning() << \"[ViewFinderGL]:\"\n\nThe display is still wrong though, but \"less wrong\". It appears that the\ntexture coordinates are not taken into account correctly.\n\nAny OpenGL expert who could have a quick look at qcam and check where we\nget binding of objects wrong ?\n\n> > On Sun, Jan 21, 2024 at 05:39:52PM -0500, 📷-dev wrote:\n> > > Open source Qt 5 has been effectively end of life since the release\n> > > of Qt 6, and Qt 6 has current LTS releases now.\n> > > \n> > > This change ports qcam to Qt 6.2 and drops some of the baggage related\n> > > to Qt 5 that is no longer applicable.\n> > > \n> > > Additionally, a couple of patches are included to update documentation\n> > > references from Qt 5 to Qt 6.\n> > > \n> > > === Changelog ===\n> > > \n> > > v2: Bump Meson to v0.63 for Qt6 module\n> > > \n> > > v1: Initial patch set\n> > > \n> > > Neal Gompa (3):\n> > > apps: qcam: Port to Qt 6\n> > > libcamera: base: signal: Update Qt documentation link to Qt 6\n> > > Documentation: Update Qt documentation links to Qt 6\n> > > \n> > > .../guides/application-developer.rst | 2 +-\n> > > Documentation/guides/pipeline-handler.rst | 2 +-\n> > > README.rst | 2 +-\n> > > meson.build | 2 +-\n> > > src/apps/qcam/meson.build | 45 ++++++-------------\n> > > src/libcamera/base/signal.cpp | 2 +-\n> > > 6 files changed, 18 insertions(+), 37 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2EC69C324C\n\tfor ;\n\tMon, 9 Sep 2024 16:21:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 240F2634F7;\n\tMon, 9 Sep 2024 18:21:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CA73C634EB\n\tfor ;\n\tMon, 9 Sep 2024 18:21:45 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(213-229-8-243.static.upcbusiness.at [213.229.8.243])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 614985A4;\n\tMon, 9 Sep 2024 18:20:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"beuH63xZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725898829;\n\tbh=edjF9S9wzA2B7RHhhBriZAqfOdO0BblILRTp/tPtonE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=beuH63xZwXqyxzyXtaww5UKK9MruVvePL8etVUoNYE4aMilTr9ODi3OgRfLtw5s4A\n\tWYmFZ0ZDsN0g97rQjfwqgomGNHwBn3Rwjr+pONt+IgcwB6Tar3Bkfpg0yzVMJYR7Z3\n\t5K58gaSZytv0iTM8Nr3bNhsG8/ReK0BSU17cLuJU=","Date":"Mon, 9 Sep 2024 19:21:42 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"Neal Gompa ,\n\tlibcamera-devel ,\n\tWim Taymans ","Subject":"Re: [libcamera-devel] [PATCH v2 0/3] apps: qcam: Port to Qt 6","Message-ID":"<20240909162142.GB2144@pendragon.ideasonboard.com>","References":"<20240121224052.1049989-1-neal@gompa.dev>\n\t<20240909130750.GI15491@pendragon.ideasonboard.com>\n\t<172589840086.2319503.4579803717873138641@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<172589840086.2319503.4579803717873138641@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]