[{"id":28482,"web_url":"https://patchwork.libcamera.org/comment/28482/","msgid":"<1f39d55f-9984-4d22-9450-b83f0755661a@ideasonboard.com>","date":"2024-01-17T15:22:30","subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Enable V4L2 subdev\n\tstreams support","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"content":"On 17/01/2024 16:42, Laurent Pinchart wrote:\n> Hello,\n> \n> In v6.4, new subdev ioctls were introduced to gate streams support\n> behind a V4L2 subdev client capability mechanism. Without enabling the\n> capability, the stream arguments to subdev ioctls is ignored (subdev\n> internal routing configuration still works, but all routes then hardcode\n> stream 0 on both the sink and source sides).\n> \n> This small patch series updates libcamera to enable the stream\n> capbility. It starts by updating the kernel headers in patch 1/2\n> (updating to v6.4 would have been enough, but there's no reason not to\n> use the most recent headers), and then enables the client capability in\n> patch 2/2.\n> \n> Laurent Pinchart (2):\n> include: linux: Update kernel headers to version v6.7\n> libcamera: v4l2_subdevice: Enable streams API when supported\n> \n> include/libcamera/internal/v4l2_subdevice.h | 2 +-\n> include/linux/README | 2 +-\n> include/linux/dma-buf.h | 84 ++\n> include/linux/drm_fourcc.h | 128 +-\n> include/linux/intel-ipu3.h | 7 +-\n> include/linux/media-bus-format.h | 13 +-\n> include/linux/media.h | 29 +-\n> include/linux/v4l2-common.h | 39 -\n> include/linux/v4l2-controls.h | 1250 ++++++++++++++++++-\n> include/linux/v4l2-mediabus.h | 4 -\n> include/linux/v4l2-subdev.h | 56 +-\n> include/linux/videodev2.h | 69 +-\n> src/libcamera/v4l2_subdevice.cpp | 15 +\n> 13 files changed, 1551 insertions(+), 147 deletions(-)\n> \n> \n> base-commit: 89227a428a82e724548399d35c98ea89566f9045\n\nLooks good to me.\n\nReviewed-by: Tomi Valkeinen \n\n Tomi","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03678BDB1C\n\tfor ;\n\tWed, 17 Jan 2024 15:22:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4C473628B7;\n\tWed, 17 Jan 2024 16:22:35 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BA0C3628AD\n\tfor ;\n\tWed, 17 Jan 2024 16:22:33 +0100 (CET)","from [192.168.88.20] (91-154-35-128.elisa-laajakaista.fi\n\t[91.154.35.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D19F17E2;\n\tWed, 17 Jan 2024 16:21:23 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1705504955;\n\tbh=qPbeauTapcJDYfdZyFG8yjBR19/zz16wkSGHlPkDKxc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=ymHCPxWn53MffW7jTmJqnsV9hDBg+HVtEZTLAwcNarIfDB84EsMVR7huy8bbup1wu\n\tSkxY9l5Ry2kirYkVzpDzZ2A3B+rhSItZOgI3lcWu8HLPPIcDSjuY2AsGbIEcCJXWOs\n\tcMZZ+w/FKqH6aFQ6rlKrwXndEjS3mpNgndn5vwIe40/5RdUjLqeI5xPERBlMgb8kjt\n\tpXpw0IyaxyQ5f0aTRQI/FNv/LuzjB5J1xJtgVRLBKw2xsN3t0PyWJfyVmZv25fQ5T0\n\t0iEqekgTjPMb2aaXakpiNQLU7aUOZRZcK41fwkvKiuwXREfk76lvEupHd7Qs6Dh11i\n\tILy9s2dlEBG9Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705504884;\n\tbh=qPbeauTapcJDYfdZyFG8yjBR19/zz16wkSGHlPkDKxc=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=bGG0HQ2Fk6YxujYfdBD5Yo28ofGpHs60ugGBNvR8ZSTgnbYFvvuPLHqScKTNDm3wZ\n\t3torij4Xd8dPIbrYc6kQQcjTtNtfFB3UEiv1/Eie2l446CGaTCOIWr963VHTvBNlyF\n\tKCa/pCkngL4i980j/sH3ZpvCH8SxbykkfLRXbHug="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"bGG0HQ2F\"; dkim-atps=neutral","Message-ID":"<1f39d55f-9984-4d22-9450-b83f0755661a@ideasonboard.com>","Date":"Wed, 17 Jan 2024 17:22:30 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20240117144242.9903-1-laurent.pinchart@ideasonboard.com>","Autocrypt":"addr=tomi.valkeinen@ideasonboard.com; keydata=\n\txsFNBE6ms0cBEACyizowecZqXfMZtnBniOieTuFdErHAUyxVgtmr0f5ZfIi9Z4l+uUN4Zdw2\n\twCEZjx3o0Z34diXBaMRJ3rAk9yB90UJAnLtb8A97Oq64DskLF81GCYB2P1i0qrG7UjpASgCA\n\tRu0lVvxsWyIwSfoYoLrazbT1wkWRs8YBkkXQFfL7Mn3ZMoGPcpfwYH9O7bV1NslbmyJzRCMO\n\teYV258gjCcwYlrkyIratlHCek4GrwV8Z9NQcjD5iLzrONjfafrWPwj6yn2RlL0mQEwt1lOvn\n\tLnI7QRtB3zxA3yB+FLsT1hx0va6xCHpX3QO2gBsyHCyVafFMrg3c/7IIWkDLngJxFgz6DLiA\n\tG4ld1QK/jsYqfP2GIMH1mFdjY+iagG4DqOsjip479HCWAptpNxSOCL6z3qxCU8MCz8iNOtZk\n\tDYXQWVscM5qgYSn+fmMM2qN+eoWlnCGVURZZLDjg387S2E1jT/dNTOsM/IqQj+ZROUZuRcF7\n\t0RTtuU5q1HnbRNwy+23xeoSGuwmLQ2UsUk7Q5CnrjYfiPo3wHze8avK95JBoSd+WIRmV3uoO\n\trXCoYOIRlDhg9XJTrbnQ3Ot5zOa0Y9c4IpyAlut6mDtxtKXr4+8OzjSVFww7tIwadTK3wDQv\n\tBus4jxHjS6dz1g2ypT65qnHen6mUUH63lhzewqO9peAHJ0SLrQARAQABzTBUb21pIFZhbGtl\n\taW5lbiA8dG9taS52YWxrZWluZW5AaWRlYXNvbmJvYXJkLmNvbT7CwY4EEwEIADgWIQTEOAw+\n\tll79gQef86f6PaqMvJYe9QUCX/HruAIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRD6\n\tPaqMvJYe9WmFD/99NGoD5lBJhlFDHMZvO+Op8vCwnIRZdTsyrtGl72rVh9xRfcSgYPZUvBuT\n\tVDxE53mY9HaZyu1eGMccYRBaTLJSfCXl/g317CrMNdY0k40b9YeIX10feiRYEWoDIPQ3tMmA\n\t0nHDygzcnuPiPT68JYZ6tUOvAt7r6OX/litM+m2/E9mtp8xCoWOo/kYO4mOAIoMNvLB8vufi\n\tuBB4e/AvAjtny4ScuNV5c5q8MkfNIiOyag9QCiQ/JfoAqzXRjVb4VZG72AKaElwipiKCWEcU\n\tR4+Bu5Qbaxj7Cd36M/bI54OrbWWETJkVVSV1i0tghCd6HHyquTdFl7wYcz6cL1hn/6byVnD+\n\tsR3BLvSBHYp8WSwv0TCuf6tLiNgHAO1hWiQ1pOoXyMEsxZlgPXT+wb4dbNVunckwqFjGxRbl\n\tRz7apFT/ZRwbazEzEzNyrBOfB55xdipG/2+SmFn0oMFqFOBEszXLQVslh64lI0CMJm2OYYe3\n\tPxHqYaztyeXsx13Bfnq9+bUynAQ4uW1P5DJ3OIRZWKmbQd/Me3Fq6TU57LsvwRgE0Le9PFQs\n\tdcP2071rMTpqTUteEgODJS4VDf4lXJfY91u32BJkiqM7/62Cqatcz5UWWHq5xeF03MIUTqdE\n\tqHWk3RJEoWHWQRzQfcx6Fn2fDAUKhAddvoopfcjAHfpAWJ+ENc7BTQROprNHARAAx0aat8GU\n\thsusCLc4MIxOQwidecCTRc9Dz/7U2goUwhw2O5j9TPqLtp57VITmHILnvZf6q3QAho2QMQyE\n\tDDvHubrdtEoqaaSKxKkFie1uhWNNvXPhwkKLYieyL9m2JdU+b88HaDnpzdyTTR4uH7wk0bBa\n\tKbTSgIFDDe5lXInypewPO30TmYNkFSexnnM3n1PBCqiJXsJahE4ZQ+WnV5FbPUj8T2zXS2xk\n\t0LZ0+DwKmZ0ZDovvdEWRWrz3UzJ8DLHb7blPpGhmqj3ANXQXC7mb9qJ6J/VSl61GbxIO2Dwb\n\txPNkHk8fwnxlUBCOyBti/uD2uSTgKHNdabhVm2dgFNVuS1y3bBHbI/qjC3J7rWE0WiaHWEqy\n\tUVPk8rsph4rqITsj2RiY70vEW0SKePrChvET7D8P1UPqmveBNNtSS7In+DdZ5kUqLV7rJnM9\n\t/4cwy+uZUt8cuCZlcA5u8IsBCNJudxEqBG10GHg1B6h1RZIz9Q9XfiBdaqa5+CjyFs8ua01c\n\t9HmyfkuhXG2OLjfQuK+Ygd56mV3lq0aFdwbaX16DG22c6flkkBSjyWXYepFtHz9KsBS0DaZb\n\t4IkLmZwEXpZcIOQjQ71fqlpiXkXSIaQ6YMEs8WjBbpP81h7QxWIfWtp+VnwNGc6nq5IQDESH\n\tmvQcsFS7d3eGVI6eyjCFdcAO8eMAEQEAAcLBXwQYAQIACQUCTqazRwIbDAAKCRD6PaqMvJYe\n\t9fA7EACS6exUedsBKmt4pT7nqXBcRsqm6YzT6DeCM8PWMTeaVGHiR4TnNFiT3otD5UpYQI7S\n\tsuYxoTdHrrrBzdlKe5rUWpzoZkVK6p0s9OIvGzLT0lrb0HC9iNDWT3JgpYDnk4Z2mFi6tTbq\n\txKMtpVFRA6FjviGDRsfkfoURZI51nf2RSAk/A8BEDDZ7lgJHskYoklSpwyrXhkp9FHGMaYII\n\tm9EKuUTX9JPDG2FTthCBrdsgWYPdJQvM+zscq09vFMQ9Fykbx5N8z/oFEUy3ACyPqW2oyfvU\n\tCH5WDpWBG0s5BALp1gBJPytIAd/pY/5ZdNoi0Cx3+Z7jaBFEyYJdWy1hGddpkgnMjyOfLI7B\n\tCFrdecTZbR5upjNSDvQ7RG85SnpYJTIin+SAUazAeA2nS6gTZzumgtdw8XmVXZwdBfF+ICof\n\t92UkbYcYNbzWO/GHgsNT1WnM4sa9lwCSWH8Fw1o/3bX1VVPEsnESOfxkNdu+gAF5S6+I6n3a\n\tueeIlwJl5CpT5l8RpoZXEOVtXYn8zzOJ7oGZYINRV9Pf8qKGLf3Dft7zKBP832I3PQjeok7F\n\tyjt+9S+KgSFSHP3Pa4E7lsSdWhSlHYNdG/czhoUkSCN09C0rEK93wxACx3vtxPLjXu6RptBw\n\t3dRq7n+mQChEB1am0BueV1JZaBboIL0AGlSJkm23kw==","In-Reply-To":"<20240117144242.9903-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Enable V4L2 subdev\n\tstreams support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]