[{"id":28262,"web_url":"https://patchwork.libcamera.org/comment/28262/","msgid":"","date":"2023-12-06T17:04:19","subject":"Re: [libcamera-devel] [PATCH v1 0/2] Raspberry Pi vendor controls","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nI think this is all great. The only thing I'd like to consider is how\nwe can make this available to Python applications, which is where many\n(probably most) of our users are.\n\nDo we need to put some \"vendor specific stuff\" into the libcamera\nPython bindings to help interpret these structures?\n\nArguably we could leave all that to Picamera2 but then it doesn't\nnecessarily help every Python user. And also someone needs to do it!\n\nAny thoughts, anyone?\n\nDavid\n\nOn Mon, 4 Dec 2023 at 16:18, Naushir Patuck via libcamera-devel\n wrote:\n>\n> Hi,\n>\n> This patch series adds Raspberry Pi specific vendor controls, initially for\n> returning hardware generated statistics out in Request metdata. This comes from\n> a user request at https://github.com/raspberrypi/libcamera/issues/90.\n>\n> Thanks,\n> Naush\n>\n> Naushir Patuck (2):\n> build: controls: Add Raspberry Pi vendor specific controls\n> ipa: vc4: Implement the StatsOutputEnable vendor control\n>\n> include/libcamera/meson.build | 1 +\n> src/ipa/rpi/common/ipa_base.cpp | 12 +++++++++---\n> src/ipa/rpi/common/ipa_base.h | 3 ++-\n> src/ipa/rpi/vc4/vc4.cpp | 6 ++++++\n> src/libcamera/control_ids_rpi.yaml | 29 +++++++++++++++++++++++++++++\n> 5 files changed, 47 insertions(+), 4 deletions(-)\n> create mode 100644 src/libcamera/control_ids_rpi.yaml\n>\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DA41AC322E\n\tfor ;\n\tWed, 6 Dec 2023 17:04:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4905462B2E;\n\tWed, 6 Dec 2023 18:04:33 +0100 (CET)","from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com\n\t[IPv6:2607:f8b0:4864:20::f2a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B71661D9E\n\tfor ;\n\tWed, 6 Dec 2023 18:04:32 +0100 (CET)","by mail-qv1-xf2a.google.com with SMTP id\n\t6a1803df08f44-67acdcb3ccdso221636d6.1\n\tfor ;\n\tWed, 06 Dec 2023 09:04:32 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701882273;\n\tbh=RWYoK6gZgvzCyiLknxoDDa3VDQK40D416nr7TshlPB4=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=QhRvqs0lgZA3Kk7rNcz5Dll/jHKNBo8yQZvxmVol01Rn6lx87kmJg2ltVRT0GFFhV\n\tYhEZP1eRnVeYIDArWwbfL7PMmET2WBSWIzsXzCZbIw0WOmUiqp8Vw4zbcxGyQiHruN\n\tyd6tEGzgH+CvBncpyLsFTZe858vP67UOQBgDOrULwfxfvNrlypbjOkSlWaskFIW9Vr\n\tAhaIF3dT52TY0OXoh6HuhB2araRLSKUlBp+MenHCB2Pu20XKVFYEYYq+BnlhBeZLC+\n\tFBs39Jo2SxZSRt+GCr+NahHTRt5b6FdzhQvi34HXUIFdDYq31H0rWvL8oDUaKFIhQv\n\tqStSd4kQTiZxw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1701882271; x=1702487071;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=iEQiuk7YQYN6dX3C3CjpH1XJtsNJe3HFLyAsXx1Y/IE=;\n\tb=qd6yE8+eKc6aUBOCMrKwdShwG/Ms4jfG05EYqa8NSBHiGMZTosYciYtZoiLq+6yoZc\n\t8eZ1k5GGcObGlLbblitJtof6UYkK/mj0Sy+jf8LeJIm2UiWfwztoL6NpdzPBvLg+Bouq\n\tJ76v6/sGAluy0lrhYrL5MThqXVkgcuKmF9VFDwaJ7ReWsgyQ47d+QPSrIHKVcC2JCHEc\n\tpMlIsaKt3XLGs10YULyt8QpMAVdDXThFoaRzxfAoJ/x/6jeXp5nwlD/Z8ux2mQE/X6nU\n\tmc9Ya3ak8Ugwvu3McH5inmJcIGaydgJKOHjdW3/LUm9s1XYfy9hbGHFqNUxlDwGA9dcW\n\tQavw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"qd6yE8+e\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1701882271; x=1702487071;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=iEQiuk7YQYN6dX3C3CjpH1XJtsNJe3HFLyAsXx1Y/IE=;\n\tb=Bc+GEUiSURFOieohjEClFQomqFzKwmuz9nmQzmF1NUn6T+JWxvqOt86w1LNAVspXPY\n\tiOfW+T9DBhiCPxkHTVU3HeBii+BXmcJ38t+OI/b9ylmO9hnnbt0915R09iK/rI8kJJPG\n\tv43lGEIz98/r0+MORs2XRBAvxOcEL/ALLoQNiyY25WYRaQRO1fLHhDxg7xc9KsBSuSQR\n\tfUKb4zJHWWw067iIHR+il3juEq4yzVKpPtrcY+1jHYTUVIUnerXcIQ3AUbG7qb604lN4\n\tjGS39t50yRO4d8Tmd9RbBwi+K9sJL8tPnSrR6uonWfhuIN8KxVO/NUTQ5L3HjTKd4DRq\n\tnVHQ==","X-Gm-Message-State":"AOJu0YyjA56PqPXcQHW/UzYJ04MGtmaTPQaHbtAAXKtAdxNtCCYeePcZ\n\tn+yRyPrHLd9tu5Lf4JVsfi2TT+XsNn0gHTkRoPwjTg==","X-Google-Smtp-Source":"AGHT+IE2Cy2DDfPupUPcqPcQe/S3UkuNgRqR2s+1scxsnDuGC9r50XlT2zlw7wykNPJJYO2SZrTvOqJ4x8fqU8vLKqs=","X-Received":"by 2002:ad4:55f3:0:b0:67a:c0f0:c0eb with SMTP id\n\tbu19-20020ad455f3000000b0067ac0f0c0ebmr1143531qvb.35.1701882271226;\n\tWed, 06 Dec 2023 09:04:31 -0800 (PST)","MIME-Version":"1.0","References":"<20231204161901.6632-1-naush@raspberrypi.com>","In-Reply-To":"<20231204161901.6632-1-naush@raspberrypi.com>","Date":"Wed, 6 Dec 2023 17:04:19 +0000","Message-ID":"","To":"Naushir Patuck ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v1 0/2] Raspberry Pi vendor controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28271,"web_url":"https://patchwork.libcamera.org/comment/28271/","msgid":"","date":"2023-12-07T08:54:35","subject":"Re: [libcamera-devel] [PATCH v1 0/2] Raspberry Pi vendor controls","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nThat's a good point, python will receive a binary blob which will need\ninterpreting.\n\nGiven this is a RPi vendor specific structure, I don't know if it's\nappropriate (or indeed if it can even be done) to translate this in\nthe pybind11 wrapping thingy. But this should be possible to do\nsomewhere in picamera2.\n\nRegards,\nNaush\n\nOn Wed, 6 Dec 2023 at 17:04, David Plowman\n wrote:\n>\n> Hi Naush\n>\n> I think this is all great. The only thing I'd like to consider is how\n> we can make this available to Python applications, which is where many\n> (probably most) of our users are.\n>\n> Do we need to put some \"vendor specific stuff\" into the libcamera\n> Python bindings to help interpret these structures?\n>\n> Arguably we could leave all that to Picamera2 but then it doesn't\n> necessarily help every Python user. And also someone needs to do it!\n>\n> Any thoughts, anyone?\n>\n> David\n>\n> On Mon, 4 Dec 2023 at 16:18, Naushir Patuck via libcamera-devel\n> wrote:\n> >\n> > Hi,\n> >\n> > This patch series adds Raspberry Pi specific vendor controls, initially for\n> > returning hardware generated statistics out in Request metdata. This comes from\n> > a user request at https://github.com/raspberrypi/libcamera/issues/90.\n> >\n> > Thanks,\n> > Naush\n> >\n> > Naushir Patuck (2):\n> > build: controls: Add Raspberry Pi vendor specific controls\n> > ipa: vc4: Implement the StatsOutputEnable vendor control\n> >\n> > include/libcamera/meson.build | 1 +\n> > src/ipa/rpi/common/ipa_base.cpp | 12 +++++++++---\n> > src/ipa/rpi/common/ipa_base.h | 3 ++-\n> > src/ipa/rpi/vc4/vc4.cpp | 6 ++++++\n> > src/libcamera/control_ids_rpi.yaml | 29 +++++++++++++++++++++++++++++\n> > 5 files changed, 47 insertions(+), 4 deletions(-)\n> > create mode 100644 src/libcamera/control_ids_rpi.yaml\n> >\n> > --\n> > 2.34.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 385A6C31E9\n\tfor ;\n\tThu, 7 Dec 2023 08:55:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4CD4462B2C;\n\tThu, 7 Dec 2023 09:55:07 +0100 (CET)","from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com\n\t[IPv6:2607:f8b0:4864:20::112d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D16A9629CC\n\tfor ;\n\tThu, 7 Dec 2023 09:55:05 +0100 (CET)","by mail-yw1-x112d.google.com with SMTP id\n\t00721157ae682-5d40c728fc4so3150227b3.1\n\tfor ;\n\tThu, 07 Dec 2023 00:55:05 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701939307;\n\tbh=Wu+8sOy0vBKoVl7Thsip1bj5UKTR7WKH1LA6JGmlMMU=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=1J3HOC+Fd6B8HqWqyW/6op3RoJcIVDhh4e7ygNEvvzE4japglKrL/xYGkOaxBUti7\n\tHS4bQviggOwQ7sClFOa79TRtIrlPW/mYkX1gz/x0JqJuk6LMg3MFpKrnE9otY/Z4KL\n\t5Pg0c5C2gaiik3KqwCD06zE7lOoyJpauI+38j2H0GJgLzxzUarGPfj0J3hbHe6L+b+\n\tXUQXvt8bPGhgkybQHuaucd0FVKFkrlsoJyte2gGqEJKoYoyHMhuUj5Z2WwOAPvcw//\n\ta1exCqBpdJcciPYTCWFEqK3vkZF4J8URF2jrjMgVsFc+g8Jp1YdjoO1j3ny34e40BQ\n\tZ8vsdaMFMnJDg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1701939304; x=1702544104;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=pI2hgILmT6cd0+pBRzrVi4BEatDPh9T+gWfEd6qFaBc=;\n\tb=EmM7r6tYE3crTF770daDPPmcGoOQxy/YSTncLdN2U9kR1pdgvdJfdsuuC4GG6/1yax\n\tk1EmMHXSGs1LiFkH+GM0ETzQFsbzsTYMQTK5IurzwI4fSnrpwWZ1w/pXZB5hSFSRo0LV\n\tXyOLsatJQKA9IxAJJ+1hvz4tt7X0D/YRSfK16lZniPLER+i0wA4iub9GlvNLs6TN1FMT\n\t7TI9TJOX7hXrebMfH6qkAZ4w1auU1z2Zv2ygrTjKoVmELB2BhImkCWeLb9bOeziM/Qkn\n\tX5E1Lkv+naGNW8YVlOtWQl9qsrkhGA5yNY87mGgsdqYglX7fKuW8IsfiA4sqUm0ShdU3\n\t2iYQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"EmM7r6tY\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1701939304; x=1702544104;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=pI2hgILmT6cd0+pBRzrVi4BEatDPh9T+gWfEd6qFaBc=;\n\tb=kewwFIzaHG9+ItPs+OOLyQOhONariaeH/uHM5yS5bYj8re3ctkbwfptmBhAILj+5ku\n\tsWwhhsxS/j4zscewNVVKeP0QQn3i8YTjeexUTyJvH/75tp61t9gP1BpZ1F6Y92vFHeUb\n\t6gVqaYyXjMQz2ii9rdI6/hg6sSwPNyNTfLAJV1orKiUGQB8hrNHdA4XHE6DJIhQULX11\n\tgZ+qV8enZpU6b5x8D2w5wziOVQB9fgYjibfoZ11zoWc3AidkNer/UNeZ9CeKIHtZ0akT\n\t5r50YegJ35Wjiv/kKIJqga6CmTmz7WXXwEjsEGNrXJ4ksru5jJ8z7IH9f0xIdFqr76Kn\n\t9ptQ==","X-Gm-Message-State":"AOJu0YwDJysaGhBKJRTyqoa6B6C7ZZuE32s+hciCJLdmxUAasNSOHGLd\n\tS6N0mfsyEepC0ZLRze/b00GMBZMpKUDgoNR/jkhP3g==","X-Google-Smtp-Source":"AGHT+IEO4Arz7EFIOobOc+owiELEsN4GZMusWkR/I41q8REZ3e037PU1Pj7Zg/kltJwLO5dnJwrDPBKMhY5XolshLr8=","X-Received":"by 2002:a25:24c6:0:b0:db9:8975:aed with SMTP id\n\tk189-20020a2524c6000000b00db989750aedmr2681318ybk.60.1701939303838;\n\tThu, 07 Dec 2023 00:55:03 -0800 (PST)","MIME-Version":"1.0","References":"<20231204161901.6632-1-naush@raspberrypi.com>\n\t","In-Reply-To":"","Date":"Thu, 7 Dec 2023 08:54:35 +0000","Message-ID":"","To":"David Plowman ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v1 0/2] Raspberry Pi vendor controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28347,"web_url":"https://patchwork.libcamera.org/comment/28347/","msgid":"","date":"2023-12-19T13:47:12","subject":"Re: [libcamera-devel] [PATCH v1 0/2] Raspberry Pi vendor controls","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi all,\n\nAny further comments on this series, or can we merge it as-is?\n\nRegards,\nNaush\n\nOn Mon, 4 Dec 2023 at 16:18, Naushir Patuck wrote:\n>\n> Hi,\n>\n> This patch series adds Raspberry Pi specific vendor controls, initially for\n> returning hardware generated statistics out in Request metdata. This comes from\n> a user request at https://github.com/raspberrypi/libcamera/issues/90.\n>\n> Thanks,\n> Naush\n>\n> Naushir Patuck (2):\n> build: controls: Add Raspberry Pi vendor specific controls\n> ipa: vc4: Implement the StatsOutputEnable vendor control\n>\n> include/libcamera/meson.build | 1 +\n> src/ipa/rpi/common/ipa_base.cpp | 12 +++++++++---\n> src/ipa/rpi/common/ipa_base.h | 3 ++-\n> src/ipa/rpi/vc4/vc4.cpp | 6 ++++++\n> src/libcamera/control_ids_rpi.yaml | 29 +++++++++++++++++++++++++++++\n> 5 files changed, 47 insertions(+), 4 deletions(-)\n> create mode 100644 src/libcamera/control_ids_rpi.yaml\n>\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 89BA4C31E9\n\tfor ;\n\tTue, 19 Dec 2023 13:47:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B27F162B40;\n\tTue, 19 Dec 2023 14:47:51 +0100 (CET)","from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com\n\t[IPv6:2607:f8b0:4864:20::1136])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6315161D92\n\tfor ;\n\tTue, 19 Dec 2023 14:47:49 +0100 (CET)","by mail-yw1-x1136.google.com with SMTP id\n\t00721157ae682-5e7467eb93aso11190747b3.1\n\tfor ;\n\tTue, 19 Dec 2023 05:47:49 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1702993671;\n\tbh=pH7W31XO7XOq3cj9qMQZS60I2M2GdDPEFtPsHvzPyoQ=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=jApx4WRZCoBzzlC+WDi8xe3X6PuuFCnIKOcmn6lracxU48vUj7tcFjYYx6+gqOtg2\n\tNsZ89CbeztU05ZAhmH8mkCkXJUhffshrp5tA/eb8XRUIPAH9sbw8J2rxok5U//NoEH\n\tO0U0foK9b21NPwgiwIvWYBKZprqnSX63I6IAhT+2X4bh5bgqj/rjlLTCwBK7NDUN1t\n\t4sYKD3VoHtiy9xaI+TZDRvFA4tk9yAaj87gip4hC4cfH0T2Xcbqum8rONcPb/ekyXp\n\tVaNtmN3yRDeVN38Zy54e/x8g6CObD9UVvnRqse5lsgXm2v0p5/N+i0wDg0zrMSFdPD\n\tUNYnnx73njfDg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1702993668; x=1703598468;\n\tdarn=lists.libcamera.org; \n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=GhtjIcp4QHK7TqI6JwYlp3eVlUQi8UXvx/xTZmu7KSE=;\n\tb=Rn9wtIZLGbngzfv5nH34OgcnRN+5mpVXAYlaNUn6cWXhIolMeGTe9OdXHnyOzwDe3h\n\ttD95NieCQHL8gxRZndG5k2g5GAoFHLTn5BK034KDDnhDfBbh5AtuZix0Hnw46WZ5Fq0R\n\ted/ICXq6zruxBRdLlQee6VEz8uJ6XjS6Y0iIKugn3EXrXJi0yB+eJ45XJnM6CnOpgVpS\n\tee0kE/qvDNlwaUZecYPqOMTe0ynvvPpIlf9SVyvKhBPIf3JyvONZfLnDjkagrNZpdsCd\n\t0bmht0p0i21+Sd1qgNORieRz9AIeyqEZKOAUXaS6TvCqKywhczWNDWrakD3ZAmP1ceg3\n\tM2eg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"Rn9wtIZL\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1702993668; x=1703598468;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=GhtjIcp4QHK7TqI6JwYlp3eVlUQi8UXvx/xTZmu7KSE=;\n\tb=WRZAQiaZntJIgmlxjBmbqPTTkkx7+FHw8vF7GCusrQMjAzm3RGLafRO7fYIdcSyCMl\n\tbMemLYdI4gP8VhitzRDGoR+gSjJp/LYTEJwm+DrazX79w0dLUJJtMTKBW0WCqtSTvtdj\n\t5pJhrbDGY9DFzXNslYlAT6t5fPncs2DcteNn3QK0/HtjjEqZGyLYYHAgXc6LChATsUnQ\n\toAGlDge6Jxq+n6QILZ6E/hByYVK0NiTJNrdlIfUF1s5qHoj4bRv7w8S8caDrFXmIgvqh\n\tsKyrbqItgQULvP4pTauZsGm4zxvf4Btx4HVr9qQ5rxyEg+tsIwJK40teitZz99ZwUY5O\n\tvYBQ==","X-Gm-Message-State":"AOJu0YwdY4MB1TnJulJcTN4kHa3Ccw2Z3H6ZI25M2vdDUikARqVrGUfw\n\tf2w9Mk0S1HKS6ZnVtXH8lMUFKG1wl3171UY8xDe9OCaKN7WiVoO/","X-Google-Smtp-Source":"AGHT+IHymU7z8WqSnePq/WwSNcH/FQKivGkT6Eav0W85L3WrLdihQGK5lkqSOQNgli7Lzm0eQlomzJ+4vCRVRBI4WOU=","X-Received":"by 2002:a81:914c:0:b0:5e5:2927:58da with SMTP id\n\ti73-20020a81914c000000b005e5292758damr2007097ywg.21.1702993667749;\n\tTue, 19 Dec 2023 05:47:47 -0800 (PST)","MIME-Version":"1.0","References":"<20231204161901.6632-1-naush@raspberrypi.com>","In-Reply-To":"<20231204161901.6632-1-naush@raspberrypi.com>","Date":"Tue, 19 Dec 2023 13:47:12 +0000","Message-ID":"","To":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v1 0/2] Raspberry Pi vendor controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28394,"web_url":"https://patchwork.libcamera.org/comment/28394/","msgid":"<170473585835.3044059.2382919534712817117@ping.linuxembedded.co.uk>","date":"2024-01-08T17:44:18","subject":"Re: [libcamera-devel] [PATCH v1 0/2] Raspberry Pi vendor controls","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck via libcamera-devel (2023-12-07 08:54:35)\n> Hi David,\n> \n> That's a good point, python will receive a binary blob which will need\n> interpreting.\n> \n> Given this is a RPi vendor specific structure, I don't know if it's\n> appropriate (or indeed if it can even be done) to translate this in\n> the pybind11 wrapping thingy. But this should be possible to do\n> somewhere in picamera2.\n\nAgreed, it wouldn't be likely to be parsed specfically at the libcamera\npython binding layer. Something with knowledge of the specific vendor\ncontrol should handle it.\n\n--\nKieran\n\n\n> \n> Regards,\n> Naush\n> \n> On Wed, 6 Dec 2023 at 17:04, David Plowman\n> wrote:\n> >\n> > Hi Naush\n> >\n> > I think this is all great. The only thing I'd like to consider is how\n> > we can make this available to Python applications, which is where many\n> > (probably most) of our users are.\n> >\n> > Do we need to put some \"vendor specific stuff\" into the libcamera\n> > Python bindings to help interpret these structures?\n> >\n> > Arguably we could leave all that to Picamera2 but then it doesn't\n> > necessarily help every Python user. And also someone needs to do it!\n> >\n> > Any thoughts, anyone?\n> >\n> > David\n> >\n> > On Mon, 4 Dec 2023 at 16:18, Naushir Patuck via libcamera-devel\n> > wrote:\n> > >\n> > > Hi,\n> > >\n> > > This patch series adds Raspberry Pi specific vendor controls, initially for\n> > > returning hardware generated statistics out in Request metdata. This comes from\n> > > a user request at https://github.com/raspberrypi/libcamera/issues/90.\n> > >\n> > > Thanks,\n> > > Naush\n> > >\n> > > Naushir Patuck (2):\n> > > build: controls: Add Raspberry Pi vendor specific controls\n> > > ipa: vc4: Implement the StatsOutputEnable vendor control\n> > >\n> > > include/libcamera/meson.build | 1 +\n> > > src/ipa/rpi/common/ipa_base.cpp | 12 +++++++++---\n> > > src/ipa/rpi/common/ipa_base.h | 3 ++-\n> > > src/ipa/rpi/vc4/vc4.cpp | 6 ++++++\n> > > src/libcamera/control_ids_rpi.yaml | 29 +++++++++++++++++++++++++++++\n> > > 5 files changed, 47 insertions(+), 4 deletions(-)\n> > > create mode 100644 src/libcamera/control_ids_rpi.yaml\n> > >\n> > > --\n> > > 2.34.1\n> > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 95466C323E\n\tfor ;\n\tMon, 8 Jan 2024 17:44:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0BF1762B31;\n\tMon, 8 Jan 2024 18:44:24 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0915061D7E\n\tfor ;\n\tMon, 8 Jan 2024 18:44:22 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 741CE552;\n\tMon, 8 Jan 2024 18:43:18 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1704735864;\n\tbh=aY3Gv4gsm6CLa1Ie4p+Lg5/iDjMrVuNpUyI8y9czxcE=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=WmetFoIOJ35IMNcSD+dkZhZaaWpt2/UOaMK8Wh0KgXn12AYxdxYT/dnv8JfIKdEyY\n\tzZchWdPXcSCnhOU99aaxh5V/4Hd85CJY+POXuDLinSjSyA3+yPY33NP7vmbLqtkYDO\n\tlpLYOSe1/wojOBhxjd44z0mxjRFgu2Xj2nVmE6SziefO3PaQW6Mco1HCaJFI2pFgFP\n\trUayVu9Amy17sVx/OxITVQI9WBi2nEWruGjVcvGrTfBHmcPsAAG0ZjweRPuCymCH38\n\trZPjZfaPn12x3eU6xpGIm8Zre6SxVJWABg6siFqFljtI6BenBIy9AXp5Pt76V1nzQi\n\td8hMZ9jCylrOQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1704735798;\n\tbh=aY3Gv4gsm6CLa1Ie4p+Lg5/iDjMrVuNpUyI8y9czxcE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=ly4n3V42Uvhv2/9+gJCeo1xKNaFOahKH69E4xQ21YA7hwXzU4ZIrkZnib8uDFmAln\n\tpxWlgsuwzPGwXPUDi21j+Cg08UyQl5AxJwuSDe6GS3FB7zJSpjIdJnbyVuT79qoB34\n\t7FLeMmZ7j8T2E/nyprT8RZ8SD40RiXkFvyKYMl68="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ly4n3V42\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20231204161901.6632-1-naush@raspberrypi.com>\n\t\n\t","To":"David Plowman ,\n\tNaushir Patuck ,\n\tNaushir Patuck via libcamera-devel ","Date":"Mon, 08 Jan 2024 17:44:18 +0000","Message-ID":"<170473585835.3044059.2382919534712817117@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v1 0/2] Raspberry Pi vendor controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]