[{"id":28140,"web_url":"https://patchwork.libcamera.org/comment/28140/","msgid":"<20231123073524.GA15697@pendragon.ideasonboard.com>","date":"2023-11-23T07:35:24","subject":"Re: [libcamera-devel] [PATCH 0/2] gstreamer: Fix EOS clang build\n\tbreakage","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patches.\n\nOn Thu, Nov 23, 2023 at 10:18:09AM +0530, Umang Jain via libcamera-devel wrote:\n> The commit fd84180d7a09(\"gstreamer: Implement element EOS handling\")\n> introduced a compile breakage on clang:\n> \n> ../../src/gstreamer/gstlibcamerasrc.cpp:768:23: error: unused variable 'oldEvent' [-Werror,-Wunused-variable]\n> g_autoptr(GstEvent) oldEvent = self->pending_eos.exchange(event);\n> ^\n> \n> \n> Revert the patch and re-applied it with a clang pleasing fix.\n> \n> Jaslo Ziska (1):\n> gstreamer: Implement element EOS handling\n> \n> Umang Jain (1):\n> Revert \"gstreamer: Implement element EOS handling\"\n\nThe point of a revert is to apply it immediately to fix an urgent issue,\ngiving more time for the correct fix to be written. Given that no revert\nhas been pushed yet and the correct fix is available, let's simply fix\nthis without a revert.\n\n> src/gstreamer/gstlibcamerasrc.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A352DBDE6B\n\tfor ;\n\tThu, 23 Nov 2023 07:35:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D9DA629BC;\n\tThu, 23 Nov 2023 08:35:19 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2910A61DA6\n\tfor ;\n\tThu, 23 Nov 2023 08:35:18 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3F4D125A;\n\tThu, 23 Nov 2023 08:34:46 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1700724919;\n\tbh=mMiGlqfN3tLZd26scd3nraUK9ZvryYQBDyg0pYCCfDk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Wuc0qDRwIqgpVWH6XAKjpjIB2hG3RazFKgWxXGi/g0gQGx90u0DNGU0cpvpgKIwFu\n\tit6LqrrciS7CY1m5aacJSx7Rzy8OFMuWudN7O+c9SwwJMuFwwDCJiHutrNR8PVtA+D\n\tqRBtKVOnt/CNFfK70xxPLjrdtwj3LfXW3EAm1kR7FRUo/LBCiqWSHmeZ7+bn3NhnUD\n\t7D6VTC3uaVtcLd1e5K91degesW4zsFWamtfMD7LxobnkRdNAdBwzKzCRiMNFgtZ9sT\n\tNFvPjFZuQRl6E5Vnr4CjKUVJb2UWU0vmukNtMN5y7+3X6INfCjt0YcImMSHPu314O7\n\tRe7sVhxEBwjqA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1700724886;\n\tbh=mMiGlqfN3tLZd26scd3nraUK9ZvryYQBDyg0pYCCfDk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jDr53TK/0diqoSosZL8CQmfgKmuVzKjGnDMtQL1EF3t9fdV0WznefBqwhUaAH/VJX\n\tOzHImpW39Ul2IJG9+a8B/omIzftG8oxIxzVQ9EieM6Oi0+/U3uxEMeIG4llYfDqufO\n\t3KAytbGrKINH8sI8fudrTlbPGHYiuHTA+bKqYCN0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"jDr53TK/\"; dkim-atps=neutral","Date":"Thu, 23 Nov 2023 09:35:24 +0200","To":"Umang Jain ","Message-ID":"<20231123073524.GA15697@pendragon.ideasonboard.com>","References":"<20231123044811.70703-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20231123044811.70703-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 0/2] gstreamer: Fix EOS clang build\n\tbreakage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]