[{"id":28207,"web_url":"https://patchwork.libcamera.org/comment/28207/","msgid":"<170118833948.630990.6147536829662482020@ping.linuxembedded.co.uk>","date":"2023-11-28T16:18:59","subject":"Re: [libcamera-devel] [PATCH 0/3] ipa: rpi: vc4: Add support for\n\tArducam OV64A40","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush, David,\n\nDo you have any feedback for this series please?\n\n--\nRegards\n\nKieran\n\n\nQuoting Jacopo Mondi via libcamera-devel (2023-11-14 10:21:19)\n> Hello,\n> this small series adds support for the Arducam OV64A40 camera module to\n> the RaspberryPi VC4 IPA.\n> \n> The first version of the driver has been published to the linux-media mailing\n> list and a v2 will soon follow.\n> \n> Jacopo Mondi (1):\n> ipa: rpi: Provide a Camera Helper for the OV64A40\n> \n> Kieran Bingham (2):\n> libcamera: camera_sensor: Add OV64A40 sensor properties\n> ipa: rpi: vc4: Add OV64A40 tuning files\n> \n> src/ipa/rpi/cam_helper/cam_helper_ov64a40.cpp | 73 +++\n> src/ipa/rpi/cam_helper/meson.build | 1 +\n> src/ipa/rpi/vc4/data/meson.build | 1 +\n> src/ipa/rpi/vc4/data/ov64a40.json | 422 ++++++++++++++++++\n> src/libcamera/camera_sensor_properties.cpp | 4 +\n> 5 files changed, 501 insertions(+)\n> create mode 100644 src/ipa/rpi/cam_helper/cam_helper_ov64a40.cpp\n> create mode 100644 src/ipa/rpi/vc4/data/ov64a40.json\n> \n> --\n> 2.41.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EAF95BDE6B\n\tfor ;\n\tTue, 28 Nov 2023 16:19:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2F4CA629B6;\n\tTue, 28 Nov 2023 17:19:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AAEAF61DA2\n\tfor ;\n\tTue, 28 Nov 2023 17:19:02 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3093966F;\n\tTue, 28 Nov 2023 17:18:27 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701188344;\n\tbh=kjd+1TDIV875PgiNlpHsJSoXgBy33H84girGMwY4onc=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=hQheaY4Wl7qdZrKqVtAH+sHiFF1awmnH4SWCZJwu6kSpH9fwUUu//5tGk48BCzFmd\n\t4vyAD6MlYHiRzIOFKHcvhVnu855RpbvOp2lKawBawMqqHT1To/q88mEsHsY+yKaMa1\n\tMgHROf4bOiPtr7zL+YeCUSP8iONThQGnCHB5XbqstT+i8mGVdc75+PEf4vvbF8508I\n\tmNVQ7wmx/XjLjsLPgj/dqPCrjb4/FVPzpyGXvMbUiTj5Cd3G47GS4RB35js1e55PEg\n\tNIXha/HJdvum4fxiw9SrwUhRnS/XkBZW2gFmVty4ppIejU22+sXCA0zfwGwx+0VcO0\n\tIh2HCvOqSIK2A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701188307;\n\tbh=kjd+1TDIV875PgiNlpHsJSoXgBy33H84girGMwY4onc=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=NVHB3G+CmLk+n0wew2MlT4CCxZCr51svyDMm7wM/kT6CmVG8eD/WJ6JdoFCUMZmbN\n\tfzggjrSSuj0ixOk/F9XQ54M6IJvU2jEkC1MZ0Lq8Ihj08BitFWrlrNS/uUZO5sp0MB\n\tQmxreWO6QUoMCkzvfwaGZzaBmAv6DBbtjGuQJ89c="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"NVHB3G+C\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20231114102122.19712-1-jacopo.mondi@ideasonboard.com>","References":"<20231114102122.19712-1-jacopo.mondi@ideasonboard.com>","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org,\n\tNaushir Patuck , \n\tDavid Plowman , ","Date":"Tue, 28 Nov 2023 16:18:59 +0000","Message-ID":"<170118833948.630990.6147536829662482020@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 0/3] ipa: rpi: vc4: Add support for\n\tArducam OV64A40","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Jacopo Mondi , lee.jackson@arducam.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28209,"web_url":"https://patchwork.libcamera.org/comment/28209/","msgid":"<20231128163521.GB24293@pendragon.ideasonboard.com>","date":"2023-11-28T16:35:21","subject":"Re: [libcamera-devel] [PATCH 0/3] ipa: rpi: vc4: Add support for\n\tArducam OV64A40","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Nov 14, 2023 at 11:21:19AM +0100, Jacopo Mondi via libcamera-devel wrote:\n> Hello,\n> this small series adds support for the Arducam OV64A40 camera module to\n> the RaspberryPi VC4 IPA.\n> \n> The first version of the driver has been published to the linux-media mailing\n> list and a v2 will soon follow.\n> \n> Jacopo Mondi (1):\n> ipa: rpi: Provide a Camera Helper for the OV64A40\n> \n> Kieran Bingham (2):\n> libcamera: camera_sensor: Add OV64A40 sensor properties\n> ipa: rpi: vc4: Add OV64A40 tuning files\n> \n> src/ipa/rpi/cam_helper/cam_helper_ov64a40.cpp | 73 +++\n\nCan we add support for the sensor in libipa too please ?\n\n> src/ipa/rpi/cam_helper/meson.build | 1 +\n> src/ipa/rpi/vc4/data/meson.build | 1 +\n> src/ipa/rpi/vc4/data/ov64a40.json | 422 ++++++++++++++++++\n> src/libcamera/camera_sensor_properties.cpp | 4 +\n> 5 files changed, 501 insertions(+)\n> create mode 100644 src/ipa/rpi/cam_helper/cam_helper_ov64a40.cpp\n> create mode 100644 src/ipa/rpi/vc4/data/ov64a40.json","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B05E0C31E9\n\tfor ;\n\tTue, 28 Nov 2023 16:35:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 70D9061DA5;\n\tTue, 28 Nov 2023 17:35:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3800761DA2\n\tfor ;\n\tTue, 28 Nov 2023 17:35:15 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BF2DE66F;\n\tTue, 28 Nov 2023 17:34:39 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701189317;\n\tbh=yPzUBCg7+g3gEsQecANFtRpS+BJZB08juD2XvHzhDNk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=GJoQfvwCC2ZkfcyKYYexk+DkIVfskFHyZOMZipvwRUk80yEZFvfu/TQ0bqc1BoJ6K\n\tGtNVQ5g7LMQSyhUZhkKhC8hMs/vq3vF9q9ibMIe2f3zDJRoIuz+kJPPe7ky5ThwHMN\n\tuD8YZA2re5sLAFxt0U4PJCODQ92B1mP1q90V901e90RXCithd4kMMlzjM1q2AmmWD/\n\tEZ86sQ3H7tG3nFMzYDuurs1GSfp+2GmKPQej5k1NrEynATrqXHNN3aPdr2vm8eOyd/\n\t5bDA1o5Z9kwAuiY52MraIG+7AvNBEbEHjLE3KfUWP+6CkLehWpiNIEL6NyuuLJ6Qwe\n\tmVNpLZ+bEoOYA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701189280;\n\tbh=yPzUBCg7+g3gEsQecANFtRpS+BJZB08juD2XvHzhDNk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=kj/Ux41uYI26WgtjcuJ7qI1NC2HFMI/aay5ZFu15dI4iEjfUZxbVQ9jUBgH9kPGbp\n\tniuWruE76o+3jGTc0Ah4VsIiwlNEXrYyjdDH2nNFacfqdha1S7rFvjlgWzIeyv1FH5\n\t/AgiHGinTWYW2nwltNuBSyzyo6JJi/J054gFvAC8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"kj/Ux41u\"; dkim-atps=neutral","Date":"Tue, 28 Nov 2023 18:35:21 +0200","To":"Jacopo Mondi ","Message-ID":"<20231128163521.GB24293@pendragon.ideasonboard.com>","References":"<20231114102122.19712-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20231114102122.19712-1-jacopo.mondi@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 0/3] ipa: rpi: vc4: Add support for\n\tArducam OV64A40","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, lee.jackson@arducam.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28211,"web_url":"https://patchwork.libcamera.org/comment/28211/","msgid":"","date":"2023-11-28T18:46:24","subject":"Re: [libcamera-devel] [PATCH 0/3] ipa: rpi: vc4: Add support for\n\tArducam OV64A40","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Kieran,\n\n\n\nOn Tue, 28 Nov 2023, 4:19 pm Kieran Bingham, <\nkieran.bingham@ideasonboard.com> wrote:\n\n> Hi Naush, David,\n>\n> Do you have any feedback for this series please?\n>\n\nEverything looks good as far as I can tell, although I don't have access to\nthe data sheet or a sensor to test delays, etc. out.\n\nSo for the whole series:\n\nReviewed-by: Naushir Patuck \n\n\n>\n>\n> --\n> Regards\n>\n> Kieran\n>\n>\n> Quoting Jacopo Mondi via libcamera-devel (2023-11-14 10:21:19)\n> > Hello,\n> > this small series adds support for the Arducam OV64A40 camera module to\n> > the RaspberryPi VC4 IPA.\n> >\n> > The first version of the driver has been published to the linux-media\n> mailing\n> > list and a v2 will soon follow.\n> >\n> > Jacopo Mondi (1):\n> > ipa: rpi: Provide a Camera Helper for the OV64A40\n> >\n> > Kieran Bingham (2):\n> > libcamera: camera_sensor: Add OV64A40 sensor properties\n> > ipa: rpi: vc4: Add OV64A40 tuning files\n> >\n> > src/ipa/rpi/cam_helper/cam_helper_ov64a40.cpp | 73 +++\n> > src/ipa/rpi/cam_helper/meson.build | 1 +\n> > src/ipa/rpi/vc4/data/meson.build | 1 +\n> > src/ipa/rpi/vc4/data/ov64a40.json | 422 ++++++++++++++++++\n> > src/libcamera/camera_sensor_properties.cpp | 4 +\n> > 5 files changed, 501 insertions(+)\n> > create mode 100644 src/ipa/rpi/cam_helper/cam_helper_ov64a40.cpp\n> > create mode 100644 src/ipa/rpi/vc4/data/ov64a40.json\n> >\n> > --\n> > 2.41.0\n> >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CFD96BDE6B\n\tfor ;\n\tTue, 28 Nov 2023 18:46:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F1D2F629B6;\n\tTue, 28 Nov 2023 19:46:37 +0100 (CET)","from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com\n\t[IPv6:2607:f8b0:4864:20::112c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0135F61DA2\n\tfor ;\n\tTue, 28 Nov 2023 19:46:36 +0100 (CET)","by mail-yw1-x112c.google.com with SMTP id\n\t00721157ae682-5ce8eff71e1so40437317b3.0\n\tfor ;\n\tTue, 28 Nov 2023 10:46:36 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701197198;\n\tbh=v6WYgArvQqvdiVeVLHSkKHdHVSHe7VDslSWkcZnKMCI=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=EK1A74EJmhJugBO3SqAXWMPCzj6NLZHB2YQtUoJV77dGBpDCP337qt/kqQ1k714fa\n\t42VBN5suPO99L5Bo51CbhMgbNs+MyHUwPPxKbL8eJp4mloWsVLLWjNkR1L2npdKWnC\n\t2DsV4rCfhR719ZnScGWdicdBvugT6L6SCcp/Iw2zEZRWPfQV8afwLrk+7lnJJf0qDe\n\tPqCKAQn3FdP3rcL79MSeBNehZVm9DltrFriW9cUElEffJZjSsY1M6U6cAYaPR4cXTh\n\tIRKkmDJXdqUauMqdi8gV38Vhhl7GB9ks/msVSkYaFclTqYLzsVcwcPd/3n8sVtOmg+\n\tPnVWZFAo4wtDg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1701197196; x=1701801996;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=DMiN520kY3NG22CQiT7MebtbHJe98Xf09kw9a/AY9N0=;\n\tb=RFS9c/+LQ3mlMQngYetXxWUi+RtIRjmmEdLjOjLKkr8jr3Mssrb0phWRWFiOdpDWJS\n\tjGEnD9CQHuWaOfncbmHwhyi+T6+dBqHCAZN67TiDcOzw5x8zT2oeATBB04EjLb2li3+Q\n\t2qun46dd9RYM3tNz0LkcTrwDjRGVT7BYV+nQho7k3qt9H7l6bKbr6gVXYPNToWbjBJls\n\tPKLYiQUjWiIMJRyyRapQnaO58Gam/VbFCeP1rKlOJ9Wk/GV56EwvpMt8ildWVoXVtyoj\n\tZdEpLyIwyfdpQo8qc5FiLwyh4DbaMV8Yv/35uPNYpsTxq4qfi964cgt6OM8ASGgGx94y\n\tlbjw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"RFS9c/+L\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1701197196; x=1701801996;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=DMiN520kY3NG22CQiT7MebtbHJe98Xf09kw9a/AY9N0=;\n\tb=KEdMzNhto20/UWl8bBp0Ud3YWwkL+w1/Gls3o1kbQjSSES4/ei8NLVoQoGCVLX17m3\n\ti83OnkzN+oi/Xcmqam5w/gc8fitPm93FmczBhhC4a17URLGSL9sJnN0REhJlvF0bSyUX\n\t/QaRjY4COIe87e0JXpV7jlxA+ohMm6QiDo8iNjycAtXlS7+KGSgCr5z2frRyX27F+O3G\n\tGyMt+978Z1tVQtwAuyLLmHccKgPZM9oNx9cJwXtRgCnwI9XjY8+aH3ldkxg97OpuqDgo\n\tuhiVE+LUliJe3HMB0rEwJT4nwk3ec0SUHGiHjsEE/eqWzF38dV3HcJ1yP1Zr4qLeDpZb\n\tkvkw==","X-Gm-Message-State":"AOJu0Ywmceb8GmsR35DL2dXd6pMEpqNwexn/kv37b6DnibzyCZcFWwIh\n\ttDgpbmcMkIBZJdFGPce1RD0dvBLs0mAUziSwaNns2+v75Q9k9HNRhEc=","X-Google-Smtp-Source":"AGHT+IH+4sDxf19Xe8uq91IEKTCm2UeOp5NLUqnFZA9JJF/P+QkEfCcsSbFedfx3PLeqwI+xGMwXSWWEx8tf6QZBRPo=","X-Received":"by 2002:a0d:fc45:0:b0:5cb:fd23:57e7 with SMTP id\n\tm66-20020a0dfc45000000b005cbfd2357e7mr15709792ywf.4.1701197195807;\n\tTue, 28 Nov 2023 10:46:35 -0800 (PST)","MIME-Version":"1.0","References":"<20231114102122.19712-1-jacopo.mondi@ideasonboard.com>\n\t<170118833948.630990.6147536829662482020@ping.linuxembedded.co.uk>","In-Reply-To":"<170118833948.630990.6147536829662482020@ping.linuxembedded.co.uk>","Date":"Tue, 28 Nov 2023 18:46:24 +0000","Message-ID":"","To":"Kieran Bingham ","Content-Type":"multipart/alternative; boundary=\"0000000000008ca655060b3ad6fd\"","Subject":"Re: [libcamera-devel] [PATCH 0/3] ipa: rpi: vc4: Add support for\n\tArducam OV64A40","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"Jacopo Mondi ,\n\tlibcamera devel ,\n\tlee.jackson@arducam.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]