[{"id":28051,"web_url":"https://patchwork.libcamera.org/comment/28051/","msgid":"<20231102090735.GH5933@pendragon.ideasonboard.com>","date":"2023-11-02T09:07:35","subject":"Re: [libcamera-devel] [PATCH v5 0/1] HDR controls","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nOn Thu, Oct 26, 2023 at 12:11:30PM +0100, David Plowman via libcamera-devel wrote:\n> Hi\n> \n> Version 5 is mostly trying to be more specific about the descriptions,\n> concentrating in the main on what the normal or default\n> implementations might do (before anyone dives in and alters the\n> behaviour). I have a few little niggles:\n> \n> * The night mode is still a bit vague. I don't have much of a feel for\n> whether there is a reasonable default behaviour for this. I suppose\n> we could just say that frames are labelled long/medium/short\n> according to the implementation?\n\nI'll check patch 1/1 and will comment there.\n\n> * I've said vaguely that frames cycle between short/long or\n> short/medium/long according to the implementation. Do we need to be\n> signalling which category an implementation falls into?\n\nMaybe in the future, but for now I think it's fine.\n\n> * There's no clear reason why HdrChannelNone exists. I do believe it\n> is useful\n\nI have a bit of trouble not reading this is a contradiction :-)\n\n> , not just for Pi users who might want to mess around and\n> do unusual things, but also when switching exposures reliably from\n> frame to frame proves difficult (because it is quite hard to do\n> right).\n\nI think I'm fine keeping it and see where it will lead us.\n\n> David Plowman (1):\n> libcamera: controls: Add controls for HDR\n> \n> src/libcamera/control_ids.yaml | 87 ++++++++++++++++++++++++++++++++++\n> 1 file changed, 87 insertions(+)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E464BDCBD\n\tfor ;\n\tThu, 2 Nov 2023 09:07:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 730006298F;\n\tThu, 2 Nov 2023 10:07:33 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3800C61DC4\n\tfor ;\n\tThu, 2 Nov 2023 10:07:30 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 92BB3667;\n\tThu, 2 Nov 2023 10:07:12 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1698916053;\n\tbh=vszLE+J46cv58c2yTrX1OfHMj/0jueYD5ryDvIkFh2A=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=HZBgFDDhYhg2ShFCXtkD98hVRPDXpiew8M8VRHtL09rZNAQB3gbdFvkC+5Qw/fioB\n\tCn9el7f/puUIznNA1TE5YM/OJryqF9YybvADgBo3EKndIB1JM1L5Ixh9PLFN3Faxxs\n\t60ls9U5gWJsE3gP8bEAxiJNBdU+wo07Dbg0BQ3LSwxbTAwqA5f3z0z4bd0eywlgtDq\n\t2t/qqKU5QVOyMYxBBhg1w0M+e3qXmRuIYRAPnWyf4yydH2OVlX6bUkGXNg4EHEIoWM\n\tMA8hIpTdxrzC5Jh4uy/VkqRuAXbcnIOTPuP6MSbw+zM+9Y+svVhHcsUJ5hNL/QxLXf\n\twawQOPNm5TmZQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1698916032;\n\tbh=vszLE+J46cv58c2yTrX1OfHMj/0jueYD5ryDvIkFh2A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=TfPDcs1HBl0f9o/JPAau44u9t/TGGDi7bGzP8h/oQT+yVUsl1VCOKAmPzxaPiUxnn\n\tg7mb29NoHXRqQDKTaFMjT9xPG4CObcMJcidbxu8jjAXL0dRbejeUCJUD22px8P46wp\n\tczHQ0gktCDiFSJ0BunCHE272PWwfDCBw97VNajAo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"TfPDcs1H\"; dkim-atps=neutral","Date":"Thu, 2 Nov 2023 11:07:35 +0200","To":"David Plowman ","Message-ID":"<20231102090735.GH5933@pendragon.ideasonboard.com>","References":"<20231026111131.93825-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20231026111131.93825-1-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v5 0/1] HDR controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]