[{"id":28038,"web_url":"https://patchwork.libcamera.org/comment/28038/","msgid":"","date":"2023-10-24T08:08:36","subject":"Re: [libcamera-devel] [PATCH v1 0/6] Raspberry Pi: Preliminary PiSP\n\tsupport (round 2)","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi all,\n\nGiven that these changes are specific to the RPi IPA, I'm not sure\nfolks would want to dive in deep and do a review. But of course, feel\nfree to do so if time permits :-)\n\nSince both David and I have added R-B tags to the patches, should I go\nahead and make a git request-pull for this series to be merged?\n\nRegards,\nNaush\n\nOn Fri, 20 Oct 2023 at 09:40, Naushir Patuck wrote:\n>\n> Hi all,\n>\n> Here is another small set of patches adding preliminary Pi 5 support to\n> libcamera. This change is predominately related to HDR functionality, and only\n> includes changes to the Raspberry Pi IPA algorithms.\n>\n> As before, the actual pipeline handler and IPA for Pi 5 is not yet published to\n> the mailing list, but can be found at https://github.com/raspberrypi/libcamera.\n>\n> Thanks,\n> Naush\n>\n> David Plowman (5):\n> ipa: rpi: hdr: Add the ability to alter the LSC table\n> ipa: rpi: alsc: Do not re-read the alsc.status metadata\n> ipa: rpi: agc: Allow AGC channels to avoid using \"fast desaturation\"\n> ipa: rpi: agc: Fetch AWB status in the prepare method\n> ipa: rpi: agc: Make AGC controls affect all channels\n>\n> Naushir Patuck (1):\n> ipa: rpi: vc4: Move denoise control handling into the VC4 derived IPA\n>\n> src/ipa/rpi/common/ipa_base.cpp | 55 ++-----\n> src/ipa/rpi/controller/agc_algorithm.h | 11 +-\n> src/ipa/rpi/controller/rpi/agc.cpp | 51 +++---\n> src/ipa/rpi/controller/rpi/agc.h | 13 +-\n> src/ipa/rpi/controller/rpi/agc_channel.cpp | 23 ++-\n> src/ipa/rpi/controller/rpi/agc_channel.h | 1 +\n> src/ipa/rpi/controller/rpi/alsc.cpp | 22 +--\n> src/ipa/rpi/controller/rpi/hdr.cpp | 183 ++++++++++++++-------\n> src/ipa/rpi/controller/rpi/hdr.h | 18 +-\n> src/ipa/rpi/vc4/vc4.cpp | 35 +++-\n> 10 files changed, 237 insertions(+), 175 deletions(-)\n>\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1A6F9C0DA4\n\tfor ;\n\tTue, 24 Oct 2023 08:09:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 47FE06297B;\n\tTue, 24 Oct 2023 10:09:09 +0200 (CEST)","from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com\n\t[IPv6:2607:f8b0:4864:20::b2b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C0D9461DCC\n\tfor ;\n\tTue, 24 Oct 2023 10:09:07 +0200 (CEST)","by mail-yb1-xb2b.google.com with SMTP id\n\t3f1490d57ef6-d9b0f27dea5so3591806276.0\n\tfor ;\n\tTue, 24 Oct 2023 01:09:07 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1698134949;\n\tbh=7gxYfaed0x1Cs2ZLGdYB8ZmuM34LDPiA9udi8RdvNdI=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=1d5XWbDIvABsmukFe5N/QLr44dcuMZpAWl2EA7Gv46BIJvIKCpKLxnrT9PrxkWKUo\n\tcC81yv1MPmy4lIQx/iUSDcGPfDIejXKkbmsWA4h0eb0+lbC7qbWARPViRbcvz9cu3U\n\tPOUkgwUzpA+rBv9w2CK8qK5TyXZET4FL50Y3NRUHWQ+X0/bf6GpBbWT9Vb5Jca8VsN\n\txuEd63gQfGrICg7oC8YAFjRAxzQVTVXApRHTYP+V3sGJEMiS5CgCnkkJjNP1hKBw3m\n\tTGP/gVd+irOjay96AzyxCzb8Qx5kHwvPaqT4gM9YCdpQ0vYQjPZKO2dDEPn6vokDuC\n\tfD07ckIrv9nhQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1698134946; x=1698739746;\n\tdarn=lists.libcamera.org; \n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=oxe8/yncCm41t88MF7novSgvYNZ7mGIqdN8RpMR8YTY=;\n\tb=mUUfkt2ovNDnaTlwt8rnagGXzvNG+D+/gGoRCU+KZlesfgoXLJ3eUQRjQuKh2+LLwR\n\tZw9Zfx7oE10FugE7oUQcE57TE1HYAqcXaM4i6DU/P+KEhWQaNwmu+XXy/dHnG+pKxTH2\n\t+OnLx57ZL5jSCbdLF/QCYfNTdVqv+bGz2Ja5VUCsTsz+BWusFiQi398SX5eKPYDVPeGa\n\tw4ESN+Ib+jQaBBeK7OpbPAJKTQf8G/voa+sLD6WkUge8tJ9wSr+RSI5yxQD8L9u9BVOr\n\tkt4ks+WwdhP6rIyFjXUW1bLnsXae5ZlN4R+xMRoC7GZA6YSf1BjtjTIZc+otbDN/5OcY\n\tr5hw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"mUUfkt2o\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1698134946; x=1698739746;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=oxe8/yncCm41t88MF7novSgvYNZ7mGIqdN8RpMR8YTY=;\n\tb=FmymVYCGn/OwCSjzDM2lqKt/flVmSvZfPukphfIeftYWDt7OLIdVmRibSfa3ZIqZ30\n\tPysAsSvv9cuw6idUSyX73QtoTnhTkmPpzGFgBaG4Xo9ow9TsfL1jvyyhLBgHuoC2nxbl\n\tBG0iEUdwM6wNPzefMBZ8JNsvy5/D+av99IcA913T9md2Hefq/fLsNAkqbcz+3B//w5cw\n\tZF7TYZlsZTo9E97AKSoS/DYj8+7hKzt4QV+ID4Sxie491Dv+uhH400EQcc9YpvBDjJBa\n\tu99alXHRjdb206EItxTE19pnsu7T++6+Zz9tAKkzZ+RVkkgYW9JVRq0PlORr5ncn319k\n\t9Fsw==","X-Gm-Message-State":"AOJu0YwTRTRGOiQi9/oL0RaaEZTC0p5/V3abwumvMghZE4zfeOoQp42j\n\tomZq0ANvHfBbPU8Pq3p9hhYRHfrlgiStplPpf+Ne4XZT6v9nGJg5drQ=","X-Google-Smtp-Source":"AGHT+IGqvVUvudFoJpl0YHw5oXYwiCxNDc5toazz6IQw9oGbYciNwWtAgXzlty47x2ucqOKNW+6CjTRac24+lHPTEN0=","X-Received":"by 2002:a5b:608:0:b0:d9a:e947:447b with SMTP id\n\td8-20020a5b0608000000b00d9ae947447bmr11170590ybq.14.1698134946394;\n\tTue, 24 Oct 2023 01:09:06 -0700 (PDT)","MIME-Version":"1.0","References":"<20231020084002.30665-1-naush@raspberrypi.com>","In-Reply-To":"<20231020084002.30665-1-naush@raspberrypi.com>","Date":"Tue, 24 Oct 2023 09:08:36 +0100","Message-ID":"","To":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v1 0/6] Raspberry Pi: Preliminary PiSP\n\tsupport (round 2)","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28040,"web_url":"https://patchwork.libcamera.org/comment/28040/","msgid":"<169813874913.630990.9333764510454505465@ping.linuxembedded.co.uk>","date":"2023-10-24T09:12:29","subject":"Re: [libcamera-devel] [PATCH v1 0/6] Raspberry Pi: Preliminary PiSP\n\tsupport (round 2)","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nQuoting Naushir Patuck via libcamera-devel (2023-10-24 09:08:36)\n> Hi all,\n> \n> Given that these changes are specific to the RPi IPA, I'm not sure\n> folks would want to dive in deep and do a review. But of course, feel\n> free to do so if time permits :-)\n> \n> Since both David and I have added R-B tags to the patches, should I go\n> ahead and make a git request-pull for this series to be merged?\n\nA PR here is fine with me.\n\n--\nRegards\n\nKieran\n\n> \n> Regards,\n> Naush\n> \n> On Fri, 20 Oct 2023 at 09:40, Naushir Patuck wrote:\n> >\n> > Hi all,\n> >\n> > Here is another small set of patches adding preliminary Pi 5 support to\n> > libcamera. This change is predominately related to HDR functionality, and only\n> > includes changes to the Raspberry Pi IPA algorithms.\n> >\n> > As before, the actual pipeline handler and IPA for Pi 5 is not yet published to\n> > the mailing list, but can be found at https://github.com/raspberrypi/libcamera.\n> >\n> > Thanks,\n> > Naush\n> >\n> > David Plowman (5):\n> > ipa: rpi: hdr: Add the ability to alter the LSC table\n> > ipa: rpi: alsc: Do not re-read the alsc.status metadata\n> > ipa: rpi: agc: Allow AGC channels to avoid using \"fast desaturation\"\n> > ipa: rpi: agc: Fetch AWB status in the prepare method\n> > ipa: rpi: agc: Make AGC controls affect all channels\n> >\n> > Naushir Patuck (1):\n> > ipa: rpi: vc4: Move denoise control handling into the VC4 derived IPA\n> >\n> > src/ipa/rpi/common/ipa_base.cpp | 55 ++-----\n> > src/ipa/rpi/controller/agc_algorithm.h | 11 +-\n> > src/ipa/rpi/controller/rpi/agc.cpp | 51 +++---\n> > src/ipa/rpi/controller/rpi/agc.h | 13 +-\n> > src/ipa/rpi/controller/rpi/agc_channel.cpp | 23 ++-\n> > src/ipa/rpi/controller/rpi/agc_channel.h | 1 +\n> > src/ipa/rpi/controller/rpi/alsc.cpp | 22 +--\n> > src/ipa/rpi/controller/rpi/hdr.cpp | 183 ++++++++++++++-------\n> > src/ipa/rpi/controller/rpi/hdr.h | 18 +-\n> > src/ipa/rpi/vc4/vc4.cpp | 35 +++-\n> > 10 files changed, 237 insertions(+), 175 deletions(-)\n> >\n> > --\n> > 2.34.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BD6F7C0DA4\n\tfor ;\n\tTue, 24 Oct 2023 09:12:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 135D86297F;\n\tTue, 24 Oct 2023 11:12:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B77F61DCC\n\tfor ;\n\tTue, 24 Oct 2023 11:12:32 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C00BAB53;\n\tTue, 24 Oct 2023 11:12:20 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1698138754;\n\tbh=jlwSVB0VGcoWgp1KaowBn+Tl0ELCOCDKp+yqnkzJxb8=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=jEqVrVLCaV4UgaWP5BHXj31tIbftZCwOTfpGB0WI4AwP52Ejx1TkOzgqaMWyq+LR8\n\trlEflaz9B4sRkvHDjxmmDllxUCXLG/3NpGl6jXiRQsyXuTiaBkj+tH0PT1uqsyYBpd\n\tsyYhv2r5FjI7Xr9ULDvff1sDs1x01DnIo9tuDW5ez94ENUHldqaBaR0NQLQ3S9DcJW\n\tzSIBTz046/zyf4HuLgVik98td6/nHX5jN5fAf7jzyDgXbwT7Qd4kotSbHgX1UVqxoK\n\tXvQg/+rlhBww5mmEr7+QtNq9o0YN8ckdKGgtmqkaCzIwwmNqeK+3i1KzomoXxRM15O\n\tmkIpxiqEXLuMw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1698138740;\n\tbh=jlwSVB0VGcoWgp1KaowBn+Tl0ELCOCDKp+yqnkzJxb8=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Vm4x+bGS0u8CUmLnStUFqV3giOjSZAzI2CCRySqHpjc1N5Vtuhd3ZVBIXBiTjV6Ug\n\tSUkViAvWcypj6RsQtzZlklZK7ZfqocdS3hDdZY7PMgqzOIa8GxGvYWQYIg2l0iltyR\n\t8txNg0GlZN9kxlq7jdhE3N3i0qbad7yI+V8mnHys="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Vm4x+bGS\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20231020084002.30665-1-naush@raspberrypi.com>\n\t","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 24 Oct 2023 10:12:29 +0100","Message-ID":"<169813874913.630990.9333764510454505465@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v1 0/6] Raspberry Pi: Preliminary PiSP\n\tsupport (round 2)","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]