[{"id":27760,"web_url":"https://patchwork.libcamera.org/comment/27760/","msgid":"","date":"2023-09-12T13:57:49","subject":"Re: [libcamera-devel] [PATCH v3 0/5] Multi-channel AGC","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi David\n\nOn Tue, Sep 12, 2023 at 11:24:37AM +0100, David Plowman via libcamera-devel wrote:\n> Hi everyone\n>\n> Version 3 of this patch set addresses most of the points that Jacopo\n> raised in his review, so thank you very much for those!\n>\n> Mostly I've done all the suggested things, especially the little\n> \"tidy-ups\", with a couple of exceptions.\n>\n> Jacopo suggested moving the addition of the setActiveChannels function\n> into the first patch where it is used, though I've left it in the\n> previous patch where AGC channels are introduced. But I don't mind\n> moving it if folks would prefer that.\n>\n> I've also not made any of the changes to code that I simply copied\n> from one file to another - probably best left for another day?\n\nI'll reply here instead that on the previous version. For code that\nhas been copied around, I'm fine with the proposed approach of not\nchaning it.\n\n>\n> I think there were a couple of things where I couldn't really decide\n> what was better, but am happy to discuss those again too.\n\nI'll go with another reivew round but you answers clarified most of my\nquestions and what's left undecided is mostly internal implementations\nof your algorithms, so really up to you!\n\nThanks\n j\n\n>\n> Thanks!\n>\n> David\n>\n> David Plowman (4):\n> ipa: rpi: agc: Reorganise code for multi-channel AGC\n> ipa: rpi: agc: Implementation of multi-channel AGC\n> ipa: rpi: agc: Add AgcChannelConstraint class\n> ipa: rpi: agc: Use channel constraints in the AGC algorithm\n>\n> Naushir Patuck (1):\n> ipa: rpi: histogram: Add interBinMean()\n>\n> src/ipa/rpi/common/ipa_base.cpp | 20 +-\n> src/ipa/rpi/controller/agc_algorithm.h | 19 +-\n> src/ipa/rpi/controller/agc_status.h | 1 +\n> src/ipa/rpi/controller/histogram.cpp | 22 +-\n> src/ipa/rpi/controller/histogram.h | 2 +\n> src/ipa/rpi/controller/meson.build | 1 +\n> src/ipa/rpi/controller/rpi/agc.cpp | 972 ++++---------------\n> src/ipa/rpi/controller/rpi/agc.h | 125 +--\n> src/ipa/rpi/controller/rpi/agc_channel.cpp | 1012 ++++++++++++++++++++\n> src/ipa/rpi/controller/rpi/agc_channel.h | 151 +++\n> 10 files changed, 1425 insertions(+), 900 deletions(-)\n> create mode 100644 src/ipa/rpi/controller/rpi/agc_channel.cpp\n> create mode 100644 src/ipa/rpi/controller/rpi/agc_channel.h\n>\n> --\n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6AFBEBD160\n\tfor ;\n\tTue, 12 Sep 2023 13:57:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7AB23628EC;\n\tTue, 12 Sep 2023 15:57:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 178D261DEF\n\tfor ;\n\tTue, 12 Sep 2023 15:57:53 +0200 (CEST)","from ideasonboard.com (mob-5-90-67-213.net.vodafone.it\n\t[5.90.67.213])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A85517F3;\n\tTue, 12 Sep 2023 15:56:21 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1694527074;\n\tbh=lUY1UcdHGoLlR8c1jUMMUBhg/ns9UH2wfnO3d/a2B00=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=aqIFI1GeqZ+I7XQJlo5iQDXy6LA27aqwa+w/ClRS7I/lTKu97IrAKqNk4kHkh4Tmx\n\t+YTDfPw73/EAYxv6oOkDV4f9xWbosl41KfN4XQn4zzfg8jkXfAMg3cG7qGlTlWa+6s\n\tt2WzXP49nYHlUiQ2R/U+wzWo9aueCAdH2MQqUKtpKC1VrDhITD8s4SSf5J3ES3uGzQ\n\t+unCxwqJdhXs67MbH5uAfNmYryBczBhYfFOxfu23Kge4gvkPWADPIhw7refWIJuId4\n\tCwcPVCFKScl3dfo3cYYGPy/iaOVD7ADYBg8wwIgRaexoiV2jXk93Va7rA7jGrKROge\n\tBGJ26ckYbMBLw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1694526981;\n\tbh=lUY1UcdHGoLlR8c1jUMMUBhg/ns9UH2wfnO3d/a2B00=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VgmsUix8p/qjnvaNk7QXfhA9yI/RV00wm0IcDMxv6oT0xCvDLB2Q96c9u+LpdxrJa\n\tHoawC3ClFSDFqSiqmNvIuBVxAAK9+2tPVh8opjlzRCvORLGz7JjqHgfdQaphSV4z+n\n\tEmy5Mgyu89LBjcgF2fp8aavD9ZnsmCXaoMYrtILQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VgmsUix8\"; dkim-atps=neutral","Date":"Tue, 12 Sep 2023 15:57:49 +0200","To":"David Plowman ","Message-ID":"","References":"<20230912102442.169001-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230912102442.169001-1-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v3 0/5] Multi-channel AGC","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]