[{"id":27720,"web_url":"https://patchwork.libcamera.org/comment/27720/","msgid":"","date":"2023-09-04T08:20:43","subject":"Re: [libcamera-devel] [PATCH v2 0/4] Raspberry Pi: External buffer\n\thandling","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi all,\n\nPing for another review on this please? Thanks!\n\nNaush\n\nOn Tue, 25 Jul 2023 at 09:56, Naushir Patuck wrote:\n\n> Hi,\n>\n> Very minor changes in v2 to address Jacopo's comments:\n>\n> 1) Remove the \"count\" test in patch 1/4.\n> 2) Remove the CameraData::handleExternalBuffer() declaration in patch 2/4.\n> 3) Fix RPi::Stream() constructor for initial id value in patch 4/4.\n>\n> Regards,\n> Naush\n>\n> Naushir Patuck (4):\n> pipeline: rpi: Increase buffer import count to 32\n> pipeline: rpi: Remove additional external dma buf handling logic\n> pipeline: rpi: Rename RPi::Stream::setExternalBuffer()\n> pipeline: rpi: Simplify buffer id generation\n>\n> .../pipeline/rpi/common/pipeline_base.cpp | 18 +------\n> .../pipeline/rpi/common/pipeline_base.h | 1 -\n> .../pipeline/rpi/common/rpi_stream.cpp | 53 +++++--------------\n> .../pipeline/rpi/common/rpi_stream.h | 48 ++---------------\n> 4 files changed, 17 insertions(+), 103 deletions(-)\n>\n> --\n> 2.34.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3DEA5C0F1B\n\tfor ;\n\tMon, 4 Sep 2023 08:21:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 901B3628DF;\n\tMon, 4 Sep 2023 10:21:22 +0200 (CEST)","from mail-yw1-x112e.google.com (mail-yw1-x112e.google.com\n\t[IPv6:2607:f8b0:4864:20::112e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB0C061DF7\n\tfor ;\n\tMon, 4 Sep 2023 10:21:20 +0200 (CEST)","by mail-yw1-x112e.google.com with SMTP id\n\t00721157ae682-58d31f142eeso11850047b3.0\n\tfor ;\n\tMon, 04 Sep 2023 01:21:20 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1693815682;\n\tbh=7WICJZPoj9L4xdX9R2H2XkzajfIdiQF5LzeLN8HWhX4=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=0JwkYZreZvT0SkSyy8JLRh6BP3xsncbZMQRdW2uLkPnDzN8FoD+OKIYXr037rAdsK\n\tlAd2xGUd8bf8owQ5O7cszltP4LbCfsw2FACuAzWF0tKoXcUb8GdmDlt0R0cwE+kpCX\n\tH2vy5qQ2RxFG0l/YWVcYuUmEVj0POzA/VlmO3HKkdG96UPAy2NVxd7qrGYPti5GcZw\n\tpIgldev5F9/CGoT4aMKq0SK2NSLAueolL+7bja+kmkpDjM5+OT9dks4FT1aOgze/2V\n\trRm3QuK9LgkpXL7jI6Vfs7tiNlwBWMFkHH3GsiIvKPu1SC5c5ZARtlZJ/O+hxY/cch\n\taI3TAHFHHNqTw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1693815679; x=1694420479;\n\tdarn=lists.libcamera.org; \n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=RP/us5r8yXf7g09mp7iZoTUMthIEfNKLMBnsqfj3+KA=;\n\tb=eZOJ3pUyE3wuBdXYqk364RWaPN1qf29ZQHgRQXXnW1EsE2ztNrz7X/vTAMGuSLxFNT\n\tReLSOppumWGsDW5Wd0YXkS07kWuoZElE5SUHCr4jxzZDk45DPI8SXQHdd2ZyMR3vYge5\n\txkJcjg5wqzRKvNkvxbZaXdBFihkA2d5IPQxXODzMRd1c84tA+Eskx9jbcEwIO+6p8ul7\n\tc+FY7BiA296lgMHGE+sMNR4J/389bYmbhCqk948+qqYMFq1L+qI5YNyuvBfOoCCXy4Lv\n\tsV/n4phfy/I7znmqQ1FLw9jcOQZPMQS8T2zRPKLVdJ8JLQ/2iBeVjUX3KXp6LbqBG0iR\n\tUILw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"eZOJ3pUy\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1693815679; x=1694420479;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=RP/us5r8yXf7g09mp7iZoTUMthIEfNKLMBnsqfj3+KA=;\n\tb=lUTiZOSbWKKboPQKlrbRI3VXoQxgWMiP3EUum/I+jkinHnszZM92tQqg1lfA2fK0W2\n\tL+4lyNuE/Sm7Oa7xtfScuReq3U/Y6TDz7vt/bc/gpB+FTH8K+9UJqaGysL0z/Z5xSHTL\n\tdVtw35n5YpQDOpLfEwOtU+VY92TI2fVSVCXFB+M4lalD5nIr+mhF/71/DGkqxZFt7HUY\n\tyGuwS3+UDhZ2kyz9u4vOElPmNflkU2jFc2ASLqVMSR4AaIvmDuPUHmOfAswwRhDkXSon\n\tS/RLjvv9/KRLJ6ia0R4wh2z+YGT4lOKyJHzt3MdFLA6DwyJv2n5u/5CI5DlLMcuDVnJ9\n\tO+Jw==","X-Gm-Message-State":"AOJu0YzK6xqr0pk8hDczLAs35iw7KyGKc+hMzJZNB2SL0dKx9Akf0wN/\n\tHZoF63cNECvueZ6pzSjVC/VG+b0FP/2PjW6ksikh1MvDWTdEXaFRM64=","X-Google-Smtp-Source":"AGHT+IHImbwcANNiPHmxRCQM1LiUpJgCDOocLpmSpwTnXK954mf5ZcQth8dRzmy501DHk6x+DmD6qpdgOYJCgLY9o5c=","X-Received":"by 2002:a0d:e2d1:0:b0:58c:6121:48e8 with SMTP id\n\tl200-20020a0de2d1000000b0058c612148e8mr10810744ywe.33.1693815679322;\n\tMon, 04 Sep 2023 01:21:19 -0700 (PDT)","MIME-Version":"1.0","References":"<20230725085540.24863-1-naush@raspberrypi.com>","In-Reply-To":"<20230725085540.24863-1-naush@raspberrypi.com>","Date":"Mon, 4 Sep 2023 09:20:43 +0100","Message-ID":"","To":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"000000000000e1a2100604843163\"","Subject":"Re: [libcamera-devel] [PATCH v2 0/4] Raspberry Pi: External buffer\n\thandling","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]