{"id":18841,"url":"https://patchwork.libcamera.org/api/covers/18841/?format=json","web_url":"https://patchwork.libcamera.org/cover/18841/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230718105210.83558-1-jacopo.mondi@ideasonboard.com>","date":"2023-07-18T10:52:00","name":"[libcamera-devel,v3,0/10] libcamera: Replace CameraConfiguration::transform","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/18841/mbox/","series":[{"id":3976,"url":"https://patchwork.libcamera.org/api/series/3976/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3976","date":"2023-07-18T10:52:00","name":"libcamera: Replace CameraConfiguration::transform","version":3,"mbox":"https://patchwork.libcamera.org/series/3976/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/18841/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2E3FBBDC71\n\tfor ;\n\tTue, 18 Jul 2023 10:52:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 813DD628BC;\n\tTue, 18 Jul 2023 12:52:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 41CB261E2B\n\tfor ;\n\tTue, 18 Jul 2023 12:52:19 +0200 (CEST)","from uno.localdomain (mob-5-90-54-150.net.vodafone.it\n\t[5.90.54.150])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 23037838;\n\tTue, 18 Jul 2023 12:51:25 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1689677541;\n\tbh=Ey41L7ZWn/xeQM4k6jR/tGMKDyFxZIEh2uwlF3zqeyg=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=nNmoSebUh7sUu/LWSaGWLE+/WymmCbkYoP15AkKhtggfOYPYwj5R9ckQsIdlMJga6\n\tUJFwIQWvE/ELyK8ZmfvGwir0T34yPuR1iCa9ssOFXPfnELDRc+7RtU1QcyNMSRjabH\n\trXZ3dI13HW8lDnabkvwW9N+y89O+UjVVR0DjGmcSKq+2IVx0n/eULdyQ8lLfDxR9vm\n\tqNiclLhfRPkxlpQYxjqqN66H1OwpRR+TwDynJBQvCn0o5GSKVGEarXo1MgTlUXG1fm\n\tjlXOh3NS7CftzLSoa2A6ROMXztdEdfokBdp8t/N45rrl1kNoBjtXnmaEoliG87UbU5\n\tSapdrUNkj+vmg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1689677485;\n\tbh=Ey41L7ZWn/xeQM4k6jR/tGMKDyFxZIEh2uwlF3zqeyg=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=bUMn2rdSuzwLi1OKACaA/1eJVRjTPu5mBuzBuAYAEomJvyPtQ3W87t5wd+/nS8k2u\n\tiymp3XiIAoymEQFv93qQGAcfm89Bxcmzb5tXkgkUbEEdw3RPksUSMXkI8+ncV0vBKv\n\t+9Zs8kYcs84Z+XH8+TGXAayIBrQQfO59BXuTspZ4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"bUMn2rdS\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 18 Jul 2023 12:52:00 +0200","Message-Id":"<20230718105210.83558-1-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.40.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 0/10] libcamera: Replace\n\tCameraConfiguration::transform","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"v2->v3:\n- Move Orientation out of CameraConfiguration to a dedicated file\n- Change operator*(Transform, Transform)\n- Address David's comments in documentation and commit messages\n\nv1->v2:\n- Provide a better definitio of Orientation based on two basic operations\n- Provide functions to combine Orientation and Transpose\n- Provide tests\n- Do not adjust properties::Rotation anymore\n\nThis series proposes to replace the usage to Transform in the public API in\nfavour of a new Orientation type, defined based on the EXIF\nspecification, tag 274, 'orientation'. For reference this is the same as\nimplemented by gstreamer:\nhttps://gstreamer.freedesktop.org/documentation/gstreamer/gsttaglist.html?gi-language=c#GST_TAG_IMAGE_ORIENTATION\n\n(the names of the enum values are different as gstreamer expresses the\n\"correction\" while we express the actual orientation in memory buffers).\n\nThe newly introduced CameraConfiguration::orientation replaces the\nexisting CameraConfiguration::tranform, and it is meant for application to\nexpress how they would like the images to be oriented, not to tell libcamera\nwhat to do. As an example, passing in 'rotation0' means that the application\nexpects the images to be rotated upright, and doesn't tell libcamera not to\napply any rotation like passing in \"Transform::Identity\" did.\n\nThe value CameraConfiguration::orientation is set to after a validate() also\ndiffers in meaning, as instead of reporting \"what applications have to do\nto obtain what they originally asked for\" it simply reports the actual\norientation of the stream: this means that if libcamera cannot fully satisfy the\nuser request it will set ::orientation to report the native images rotation\nand the CameraConfiguration::status will be set to Adjusted.\n\nHandling of 90 and 270 degrees rotation has also changed: as the camera sensor\ncannot correct rotations that include a transposition, requests for a 90/270\ncorrections are ignored. This makes it clear and less confusing for applications\nthat they have to deal with correction fully by themselves. As an example, with\nthe current implementation if the application requires a Rot270 (HFlip +\nTranspose) libcamera will do the HFlip and leave transposition to the upper\nlayers. There is no clear advantage in doing so, and display compositors are\nbetter suited for handling transpositions and flipping in a single pass instead\nof having the library try to handle part of that.\n\nThis series clearly breaks the application API as it removes a member from\nCameraConfiguration, so it should be introduced probably only when a new release\nis cut.\n\nTested on RPi imx219 with the newly introduced cam option, flip, mirror and\nrotation work as expected.\n\nJacopo Mondi (10):\n libcamera: camera_sensor: Cache rotationTransform_\n libcamera: camera: Introduce Orientation\n Documentation: Add figures to document Orientation\n libcamera: properties: Make 'Rotation' the mounting rotation\n libcamera: transform: Add functions to convert Orientation\n libcamera: transform: Invert operator*() operands\n libcamera: transform: Add operations with Orientation\n test: Add unit test for Transform and Orientation\n libcamera: Move to use CameraConfiguration::orientation\n apps: cam: Add option to set stream orientation\n\n Documentation/Doxyfile.in | 2 +\n Documentation/rotation/flip-rotate-0.eps | 170 +++++++++\n Documentation/rotation/flip-rotate-0.png | Bin 0 -> 16488 bytes\n Documentation/rotation/flip-rotate-180.eps | 191 ++++++++++\n Documentation/rotation/flip-rotate-180.png | Bin 0 -> 22198 bytes\n Documentation/rotation/flip-rotate-270.eps | 118 ++++++\n Documentation/rotation/flip-rotate-270.png | Bin 0 -> 9108 bytes\n Documentation/rotation/flip-rotate-90.eps | 118 ++++++\n Documentation/rotation/flip-rotate-90.png | Bin 0 -> 10918 bytes\n Documentation/rotation/rotate-0.eps | 169 +++++++++\n Documentation/rotation/rotate-0.png | Bin 0 -> 9086 bytes\n Documentation/rotation/rotate-180.eps | 189 ++++++++++\n Documentation/rotation/rotate-180.png | Bin 0 -> 22182 bytes\n Documentation/rotation/rotate-270.eps | 118 ++++++\n Documentation/rotation/rotate-270.png | Bin 0 -> 9334 bytes\n Documentation/rotation/rotate-90.eps | 118 ++++++\n Documentation/rotation/rotate-90.png | Bin 0 -> 9163 bytes\n include/libcamera/camera.h | 4 +-\n include/libcamera/internal/camera_sensor.h | 5 +-\n include/libcamera/meson.build | 1 +\n include/libcamera/orientation.h | 28 ++\n include/libcamera/transform.h | 7 +\n src/apps/cam/camera_session.cpp | 17 +\n src/apps/cam/main.cpp | 5 +\n src/apps/cam/main.h | 1 +\n src/libcamera/camera.cpp | 20 +-\n src/libcamera/camera_sensor.cpp | 129 ++++---\n src/libcamera/meson.build | 1 +\n src/libcamera/orientation.cpp | 103 ++++++\n src/libcamera/pipeline/ipu3/ipu3.cpp | 6 +-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 8 +-\n .../pipeline/rpi/common/pipeline_base.cpp | 9 +-\n src/libcamera/pipeline/simple/simple.cpp | 6 +-\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 4 +-\n src/libcamera/pipeline/vimc/vimc.cpp | 4 +-\n src/libcamera/property_ids.yaml | 8 +-\n src/libcamera/transform.cpp | 116 +++++-\n test/meson.build | 1 +\n test/transform.cpp | 335 ++++++++++++++++++\n 39 files changed, 1901 insertions(+), 110 deletions(-)\n create mode 100644 Documentation/rotation/flip-rotate-0.eps\n create mode 100644 Documentation/rotation/flip-rotate-0.png\n create mode 100644 Documentation/rotation/flip-rotate-180.eps\n create mode 100644 Documentation/rotation/flip-rotate-180.png\n create mode 100644 Documentation/rotation/flip-rotate-270.eps\n create mode 100644 Documentation/rotation/flip-rotate-270.png\n create mode 100644 Documentation/rotation/flip-rotate-90.eps\n create mode 100644 Documentation/rotation/flip-rotate-90.png\n create mode 100644 Documentation/rotation/rotate-0.eps\n create mode 100644 Documentation/rotation/rotate-0.png\n create mode 100644 Documentation/rotation/rotate-180.eps\n create mode 100644 Documentation/rotation/rotate-180.png\n create mode 100644 Documentation/rotation/rotate-270.eps\n create mode 100644 Documentation/rotation/rotate-270.png\n create mode 100644 Documentation/rotation/rotate-90.eps\n create mode 100644 Documentation/rotation/rotate-90.png\n create mode 100644 include/libcamera/orientation.h\n create mode 100644 src/libcamera/orientation.cpp\n create mode 100644 test/transform.cpp\n\n--\n2.40.1"}