[{"id":27367,"web_url":"https://patchwork.libcamera.org/comment/27367/","msgid":"<20230616134217.GD14547@pendragon.ideasonboard.com>","date":"2023-06-16T13:42:17","subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Remove\n\tCameraManager::get(dev_t)","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Thu, Jun 15, 2023 at 11:51:31PM +0100, Kieran Bingham via libcamera-devel wrote:\n> Now that Cameras expose a SystemDevices property which reports any\n> associated dev_t identifiers, remove the now redundant implementation of\n> CameraManager::get(dev_t) which was provided purely for the V4L2\n> Adaptation layer.\n> \n> The V4L2 adaptation layer reimplements the same functionality relying on\n> the SystemDevices data instead.\n> \n> This series removes a public API function and is a clear break of\n> API/ABI.\n\nThis function was never meant to be used by applications, so hopefully\nnobody will notice :-)\n\n> It is (hopefully clearly) dependant upon the series \" libcamera: Add new\n> Camera devices property \" [0]\n> \n> [0] https://patchwork.libcamera.org/project/libcamera/list/?series=3925\n> \n> Kieran Bingham (2):\n> v4l2: Use SystemDevices properties to identify cameras\n> libcamera: CameraManager: Remove ::get(dev_t)\n> \n> include/libcamera/camera_manager.h | 1 -\n> include/libcamera/internal/camera_manager.h | 3 +-\n> src/libcamera/camera_manager.cpp | 42 ---------------------\n> src/v4l2/v4l2_compat_manager.cpp | 28 +++++++++++---\n> 4 files changed, 24 insertions(+), 50 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D2DB7BD78E\n\tfor ;\n\tFri, 16 Jun 2023 13:42:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 44B27628AE;\n\tFri, 16 Jun 2023 15:42:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A0CC1628AD\n\tfor ;\n\tFri, 16 Jun 2023 15:42:17 +0200 (CEST)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 639759CA;\n\tFri, 16 Jun 2023 15:41:45 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686922939;\n\tbh=SoDMdv7hjAMNGoTEresptrpNaUBtJe5Y4R2LYMhW4hg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=HiOXwJiBsyMp0VxBnDzfyUIemwS+ZD1q+QLjGJTyxpqxMpCLmKxHQtAGJijTJrOQt\n\tQw7+aALSQULAODlUdv18A7rneKvtEGqNmeOJj8ndpOVhZeMOfoay1HkgSLFQT3w72Y\n\tqJCzZt8qcZm4ofrWsNhC5m5owgJ68KA4aMZeCZYmnyjLTBnt8Bs7+fQ0xOZwwuvm8H\n\tSNXCcG8Z+fGeSb/zIq3jXyb7Iits3P/rAZFbdjDfrWtdORxZNlBMR1R/hLxRucNhMB\n\to1FTl+IKzSDJ5XMk4ucx3OrIV258dHv5GO+BotA4VQXKOu1H8hVbzEZm/WUFyu225E\n\tPfbW6M5F6g7EA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1686922905;\n\tbh=SoDMdv7hjAMNGoTEresptrpNaUBtJe5Y4R2LYMhW4hg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=t5aHM2E7qVLOVyzU1b36LhVpQZBZhfw/RgtYLnBsKoFYgNWJZWJhBrW1FBA00wDHt\n\tUozVP68nxJZx1FKzlMECaAMfQdbmvnAj0QZO8X0Ntz25Rfrrwh8G8idx/Cn3rdUpXH\n\tCKzS1o5zezpaxL5V1+WLOxmO6Fxh6gV+0PKzwdPY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"t5aHM2E7\"; dkim-atps=neutral","Date":"Fri, 16 Jun 2023 16:42:17 +0300","To":"Kieran Bingham ","Message-ID":"<20230616134217.GD14547@pendragon.ideasonboard.com>","References":"<20230615225133.622612-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230615225133.622612-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Remove\n\tCameraManager::get(dev_t)","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27378,"web_url":"https://patchwork.libcamera.org/comment/27378/","msgid":"<168704027564.2319555.11500047928117848053@Monstersaurus>","date":"2023-06-17T22:17:55","subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Remove\n\tCameraManager::get(dev_t)","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2023-06-16 14:42:17)\n> Hi Kieran,\n> \n> On Thu, Jun 15, 2023 at 11:51:31PM +0100, Kieran Bingham via libcamera-devel wrote:\n> > Now that Cameras expose a SystemDevices property which reports any\n> > associated dev_t identifiers, remove the now redundant implementation of\n> > CameraManager::get(dev_t) which was provided purely for the V4L2\n> > Adaptation layer.\n> > \n> > The V4L2 adaptation layer reimplements the same functionality relying on\n> > the SystemDevices data instead.\n> > \n> > This series removes a public API function and is a clear break of\n> > API/ABI.\n> \n> This function was never meant to be used by applications, so hopefully\n> nobody will notice :-)\n\nIndeed, and all the more reason why I wanted to make this break ;-)\n\n\n\n> > It is (hopefully clearly) dependant upon the series \" libcamera: Add new\n> > Camera devices property \" [0]\n> > \n> > [0] https://patchwork.libcamera.org/project/libcamera/list/?series=3925\n> > \n> > Kieran Bingham (2):\n> > v4l2: Use SystemDevices properties to identify cameras\n> > libcamera: CameraManager: Remove ::get(dev_t)\n> > \n> > include/libcamera/camera_manager.h | 1 -\n> > include/libcamera/internal/camera_manager.h | 3 +-\n> > src/libcamera/camera_manager.cpp | 42 ---------------------\n> > src/v4l2/v4l2_compat_manager.cpp | 28 +++++++++++---\n> > 4 files changed, 24 insertions(+), 50 deletions(-)\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AB995BD78E\n\tfor ;\n\tSat, 17 Jun 2023 22:17:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 600BA628B8;\n\tSun, 18 Jun 2023 00:17:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4EAE0628AE\n\tfor ;\n\tSun, 18 Jun 2023 00:17:58 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 51D47922;\n\tSun, 18 Jun 2023 00:17:25 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1687040279;\n\tbh=gSotr/E+w1zMPNqhZijY3J6hHOfbNs8OvWrtb9UPt7c=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=q2yHJiM+1sB6VJShHkMAzFEXZz+NP+9/PwO3Nd55r4Gh00vFDxRbQeZqNM7yukZd+\n\tiuCPKT02qGbmaOc5WH5piJmqaY441DhKEIExEdHZgniXnEHhjs0We4zeyH5ccDouX/\n\tsbRMLxldHYC//fiA1A7wbQaEOWLobc0JGMXLXMQLuEYHCfnPzmPWNzBfkNd/6IzNaV\n\tX9obFk1LogtlW8vnpmq4wRd7Py/+0hRQnobotgBtCgSe1GCJMajMPyP9DZxYdWWTbQ\n\tYm4YHtP1hVOv9hcQAQPqv+9TxmUsgn8Bn6+5Se0bgBD5uL4cBT/2lwbdwXy9Ps3u9w\n\ty5QCIjTZsVlvA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1687040245;\n\tbh=gSotr/E+w1zMPNqhZijY3J6hHOfbNs8OvWrtb9UPt7c=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=dYKnWHeNWH04Ib6ry9sT+Xdury5ZWizkz4RurSEeJYkD36Ov3sibl5I7R2gC65APS\n\t+Fw53YPQnJDe2IIMGEL26xqYPOK8wp2X8o5I58IOptqECfKguTLZyFJxGDdOtzHmGC\n\tpIvEKo1wbPHoYXCOOrc//xbzjnu7p7m91CoGk4RA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"dYKnWHeN\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230616134217.GD14547@pendragon.ideasonboard.com>","References":"<20230615225133.622612-1-kieran.bingham@ideasonboard.com>\n\t<20230616134217.GD14547@pendragon.ideasonboard.com>","To":"Laurent Pinchart ","Date":"Sat, 17 Jun 2023 23:17:55 +0100","Message-ID":"<168704027564.2319555.11500047928117848053@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Remove\n\tCameraManager::get(dev_t)","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27381,"web_url":"https://patchwork.libcamera.org/comment/27381/","msgid":"<168704127337.2319555.11992423091201374735@Monstersaurus>","date":"2023-06-17T22:34:33","subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Remove\n\tCameraManager::get(dev_t)","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Kieran Bingham (2023-06-17 23:17:55)\n> Quoting Laurent Pinchart (2023-06-16 14:42:17)\n> > Hi Kieran,\n> > \n> > On Thu, Jun 15, 2023 at 11:51:31PM +0100, Kieran Bingham via libcamera-devel wrote:\n> > > Now that Cameras expose a SystemDevices property which reports any\n> > > associated dev_t identifiers, remove the now redundant implementation of\n> > > CameraManager::get(dev_t) which was provided purely for the V4L2\n> > > Adaptation layer.\n> > > \n> > > The V4L2 adaptation layer reimplements the same functionality relying on\n> > > the SystemDevices data instead.\n> > > \n> > > This series removes a public API function and is a clear break of\n> > > API/ABI.\n> > \n> > This function was never meant to be used by applications, so hopefully\n> > nobody will notice :-)\n> \n> Indeed, and all the more reason why I wanted to make this break ;-)\n> \n\nRunning:\n\n./utils/abi-compat.sh # no args\n\nproduces a compat_report.html that correctly identifies the removal of\nthree symbols at the ABI\n\nAdded Symbols 1\n property_ids.h, libcamera.so.0.0.5\n namespace libcamera::properties\n SystemDevices [data]\n\nRemoved Symbols 3\n camera_manager.h, libcamera.so.0.0.5\n namespace libcamera\n CameraManager::addCamera ( std::shared_ptr camera, std::vectorconst& devnums )\n CameraManager::get ( dev_t devnum )\n CameraManager::removeCamera ( std::shared_ptr camera )\n\n--\nKieran\n\n\n> > > It is (hopefully clearly) dependant upon the series \" libcamera: Add new\n> > > Camera devices property \" [0]\n> > > \n> > > [0] https://patchwork.libcamera.org/project/libcamera/list/?series=3925\n> > > \n> > > Kieran Bingham (2):\n> > > v4l2: Use SystemDevices properties to identify cameras\n> > > libcamera: CameraManager: Remove ::get(dev_t)\n> > > \n> > > include/libcamera/camera_manager.h | 1 -\n> > > include/libcamera/internal/camera_manager.h | 3 +-\n> > > src/libcamera/camera_manager.cpp | 42 ---------------------\n> > > src/v4l2/v4l2_compat_manager.cpp | 28 +++++++++++---\n> > > 4 files changed, 24 insertions(+), 50 deletions(-)\n> > \n> > -- \n> > Regards,\n> > \n> > Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E532CC322E\n\tfor ;\n\tSat, 17 Jun 2023 22:34:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4F354628AE;\n\tSun, 18 Jun 2023 00:34:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 49362628AD\n\tfor ;\n\tSun, 18 Jun 2023 00:34:36 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2272A975;\n\tSun, 18 Jun 2023 00:34:03 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1687041278;\n\tbh=3O8aj9i3/ahv9GSCya+OTISpS4Ie0jsFISjLGe1jFIA=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ijhqNUhB2t20XNs48YytWcAs4HRi4OcGzzsmDr6L8uZloTq2Llq9RksnbXbBLYKiE\n\tl9byNu9/SeUEJe2CUuh0XwM07A08fyGPvoeIXcP3SMQCgbfmk/zq9yUN59LgiFvmee\n\tHSyDXYqY1oRrq3FCW2yL/hWeTwjgX9Ax04YMOhqnS3a6gMrFDuR+B4qqiv9dVVz1YB\n\t3yji+0wLU1wQwZqN36Vjeu2RrIt7LzDusgIB8yE0J+XInNgmVGaX3BLMyLvAFPLSzr\n\tvLtmiREPsz/iW5ynsRXgOuuUaNW/ZW54n1CScbo2BVb+BeKCPCAPsxGbyQzyRFbKap\n\thMHCYSKWOc+bw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1687041243;\n\tbh=3O8aj9i3/ahv9GSCya+OTISpS4Ie0jsFISjLGe1jFIA=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=tbiOy5l1x30B1ws4tM3MBsK/Xb1IKGy54dz/QFHBudN4SxpIsr1+XV8PFVy06/xcL\n\tD7tqBrNs8/c5UaFHeeAWS7vBUwHqh9+6MDDNKpDM1tNWDZP4/KZqrcObNKMLNMlmCc\n\t+oP+HCHaCJroijr5BdwNYJ9p84LLwRW7BhEbd0O4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"tbiOy5l1\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<168704027564.2319555.11500047928117848053@Monstersaurus>","References":"<20230615225133.622612-1-kieran.bingham@ideasonboard.com>\n\t<20230616134217.GD14547@pendragon.ideasonboard.com>\n\t<168704027564.2319555.11500047928117848053@Monstersaurus>","To":"Laurent Pinchart ","Date":"Sat, 17 Jun 2023 23:34:33 +0100","Message-ID":"<168704127337.2319555.11992423091201374735@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Remove\n\tCameraManager::get(dev_t)","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]