[{"id":27253,"web_url":"https://patchwork.libcamera.org/comment/27253/","msgid":"<20230605100538.GA8066@pendragon.ideasonboard.com>","date":"2023-06-05T10:05:38","subject":"Re: [libcamera-devel] [PATCH v3 0/2] Mono sensor improvements","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nOn Mon, Jun 05, 2023 at 09:26:03AM +0100, Naushir Patuck via libcamera-devel wrote:\n> Hi,\n> \n> Some small updates for v3:\n> \n> - Add a \\todo in patch 1/2 to note the need for optional vars in the mojom\n> interface.\n> - Pass IPACameraSensorInfo into ipa->init() so that the ControlInfoMap is\n> (more) correctly setup before the call to ipa->configure().\n\nThank you. I've pushed the patches.\n\nIn the future, would it be possible to record changelogs per patch ? You\ncan add them directly to the commit message when you amend commits, with\na '---' separator below the Signed-off-by and other tags.\n\n> Naushir Patuck (2):\n> camera_sensor: ipa: core: Add CFA pattern to IPACameraSensorInfo\n> ipa: rpi: Handle controls for mono variant sensors\n> \n> include/libcamera/ipa/core.mojom | 13 +++++++\n> include/libcamera/ipa/raspberrypi.mojom | 1 +\n> src/ipa/rpi/common/ipa_base.cpp | 39 ++++++++++++++++---\n> src/ipa/rpi/common/ipa_base.h | 1 +\n> src/libcamera/camera_sensor.cpp | 3 ++\n> .../pipeline/rpi/common/pipeline_base.cpp | 10 ++++-\n> 6 files changed, 61 insertions(+), 6 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A7EA4C31E9\n\tfor ;\n\tMon, 5 Jun 2023 10:05:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 02F3262885;\n\tMon, 5 Jun 2023 12:05:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6CFA562709\n\tfor ;\n\tMon, 5 Jun 2023 12:05:41 +0200 (CEST)","from pendragon.ideasonboard.com (om126156242094.26.openmobile.ne.jp\n\t[126.156.242.94])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C6B8383F;\n\tMon, 5 Jun 2023 12:05:15 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1685959543;\n\tbh=vBqLbYi4rdCqH7cmQYpdteGsOH2uae43XTCYEWM2+sM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=JbkPI8HeqYkC3tKVvB8Qz06a/XpIgDoCE6cw0+hx/tqM/b8YbopDLDg7xR4Qyuf+k\n\t5/Cy41SK6zVjiHT/o7L+v19mFIwfzthnibLAdtaRKIETrWNALAo7NA1JsB5sjVDNm+\n\tIrUve8/LVNkYXeAXhZWn1Luc2s1bMTgliMsSs5MgTq1hH+dA+gCy4BJa7OtQf0Vvo2\n\tUEiYezE0bt5p+OkkYh8wN77nKvI5VUAIq88K1WooxZMHqDVgZZ8Ss8m20CT4Xl/icv\n\tgMvU2LqXPSgi1InxEZ3wy2YQMu5uPbmmwu3YEtKM/vFnwKnzIZhFwfXjGBjEzYLQRW\n\th03nggeqByBdw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1685959516;\n\tbh=vBqLbYi4rdCqH7cmQYpdteGsOH2uae43XTCYEWM2+sM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GKO1Q5QK3I2KcOCudabpRqKxwa45up4CQfWx/BtBzVNpE2OGaG/bQO0tjs+H5NxSX\n\tA+rbEBfaBdkdYtvbML2H2WAaIHxZDebGFW9b/W05JqxkFBGlPWLW1OGLzWXuQ9eOeG\n\t3Bd41wBjjiZWCXOAK/UVfTnCH8ndTruEfNVlvTLw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"GKO1Q5QK\"; dkim-atps=neutral","Date":"Mon, 5 Jun 2023 13:05:38 +0300","To":"Naushir Patuck ","Message-ID":"<20230605100538.GA8066@pendragon.ideasonboard.com>","References":"<20230605082605.9993-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230605082605.9993-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v3 0/2] Mono sensor improvements","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]