{"id":18606,"url":"https://patchwork.libcamera.org/api/covers/18606/?format=json","web_url":"https://patchwork.libcamera.org/cover/18606/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230506111025.18669-1-laurent.pinchart@ideasonboard.com>","date":"2023-05-06T11:10:23","name":"[libcamera-devel,v1,0/2] libcamera: Add an application to verify IPA module signatures","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/18606/mbox/","series":[{"id":3868,"url":"https://patchwork.libcamera.org/api/series/3868/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3868","date":"2023-05-06T11:10:23","name":"libcamera: Add an application to verify IPA module signatures","version":1,"mbox":"https://patchwork.libcamera.org/series/3868/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/18606/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 00069C0DA4\n\tfor ;\n\tSat, 6 May 2023 11:10:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 599E561EAD;\n\tSat, 6 May 2023 13:10:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C547861EAC\n\tfor ;\n\tSat, 6 May 2023 13:10:14 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B6267800;\n\tSat, 6 May 2023 13:10:08 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683371416;\n\tbh=lBXl4bwmvNvbr/pvVISd+96FMpws6Iu+0S64qNGxCRg=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=1OqBqDpnntlgme4sZTdED5wOgvguPO5AwA6mTDDNW2SNLI1I1ZZbdrJMDtU+anUd2\n\tApTPa1lCOG0y12fy2EOyaXCkjt0e3jwE+Xb4mAyBCGBgZqejJaSxib7anJwVfgVcLd\n\tYBY7f5ZR6A7lkyJ9fzkkaz0aSMGiSYkFpRcMAwWXdSN5n4O4jBU4cuXBmk4mn9NZOC\n\tnvxVzFhlOQ2vw+JTb8nnSzAmuqdtIABNJ10YDKp9xjOJZLRAImxw6/DjdmfBbtClrX\n\tfwJXiNTmrjjSRVWarNjwEKjYEMkoJ/N8rTt1ast1oDFRm+78HOC5EW5I6FTcLlLpJ3\n\tSwkXIYvZdagcg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1683371410;\n\tbh=lBXl4bwmvNvbr/pvVISd+96FMpws6Iu+0S64qNGxCRg=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=MGVX0c4hrbvswAJWQgpOUfFUSWsUkUGXLXpiF/jZDkB2q8InN4vZ3lvCqEXMAuRPU\n\tfkbF+7i7ZgUg9HKsZ5NYLGzL4ykBl9dNQSX4Pj3diWorDPb6Km7kXd0ZrlTEdny8jI\n\tyf7jSGrk+eluFkcakCaemCqvg4rqWSBBlNGYzH5A="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"MGVX0c4h\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 6 May 2023 14:10:23 +0300","Message-Id":"<20230506111025.18669-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.39.3","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1 0/2] libcamera: Add an application to\n\tverify IPA module signatures","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello,\n\nThis small series adds a new utility, named ipa-verify, to verify\nsignatures of IPA modules. This is useful for packagers who want to\nensure the packaging process doesn't break signatures.\n\nPatch 1/2 fixes a bug in the Doxygen documentation generation that\ndidn't take macros defined in config.h into account. Patch 2/2 then adds\nthe ipa-verify utility.\n\nI would have liked to add the utility to the utils/ directory instead of\nsrc/apps/, but that wasn't possible due to the utils/ directory being\nprocessed by meson before src/ipa/ and src/libcamera/. I didn't\ninvestigate alternative options much, but I can if desired.\n\nAnother thing that bothers me slightly in patch 2/2 is the addition of\nthe IPAManager::pubKey() function. Ideally the API exposed by internal\nclasses shouldn't be driven by the need of external tools. I would\nprobably consider it to be a bigger issue for classes exposed through\nthe public API, but as IPAManager is internal, it's probably not too big\nof a deal.\n\nLaurent Pinchart (2):\n Documentation: Add predefined macros from config.h to Doxyfile\n apps: Add ipa-verify application\n\n Documentation/Doxyfile.in | 3 +-\n Documentation/meson.build | 7 +++\n include/libcamera/internal/ipa_manager.h | 7 +++\n src/apps/ipa-verify/main.cpp | 64 ++++++++++++++++++++++++\n src/apps/ipa-verify/meson.build | 15 ++++++\n src/apps/meson.build | 2 +\n src/libcamera/ipa_manager.cpp | 13 +++++\n 7 files changed, 110 insertions(+), 1 deletion(-)\n create mode 100644 src/apps/ipa-verify/main.cpp\n create mode 100644 src/apps/ipa-verify/meson.build\n\n\nbase-commit: 0fbf6b57a7bd281c7d187244b7f480c0899cb94a"}