[{"id":27021,"web_url":"https://patchwork.libcamera.org/comment/27021/","msgid":"","date":"2023-05-03T12:23:43","subject":"Re: [libcamera-devel] [PATCH 00/13] Raspberry Pi: Code refactoring","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi,\n\nSorry, I forgot to mention (as I did in the v1 cover letter), patches 5 and 6\nought to be squashed together before merging to ensure correct\n\"bisectability\" of\nthe tree.\n\nThanks,\nNaush\n\n\nOn Wed, 3 May 2023 at 13:20, Naushir Patuck wrote:\n>\n> Hi,\n>\n> Version 2 of this incorporates all the suggest fixes from the review feedback.\n> In particular the major changes include:\n>\n> - More wording in the documentation in patch 1/13.\n> - Remove the '/' character restriction for the IPA name in patch 2/13.\n> - Changes to the base meson.build files so they don't include \"rpi\" specific\n> functional blocks (new patches 3 and 4).\n> - The common rpi IPA code is now built as a static library in patch 6/13.\n> - Add documentation to the raspberrypi.mojom file in patch 8/13.\n> - Remove a level of base -> derived class indirection in patch 12/13.\n>\n> If there's anything I missed out from the last round of feedback, please do\n> shout.\n>\n> Regards,\n> Naush\n>\n> David Plowman (1):\n> ipa: raspberrypi: agc: Move weights out of AGC\n>\n> Naushir Patuck (12):\n> meson: ipa: Add mapping for pipeline handler to mojom interface file\n> libcamera: ipa: Remove character restriction on the IPA name\n> ipa: meson: Allow nested IPA directory structures\n> pipeline: meson: Allow nested pipeline handler directory structures\n> pipeline: raspberrypi: Refactor and move pipeline handler code\n> ipa: raspberrypi: Refactor and move IPA code\n> pipeline: raspberrypi: rpi_stream: Set invalid buffer to id == 0\n> pipeline: ipa: raspberrypi: Restructure the IPA mojom interface\n> ipa: raspberrypi: Introduce IpaBase class\n> pipeline: raspberrypi: Make RPi::Stream::name() return const\n> std::string &\n> pipeline: raspberrypi: Introduce PipelineHandlerBase class\n> pipeline: raspberrypi: Add stream flags to RPi::Stream\n>\n> Documentation/environment_variables.rst | 4 +-\n> Documentation/guides/introduction.rst | 2 +-\n> Documentation/guides/ipa.rst | 39 +-\n> Documentation/guides/pipeline-handler.rst | 2 +-\n> include/libcamera/ipa/meson.build | 36 +-\n> include/libcamera/ipa/raspberrypi.mojom | 238 +-\n> meson.build | 4 +-\n> meson_options.txt | 4 +-\n> src/ipa/ipu3/meson.build | 2 +\n> src/ipa/meson.build | 26 +-\n> src/ipa/raspberrypi/meson.build | 66 -\n> src/ipa/rkisp1/meson.build | 2 +\n> src/ipa/{raspberrypi => rpi}/README.md | 0\n> .../cam_helper}/cam_helper.cpp | 0\n> .../cam_helper}/cam_helper.h | 2 +-\n> .../cam_helper}/cam_helper_imx219.cpp | 0\n> .../cam_helper}/cam_helper_imx290.cpp | 0\n> .../cam_helper}/cam_helper_imx296.cpp | 0\n> .../cam_helper}/cam_helper_imx477.cpp | 0\n> .../cam_helper}/cam_helper_imx519.cpp | 0\n> .../cam_helper}/cam_helper_imx708.cpp | 0\n> .../cam_helper}/cam_helper_ov5647.cpp | 0\n> .../cam_helper}/cam_helper_ov9281.cpp | 0\n> .../cam_helper}/md_parser.h | 0\n> .../cam_helper}/md_parser_smia.cpp | 0\n> src/ipa/rpi/cam_helper/meson.build | 26 +\n> .../common/ipa_base.cpp} | 1511 ++++------\n> src/ipa/rpi/common/ipa_base.h | 122 +\n> src/ipa/rpi/common/meson.build | 17 +\n> .../controller/af_algorithm.h | 0\n> .../controller/af_status.h | 0\n> .../controller/agc_algorithm.h | 3 +\n> .../controller/agc_status.h | 0\n> .../controller/algorithm.cpp | 0\n> .../controller/algorithm.h | 0\n> .../controller/alsc_status.h | 0\n> .../controller/awb_algorithm.h | 0\n> .../controller/awb_status.h | 0\n> .../controller/black_level_status.h | 0\n> .../controller/camera_mode.h | 0\n> .../controller/ccm_algorithm.h | 0\n> .../controller/ccm_status.h | 0\n> .../controller/contrast_algorithm.h | 0\n> .../controller/contrast_status.h | 0\n> .../controller/controller.cpp | 0\n> .../controller/controller.h | 0\n> .../controller/denoise_algorithm.h | 0\n> .../controller/denoise_status.h | 0\n> .../controller/device_status.cpp | 0\n> .../controller/device_status.h | 0\n> .../controller/dpc_status.h | 0\n> .../controller/geq_status.h | 0\n> .../controller/histogram.cpp | 0\n> .../controller/histogram.h | 0\n> .../controller/lux_status.h | 0\n> src/ipa/rpi/controller/meson.build | 29 +\n> .../controller/metadata.h | 0\n> .../controller/noise_status.h | 0\n> .../controller/pdaf_data.h | 0\n> .../{raspberrypi => rpi}/controller/pwl.cpp | 0\n> src/ipa/{raspberrypi => rpi}/controller/pwl.h | 0\n> .../controller/region_stats.h | 0\n> .../controller/rpi/af.cpp | 0\n> .../{raspberrypi => rpi}/controller/rpi/af.h | 0\n> .../controller/rpi/agc.cpp | 27 +-\n> .../{raspberrypi => rpi}/controller/rpi/agc.h | 1 +\n> .../controller/rpi/alsc.cpp | 0\n> .../controller/rpi/alsc.h | 0\n> .../controller/rpi/awb.cpp | 0\n> .../{raspberrypi => rpi}/controller/rpi/awb.h | 0\n> .../controller/rpi/black_level.cpp | 0\n> .../controller/rpi/black_level.h | 0\n> .../controller/rpi/ccm.cpp | 0\n> .../{raspberrypi => rpi}/controller/rpi/ccm.h | 0\n> .../controller/rpi/contrast.cpp | 0\n> .../controller/rpi/contrast.h | 0\n> .../controller/rpi/dpc.cpp | 0\n> .../{raspberrypi => rpi}/controller/rpi/dpc.h | 0\n> .../controller/rpi/focus.h | 0\n> .../controller/rpi/geq.cpp | 0\n> .../{raspberrypi => rpi}/controller/rpi/geq.h | 0\n> .../controller/rpi/lux.cpp | 0\n> .../{raspberrypi => rpi}/controller/rpi/lux.h | 0\n> .../controller/rpi/noise.cpp | 0\n> .../controller/rpi/noise.h | 0\n> .../controller/rpi/sdn.cpp | 0\n> .../{raspberrypi => rpi}/controller/rpi/sdn.h | 0\n> .../controller/rpi/sharpen.cpp | 0\n> .../controller/rpi/sharpen.h | 0\n> .../controller/sharpen_algorithm.h | 0\n> .../controller/sharpen_status.h | 0\n> .../controller}/statistics.h | 0\n> src/ipa/rpi/meson.build | 14 +\n> .../{raspberrypi => rpi/vc4}/data/imx219.json | 0\n> .../vc4}/data/imx219_noir.json | 0\n> .../{raspberrypi => rpi/vc4}/data/imx290.json | 0\n> .../{raspberrypi => rpi/vc4}/data/imx296.json | 0\n> .../vc4}/data/imx296_mono.json | 0\n> .../{raspberrypi => rpi/vc4}/data/imx378.json | 0\n> .../{raspberrypi => rpi/vc4}/data/imx477.json | 0\n> .../vc4}/data/imx477_noir.json | 0\n> .../vc4}/data/imx477_scientific.json | 0\n> .../vc4}/data/imx477_v1.json | 0\n> .../{raspberrypi => rpi/vc4}/data/imx519.json | 0\n> .../{raspberrypi => rpi/vc4}/data/imx708.json | 0\n> .../vc4}/data/imx708_noir.json | 0\n> .../vc4}/data/imx708_wide.json | 0\n> .../vc4}/data/imx708_wide_noir.json | 0\n> .../{raspberrypi => rpi/vc4}/data/meson.build | 2 +-\n> .../{raspberrypi => rpi/vc4}/data/ov5647.json | 0\n> .../vc4}/data/ov5647_noir.json | 0\n> .../vc4}/data/ov9281_mono.json | 0\n> .../vc4}/data/se327m12.json | 0\n> .../vc4}/data/uncalibrated.json | 0\n> src/ipa/rpi/vc4/meson.build | 48 +\n> src/ipa/rpi/vc4/vc4.cpp | 552 ++++\n> src/libcamera/ipa_module.cpp | 11 +-\n> src/libcamera/pipeline/meson.build | 9 +\n> .../pipeline/raspberrypi/raspberrypi.cpp | 2433 -----------------\n> .../common}/delayed_controls.cpp | 0\n> .../common}/delayed_controls.h | 0\n> .../{raspberrypi => rpi/common}/meson.build | 5 +-\n> .../pipeline/rpi/common/pipeline_base.cpp | 1482 ++++++++++\n> .../pipeline/rpi/common/pipeline_base.h | 277 ++\n> .../common}/rpi_stream.cpp | 52 +-\n> .../{raspberrypi => rpi/common}/rpi_stream.h | 62 +-\n> src/libcamera/pipeline/rpi/meson.build | 12 +\n> .../vc4}/data/example.yaml | 4 +-\n> .../{raspberrypi => rpi/vc4}/data/meson.build | 2 +-\n> .../{raspberrypi => rpi/vc4}/dma_heaps.cpp | 0\n> .../{raspberrypi => rpi/vc4}/dma_heaps.h | 0\n> src/libcamera/pipeline/rpi/vc4/meson.build | 8 +\n> src/libcamera/pipeline/rpi/vc4/vc4.cpp | 975 +++++++\n> 133 files changed, 4420 insertions(+), 3691 deletions(-)\n> delete mode 100644 src/ipa/raspberrypi/meson.build\n> rename src/ipa/{raspberrypi => rpi}/README.md (100%)\n> rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper.h (99%)\n> rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx219.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx290.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx296.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx477.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx519.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx708.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_ov5647.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_ov9281.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi/cam_helper}/md_parser.h (100%)\n> rename src/ipa/{raspberrypi => rpi/cam_helper}/md_parser_smia.cpp (100%)\n> create mode 100644 src/ipa/rpi/cam_helper/meson.build\n> rename src/ipa/{raspberrypi/raspberrypi.cpp => rpi/common/ipa_base.cpp} (62%)\n> create mode 100644 src/ipa/rpi/common/ipa_base.h\n> create mode 100644 src/ipa/rpi/common/meson.build\n> rename src/ipa/{raspberrypi => rpi}/controller/af_algorithm.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/af_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/agc_algorithm.h (93%)\n> rename src/ipa/{raspberrypi => rpi}/controller/agc_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/algorithm.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/algorithm.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/alsc_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/awb_algorithm.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/awb_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/black_level_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/camera_mode.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/ccm_algorithm.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/ccm_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/contrast_algorithm.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/contrast_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/controller.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/controller.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/denoise_algorithm.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/denoise_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/device_status.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/device_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/dpc_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/geq_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/histogram.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/histogram.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/lux_status.h (100%)\n> create mode 100644 src/ipa/rpi/controller/meson.build\n> rename src/ipa/{raspberrypi => rpi}/controller/metadata.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/noise_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/pdaf_data.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/pwl.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/pwl.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/region_stats.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/af.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/af.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/agc.cpp (97%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/agc.h (98%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/alsc.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/alsc.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/awb.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/awb.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/black_level.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/black_level.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/ccm.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/ccm.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/contrast.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/contrast.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/dpc.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/dpc.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/focus.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/geq.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/geq.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/lux.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/lux.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/noise.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/noise.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/sdn.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/sdn.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/sharpen.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/sharpen.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/sharpen_algorithm.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/sharpen_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi/controller}/statistics.h (100%)\n> create mode 100644 src/ipa/rpi/meson.build\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx219.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx219_noir.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx290.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx296.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx296_mono.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx378.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx477.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx477_noir.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx477_scientific.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx477_v1.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx519.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx708.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx708_noir.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx708_wide.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx708_wide_noir.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/meson.build (89%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/ov5647.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/ov5647_noir.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/ov9281_mono.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/se327m12.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/uncalibrated.json (100%)\n> create mode 100644 src/ipa/rpi/vc4/meson.build\n> create mode 100644 src/ipa/rpi/vc4/vc4.cpp\n> delete mode 100644 src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> rename src/libcamera/pipeline/{raspberrypi => rpi/common}/delayed_controls.cpp (100%)\n> rename src/libcamera/pipeline/{raspberrypi => rpi/common}/delayed_controls.h (100%)\n> rename src/libcamera/pipeline/{raspberrypi => rpi/common}/meson.build (66%)\n> create mode 100644 src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> create mode 100644 src/libcamera/pipeline/rpi/common/pipeline_base.h\n> rename src/libcamera/pipeline/{raspberrypi => rpi/common}/rpi_stream.cpp (87%)\n> rename src/libcamera/pipeline/{raspberrypi => rpi/common}/rpi_stream.h (76%)\n> create mode 100644 src/libcamera/pipeline/rpi/meson.build\n> rename src/libcamera/pipeline/{raspberrypi => rpi/vc4}/data/example.yaml (94%)\n> rename src/libcamera/pipeline/{raspberrypi => rpi/vc4}/data/meson.build (63%)\n> rename src/libcamera/pipeline/{raspberrypi => rpi/vc4}/dma_heaps.cpp (100%)\n> rename src/libcamera/pipeline/{raspberrypi => rpi/vc4}/dma_heaps.h (100%)\n> create mode 100644 src/libcamera/pipeline/rpi/vc4/meson.build\n> create mode 100644 src/libcamera/pipeline/rpi/vc4/vc4.cpp\n>\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EFC4ABD16B\n\tfor ;\n\tWed, 3 May 2023 12:24:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 895B3627DE;\n\tWed, 3 May 2023 14:24:00 +0200 (CEST)","from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com\n\t[IPv6:2607:f8b0:4864:20::b34])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 883B461EAF\n\tfor ;\n\tWed, 3 May 2023 14:23:58 +0200 (CEST)","by mail-yb1-xb34.google.com with SMTP id\n\t3f1490d57ef6-b99efd7c335so7174102276.0\n\tfor ;\n\tWed, 03 May 2023 05:23:58 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683116640;\n\tbh=CTlm5EHm6c+vFYG/En2KVtHxYV1r6Ii7/WLlwOeJ99g=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=2pZjqKpdPnTkxasiG6yF60y4IpCU0Ssft+jT+dG1EhBTq9WyDu3zCDdXOaWWLps9q\n\tjc5JSGPr0Ic1oaYHGd2p/r/W7jP5d/wJBkcSG/Kw651pu32q/ifhfDY3LqvUl0s1aW\n\tASurJ4EPPbccLGfOnFh9uLS4+RDumxveqiKuw3J87wxwfik6CgndYqHUh/CPPN+qOn\n\tt1HcfFq72Xo+7S3XDS64dIr+O5Ofa+gfmbGM95ctv9I47gXvs+1Gw2igYt0+42QPpv\n\taGsQs7QbYY5wojakwzBUlwn4WOvKnKGEj/AlpiY47oEhP+gW8BNgOsN79xV1TO6lup\n\tEQiTCgQDCQ9oA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1683116637; x=1685708637;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=jHbXtlEWcFACNM/dYBNJYXuw6rGbO5yRedHQ7IiFUIA=;\n\tb=dUxM6UNbE7Y55VTQxGm8tQnZunK1HdiR5CCLUtLdcsc3hEpbHsXv5WcEnRlbMpfERM\n\tJryU5nGddKP9cns4U5YzO85EAqcVVNiDMdT6oysyCL85kZk5x7qbkRCso5GAc/8pO6JG\n\tWcCbpxlhP0gVBkt4NOEsuGNHpS+m0RKkeBqygMGjVajy86+P8iBCkfA8rID/r6OLkMF9\n\tSazdtTG+n7pbrTHfPxsZRSIPjNaiqBwXwft/x4lFzhrcCaGD7iXNAuKB0Y3oIcLCu+nu\n\tS1BYLqSIpQ0sljExJIAOrJVimJ7zX13YKc/h6QESXQntS1sGUz0ceBFygWAKKvzVIp/0\n\tEyFw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"dUxM6UNb\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1683116637; x=1685708637;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=jHbXtlEWcFACNM/dYBNJYXuw6rGbO5yRedHQ7IiFUIA=;\n\tb=PPxFaisOXoHD9ZDrsa+pKGchTvo1LjhDF5uqKbhAwksMnZYNfMjBdjKta0ye/s66QH\n\tRw0zXpA13Yi1W/fhrzKLGGbHChX8S3l+H42lSeoCK+/HkQQzqBQ1UT7OfvgEKSs+4zqJ\n\tZrtJ2MzfqqKxjxHDfXhmC/aAKja4JOqmt6t/lwNf4KAJUVrYNIIwK9zLj8F4vJ/+U7cm\n\thSl1jRrO3yycYEdwc+GYRfgM1gWUxgvaHCE+pr4ZP8EMaLRiNiF5EiyYFYTwTrfR/ISu\n\ttaoEjDE1xOb+83AktLEHj0AUIwZ/l7YpwU2bpTT7W/Qznp/O+Xv5FDKHIctpTtWKhq2L\n\tjUqw==","X-Gm-Message-State":"AC+VfDy8KcGLwJ8+1XNzTGNqDa6ATx+pqC4H5Wt1COtK4uf51GZZLFpM\n\tDBkOTPvaXGKS5tNXLyKv88jjwnsjpP9O80JfDBBIrZKb1BRYKaluhvGb4w==","X-Google-Smtp-Source":"ACHHUZ7HhYiJDUQP3puHzquZQf/3btD/A5wmAceDTz5mcCtFjbYXZ83S85JKQXOwsf3LJQBBz6ERlwBCpWfJ7TckhUk=","X-Received":"by 2002:a0d:c347:0:b0:556:dd1b:3bb7 with SMTP id\n\tf68-20020a0dc347000000b00556dd1b3bb7mr19934751ywd.43.1683116636998;\n\tWed, 03 May 2023 05:23:56 -0700 (PDT)","MIME-Version":"1.0","References":"<20230503122035.32026-1-naush@raspberrypi.com>","In-Reply-To":"<20230503122035.32026-1-naush@raspberrypi.com>","Date":"Wed, 3 May 2023 13:23:43 +0100","Message-ID":"","To":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 00/13] Raspberry Pi: Code refactoring","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27049,"web_url":"https://patchwork.libcamera.org/comment/27049/","msgid":"<20230504111307.GI4551@pendragon.ideasonboard.com>","date":"2023-05-04T11:13:07","subject":"Re: [libcamera-devel] [PATCH 00/13] Raspberry Pi: Code refactoring","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nOn Wed, May 03, 2023 at 01:23:43PM +0100, Naushir Patuck via libcamera-devel wrote:\n> Hi,\n> \n> Sorry, I forgot to mention (as I did in the v1 cover letter), patches 5 and 6\n> ought to be squashed together before merging to ensure correct\n> \"bisectability\" of\n> the tree.\n\nWhat commit message should I use for the squashed patch ?\n\n> On Wed, 3 May 2023 at 13:20, Naushir Patuck wrote:\n> >\n> > Hi,\n> >\n> > Version 2 of this incorporates all the suggest fixes from the review feedback.\n> > In particular the major changes include:\n> >\n> > - More wording in the documentation in patch 1/13.\n> > - Remove the '/' character restriction for the IPA name in patch 2/13.\n> > - Changes to the base meson.build files so they don't include \"rpi\" specific\n> > functional blocks (new patches 3 and 4).\n> > - The common rpi IPA code is now built as a static library in patch 6/13.\n> > - Add documentation to the raspberrypi.mojom file in patch 8/13.\n> > - Remove a level of base -> derived class indirection in patch 12/13.\n> >\n> > If there's anything I missed out from the last round of feedback, please do\n> > shout.\n> >\n> > Regards,\n> > Naush\n> >\n> > David Plowman (1):\n> > ipa: raspberrypi: agc: Move weights out of AGC\n> >\n> > Naushir Patuck (12):\n> > meson: ipa: Add mapping for pipeline handler to mojom interface file\n> > libcamera: ipa: Remove character restriction on the IPA name\n> > ipa: meson: Allow nested IPA directory structures\n> > pipeline: meson: Allow nested pipeline handler directory structures\n> > pipeline: raspberrypi: Refactor and move pipeline handler code\n> > ipa: raspberrypi: Refactor and move IPA code\n> > pipeline: raspberrypi: rpi_stream: Set invalid buffer to id == 0\n> > pipeline: ipa: raspberrypi: Restructure the IPA mojom interface\n> > ipa: raspberrypi: Introduce IpaBase class\n> > pipeline: raspberrypi: Make RPi::Stream::name() return const\n> > std::string &\n> > pipeline: raspberrypi: Introduce PipelineHandlerBase class\n> > pipeline: raspberrypi: Add stream flags to RPi::Stream\n> >\n> > Documentation/environment_variables.rst | 4 +-\n> > Documentation/guides/introduction.rst | 2 +-\n> > Documentation/guides/ipa.rst | 39 +-\n> > Documentation/guides/pipeline-handler.rst | 2 +-\n> > include/libcamera/ipa/meson.build | 36 +-\n> > include/libcamera/ipa/raspberrypi.mojom | 238 +-\n> > meson.build | 4 +-\n> > meson_options.txt | 4 +-\n> > src/ipa/ipu3/meson.build | 2 +\n> > src/ipa/meson.build | 26 +-\n> > src/ipa/raspberrypi/meson.build | 66 -\n> > src/ipa/rkisp1/meson.build | 2 +\n> > src/ipa/{raspberrypi => rpi}/README.md | 0\n> > .../cam_helper}/cam_helper.cpp | 0\n> > .../cam_helper}/cam_helper.h | 2 +-\n> > .../cam_helper}/cam_helper_imx219.cpp | 0\n> > .../cam_helper}/cam_helper_imx290.cpp | 0\n> > .../cam_helper}/cam_helper_imx296.cpp | 0\n> > .../cam_helper}/cam_helper_imx477.cpp | 0\n> > .../cam_helper}/cam_helper_imx519.cpp | 0\n> > .../cam_helper}/cam_helper_imx708.cpp | 0\n> > .../cam_helper}/cam_helper_ov5647.cpp | 0\n> > .../cam_helper}/cam_helper_ov9281.cpp | 0\n> > .../cam_helper}/md_parser.h | 0\n> > .../cam_helper}/md_parser_smia.cpp | 0\n> > src/ipa/rpi/cam_helper/meson.build | 26 +\n> > .../common/ipa_base.cpp} | 1511 ++++------\n> > src/ipa/rpi/common/ipa_base.h | 122 +\n> > src/ipa/rpi/common/meson.build | 17 +\n> > .../controller/af_algorithm.h | 0\n> > .../controller/af_status.h | 0\n> > .../controller/agc_algorithm.h | 3 +\n> > .../controller/agc_status.h | 0\n> > .../controller/algorithm.cpp | 0\n> > .../controller/algorithm.h | 0\n> > .../controller/alsc_status.h | 0\n> > .../controller/awb_algorithm.h | 0\n> > .../controller/awb_status.h | 0\n> > .../controller/black_level_status.h | 0\n> > .../controller/camera_mode.h | 0\n> > .../controller/ccm_algorithm.h | 0\n> > .../controller/ccm_status.h | 0\n> > .../controller/contrast_algorithm.h | 0\n> > .../controller/contrast_status.h | 0\n> > .../controller/controller.cpp | 0\n> > .../controller/controller.h | 0\n> > .../controller/denoise_algorithm.h | 0\n> > .../controller/denoise_status.h | 0\n> > .../controller/device_status.cpp | 0\n> > .../controller/device_status.h | 0\n> > .../controller/dpc_status.h | 0\n> > .../controller/geq_status.h | 0\n> > .../controller/histogram.cpp | 0\n> > .../controller/histogram.h | 0\n> > .../controller/lux_status.h | 0\n> > src/ipa/rpi/controller/meson.build | 29 +\n> > .../controller/metadata.h | 0\n> > .../controller/noise_status.h | 0\n> > .../controller/pdaf_data.h | 0\n> > .../{raspberrypi => rpi}/controller/pwl.cpp | 0\n> > src/ipa/{raspberrypi => rpi}/controller/pwl.h | 0\n> > .../controller/region_stats.h | 0\n> > .../controller/rpi/af.cpp | 0\n> > .../{raspberrypi => rpi}/controller/rpi/af.h | 0\n> > .../controller/rpi/agc.cpp | 27 +-\n> > .../{raspberrypi => rpi}/controller/rpi/agc.h | 1 +\n> > .../controller/rpi/alsc.cpp | 0\n> > .../controller/rpi/alsc.h | 0\n> > .../controller/rpi/awb.cpp | 0\n> > .../{raspberrypi => rpi}/controller/rpi/awb.h | 0\n> > .../controller/rpi/black_level.cpp | 0\n> > .../controller/rpi/black_level.h | 0\n> > .../controller/rpi/ccm.cpp | 0\n> > .../{raspberrypi => rpi}/controller/rpi/ccm.h | 0\n> > .../controller/rpi/contrast.cpp | 0\n> > .../controller/rpi/contrast.h | 0\n> > .../controller/rpi/dpc.cpp | 0\n> > .../{raspberrypi => rpi}/controller/rpi/dpc.h | 0\n> > .../controller/rpi/focus.h | 0\n> > .../controller/rpi/geq.cpp | 0\n> > .../{raspberrypi => rpi}/controller/rpi/geq.h | 0\n> > .../controller/rpi/lux.cpp | 0\n> > .../{raspberrypi => rpi}/controller/rpi/lux.h | 0\n> > .../controller/rpi/noise.cpp | 0\n> > .../controller/rpi/noise.h | 0\n> > .../controller/rpi/sdn.cpp | 0\n> > .../{raspberrypi => rpi}/controller/rpi/sdn.h | 0\n> > .../controller/rpi/sharpen.cpp | 0\n> > .../controller/rpi/sharpen.h | 0\n> > .../controller/sharpen_algorithm.h | 0\n> > .../controller/sharpen_status.h | 0\n> > .../controller}/statistics.h | 0\n> > src/ipa/rpi/meson.build | 14 +\n> > .../{raspberrypi => rpi/vc4}/data/imx219.json | 0\n> > .../vc4}/data/imx219_noir.json | 0\n> > .../{raspberrypi => rpi/vc4}/data/imx290.json | 0\n> > .../{raspberrypi => rpi/vc4}/data/imx296.json | 0\n> > .../vc4}/data/imx296_mono.json | 0\n> > .../{raspberrypi => rpi/vc4}/data/imx378.json | 0\n> > .../{raspberrypi => rpi/vc4}/data/imx477.json | 0\n> > .../vc4}/data/imx477_noir.json | 0\n> > .../vc4}/data/imx477_scientific.json | 0\n> > .../vc4}/data/imx477_v1.json | 0\n> > .../{raspberrypi => rpi/vc4}/data/imx519.json | 0\n> > .../{raspberrypi => rpi/vc4}/data/imx708.json | 0\n> > .../vc4}/data/imx708_noir.json | 0\n> > .../vc4}/data/imx708_wide.json | 0\n> > .../vc4}/data/imx708_wide_noir.json | 0\n> > .../{raspberrypi => rpi/vc4}/data/meson.build | 2 +-\n> > .../{raspberrypi => rpi/vc4}/data/ov5647.json | 0\n> > .../vc4}/data/ov5647_noir.json | 0\n> > .../vc4}/data/ov9281_mono.json | 0\n> > .../vc4}/data/se327m12.json | 0\n> > .../vc4}/data/uncalibrated.json | 0\n> > src/ipa/rpi/vc4/meson.build | 48 +\n> > src/ipa/rpi/vc4/vc4.cpp | 552 ++++\n> > src/libcamera/ipa_module.cpp | 11 +-\n> > src/libcamera/pipeline/meson.build | 9 +\n> > .../pipeline/raspberrypi/raspberrypi.cpp | 2433 -----------------\n> > .../common}/delayed_controls.cpp | 0\n> > .../common}/delayed_controls.h | 0\n> > .../{raspberrypi => rpi/common}/meson.build | 5 +-\n> > .../pipeline/rpi/common/pipeline_base.cpp | 1482 ++++++++++\n> > .../pipeline/rpi/common/pipeline_base.h | 277 ++\n> > .../common}/rpi_stream.cpp | 52 +-\n> > .../{raspberrypi => rpi/common}/rpi_stream.h | 62 +-\n> > src/libcamera/pipeline/rpi/meson.build | 12 +\n> > .../vc4}/data/example.yaml | 4 +-\n> > .../{raspberrypi => rpi/vc4}/data/meson.build | 2 +-\n> > .../{raspberrypi => rpi/vc4}/dma_heaps.cpp | 0\n> > .../{raspberrypi => rpi/vc4}/dma_heaps.h | 0\n> > src/libcamera/pipeline/rpi/vc4/meson.build | 8 +\n> > src/libcamera/pipeline/rpi/vc4/vc4.cpp | 975 +++++++\n> > 133 files changed, 4420 insertions(+), 3691 deletions(-)\n> > delete mode 100644 src/ipa/raspberrypi/meson.build\n> > rename src/ipa/{raspberrypi => rpi}/README.md (100%)\n> > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper.h (99%)\n> > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx219.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx290.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx296.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx477.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx519.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx708.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_ov5647.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_ov9281.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi/cam_helper}/md_parser.h (100%)\n> > rename src/ipa/{raspberrypi => rpi/cam_helper}/md_parser_smia.cpp (100%)\n> > create mode 100644 src/ipa/rpi/cam_helper/meson.build\n> > rename src/ipa/{raspberrypi/raspberrypi.cpp => rpi/common/ipa_base.cpp} (62%)\n> > create mode 100644 src/ipa/rpi/common/ipa_base.h\n> > create mode 100644 src/ipa/rpi/common/meson.build\n> > rename src/ipa/{raspberrypi => rpi}/controller/af_algorithm.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/af_status.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/agc_algorithm.h (93%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/agc_status.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/algorithm.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/algorithm.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/alsc_status.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/awb_algorithm.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/awb_status.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/black_level_status.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/camera_mode.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/ccm_algorithm.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/ccm_status.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/contrast_algorithm.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/contrast_status.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/controller.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/controller.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/denoise_algorithm.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/denoise_status.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/device_status.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/device_status.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/dpc_status.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/geq_status.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/histogram.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/histogram.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/lux_status.h (100%)\n> > create mode 100644 src/ipa/rpi/controller/meson.build\n> > rename src/ipa/{raspberrypi => rpi}/controller/metadata.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/noise_status.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/pdaf_data.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/pwl.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/pwl.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/region_stats.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/af.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/af.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/agc.cpp (97%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/agc.h (98%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/alsc.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/alsc.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/awb.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/awb.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/black_level.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/black_level.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/ccm.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/ccm.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/contrast.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/contrast.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/dpc.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/dpc.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/focus.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/geq.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/geq.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/lux.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/lux.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/noise.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/noise.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/sdn.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/sdn.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/sharpen.cpp (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/rpi/sharpen.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/sharpen_algorithm.h (100%)\n> > rename src/ipa/{raspberrypi => rpi}/controller/sharpen_status.h (100%)\n> > rename src/ipa/{raspberrypi => rpi/controller}/statistics.h (100%)\n> > create mode 100644 src/ipa/rpi/meson.build\n> > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx219.json (100%)\n> > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx219_noir.json (100%)\n> > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx290.json (100%)\n> > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx296.json (100%)\n> > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx296_mono.json (100%)\n> > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx378.json (100%)\n> > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx477.json (100%)\n> > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx477_noir.json (100%)\n> > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx477_scientific.json (100%)\n> > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx477_v1.json (100%)\n> > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx519.json (100%)\n> > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx708.json (100%)\n> > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx708_noir.json (100%)\n> > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx708_wide.json (100%)\n> > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx708_wide_noir.json (100%)\n> > rename src/ipa/{raspberrypi => rpi/vc4}/data/meson.build (89%)\n> > rename src/ipa/{raspberrypi => rpi/vc4}/data/ov5647.json (100%)\n> > rename src/ipa/{raspberrypi => rpi/vc4}/data/ov5647_noir.json (100%)\n> > rename src/ipa/{raspberrypi => rpi/vc4}/data/ov9281_mono.json (100%)\n> > rename src/ipa/{raspberrypi => rpi/vc4}/data/se327m12.json (100%)\n> > rename src/ipa/{raspberrypi => rpi/vc4}/data/uncalibrated.json (100%)\n> > create mode 100644 src/ipa/rpi/vc4/meson.build\n> > create mode 100644 src/ipa/rpi/vc4/vc4.cpp\n> > delete mode 100644 src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > rename src/libcamera/pipeline/{raspberrypi => rpi/common}/delayed_controls.cpp (100%)\n> > rename src/libcamera/pipeline/{raspberrypi => rpi/common}/delayed_controls.h (100%)\n> > rename src/libcamera/pipeline/{raspberrypi => rpi/common}/meson.build (66%)\n> > create mode 100644 src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > create mode 100644 src/libcamera/pipeline/rpi/common/pipeline_base.h\n> > rename src/libcamera/pipeline/{raspberrypi => rpi/common}/rpi_stream.cpp (87%)\n> > rename src/libcamera/pipeline/{raspberrypi => rpi/common}/rpi_stream.h (76%)\n> > create mode 100644 src/libcamera/pipeline/rpi/meson.build\n> > rename src/libcamera/pipeline/{raspberrypi => rpi/vc4}/data/example.yaml (94%)\n> > rename src/libcamera/pipeline/{raspberrypi => rpi/vc4}/data/meson.build (63%)\n> > rename src/libcamera/pipeline/{raspberrypi => rpi/vc4}/dma_heaps.cpp (100%)\n> > rename src/libcamera/pipeline/{raspberrypi => rpi/vc4}/dma_heaps.h (100%)\n> > create mode 100644 src/libcamera/pipeline/rpi/vc4/meson.build\n> > create mode 100644 src/libcamera/pipeline/rpi/vc4/vc4.cpp","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 89E81C0DA4\n\tfor ;\n\tThu, 4 May 2023 11:12:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 49653627DE;\n\tThu, 4 May 2023 13:12:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 582A361EAE\n\tfor ;\n\tThu, 4 May 2023 13:12:57 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2D5EF7CE;\n\tThu, 4 May 2023 13:12:52 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683198779;\n\tbh=WKiIrYgh/WUaOMJYNu6x1gcgJIFVVw6ToFRnTH92THE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=uGomOIEI96uI+kvPtpCEg4U06mTZR6/U9w6MJOTrcZe3mLWN3YdFJlX4u1Hc9lW9R\n\tJ7jk2QolQzuWPz085oneLiZ1i2Y5uzI3dGqBgZyFnjHE1zzBD3OzpvSAlibRaD0We8\n\tYpjx+7VP4+1JyNp5TwanIuQe9V+clIujvfFiSMe7/dJl5oe+aux2sxb+DePeru9W3f\n\t6diOX0Ir9884N1vKuxJqqhuM+izFRsFqf4S2joBvo8ay5QRV1iQQyyghe/TbwwtGbW\n\tirhII9VUgQMyo2ckl47zJHFBsCsMRDvWamBKOply9gthwKovpP78IG2kLxy5ZUCO4I\n\txynRrzb9ZFXSA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1683198774;\n\tbh=WKiIrYgh/WUaOMJYNu6x1gcgJIFVVw6ToFRnTH92THE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=oKBBB3bBohXEsxe0c0rCAgu9YYFaSn7NEVujOvpBtvt1p0NQ8kOhizyT7rGFETcV+\n\tahT5NLYoJedUGSN1w0jFXyRy3iPNv398ObdyKAbf5AmHhojTnSl7l3lEaPkXL495+i\n\tcbbxhpIkqvbp0LHxk6YGhp0O1EbUmRPOm5OZMk4w="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"oKBBB3bB\"; dkim-atps=neutral","Date":"Thu, 4 May 2023 14:13:07 +0300","To":"Naushir Patuck ","Message-ID":"<20230504111307.GI4551@pendragon.ideasonboard.com>","References":"<20230503122035.32026-1-naush@raspberrypi.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 00/13] Raspberry Pi: Code refactoring","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27050,"web_url":"https://patchwork.libcamera.org/comment/27050/","msgid":"","date":"2023-05-04T11:51:11","subject":"Re: [libcamera-devel] [PATCH 00/13] Raspberry Pi: Code refactoring","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nOn Thu, 4 May 2023 at 12:12, Laurent Pinchart\n wrote:\n>\n> Hi Naush,\n>\n> On Wed, May 03, 2023 at 01:23:43PM +0100, Naushir Patuck via libcamera-devel wrote:\n> > Hi,\n> >\n> > Sorry, I forgot to mention (as I did in the v1 cover letter), patches 5 and 6\n> > ought to be squashed together before merging to ensure correct\n> > \"bisectability\" of\n> > the tree.\n>\n> What commit message should I use for the squashed patch ?\n\nHow about:\n\n\"\npipeline: ipa: raspberrypi: Refactor and move the Raspberry Pi code\n\nSplit the Raspberry Pi pipeline handler and IPA source code into common\nand VC4/BCM2835 specific file structures.\n\nFor the pipeline handler, the common code files now live in\nsrc/libcamera/pipeline/rpi/common/\nand the vc4 specific files in src/libcamera/pipeline/rpi/vc4/.\n\nFor the IPA, the common code files now live in\nsrc/ipa/rpi/{cam_helper,controller}/\nand the vc4 specific files in src/ipa/rpi/vc4/. With this change, the\ncamera tuning files are now installed under share/libcamera/ipa/rpi/vc4/.\n\nTo build the pipeline and IPA, the meson configuration options have now\nchanged from \"raspberrypi\" to \"rpi/vc4\":\n\nmeson setup build -Dipas=rpi/vc4 -Dpipelines=rpi/vc4\n\nSigned-off-by: Naushir Patuck \nReviewed-by: Jacopo Mondi \n\"\n\nRegards,\nNaush\n\n>\n> > On Wed, 3 May 2023 at 13:20, Naushir Patuck wrote:\n> > >\n> > > Hi,\n> > >\n> > > Version 2 of this incorporates all the suggest fixes from the review feedback.\n> > > In particular the major changes include:\n> > >\n> > > - More wording in the documentation in patch 1/13.\n> > > - Remove the '/' character restriction for the IPA name in patch 2/13.\n> > > - Changes to the base meson.build files so they don't include \"rpi\" specific\n> > > functional blocks (new patches 3 and 4).\n> > > - The common rpi IPA code is now built as a static library in patch 6/13.\n> > > - Add documentation to the raspberrypi.mojom file in patch 8/13.\n> > > - Remove a level of base -> derived class indirection in patch 12/13.\n> > >\n> > > If there's anything I missed out from the last round of feedback, please do\n> > > shout.\n> > >\n> > > Regards,\n> > > Naush\n> > >\n> > > David Plowman (1):\n> > > ipa: raspberrypi: agc: Move weights out of AGC\n> > >\n> > > Naushir Patuck (12):\n> > > meson: ipa: Add mapping for pipeline handler to mojom interface file\n> > > libcamera: ipa: Remove character restriction on the IPA name\n> > > ipa: meson: Allow nested IPA directory structures\n> > > pipeline: meson: Allow nested pipeline handler directory structures\n> > > pipeline: raspberrypi: Refactor and move pipeline handler code\n> > > ipa: raspberrypi: Refactor and move IPA code\n> > > pipeline: raspberrypi: rpi_stream: Set invalid buffer to id == 0\n> > > pipeline: ipa: raspberrypi: Restructure the IPA mojom interface\n> > > ipa: raspberrypi: Introduce IpaBase class\n> > > pipeline: raspberrypi: Make RPi::Stream::name() return const\n> > > std::string &\n> > > pipeline: raspberrypi: Introduce PipelineHandlerBase class\n> > > pipeline: raspberrypi: Add stream flags to RPi::Stream\n> > >\n> > > Documentation/environment_variables.rst | 4 +-\n> > > Documentation/guides/introduction.rst | 2 +-\n> > > Documentation/guides/ipa.rst | 39 +-\n> > > Documentation/guides/pipeline-handler.rst | 2 +-\n> > > include/libcamera/ipa/meson.build | 36 +-\n> > > include/libcamera/ipa/raspberrypi.mojom | 238 +-\n> > > meson.build | 4 +-\n> > > meson_options.txt | 4 +-\n> > > src/ipa/ipu3/meson.build | 2 +\n> > > src/ipa/meson.build | 26 +-\n> > > src/ipa/raspberrypi/meson.build | 66 -\n> > > src/ipa/rkisp1/meson.build | 2 +\n> > > src/ipa/{raspberrypi => rpi}/README.md | 0\n> > > .../cam_helper}/cam_helper.cpp | 0\n> > > .../cam_helper}/cam_helper.h | 2 +-\n> > > .../cam_helper}/cam_helper_imx219.cpp | 0\n> > > .../cam_helper}/cam_helper_imx290.cpp | 0\n> > > .../cam_helper}/cam_helper_imx296.cpp | 0\n> > > .../cam_helper}/cam_helper_imx477.cpp | 0\n> > > .../cam_helper}/cam_helper_imx519.cpp | 0\n> > > .../cam_helper}/cam_helper_imx708.cpp | 0\n> > > .../cam_helper}/cam_helper_ov5647.cpp | 0\n> > > .../cam_helper}/cam_helper_ov9281.cpp | 0\n> > > .../cam_helper}/md_parser.h | 0\n> > > .../cam_helper}/md_parser_smia.cpp | 0\n> > > src/ipa/rpi/cam_helper/meson.build | 26 +\n> > > .../common/ipa_base.cpp} | 1511 ++++------\n> > > src/ipa/rpi/common/ipa_base.h | 122 +\n> > > src/ipa/rpi/common/meson.build | 17 +\n> > > .../controller/af_algorithm.h | 0\n> > > .../controller/af_status.h | 0\n> > > .../controller/agc_algorithm.h | 3 +\n> > > .../controller/agc_status.h | 0\n> > > .../controller/algorithm.cpp | 0\n> > > .../controller/algorithm.h | 0\n> > > .../controller/alsc_status.h | 0\n> > > .../controller/awb_algorithm.h | 0\n> > > .../controller/awb_status.h | 0\n> > > .../controller/black_level_status.h | 0\n> > > .../controller/camera_mode.h | 0\n> > > .../controller/ccm_algorithm.h | 0\n> > > .../controller/ccm_status.h | 0\n> > > .../controller/contrast_algorithm.h | 0\n> > > .../controller/contrast_status.h | 0\n> > > .../controller/controller.cpp | 0\n> > > .../controller/controller.h | 0\n> > > .../controller/denoise_algorithm.h | 0\n> > > .../controller/denoise_status.h | 0\n> > > .../controller/device_status.cpp | 0\n> > > .../controller/device_status.h | 0\n> > > .../controller/dpc_status.h | 0\n> > > .../controller/geq_status.h | 0\n> > > .../controller/histogram.cpp | 0\n> > > .../controller/histogram.h | 0\n> > > .../controller/lux_status.h | 0\n> > > src/ipa/rpi/controller/meson.build | 29 +\n> > > .../controller/metadata.h | 0\n> > > .../controller/noise_status.h | 0\n> > > .../controller/pdaf_data.h | 0\n> > > .../{raspberrypi => rpi}/controller/pwl.cpp | 0\n> > > src/ipa/{raspberrypi => rpi}/controller/pwl.h | 0\n> > > .../controller/region_stats.h | 0\n> > > .../controller/rpi/af.cpp | 0\n> > > .../{raspberrypi => rpi}/controller/rpi/af.h | 0\n> > > .../controller/rpi/agc.cpp | 27 +-\n> > > .../{raspberrypi => rpi}/controller/rpi/agc.h | 1 +\n> > > .../controller/rpi/alsc.cpp | 0\n> > > .../controller/rpi/alsc.h | 0\n> > > .../controller/rpi/awb.cpp | 0\n> > > .../{raspberrypi => rpi}/controller/rpi/awb.h | 0\n> > > .../controller/rpi/black_level.cpp | 0\n> > > .../controller/rpi/black_level.h | 0\n> > > .../controller/rpi/ccm.cpp | 0\n> > > .../{raspberrypi => rpi}/controller/rpi/ccm.h | 0\n> > > .../controller/rpi/contrast.cpp | 0\n> > > .../controller/rpi/contrast.h | 0\n> > > .../controller/rpi/dpc.cpp | 0\n> > > .../{raspberrypi => rpi}/controller/rpi/dpc.h | 0\n> > > .../controller/rpi/focus.h | 0\n> > > .../controller/rpi/geq.cpp | 0\n> > > .../{raspberrypi => rpi}/controller/rpi/geq.h | 0\n> > > .../controller/rpi/lux.cpp | 0\n> > > .../{raspberrypi => rpi}/controller/rpi/lux.h | 0\n> > > .../controller/rpi/noise.cpp | 0\n> > > .../controller/rpi/noise.h | 0\n> > > .../controller/rpi/sdn.cpp | 0\n> > > .../{raspberrypi => rpi}/controller/rpi/sdn.h | 0\n> > > .../controller/rpi/sharpen.cpp | 0\n> > > .../controller/rpi/sharpen.h | 0\n> > > .../controller/sharpen_algorithm.h | 0\n> > > .../controller/sharpen_status.h | 0\n> > > .../controller}/statistics.h | 0\n> > > src/ipa/rpi/meson.build | 14 +\n> > > .../{raspberrypi => rpi/vc4}/data/imx219.json | 0\n> > > .../vc4}/data/imx219_noir.json | 0\n> > > .../{raspberrypi => rpi/vc4}/data/imx290.json | 0\n> > > .../{raspberrypi => rpi/vc4}/data/imx296.json | 0\n> > > .../vc4}/data/imx296_mono.json | 0\n> > > .../{raspberrypi => rpi/vc4}/data/imx378.json | 0\n> > > .../{raspberrypi => rpi/vc4}/data/imx477.json | 0\n> > > .../vc4}/data/imx477_noir.json | 0\n> > > .../vc4}/data/imx477_scientific.json | 0\n> > > .../vc4}/data/imx477_v1.json | 0\n> > > .../{raspberrypi => rpi/vc4}/data/imx519.json | 0\n> > > .../{raspberrypi => rpi/vc4}/data/imx708.json | 0\n> > > .../vc4}/data/imx708_noir.json | 0\n> > > .../vc4}/data/imx708_wide.json | 0\n> > > .../vc4}/data/imx708_wide_noir.json | 0\n> > > .../{raspberrypi => rpi/vc4}/data/meson.build | 2 +-\n> > > .../{raspberrypi => rpi/vc4}/data/ov5647.json | 0\n> > > .../vc4}/data/ov5647_noir.json | 0\n> > > .../vc4}/data/ov9281_mono.json | 0\n> > > .../vc4}/data/se327m12.json | 0\n> > > .../vc4}/data/uncalibrated.json | 0\n> > > src/ipa/rpi/vc4/meson.build | 48 +\n> > > src/ipa/rpi/vc4/vc4.cpp | 552 ++++\n> > > src/libcamera/ipa_module.cpp | 11 +-\n> > > src/libcamera/pipeline/meson.build | 9 +\n> > > .../pipeline/raspberrypi/raspberrypi.cpp | 2433 -----------------\n> > > .../common}/delayed_controls.cpp | 0\n> > > .../common}/delayed_controls.h | 0\n> > > .../{raspberrypi => rpi/common}/meson.build | 5 +-\n> > > .../pipeline/rpi/common/pipeline_base.cpp | 1482 ++++++++++\n> > > .../pipeline/rpi/common/pipeline_base.h | 277 ++\n> > > .../common}/rpi_stream.cpp | 52 +-\n> > > .../{raspberrypi => rpi/common}/rpi_stream.h | 62 +-\n> > > src/libcamera/pipeline/rpi/meson.build | 12 +\n> > > .../vc4}/data/example.yaml | 4 +-\n> > > .../{raspberrypi => rpi/vc4}/data/meson.build | 2 +-\n> > > .../{raspberrypi => rpi/vc4}/dma_heaps.cpp | 0\n> > > .../{raspberrypi => rpi/vc4}/dma_heaps.h | 0\n> > > src/libcamera/pipeline/rpi/vc4/meson.build | 8 +\n> > > src/libcamera/pipeline/rpi/vc4/vc4.cpp | 975 +++++++\n> > > 133 files changed, 4420 insertions(+), 3691 deletions(-)\n> > > delete mode 100644 src/ipa/raspberrypi/meson.build\n> > > rename src/ipa/{raspberrypi => rpi}/README.md (100%)\n> > > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper.h (99%)\n> > > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx219.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx290.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx296.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx477.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx519.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx708.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_ov5647.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_ov9281.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi/cam_helper}/md_parser.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi/cam_helper}/md_parser_smia.cpp (100%)\n> > > create mode 100644 src/ipa/rpi/cam_helper/meson.build\n> > > rename src/ipa/{raspberrypi/raspberrypi.cpp => rpi/common/ipa_base.cpp} (62%)\n> > > create mode 100644 src/ipa/rpi/common/ipa_base.h\n> > > create mode 100644 src/ipa/rpi/common/meson.build\n> > > rename src/ipa/{raspberrypi => rpi}/controller/af_algorithm.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/af_status.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/agc_algorithm.h (93%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/agc_status.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/algorithm.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/algorithm.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/alsc_status.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/awb_algorithm.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/awb_status.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/black_level_status.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/camera_mode.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/ccm_algorithm.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/ccm_status.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/contrast_algorithm.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/contrast_status.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/controller.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/controller.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/denoise_algorithm.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/denoise_status.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/device_status.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/device_status.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/dpc_status.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/geq_status.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/histogram.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/histogram.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/lux_status.h (100%)\n> > > create mode 100644 src/ipa/rpi/controller/meson.build\n> > > rename src/ipa/{raspberrypi => rpi}/controller/metadata.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/noise_status.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/pdaf_data.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/pwl.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/pwl.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/region_stats.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/af.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/af.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/agc.cpp (97%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/agc.h (98%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/alsc.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/alsc.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/awb.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/awb.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/black_level.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/black_level.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/ccm.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/ccm.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/contrast.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/contrast.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/dpc.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/dpc.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/focus.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/geq.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/geq.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/lux.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/lux.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/noise.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/noise.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/sdn.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/sdn.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/sharpen.cpp (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/sharpen.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/sharpen_algorithm.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi}/controller/sharpen_status.h (100%)\n> > > rename src/ipa/{raspberrypi => rpi/controller}/statistics.h (100%)\n> > > create mode 100644 src/ipa/rpi/meson.build\n> > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx219.json (100%)\n> > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx219_noir.json (100%)\n> > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx290.json (100%)\n> > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx296.json (100%)\n> > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx296_mono.json (100%)\n> > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx378.json (100%)\n> > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx477.json (100%)\n> > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx477_noir.json (100%)\n> > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx477_scientific.json (100%)\n> > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx477_v1.json (100%)\n> > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx519.json (100%)\n> > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx708.json (100%)\n> > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx708_noir.json (100%)\n> > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx708_wide.json (100%)\n> > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx708_wide_noir.json (100%)\n> > > rename src/ipa/{raspberrypi => rpi/vc4}/data/meson.build (89%)\n> > > rename src/ipa/{raspberrypi => rpi/vc4}/data/ov5647.json (100%)\n> > > rename src/ipa/{raspberrypi => rpi/vc4}/data/ov5647_noir.json (100%)\n> > > rename src/ipa/{raspberrypi => rpi/vc4}/data/ov9281_mono.json (100%)\n> > > rename src/ipa/{raspberrypi => rpi/vc4}/data/se327m12.json (100%)\n> > > rename src/ipa/{raspberrypi => rpi/vc4}/data/uncalibrated.json (100%)\n> > > create mode 100644 src/ipa/rpi/vc4/meson.build\n> > > create mode 100644 src/ipa/rpi/vc4/vc4.cpp\n> > > delete mode 100644 src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > > rename src/libcamera/pipeline/{raspberrypi => rpi/common}/delayed_controls.cpp (100%)\n> > > rename src/libcamera/pipeline/{raspberrypi => rpi/common}/delayed_controls.h (100%)\n> > > rename src/libcamera/pipeline/{raspberrypi => rpi/common}/meson.build (66%)\n> > > create mode 100644 src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > > create mode 100644 src/libcamera/pipeline/rpi/common/pipeline_base.h\n> > > rename src/libcamera/pipeline/{raspberrypi => rpi/common}/rpi_stream.cpp (87%)\n> > > rename src/libcamera/pipeline/{raspberrypi => rpi/common}/rpi_stream.h (76%)\n> > > create mode 100644 src/libcamera/pipeline/rpi/meson.build\n> > > rename src/libcamera/pipeline/{raspberrypi => rpi/vc4}/data/example.yaml (94%)\n> > > rename src/libcamera/pipeline/{raspberrypi => rpi/vc4}/data/meson.build (63%)\n> > > rename src/libcamera/pipeline/{raspberrypi => rpi/vc4}/dma_heaps.cpp (100%)\n> > > rename src/libcamera/pipeline/{raspberrypi => rpi/vc4}/dma_heaps.h (100%)\n> > > create mode 100644 src/libcamera/pipeline/rpi/vc4/meson.build\n> > > create mode 100644 src/libcamera/pipeline/rpi/vc4/vc4.cpp\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12633BD16B\n\tfor ;\n\tThu, 4 May 2023 11:51:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7B4B6633B4;\n\tThu, 4 May 2023 13:51:28 +0200 (CEST)","from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com\n\t[IPv6:2607:f8b0:4864:20::b35])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0DB2661EAE\n\tfor ;\n\tThu, 4 May 2023 13:51:27 +0200 (CEST)","by mail-yb1-xb35.google.com with SMTP id\n\t3f1490d57ef6-b99efd7c335so553225276.0\n\tfor ;\n\tThu, 04 May 2023 04:51:26 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683201088;\n\tbh=RGLjUGfZZ6bcV0QEUEPD0SC1YkVLHPYb+GwTJDmRxD0=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Dmq9R5hE6+CjS4faFmASTZpCy0ROueC9FJ0WKHxj9TEe53c1p4Ksv0zaBrCBG3Rce\n\tloAV8RgaeWresnOUrwEfFbnGyLdEQTAwQHfqM+sqFbL/+GFHa/FWxq2DM1oV2bEuRM\n\tFWAwoyUpUUWgrnVJMqhlQkbRzk3P8YypMm/gm3VhyexVbjnqjH8F3qzlLjcZvMgw3t\n\tt1uELzQIaNHrdAMWRbO9ZP57rS34X8Nv4RBTvM8F2kliNwJ2VRQgcHHpTdIl0I5tIp\n\tbKVEkQExw5ZRxfsVcBhSNcsM4x5/P3RVNTmykfsyM0GL4ygBNlVQu+u1uQVx1Gd3Es\n\tsd8WncNa1K36Q==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1683201086; x=1685793086;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=KQGgBpoucCTOuXDWtJEXrRs95y8d3gJYJbSMYxsJnXE=;\n\tb=c/UQxfmHUXPeAMonpA7uNzVqUcV3Ca2UwYgshqSWQZt574FPwpn/l1+h6uBLYVsjFH\n\t/TnEd8lAaMNeUHnzqk2/WLdMucP8N3wbRha7y577+3V2AS6+og05Jk8pk6ybTQKuZ13R\n\tI4To446TI400WaFKSmsCzlJbYsbDyY7Koc1zB8whz7FOQT87d3NpzKWcJxn9xiVjMjWS\n\tFGhdylo+eSuawxrmRBrafegjmPOhpLh2QD0j7rv/MZwCyCuKGVzFW2jrrsAZRkYlVW6I\n\tgm8xEOHSNlSOB7ekAso7buFFjHxvYVVKV9TVKnwSV3umJhiwiLbK4Xt2RqmyjRG7VoaC\n\tn2Pg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"c/UQxfmH\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1683201086; x=1685793086;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=KQGgBpoucCTOuXDWtJEXrRs95y8d3gJYJbSMYxsJnXE=;\n\tb=bsN125LFCfz799YkssXrIJJcImy2HfdcwK60etaDqxxVFbxgAZ/77PaiDLkay5jBWQ\n\tKfmw7e3ldmBiiO64tNSD+0El5s9s0xO1+fjlSnIcEk3+mG7haV/PQ+JUhrcIVBOePLuU\n\tSmh4XZcrOTFLhuGvRxRVicLuMUcjmNFt//b1j2ZEGkXIKnJJZpqwXg2rxyCUy97wU3dH\n\t5Qg6uYMhJKydiEuT8fJMxsaPs+xe7VzeRvlF95A4gi1STYopkhQEgyvF7y27w+Lv+koy\n\tE5GiNtFCu31hQ757rcQiiFRoc1uc5QVdK1zcRwqsgl/CKVZ6DUkMzvA7zpIQXz721P0z\n\tJzuA==","X-Gm-Message-State":"AC+VfDyK6a5bocuumwLT3K++2Lt90r7C4lDOyZD+aTM5jdABrims5Yht\n\tCZRjJSEn6Ygpynum3fcg+4qPdrG5zS6t6LPfw+56ISd8GdEGYl1hfkL3Pg==","X-Google-Smtp-Source":"ACHHUZ5g/EoR6tbYFIfYjljurk+0TcmvYpYD//PwHDauTNJGVLUgbHFRz/arInLaIpH+9vgh+WSJpfdDAyyVnyg+wTw=","X-Received":"by 2002:a25:2803:0:b0:b98:ddf4:7146 with SMTP id\n\to3-20020a252803000000b00b98ddf47146mr24804606ybo.21.1683201085658;\n\tThu, 04 May 2023 04:51:25 -0700 (PDT)","MIME-Version":"1.0","References":"<20230503122035.32026-1-naush@raspberrypi.com>\n\t\n\t<20230504111307.GI4551@pendragon.ideasonboard.com>","In-Reply-To":"<20230504111307.GI4551@pendragon.ideasonboard.com>","Date":"Thu, 4 May 2023 12:51:11 +0100","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 00/13] Raspberry Pi: Code refactoring","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27060,"web_url":"https://patchwork.libcamera.org/comment/27060/","msgid":"<20230504165928.GQ4551@pendragon.ideasonboard.com>","date":"2023-05-04T16:59:28","subject":"Re: [libcamera-devel] [PATCH 00/13] Raspberry Pi: Code refactoring","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nOn Thu, May 04, 2023 at 12:51:11PM +0100, Naushir Patuck wrote:\n> On Thu, 4 May 2023 at 12:12, Laurent Pinchart wrote:\n> > On Wed, May 03, 2023 at 01:23:43PM +0100, Naushir Patuck via libcamera-devel wrote:\n> > > Hi,\n> > >\n> > > Sorry, I forgot to mention (as I did in the v1 cover letter), patches 5 and 6\n> > > ought to be squashed together before merging to ensure correct\n> > > \"bisectability\" of\n> > > the tree.\n> >\n> > What commit message should I use for the squashed patch ?\n> \n> How about:\n> \n> \"\n> pipeline: ipa: raspberrypi: Refactor and move the Raspberry Pi code\n> \n> Split the Raspberry Pi pipeline handler and IPA source code into common\n> and VC4/BCM2835 specific file structures.\n> \n> For the pipeline handler, the common code files now live in\n> src/libcamera/pipeline/rpi/common/\n> and the vc4 specific files in src/libcamera/pipeline/rpi/vc4/.\n> \n> For the IPA, the common code files now live in\n> src/ipa/rpi/{cam_helper,controller}/\n> and the vc4 specific files in src/ipa/rpi/vc4/. With this change, the\n> camera tuning files are now installed under share/libcamera/ipa/rpi/vc4/.\n> \n> To build the pipeline and IPA, the meson configuration options have now\n> changed from \"raspberrypi\" to \"rpi/vc4\":\n> \n> meson setup build -Dipas=rpi/vc4 -Dpipelines=rpi/vc4\n> \n> Signed-off-by: Naushir Patuck \n> Reviewed-by: Jacopo Mondi \n> \"\n\nSounds good. I'll use that.\n\n> > > On Wed, 3 May 2023 at 13:20, Naushir Patuck wrote:\n> > > >\n> > > > Hi,\n> > > >\n> > > > Version 2 of this incorporates all the suggest fixes from the review feedback.\n> > > > In particular the major changes include:\n> > > >\n> > > > - More wording in the documentation in patch 1/13.\n> > > > - Remove the '/' character restriction for the IPA name in patch 2/13.\n> > > > - Changes to the base meson.build files so they don't include \"rpi\" specific\n> > > > functional blocks (new patches 3 and 4).\n> > > > - The common rpi IPA code is now built as a static library in patch 6/13.\n> > > > - Add documentation to the raspberrypi.mojom file in patch 8/13.\n> > > > - Remove a level of base -> derived class indirection in patch 12/13.\n> > > >\n> > > > If there's anything I missed out from the last round of feedback, please do\n> > > > shout.\n> > > >\n> > > > Regards,\n> > > > Naush\n> > > >\n> > > > David Plowman (1):\n> > > > ipa: raspberrypi: agc: Move weights out of AGC\n> > > >\n> > > > Naushir Patuck (12):\n> > > > meson: ipa: Add mapping for pipeline handler to mojom interface file\n> > > > libcamera: ipa: Remove character restriction on the IPA name\n> > > > ipa: meson: Allow nested IPA directory structures\n> > > > pipeline: meson: Allow nested pipeline handler directory structures\n> > > > pipeline: raspberrypi: Refactor and move pipeline handler code\n> > > > ipa: raspberrypi: Refactor and move IPA code\n> > > > pipeline: raspberrypi: rpi_stream: Set invalid buffer to id == 0\n> > > > pipeline: ipa: raspberrypi: Restructure the IPA mojom interface\n> > > > ipa: raspberrypi: Introduce IpaBase class\n> > > > pipeline: raspberrypi: Make RPi::Stream::name() return const\n> > > > std::string &\n> > > > pipeline: raspberrypi: Introduce PipelineHandlerBase class\n> > > > pipeline: raspberrypi: Add stream flags to RPi::Stream\n> > > >\n> > > > Documentation/environment_variables.rst | 4 +-\n> > > > Documentation/guides/introduction.rst | 2 +-\n> > > > Documentation/guides/ipa.rst | 39 +-\n> > > > Documentation/guides/pipeline-handler.rst | 2 +-\n> > > > include/libcamera/ipa/meson.build | 36 +-\n> > > > include/libcamera/ipa/raspberrypi.mojom | 238 +-\n> > > > meson.build | 4 +-\n> > > > meson_options.txt | 4 +-\n> > > > src/ipa/ipu3/meson.build | 2 +\n> > > > src/ipa/meson.build | 26 +-\n> > > > src/ipa/raspberrypi/meson.build | 66 -\n> > > > src/ipa/rkisp1/meson.build | 2 +\n> > > > src/ipa/{raspberrypi => rpi}/README.md | 0\n> > > > .../cam_helper}/cam_helper.cpp | 0\n> > > > .../cam_helper}/cam_helper.h | 2 +-\n> > > > .../cam_helper}/cam_helper_imx219.cpp | 0\n> > > > .../cam_helper}/cam_helper_imx290.cpp | 0\n> > > > .../cam_helper}/cam_helper_imx296.cpp | 0\n> > > > .../cam_helper}/cam_helper_imx477.cpp | 0\n> > > > .../cam_helper}/cam_helper_imx519.cpp | 0\n> > > > .../cam_helper}/cam_helper_imx708.cpp | 0\n> > > > .../cam_helper}/cam_helper_ov5647.cpp | 0\n> > > > .../cam_helper}/cam_helper_ov9281.cpp | 0\n> > > > .../cam_helper}/md_parser.h | 0\n> > > > .../cam_helper}/md_parser_smia.cpp | 0\n> > > > src/ipa/rpi/cam_helper/meson.build | 26 +\n> > > > .../common/ipa_base.cpp} | 1511 ++++------\n> > > > src/ipa/rpi/common/ipa_base.h | 122 +\n> > > > src/ipa/rpi/common/meson.build | 17 +\n> > > > .../controller/af_algorithm.h | 0\n> > > > .../controller/af_status.h | 0\n> > > > .../controller/agc_algorithm.h | 3 +\n> > > > .../controller/agc_status.h | 0\n> > > > .../controller/algorithm.cpp | 0\n> > > > .../controller/algorithm.h | 0\n> > > > .../controller/alsc_status.h | 0\n> > > > .../controller/awb_algorithm.h | 0\n> > > > .../controller/awb_status.h | 0\n> > > > .../controller/black_level_status.h | 0\n> > > > .../controller/camera_mode.h | 0\n> > > > .../controller/ccm_algorithm.h | 0\n> > > > .../controller/ccm_status.h | 0\n> > > > .../controller/contrast_algorithm.h | 0\n> > > > .../controller/contrast_status.h | 0\n> > > > .../controller/controller.cpp | 0\n> > > > .../controller/controller.h | 0\n> > > > .../controller/denoise_algorithm.h | 0\n> > > > .../controller/denoise_status.h | 0\n> > > > .../controller/device_status.cpp | 0\n> > > > .../controller/device_status.h | 0\n> > > > .../controller/dpc_status.h | 0\n> > > > .../controller/geq_status.h | 0\n> > > > .../controller/histogram.cpp | 0\n> > > > .../controller/histogram.h | 0\n> > > > .../controller/lux_status.h | 0\n> > > > src/ipa/rpi/controller/meson.build | 29 +\n> > > > .../controller/metadata.h | 0\n> > > > .../controller/noise_status.h | 0\n> > > > .../controller/pdaf_data.h | 0\n> > > > .../{raspberrypi => rpi}/controller/pwl.cpp | 0\n> > > > src/ipa/{raspberrypi => rpi}/controller/pwl.h | 0\n> > > > .../controller/region_stats.h | 0\n> > > > .../controller/rpi/af.cpp | 0\n> > > > .../{raspberrypi => rpi}/controller/rpi/af.h | 0\n> > > > .../controller/rpi/agc.cpp | 27 +-\n> > > > .../{raspberrypi => rpi}/controller/rpi/agc.h | 1 +\n> > > > .../controller/rpi/alsc.cpp | 0\n> > > > .../controller/rpi/alsc.h | 0\n> > > > .../controller/rpi/awb.cpp | 0\n> > > > .../{raspberrypi => rpi}/controller/rpi/awb.h | 0\n> > > > .../controller/rpi/black_level.cpp | 0\n> > > > .../controller/rpi/black_level.h | 0\n> > > > .../controller/rpi/ccm.cpp | 0\n> > > > .../{raspberrypi => rpi}/controller/rpi/ccm.h | 0\n> > > > .../controller/rpi/contrast.cpp | 0\n> > > > .../controller/rpi/contrast.h | 0\n> > > > .../controller/rpi/dpc.cpp | 0\n> > > > .../{raspberrypi => rpi}/controller/rpi/dpc.h | 0\n> > > > .../controller/rpi/focus.h | 0\n> > > > .../controller/rpi/geq.cpp | 0\n> > > > .../{raspberrypi => rpi}/controller/rpi/geq.h | 0\n> > > > .../controller/rpi/lux.cpp | 0\n> > > > .../{raspberrypi => rpi}/controller/rpi/lux.h | 0\n> > > > .../controller/rpi/noise.cpp | 0\n> > > > .../controller/rpi/noise.h | 0\n> > > > .../controller/rpi/sdn.cpp | 0\n> > > > .../{raspberrypi => rpi}/controller/rpi/sdn.h | 0\n> > > > .../controller/rpi/sharpen.cpp | 0\n> > > > .../controller/rpi/sharpen.h | 0\n> > > > .../controller/sharpen_algorithm.h | 0\n> > > > .../controller/sharpen_status.h | 0\n> > > > .../controller}/statistics.h | 0\n> > > > src/ipa/rpi/meson.build | 14 +\n> > > > .../{raspberrypi => rpi/vc4}/data/imx219.json | 0\n> > > > .../vc4}/data/imx219_noir.json | 0\n> > > > .../{raspberrypi => rpi/vc4}/data/imx290.json | 0\n> > > > .../{raspberrypi => rpi/vc4}/data/imx296.json | 0\n> > > > .../vc4}/data/imx296_mono.json | 0\n> > > > .../{raspberrypi => rpi/vc4}/data/imx378.json | 0\n> > > > .../{raspberrypi => rpi/vc4}/data/imx477.json | 0\n> > > > .../vc4}/data/imx477_noir.json | 0\n> > > > .../vc4}/data/imx477_scientific.json | 0\n> > > > .../vc4}/data/imx477_v1.json | 0\n> > > > .../{raspberrypi => rpi/vc4}/data/imx519.json | 0\n> > > > .../{raspberrypi => rpi/vc4}/data/imx708.json | 0\n> > > > .../vc4}/data/imx708_noir.json | 0\n> > > > .../vc4}/data/imx708_wide.json | 0\n> > > > .../vc4}/data/imx708_wide_noir.json | 0\n> > > > .../{raspberrypi => rpi/vc4}/data/meson.build | 2 +-\n> > > > .../{raspberrypi => rpi/vc4}/data/ov5647.json | 0\n> > > > .../vc4}/data/ov5647_noir.json | 0\n> > > > .../vc4}/data/ov9281_mono.json | 0\n> > > > .../vc4}/data/se327m12.json | 0\n> > > > .../vc4}/data/uncalibrated.json | 0\n> > > > src/ipa/rpi/vc4/meson.build | 48 +\n> > > > src/ipa/rpi/vc4/vc4.cpp | 552 ++++\n> > > > src/libcamera/ipa_module.cpp | 11 +-\n> > > > src/libcamera/pipeline/meson.build | 9 +\n> > > > .../pipeline/raspberrypi/raspberrypi.cpp | 2433 -----------------\n> > > > .../common}/delayed_controls.cpp | 0\n> > > > .../common}/delayed_controls.h | 0\n> > > > .../{raspberrypi => rpi/common}/meson.build | 5 +-\n> > > > .../pipeline/rpi/common/pipeline_base.cpp | 1482 ++++++++++\n> > > > .../pipeline/rpi/common/pipeline_base.h | 277 ++\n> > > > .../common}/rpi_stream.cpp | 52 +-\n> > > > .../{raspberrypi => rpi/common}/rpi_stream.h | 62 +-\n> > > > src/libcamera/pipeline/rpi/meson.build | 12 +\n> > > > .../vc4}/data/example.yaml | 4 +-\n> > > > .../{raspberrypi => rpi/vc4}/data/meson.build | 2 +-\n> > > > .../{raspberrypi => rpi/vc4}/dma_heaps.cpp | 0\n> > > > .../{raspberrypi => rpi/vc4}/dma_heaps.h | 0\n> > > > src/libcamera/pipeline/rpi/vc4/meson.build | 8 +\n> > > > src/libcamera/pipeline/rpi/vc4/vc4.cpp | 975 +++++++\n> > > > 133 files changed, 4420 insertions(+), 3691 deletions(-)\n> > > > delete mode 100644 src/ipa/raspberrypi/meson.build\n> > > > rename src/ipa/{raspberrypi => rpi}/README.md (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper.h (99%)\n> > > > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx219.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx290.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx296.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx477.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx519.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx708.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_ov5647.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_ov9281.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/cam_helper}/md_parser.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/cam_helper}/md_parser_smia.cpp (100%)\n> > > > create mode 100644 src/ipa/rpi/cam_helper/meson.build\n> > > > rename src/ipa/{raspberrypi/raspberrypi.cpp => rpi/common/ipa_base.cpp} (62%)\n> > > > create mode 100644 src/ipa/rpi/common/ipa_base.h\n> > > > create mode 100644 src/ipa/rpi/common/meson.build\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/af_algorithm.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/af_status.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/agc_algorithm.h (93%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/agc_status.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/algorithm.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/algorithm.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/alsc_status.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/awb_algorithm.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/awb_status.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/black_level_status.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/camera_mode.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/ccm_algorithm.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/ccm_status.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/contrast_algorithm.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/contrast_status.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/controller.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/controller.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/denoise_algorithm.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/denoise_status.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/device_status.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/device_status.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/dpc_status.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/geq_status.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/histogram.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/histogram.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/lux_status.h (100%)\n> > > > create mode 100644 src/ipa/rpi/controller/meson.build\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/metadata.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/noise_status.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/pdaf_data.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/pwl.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/pwl.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/region_stats.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/af.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/af.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/agc.cpp (97%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/agc.h (98%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/alsc.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/alsc.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/awb.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/awb.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/black_level.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/black_level.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/ccm.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/ccm.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/contrast.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/contrast.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/dpc.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/dpc.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/focus.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/geq.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/geq.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/lux.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/lux.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/noise.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/noise.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/sdn.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/sdn.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/sharpen.cpp (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/rpi/sharpen.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/sharpen_algorithm.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi}/controller/sharpen_status.h (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/controller}/statistics.h (100%)\n> > > > create mode 100644 src/ipa/rpi/meson.build\n> > > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx219.json (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx219_noir.json (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx290.json (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx296.json (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx296_mono.json (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx378.json (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx477.json (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx477_noir.json (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx477_scientific.json (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx477_v1.json (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx519.json (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx708.json (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx708_noir.json (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx708_wide.json (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/vc4}/data/imx708_wide_noir.json (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/vc4}/data/meson.build (89%)\n> > > > rename src/ipa/{raspberrypi => rpi/vc4}/data/ov5647.json (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/vc4}/data/ov5647_noir.json (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/vc4}/data/ov9281_mono.json (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/vc4}/data/se327m12.json (100%)\n> > > > rename src/ipa/{raspberrypi => rpi/vc4}/data/uncalibrated.json (100%)\n> > > > create mode 100644 src/ipa/rpi/vc4/meson.build\n> > > > create mode 100644 src/ipa/rpi/vc4/vc4.cpp\n> > > > delete mode 100644 src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > > > rename src/libcamera/pipeline/{raspberrypi => rpi/common}/delayed_controls.cpp (100%)\n> > > > rename src/libcamera/pipeline/{raspberrypi => rpi/common}/delayed_controls.h (100%)\n> > > > rename src/libcamera/pipeline/{raspberrypi => rpi/common}/meson.build (66%)\n> > > > create mode 100644 src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > > > create mode 100644 src/libcamera/pipeline/rpi/common/pipeline_base.h\n> > > > rename src/libcamera/pipeline/{raspberrypi => rpi/common}/rpi_stream.cpp (87%)\n> > > > rename src/libcamera/pipeline/{raspberrypi => rpi/common}/rpi_stream.h (76%)\n> > > > create mode 100644 src/libcamera/pipeline/rpi/meson.build\n> > > > rename src/libcamera/pipeline/{raspberrypi => rpi/vc4}/data/example.yaml (94%)\n> > > > rename src/libcamera/pipeline/{raspberrypi => rpi/vc4}/data/meson.build (63%)\n> > > > rename src/libcamera/pipeline/{raspberrypi => rpi/vc4}/dma_heaps.cpp (100%)\n> > > > rename src/libcamera/pipeline/{raspberrypi => rpi/vc4}/dma_heaps.h (100%)\n> > > > create mode 100644 src/libcamera/pipeline/rpi/vc4/meson.build\n> > > > create mode 100644 src/libcamera/pipeline/rpi/vc4/vc4.cpp","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1F468BD16B\n\tfor ;\n\tThu, 4 May 2023 16:59:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7B414633B1;\n\tThu, 4 May 2023 18:59:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9BBED627DE\n\tfor ;\n\tThu, 4 May 2023 18:59:18 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4FECE7CE;\n\tThu, 4 May 2023 18:59:14 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683219560;\n\tbh=vQRI2q2bAtJuEhaeTLC6k8PY9hM+b6xxgeXpDp7fli8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Z42qAAP/4aeLyddb+Pch0+J28rX7/Xky9Nsvp+0E2W4B+UypQQ+VfP5jEI8lqEQ2v\n\tDTZtBenQlfx/RL5o1tkfho6vl4ETkTNH5D1YHPTbpTUA/hJeR3kex9wO4coseDu6np\n\t53p1DWPTys4dg258Z0/qb2N31f45asU0EC/FaaaLF07AbHDXudBFU7IPrRKZPgw/Pr\n\tSdyHJcGvGD2xukCeiIltseCJf2d7aDudunvwv6zIL1I0uFsTNLCqv28+0fa/5tMvhY\n\tCnReWAVC2o+at6rH4LiwJWvmN8C5CnV0Er3rY8Sye7ZhFG3bO5Fl8nA00DkfUEpMBv\n\tNte/ChzMaywPw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1683219555;\n\tbh=vQRI2q2bAtJuEhaeTLC6k8PY9hM+b6xxgeXpDp7fli8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YgNevJWzSYyZdzG4xXcZGdAe9vIiKXPNGzoDSRZCcIPMmC3TK6nJKqslIUgXay/0r\n\tKjr/TX9ri3Ea0y51324XCYDlWP6Ik6JvPb+u9/TYesEIc1hmWciHep89n419WnoNfp\n\t9k7sPZhPkENP/CU/qx+BjYp7oy81zFxV8h204sGg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"YgNevJWz\"; dkim-atps=neutral","Date":"Thu, 4 May 2023 19:59:28 +0300","To":"Naushir Patuck ","Message-ID":"<20230504165928.GQ4551@pendragon.ideasonboard.com>","References":"<20230503122035.32026-1-naush@raspberrypi.com>\n\t\n\t<20230504111307.GI4551@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 00/13] Raspberry Pi: Code refactoring","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27062,"web_url":"https://patchwork.libcamera.org/comment/27062/","msgid":"<20230504180052.GS4551@pendragon.ideasonboard.com>","date":"2023-05-04T18:00:52","subject":"Re: [libcamera-devel] [PATCH 00/13] Raspberry Pi: Code refactoring","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, May 03, 2023 at 01:20:22PM +0100, Naushir Patuck via libcamera-devel wrote:\n> Hi,\n> \n> Version 2 of this incorporates all the suggest fixes from the review feedback.\n> In particular the major changes include:\n> \n> - More wording in the documentation in patch 1/13.\n> - Remove the '/' character restriction for the IPA name in patch 2/13.\n> - Changes to the base meson.build files so they don't include \"rpi\" specific\n> functional blocks (new patches 3 and 4).\n> - The common rpi IPA code is now built as a static library in patch 6/13.\n> - Add documentation to the raspberrypi.mojom file in patch 8/13.\n> - Remove a level of base -> derived class indirection in patch 12/13.\n> \n> If there's anything I missed out from the last round of feedback, please do\n> shout.\n\nPushed, thanks.\n\n> David Plowman (1):\n> ipa: raspberrypi: agc: Move weights out of AGC\n> \n> Naushir Patuck (12):\n> meson: ipa: Add mapping for pipeline handler to mojom interface file\n> libcamera: ipa: Remove character restriction on the IPA name\n> ipa: meson: Allow nested IPA directory structures\n> pipeline: meson: Allow nested pipeline handler directory structures\n> pipeline: raspberrypi: Refactor and move pipeline handler code\n> ipa: raspberrypi: Refactor and move IPA code\n> pipeline: raspberrypi: rpi_stream: Set invalid buffer to id == 0\n> pipeline: ipa: raspberrypi: Restructure the IPA mojom interface\n> ipa: raspberrypi: Introduce IpaBase class\n> pipeline: raspberrypi: Make RPi::Stream::name() return const\n> std::string &\n> pipeline: raspberrypi: Introduce PipelineHandlerBase class\n> pipeline: raspberrypi: Add stream flags to RPi::Stream\n> \n> Documentation/environment_variables.rst | 4 +-\n> Documentation/guides/introduction.rst | 2 +-\n> Documentation/guides/ipa.rst | 39 +-\n> Documentation/guides/pipeline-handler.rst | 2 +-\n> include/libcamera/ipa/meson.build | 36 +-\n> include/libcamera/ipa/raspberrypi.mojom | 238 +-\n> meson.build | 4 +-\n> meson_options.txt | 4 +-\n> src/ipa/ipu3/meson.build | 2 +\n> src/ipa/meson.build | 26 +-\n> src/ipa/raspberrypi/meson.build | 66 -\n> src/ipa/rkisp1/meson.build | 2 +\n> src/ipa/{raspberrypi => rpi}/README.md | 0\n> .../cam_helper}/cam_helper.cpp | 0\n> .../cam_helper}/cam_helper.h | 2 +-\n> .../cam_helper}/cam_helper_imx219.cpp | 0\n> .../cam_helper}/cam_helper_imx290.cpp | 0\n> .../cam_helper}/cam_helper_imx296.cpp | 0\n> .../cam_helper}/cam_helper_imx477.cpp | 0\n> .../cam_helper}/cam_helper_imx519.cpp | 0\n> .../cam_helper}/cam_helper_imx708.cpp | 0\n> .../cam_helper}/cam_helper_ov5647.cpp | 0\n> .../cam_helper}/cam_helper_ov9281.cpp | 0\n> .../cam_helper}/md_parser.h | 0\n> .../cam_helper}/md_parser_smia.cpp | 0\n> src/ipa/rpi/cam_helper/meson.build | 26 +\n> .../common/ipa_base.cpp} | 1511 ++++------\n> src/ipa/rpi/common/ipa_base.h | 122 +\n> src/ipa/rpi/common/meson.build | 17 +\n> .../controller/af_algorithm.h | 0\n> .../controller/af_status.h | 0\n> .../controller/agc_algorithm.h | 3 +\n> .../controller/agc_status.h | 0\n> .../controller/algorithm.cpp | 0\n> .../controller/algorithm.h | 0\n> .../controller/alsc_status.h | 0\n> .../controller/awb_algorithm.h | 0\n> .../controller/awb_status.h | 0\n> .../controller/black_level_status.h | 0\n> .../controller/camera_mode.h | 0\n> .../controller/ccm_algorithm.h | 0\n> .../controller/ccm_status.h | 0\n> .../controller/contrast_algorithm.h | 0\n> .../controller/contrast_status.h | 0\n> .../controller/controller.cpp | 0\n> .../controller/controller.h | 0\n> .../controller/denoise_algorithm.h | 0\n> .../controller/denoise_status.h | 0\n> .../controller/device_status.cpp | 0\n> .../controller/device_status.h | 0\n> .../controller/dpc_status.h | 0\n> .../controller/geq_status.h | 0\n> .../controller/histogram.cpp | 0\n> .../controller/histogram.h | 0\n> .../controller/lux_status.h | 0\n> src/ipa/rpi/controller/meson.build | 29 +\n> .../controller/metadata.h | 0\n> .../controller/noise_status.h | 0\n> .../controller/pdaf_data.h | 0\n> .../{raspberrypi => rpi}/controller/pwl.cpp | 0\n> src/ipa/{raspberrypi => rpi}/controller/pwl.h | 0\n> .../controller/region_stats.h | 0\n> .../controller/rpi/af.cpp | 0\n> .../{raspberrypi => rpi}/controller/rpi/af.h | 0\n> .../controller/rpi/agc.cpp | 27 +-\n> .../{raspberrypi => rpi}/controller/rpi/agc.h | 1 +\n> .../controller/rpi/alsc.cpp | 0\n> .../controller/rpi/alsc.h | 0\n> .../controller/rpi/awb.cpp | 0\n> .../{raspberrypi => rpi}/controller/rpi/awb.h | 0\n> .../controller/rpi/black_level.cpp | 0\n> .../controller/rpi/black_level.h | 0\n> .../controller/rpi/ccm.cpp | 0\n> .../{raspberrypi => rpi}/controller/rpi/ccm.h | 0\n> .../controller/rpi/contrast.cpp | 0\n> .../controller/rpi/contrast.h | 0\n> .../controller/rpi/dpc.cpp | 0\n> .../{raspberrypi => rpi}/controller/rpi/dpc.h | 0\n> .../controller/rpi/focus.h | 0\n> .../controller/rpi/geq.cpp | 0\n> .../{raspberrypi => rpi}/controller/rpi/geq.h | 0\n> .../controller/rpi/lux.cpp | 0\n> .../{raspberrypi => rpi}/controller/rpi/lux.h | 0\n> .../controller/rpi/noise.cpp | 0\n> .../controller/rpi/noise.h | 0\n> .../controller/rpi/sdn.cpp | 0\n> .../{raspberrypi => rpi}/controller/rpi/sdn.h | 0\n> .../controller/rpi/sharpen.cpp | 0\n> .../controller/rpi/sharpen.h | 0\n> .../controller/sharpen_algorithm.h | 0\n> .../controller/sharpen_status.h | 0\n> .../controller}/statistics.h | 0\n> src/ipa/rpi/meson.build | 14 +\n> .../{raspberrypi => rpi/vc4}/data/imx219.json | 0\n> .../vc4}/data/imx219_noir.json | 0\n> .../{raspberrypi => rpi/vc4}/data/imx290.json | 0\n> .../{raspberrypi => rpi/vc4}/data/imx296.json | 0\n> .../vc4}/data/imx296_mono.json | 0\n> .../{raspberrypi => rpi/vc4}/data/imx378.json | 0\n> .../{raspberrypi => rpi/vc4}/data/imx477.json | 0\n> .../vc4}/data/imx477_noir.json | 0\n> .../vc4}/data/imx477_scientific.json | 0\n> .../vc4}/data/imx477_v1.json | 0\n> .../{raspberrypi => rpi/vc4}/data/imx519.json | 0\n> .../{raspberrypi => rpi/vc4}/data/imx708.json | 0\n> .../vc4}/data/imx708_noir.json | 0\n> .../vc4}/data/imx708_wide.json | 0\n> .../vc4}/data/imx708_wide_noir.json | 0\n> .../{raspberrypi => rpi/vc4}/data/meson.build | 2 +-\n> .../{raspberrypi => rpi/vc4}/data/ov5647.json | 0\n> .../vc4}/data/ov5647_noir.json | 0\n> .../vc4}/data/ov9281_mono.json | 0\n> .../vc4}/data/se327m12.json | 0\n> .../vc4}/data/uncalibrated.json | 0\n> src/ipa/rpi/vc4/meson.build | 48 +\n> src/ipa/rpi/vc4/vc4.cpp | 552 ++++\n> src/libcamera/ipa_module.cpp | 11 +-\n> src/libcamera/pipeline/meson.build | 9 +\n> .../pipeline/raspberrypi/raspberrypi.cpp | 2433 -----------------\n> .../common}/delayed_controls.cpp | 0\n> .../common}/delayed_controls.h | 0\n> .../{raspberrypi => rpi/common}/meson.build | 5 +-\n> .../pipeline/rpi/common/pipeline_base.cpp | 1482 ++++++++++\n> .../pipeline/rpi/common/pipeline_base.h | 277 ++\n> .../common}/rpi_stream.cpp | 52 +-\n> .../{raspberrypi => rpi/common}/rpi_stream.h | 62 +-\n> src/libcamera/pipeline/rpi/meson.build | 12 +\n> .../vc4}/data/example.yaml | 4 +-\n> .../{raspberrypi => rpi/vc4}/data/meson.build | 2 +-\n> .../{raspberrypi => rpi/vc4}/dma_heaps.cpp | 0\n> .../{raspberrypi => rpi/vc4}/dma_heaps.h | 0\n> src/libcamera/pipeline/rpi/vc4/meson.build | 8 +\n> src/libcamera/pipeline/rpi/vc4/vc4.cpp | 975 +++++++\n> 133 files changed, 4420 insertions(+), 3691 deletions(-)\n> delete mode 100644 src/ipa/raspberrypi/meson.build\n> rename src/ipa/{raspberrypi => rpi}/README.md (100%)\n> rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper.h (99%)\n> rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx219.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx290.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx296.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx477.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx519.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx708.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_ov5647.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_ov9281.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi/cam_helper}/md_parser.h (100%)\n> rename src/ipa/{raspberrypi => rpi/cam_helper}/md_parser_smia.cpp (100%)\n> create mode 100644 src/ipa/rpi/cam_helper/meson.build\n> rename src/ipa/{raspberrypi/raspberrypi.cpp => rpi/common/ipa_base.cpp} (62%)\n> create mode 100644 src/ipa/rpi/common/ipa_base.h\n> create mode 100644 src/ipa/rpi/common/meson.build\n> rename src/ipa/{raspberrypi => rpi}/controller/af_algorithm.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/af_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/agc_algorithm.h (93%)\n> rename src/ipa/{raspberrypi => rpi}/controller/agc_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/algorithm.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/algorithm.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/alsc_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/awb_algorithm.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/awb_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/black_level_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/camera_mode.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/ccm_algorithm.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/ccm_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/contrast_algorithm.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/contrast_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/controller.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/controller.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/denoise_algorithm.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/denoise_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/device_status.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/device_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/dpc_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/geq_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/histogram.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/histogram.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/lux_status.h (100%)\n> create mode 100644 src/ipa/rpi/controller/meson.build\n> rename src/ipa/{raspberrypi => rpi}/controller/metadata.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/noise_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/pdaf_data.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/pwl.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/pwl.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/region_stats.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/af.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/af.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/agc.cpp (97%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/agc.h (98%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/alsc.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/alsc.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/awb.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/awb.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/black_level.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/black_level.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/ccm.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/ccm.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/contrast.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/contrast.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/dpc.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/dpc.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/focus.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/geq.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/geq.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/lux.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/lux.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/noise.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/noise.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/sdn.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/sdn.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/sharpen.cpp (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/rpi/sharpen.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/sharpen_algorithm.h (100%)\n> rename src/ipa/{raspberrypi => rpi}/controller/sharpen_status.h (100%)\n> rename src/ipa/{raspberrypi => rpi/controller}/statistics.h (100%)\n> create mode 100644 src/ipa/rpi/meson.build\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx219.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx219_noir.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx290.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx296.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx296_mono.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx378.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx477.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx477_noir.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx477_scientific.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx477_v1.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx519.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx708.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx708_noir.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx708_wide.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/imx708_wide_noir.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/meson.build (89%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/ov5647.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/ov5647_noir.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/ov9281_mono.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/se327m12.json (100%)\n> rename src/ipa/{raspberrypi => rpi/vc4}/data/uncalibrated.json (100%)\n> create mode 100644 src/ipa/rpi/vc4/meson.build\n> create mode 100644 src/ipa/rpi/vc4/vc4.cpp\n> delete mode 100644 src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> rename src/libcamera/pipeline/{raspberrypi => rpi/common}/delayed_controls.cpp (100%)\n> rename src/libcamera/pipeline/{raspberrypi => rpi/common}/delayed_controls.h (100%)\n> rename src/libcamera/pipeline/{raspberrypi => rpi/common}/meson.build (66%)\n> create mode 100644 src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> create mode 100644 src/libcamera/pipeline/rpi/common/pipeline_base.h\n> rename src/libcamera/pipeline/{raspberrypi => rpi/common}/rpi_stream.cpp (87%)\n> rename src/libcamera/pipeline/{raspberrypi => rpi/common}/rpi_stream.h (76%)\n> create mode 100644 src/libcamera/pipeline/rpi/meson.build\n> rename src/libcamera/pipeline/{raspberrypi => rpi/vc4}/data/example.yaml (94%)\n> rename src/libcamera/pipeline/{raspberrypi => rpi/vc4}/data/meson.build (63%)\n> rename src/libcamera/pipeline/{raspberrypi => rpi/vc4}/dma_heaps.cpp (100%)\n> rename src/libcamera/pipeline/{raspberrypi => rpi/vc4}/dma_heaps.h (100%)\n> create mode 100644 src/libcamera/pipeline/rpi/vc4/meson.build\n> create mode 100644 src/libcamera/pipeline/rpi/vc4/vc4.cpp\n> \n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 09659BD16B\n\tfor ;\n\tThu, 4 May 2023 18:00:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CDD22633B1;\n\tThu, 4 May 2023 20:00:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB078627DE\n\tfor ;\n\tThu, 4 May 2023 20:00:40 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9809F6E0;\n\tThu, 4 May 2023 20:00:36 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683223242;\n\tbh=AtZocHAwJ5u1kEEwMlsc0S2MujsLIQ073W+lxhAL2NY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=l47MiZ0RCxyLLd7ryEKT0ZaKAc9eROVRoDVTrSLomW/5mt8at5dVxO612E9urPJgo\n\tmDFpN5jjPc4AVTWE7zlYgyG65uKXjOykGXsv+oq4/TRXXHYJovBRrvpioqNejFeCsY\n\t4OCUJemxsLhpjoCUpY0HTVyY1LI/q8z5+LEm/JjsId0btfXmcxw+1/VyFSteLsudq7\n\tOptLT8roiEoJJasbrX+xDpHWJPAA7FFCYUVXrnOTsvOM/WRTnYmbQFpt3GlYQOgxct\n\tkBago8OTELfswEQ4T4mY+ZRfF7NsKtSHFcooitvqw7Wtf6Uf2teNFj13SVQcXI6+sj\n\tbIHLXcOMpQOzA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1683223237;\n\tbh=AtZocHAwJ5u1kEEwMlsc0S2MujsLIQ073W+lxhAL2NY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bdHX4zNI4BqN17ES6PjtSRcEWBK6YlEq2uQLssRl/WmjTd+RqwI+RIus07Bqym7ru\n\t4cmGAFZtV8MX/Dsks8Zj9abbKvWyI6kEoZ6nMmHLOXitOHoYAbF6/xo1+04OUop4F9\n\tyIy8efPPWYXvVMOiwxdqn7IIZD/kySIYWxEVtV6w="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"bdHX4zNI\"; dkim-atps=neutral","Date":"Thu, 4 May 2023 21:00:52 +0300","To":"Naushir Patuck ","Message-ID":"<20230504180052.GS4551@pendragon.ideasonboard.com>","References":"<20230503122035.32026-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230503122035.32026-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 00/13] Raspberry Pi: Code refactoring","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]