{"id":18438,"url":"https://patchwork.libcamera.org/api/covers/18438/?format=json","web_url":"https://patchwork.libcamera.org/cover/18438/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230322161317.18055-1-naush@raspberrypi.com>","date":"2023-03-22T16:13:14","name":"[libcamera-devel,v1,0/3] Raspberry Pi: Sensor limits","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"mbox":"https://patchwork.libcamera.org/cover/18438/mbox/","series":[{"id":3811,"url":"https://patchwork.libcamera.org/api/series/3811/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3811","date":"2023-03-22T16:13:14","name":"Raspberry Pi: Sensor limits","version":1,"mbox":"https://patchwork.libcamera.org/series/3811/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/18438/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A488C0F1B\n\tfor ;\n\tWed, 22 Mar 2023 16:13:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CC9686270D;\n\tWed, 22 Mar 2023 17:13:14 +0100 (CET)","from mail-il1-x12f.google.com (mail-il1-x12f.google.com\n\t[IPv6:2607:f8b0:4864:20::12f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6458061ECE\n\tfor ;\n\tWed, 22 Mar 2023 17:13:12 +0100 (CET)","by mail-il1-x12f.google.com with SMTP id bc5so4402943ilb.9\n\tfor ;\n\tWed, 22 Mar 2023 09:13:12 -0700 (PDT)","from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tn24-20020a02a918000000b004050d92f6d4sm5100119jam.50.2023.03.22.09.13.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 22 Mar 2023 09:13:10 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1679501594;\n\tbh=VeEbf9CkDtaalApbHzYZsmFGUroUhCtEnoZEETtWPRo=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=rUdMLCWi7ut+OrkJeK3X1oG+I3hog3yUAsjk1MehNJObP93c/HiiWGFtJphgCuzkq\n\tp8n1duP2Q6Grwkn83Ty5RxAaRzxaUV/G7T3waP/WKkRMJKU6vVXkkM8VRoC7bn8ieg\n\t7V8JbhoLCdx3QRlcR59Q0QTSufZVRsmmohb2KRLcc42toRWC00E9AoYi62N1TD2ih3\n\tpl306f/5Ts0HiEfT7ImqLw0O2FhfHHz6nHJbYrIrEqkOPD+5oFLBxsR4mdf4m+d3ep\n\tuW9bEoP1MUN0r3JEe3Xvhq+ZD6oivmaEqN3dwCFIGP27vvJRB5rDkr3ZpV5dDZtAzc\n\tRm1SxWOqV0TQA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1679501591;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=+3fNWDtxPzB76/+PMMf6SEtU/kX5Nc/IMTqeFQ1cog8=;\n\tb=EwzC38fEaerV8g/v5rgeTqajNNlOTEXgwJ2dx1XJ+i48vVmR02mF1x+/NoH6yQyxPz\n\tCZyLYpAwDuhiU2mICnxChfGqbxVnKMyuSld7SusSQMejod53QEp28ye/Kg4xcBKESdSo\n\tf0VXJuP7aAQLlJkpP+6x5AdSOYMZnIKzwCfolWL6H0znfVgN/cKcECOf82QH+uaJJGPd\n\twO4gDAyu+0r4K3mlRRi3DNmyZqPbKOiKhFR+rpUiiXAzQdJcFDrr9Mx2iVzpOB0XKhxJ\n\tfyEVdZkw2kAb8NJAvB5rmJLCl51sME1fhkIamAf6DupT9H5izO31gDB4jKaXTHft7F0T\n\th1xA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"EwzC38fE\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112; t=1679501591;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=+3fNWDtxPzB76/+PMMf6SEtU/kX5Nc/IMTqeFQ1cog8=;\n\tb=p/wb/Z1IwdLaUH2aObI7WLg6aNteMj2OrEe+F+D2XHEjwnfFxCUWj6KSTS6Fsqh74/\n\tsfT//EHTbL2cDGZfl4HS3dN99rQMqNMi5DN2k6djmK2n2dolFioUlenCCnYOnlMffaXz\n\tGf8P+eB3l/yGRD99GapG9idM5Q/WFqPUJVUweGavKBoPLIKzcJ1j0pEVuBIlzoyA3dwm\n\tfcD6qjPx25hFt43uiDcd70JHcK7nDOECJI37jwwM6uyHrqjlvbycWygaf02HhUK3gcc7\n\toTGRMzMN3RrZgSjr8adHyRuNy7zTMynp15VO669/ivfjenlM2NOib/cVbXmWN1Ge0Gj3\n\t7ubw==","X-Gm-Message-State":"AO0yUKUkMjFftXQXqLvaezIXnvKN1Z08n1PvVhHiF9+YJ6PoAaGZ+n/m\n\tvGOBdbhqxWwIj/LT+pvMPMI6AaQy+Q1NQFxEDxZp6g==","X-Google-Smtp-Source":"AK7set8soK0dAF3OgqYNUAFmMmLGTTbHxK27yq3SE1QwvqdCQN8wk3NRv+Abo+OqjzsDoYYxEoAyng==","X-Received":"by 2002:a92:d346:0:b0:317:9768:fbb4 with SMTP id\n\ta6-20020a92d346000000b003179768fbb4mr5249487ilh.31.1679501590817; \n\tWed, 22 Mar 2023 09:13:10 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 22 Mar 2023 16:13:14 +0000","Message-Id":"<20230322161317.18055-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1 0/3] Raspberry Pi: Sensor limits","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi,\n\nThis small series makes a small change to how we handle sensor control limits,\nparticularly gain and exposure.\n\nWith this series, we introduce an explicit SensorLimits structure that stores\nthe limits. The AGC algorithm has a new member function that accepts this\nstructure, replacing the existing setMaxShutter() function. This allows the\nAGC to corretly handle limits of gain values which it currently does not do - \nspecifically for the imx708 that has a minimum gain of 1.12x.\n\nThanks,\nNaush\n\nNaushir Patuck (3):\n ipa: raspberrypi: Replace setMaxShutter with setSensorLimits in AGC\n ipa: raspberrypi: Populate SensorLimits\n ipa: raspberrypi: Ensure shutter speed and gain are clipped in the AGC\n\n .../raspberrypi/controller/agc_algorithm.h | 11 +++-\n src/ipa/raspberrypi/controller/rpi/agc.cpp | 53 +++++++++++----\n src/ipa/raspberrypi/controller/rpi/agc.h | 7 +-\n src/ipa/raspberrypi/raspberrypi.cpp | 66 +++++++++++--------\n 4 files changed, 92 insertions(+), 45 deletions(-)"}