[{"id":26660,"web_url":"https://patchwork.libcamera.org/comment/26660/","msgid":"","date":"2023-03-17T07:09:24","subject":"Re: [libcamera-devel] [PATCH v3 0/4] libcamera: rkisp1: Fix\n\tgenerateConfiguration","submitter":{"id":126,"url":"https://patchwork.libcamera.org/api/people/126/","name":"Daniel Semkowicz","email":"dse@thaumatec.com"},"content":"On Tue, Mar 7, 2023 at 12:48 PM Jacopo Mondi via libcamera-devel\n wrote:\n>\n> The series started with bug 180:\n> https://bugs.libcamera.org/show_bug.cgi?id=180\n>\n> which reports how using the self-path for generating a configuration\n> for a single stream results in only StreamFormats up to 1920x1920\n> to be produced.\n>\n> I have then noticed how the current implementation of\n> RkISP1Path::generateConfiguration() could produce unusual sizes, such as\n> 1920x1432 in case the sensor's resolution is larger than the maximum supported\n> 1920x1920 output.\n>\n> Finally, if StillCapture is requested, make sure it is assigned to the main\n> path in RkISP1::generateConfiguration() to make sure it can produce images\n> in full resolution.\n>\n> Tested on Pinephone Pro with imx258 camera.\n>\n> Updated branch jmondi/pinephonepro-af on\n> https://git.libcamera.org/libcamera/jmondi/libcamera.git\n>\n> v2->v3:\n> - Add review tags\n> - Improve 3/4 as suggested by Paul\n>\n> v1->v2:\n> - Enumerate StreamFormats for all the available size and not limited to the\n> current output size. This allows to enumerate higher resolutions even if the\n> desired role has a smaller resolution.\n>\n> In example:\n> gst-launch-1.0 libcamerasrc camera-name=\"/base/i2c\\@ff110000/camera\\@1a\" ! 'video/x-raw,format=NV12,width=4208,height=3120' ! glimagesink\n>\n> which used to fail now works correctly\n>\n> - Enumerate all the RAW sizes the sensor can produce but only if the requested\n> role is StreamRole::Raw\n>\n>\n> Jacopo Mondi (4):\n> libcamera: rkisp1: Generate config using main path\n> libcamera: rkisp1: Assign sizes to roles\n> libcamera: rkisp1: Reserve main path for StillCapture\n> libcamera: rkisp1: Fix enumeration of RAW formats\n>\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 30 ++++++++++++-------\n> src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 29 +++++++++++++++---\n> src/libcamera/pipeline/rkisp1/rkisp1_path.h | 1 +\n> 3 files changed, 46 insertions(+), 14 deletions(-)\n>\n> --\n> 2.39.0\n>\n\nHi Jacopo,\n\nThank you very much for this fix!\n\nI tested your patches with RK3399 + OV5675 and it worked correctly.\nI was able to capture streams with the full sensor resolution.\n\nBest regards\nDaniel Semkowicz","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A3EF4C0F1B\n\tfor ;\n\tFri, 17 Mar 2023 07:09:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D1FE862709;\n\tFri, 17 Mar 2023 08:09:37 +0100 (CET)","from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com\n\t[IPv6:2a00:1450:4864:20::52b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3235561ED0\n\tfor ;\n\tFri, 17 Mar 2023 08:09:36 +0100 (CET)","by mail-ed1-x52b.google.com with SMTP id cy23so16622542edb.12\n\tfor ;\n\tFri, 17 Mar 2023 00:09:36 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1679036977;\n\tbh=4uEneEENPn0ttSIO+tyujAhDbKTI6OD+RFfM0+W0HDE=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=jzmwCy4vMrHIzOSxqJxI21BIGeYuJtC6yJ6zR3cw0eJK6hCTg6Ag3S11AvcoS77Y/\n\tkznvMdn9+X41hkFJzBcn+u8wS3dI9bvsb287Gj62dXUHYHn2L5oMiQmdD/q2GQjLNg\n\t1h/oOfnLrF5N1oN2UthyyLy2uonONLtqbECQEvX+DNfMlTrygJbhh787uP7xsU/0jy\n\t9UL1prbfvcdh1dfbPvorH4cPU54EHvDNsQ+G9CaH4Vlp4dowy+LjQsPmA1Do1mMOOE\n\t7rhdpEDmQd8hW94AOA8hMcjJ7xMkZmPpZZhbzjH388NmdikRqeB0+C9vw2IMsebVfP\n\tcxgbCztDsUmjg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=thaumatec-com.20210112.gappssmtp.com; s=20210112; t=1679036975;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=QX4IIhSxL9etSZdeUEYOHKN0fgiQDrW9xvVdi2jlw/I=;\n\tb=1sA83yh5/zbEN6e7DiWeu+dqP+h90rK83nzHS/xF0sNp1StmNFAikKntupALBwwn8p\n\twv1GIPPS0G28ap5KojEvA6hk43U+j4oNwpW6vCYOB0O3I6Y3hFEao1xfcbB5pKM3pjwf\n\toNTMV7tFx2tPcn0c2sSfC0MxCaRrYRtFWdoRMu4PreO02sWgH/tCNqmZkJOf07QghEWz\n\t9s0/F0noKibsncBaAFEPZSQZ40YXtn/9wzhvwKgI2TAUp7wS4pDOzdUCBGtkCqrH9FSx\n\t7jyisMMoNOiyeWpQV3cITtQwUWmAxBzWVNnQrUv111qRPfSewgf5BzagckpIHMnGPHGn\n\tcO0A=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=thaumatec-com.20210112.gappssmtp.com\n\theader.i=@thaumatec-com.20210112.gappssmtp.com header.b=\"1sA83yh5\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112; t=1679036975;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=QX4IIhSxL9etSZdeUEYOHKN0fgiQDrW9xvVdi2jlw/I=;\n\tb=u8jR6RY8dTiKyJqTJiTe9kdRljUaXMXmEVHvI0seVfoNkE11y6Gzy776rMf9luA9RL\n\tBf68OOMKp2epTUsKImjHQFRdnGB1+DKGVomvJpFbKBiCAE3RtJWlcWYWEFrYL8l8l0wq\n\tQ8WdFHCr6iM2FOd5wLcOhgCrbhfVSHgfGMTPjKaD0UZ8CcOQHBj+UH0As/EY0M4QYNaZ\n\tdn1z/QBGkvTP2COTu41/5dUdeqsiHPDcddM635Nx7QwFOJ7paA/PKaT9OGUpFoTiybp9\n\t+T1Ggu0QgauPHWisaeYxXNldzWj7T69v5s6gFlduDbg07A2aNJLApUNGlmx1QXc8OMEQ\n\tUJEw==","X-Gm-Message-State":"AO0yUKULj+SuQil6IycYsNqgUr9TIWfXTsqPsfMO5cpHDVfCPv/0D968\n\ta8bqobFF/NEakZeQkSKO+QR3e7RNugrvKB6inznZjQ==","X-Google-Smtp-Source":"AK7set+IKQ0mICrHHpmXUaRYXbXrNo41muzpbR9d7vmvndnPWcpNDeoz/4rLUpK80VAUuMQkV375eXS+RwO7p85vt1Q=","X-Received":"by 2002:a50:f602:0:b0:4fb:f19:881 with SMTP id\n\tc2-20020a50f602000000b004fb0f190881mr1127376edn.3.1679036975606; \n\tFri, 17 Mar 2023 00:09:35 -0700 (PDT)","MIME-Version":"1.0","References":"<20230307114804.42291-1-jacopo.mondi@ideasonboard.com>","In-Reply-To":"<20230307114804.42291-1-jacopo.mondi@ideasonboard.com>","Date":"Fri, 17 Mar 2023 08:09:24 +0100","Message-ID":"","To":"Jacopo Mondi ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [libcamera-devel] [PATCH v3 0/4] libcamera: rkisp1: Fix\n\tgenerateConfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Daniel Semkowicz via libcamera-devel\n\t","Reply-To":"Daniel Semkowicz ","Cc":"libcamera-devel@lists.libcamera.org, libcamera@luigi311.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]