[{"id":26567,"web_url":"https://patchwork.libcamera.org/comment/26567/","msgid":"<20230306175027.GA22236@pendragon.ideasonboard.com>","date":"2023-03-06T17:50:27","subject":"Re: [libcamera-devel] [PATCH 0/3] ipa: rkisp1: Add script to\n\textract LSC tables from Android","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patches.\n\nOn Mon, Mar 06, 2023 at 06:24:37PM +0100, Jacopo Mondi via libcamera-devel wrote:\n> Android configuration files in .xml format contain important information\n> among which LSC tables which can be reused for libcamera.\n> \n> Add a script to extract LSC tables from Android .xml configuration files\n> used by the Rockchip IQ algorithm library.\n> \n> With the new script extract LSC tables for the Google DRU and Pine64 Pinephone\n> Pro devices and add tuning files for their sensors.\n\nIt would be an interesting exercise to later generate LSC tables with\nour tuning tool and compare the values.\n\n> Jacopo Mondi (3):\n> utils: rkisp1: Add script to extract LSC tables from Android\n> ipa: rkisp1: Add tuning files for Google DRU \"Scarlet\" sensors\n> ipa: rkisp1: Add tuning files for PinephonePro sensors\n> \n> src/ipa/rkisp1/data/imx258.yaml | 54 +++++++\n> src/ipa/rkisp1/data/ov2685.yaml | 41 +++++\n> src/ipa/rkisp1/data/ov5695.yaml | 41 +++++\n\nThose two sensors should be added to the camera sensor helper.\n\n> src/ipa/rkisp1/data/ov8858.yaml | 54 +++++++\n> utils/rkisp1/lsc_parse_android_config.py | 187 +++++++++++++++++++++++\n> 5 files changed, 377 insertions(+)\n> create mode 100644 src/ipa/rkisp1/data/imx258.yaml\n> create mode 100644 src/ipa/rkisp1/data/ov2685.yaml\n> create mode 100644 src/ipa/rkisp1/data/ov5695.yaml\n> create mode 100644 src/ipa/rkisp1/data/ov8858.yaml\n> create mode 100755 utils/rkisp1/lsc_parse_android_config.py","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ABA3BBE080\n\tfor ;\n\tMon, 6 Mar 2023 17:50:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 19B4362698;\n\tMon, 6 Mar 2023 18:50:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 27C0A603B1\n\tfor ;\n\tMon, 6 Mar 2023 18:50:24 +0100 (CET)","from pendragon.ideasonboard.com\n\t(153.162-64-87.adsl-dyn.isp.belgacom.be [87.64.162.153])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9EB8F308;\n\tMon, 6 Mar 2023 18:50:23 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678125026;\n\tbh=F9MtHYdXDJk7puccTeuOQrJfMcwMjH4qIej6jJIgArA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Kr/yZLvygrwka8Ck4XitX0mPgd3zwbExPig9DkN+lZ24X8ukgWbCIdyh8Giab+E2y\n\tyJdvwfrZKHcjxPkBj9Xl9/snoKX5GjxXMBmT+m36a/z9pWwDle8YmdyZJLOqMrswce\n\tlAPJpmIF6wZsMdf7uVDHAGuIRr7JTupggDuB6zACTGmI7/ptEbdw20zImcdgfPGqLG\n\tjT3qdKFzsACP7X6d7k1dsk6qaHNptgoAS4W6KJrsadnj4RDsraTajgwxSJjSvtZz2i\n\t4rHt8dOM22NSxKOvgeoXqaLqJMP16gzw6e7iLrDgb8P2Z107Mt3zta05uirXxRm4mS\n\tKPHzRBbxUW3lw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678125023;\n\tbh=F9MtHYdXDJk7puccTeuOQrJfMcwMjH4qIej6jJIgArA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Sbvogo8I4H5c88SSxo7lAcS7r7jaDuKYQnkhN2D5TH2fd/D6gJF1wt1Brj8KLkycZ\n\t6Ju4eULG+nz1g4xabGWMjrYXhhyyNLrY/BLLmlUpX66eCgok930ysvYnH9j3B0hMgu\n\t2o+cibNWKhOWgSJ7eGafVJhWYMJN+Ydctt0uxNLA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Sbvogo8I\"; dkim-atps=neutral","Date":"Mon, 6 Mar 2023 19:50:27 +0200","To":"Jacopo Mondi ","Message-ID":"<20230306175027.GA22236@pendragon.ideasonboard.com>","References":"<20230306172440.57764-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230306172440.57764-1-jacopo.mondi@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 0/3] ipa: rkisp1: Add script to\n\textract LSC tables from Android","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26568,"web_url":"https://patchwork.libcamera.org/comment/26568/","msgid":"<167812536449.3105479.15646805245031808254@Monstersaurus>","date":"2023-03-06T17:56:04","subject":"Re: [libcamera-devel] [PATCH 0/3] ipa: rkisp1: Add script to\n\textract LSC tables from Android","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2023-03-06 17:50:27)\n> Hi Jacopo,\n> \n> Thank you for the patches.\n> \n> On Mon, Mar 06, 2023 at 06:24:37PM +0100, Jacopo Mondi via libcamera-devel wrote:\n> > Android configuration files in .xml format contain important information\n> > among which LSC tables which can be reused for libcamera.\n> > \n> > Add a script to extract LSC tables from Android .xml configuration files\n> > used by the Rockchip IQ algorithm library.\n> > \n> > With the new script extract LSC tables for the Google DRU and Pine64 Pinephone\n> > Pro devices and add tuning files for their sensors.\n> \n> It would be an interesting exercise to later generate LSC tables with\n> our tuning tool and compare the values.\n> \n> > Jacopo Mondi (3):\n> > utils: rkisp1: Add script to extract LSC tables from Android\n> > ipa: rkisp1: Add tuning files for Google DRU \"Scarlet\" sensors\n> > ipa: rkisp1: Add tuning files for PinephonePro sensors\n> > \n> > src/ipa/rkisp1/data/imx258.yaml | 54 +++++++\n> > src/ipa/rkisp1/data/ov2685.yaml | 41 +++++\n> > src/ipa/rkisp1/data/ov5695.yaml | 41 +++++\n> \n> Those two sensors should be added to the camera sensor helper.\n\nAlready done:\n\nhttps://patchwork.libcamera.org/project/libcamera/list/?series=3773\n\nOne little RB tag and I could even merge them ;-)\n\n--\nKieran\n\n\n> \n> > src/ipa/rkisp1/data/ov8858.yaml | 54 +++++++\n> > utils/rkisp1/lsc_parse_android_config.py | 187 +++++++++++++++++++++++\n> > 5 files changed, 377 insertions(+)\n> > create mode 100644 src/ipa/rkisp1/data/imx258.yaml\n> > create mode 100644 src/ipa/rkisp1/data/ov2685.yaml\n> > create mode 100644 src/ipa/rkisp1/data/ov5695.yaml\n> > create mode 100644 src/ipa/rkisp1/data/ov8858.yaml\n> > create mode 100755 utils/rkisp1/lsc_parse_android_config.py\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A02FEBDE17\n\tfor ;\n\tMon, 6 Mar 2023 17:56:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 138D0626A0;\n\tMon, 6 Mar 2023 18:56:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC3FB6266E\n\tfor ;\n\tMon, 6 Mar 2023 18:56:07 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 79573308;\n\tMon, 6 Mar 2023 18:56:07 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678125369;\n\tbh=Jcj18Nb3g/Tc2ibIp8bYeTlZSZvn//txsnsw3PE1xlQ=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=iTlR342JwQp2YaqdcPmI9jCGNhRxaaD+KfJkzRjue6Vv213t6TKvADYbiufH5hE5Y\n\te3cRm9z7Wss8P2/xiDhdHP1J2d3qlhBOYYIywKgCWB9i4e9gNU00DpObojL3glG4tW\n\tsRjboKvpGLjelrV+Aa/4Jo2E1LR9F5gF8UtqbIG1Nhh3RRHuMtQYO6FQJY1fCji2F2\n\tFPtp2vISdxDEHh5Xiup2ZEJWTf7mo7XLDNM/vXvKGpvRCu7Q9KkzfdsftUi8a2HBla\n\tB/g2MQuOx+TjHuw4lQmreN8b7RL3NEVcqmTZWGg3U0tbTW3kQJzruJQyiTEPVWPGJt\n\tAX33ANlEYTIPA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678125367;\n\tbh=Jcj18Nb3g/Tc2ibIp8bYeTlZSZvn//txsnsw3PE1xlQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=tM+6SJ/fhVhMQivNADdM8MdxLdrH9Q6xXtbpBZ7OSOL57sKj9p2mzY7gYfw/3adAa\n\tyiYhM2f7+nDkjkkh2pq1m9JMTKJ8fGCbJL6gFqtsUs2qV9YFoSUrtV3dk8nigjR9zf\n\t+thrdIXYomf6mVTO6t0on46ohvNQP1YbPJpqOR+s="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"tM+6SJ/f\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230306175027.GA22236@pendragon.ideasonboard.com>","References":"<20230306172440.57764-1-jacopo.mondi@ideasonboard.com>\n\t<20230306175027.GA22236@pendragon.ideasonboard.com>","To":"Jacopo Mondi ,\n\tLaurent Pinchart ,\n\tLaurent Pinchart via libcamera-devel\n\t","Date":"Mon, 06 Mar 2023 17:56:04 +0000","Message-ID":"<167812536449.3105479.15646805245031808254@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 0/3] ipa: rkisp1: Add script to\n\textract LSC tables from Android","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]