[{"id":2459,"web_url":"https://patchwork.libcamera.org/comment/2459/","msgid":"<20190817162203.GG15630@pendragon.ideasonboard.com>","date":"2019-08-17T16:22:03","subject":"Re: [libcamera-devel] [PATCH 0/5] libcamera: camera_sensor: Collect\n\tcamera location and sizes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patches.\n\nOn Sat, Aug 17, 2019 at 12:59:32PM +0200, Jacopo Mondi wrote:\n> Hello, this small series add to the CameraSensor class informations on the\n> camera sensor location, the pixel array size and the active area sizes.\n> \n> The information are required to populate the Android static metadata:\n> android.sensor.info.activeArraySize\n> android.sensor.info.pixelArraySize\n> \n> and the 'struct camera_info.facing' flag.\n> \n> Now that information are collected in the CameraSensor class, a way to expose\n> them through the Camera class is required. In example, adding the CameraSensor\n> that a Camera uses to the Camera class and collects all its Property in a single\n> properties vector might be the simplest way forward.\n> \n> The series depends on the following kernel patch series:\n> https://patchwork.kernel.org/project/linux-media/list/?series=161169\n> https://patchwork.kernel.org/project/linux-media/list/?series=160901\n> \n> Tested on IPU3 Soraka.\n> \n> Jacopo Mondi (5):\n> [TEMP] include: linux: Update v4l2-controls.h\n> libcamera: controls: Add camera location control\n> libcamera: camera_sensor: Store the camera location\n> libcamera: v4l2_subdevice: Add G_SELECTION ioctl support\n> libcamera: camera_sensor: Retrieve sensor sizes\n\nIt would be nice to add a test for the new camera_sensor public methods.\nThis would require adding the location control to the vimc driver, but\nthat shouldn't be a big deal.\n\n> \n> include/libcamera/control_ids.h | 7 ++++\n> include/linux/v4l2-controls.h | 5 +++\n> src/libcamera/camera_sensor.cpp | 39 +++++++++++++++++++++\n> src/libcamera/include/camera_sensor.h | 5 +++\n> src/libcamera/include/v4l2_subdevice.h | 4 +++\n> src/libcamera/v4l2_subdevice.cpp | 48 ++++++++++++++++++++++++++\n> 6 files changed, 108 insertions(+)\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C390D60E2B\n\tfor ;\n\tSat, 17 Aug 2019 18:22:08 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2A776556;\n\tSat, 17 Aug 2019 18:22:08 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1566058928;\n\tbh=gFKQF1H+FcDZEi7Uia0EtQ+REBtca4nQHXl51FVeL0E=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BKwhqv5o5DMKtlj+eYqHU4Shx2SBlNMhsTyHi9Y7S3qX5a1LsmIr6uXXZgbS6EY42\n\tMXFn8sHG7WSYv5mxvytxvxPU49HAHDBPBeyxbSH78dEvIPxv6bUzg+SJ0N6nsIwgBo\n\tIlYaqZC5hIlfGA04b+WEwv+xNRw8Si4Ww8uZ5lHs=","Date":"Sat, 17 Aug 2019 19:22:03 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190817162203.GG15630@pendragon.ideasonboard.com>","References":"<20190817105937.29353-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190817105937.29353-1-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 0/5] libcamera: camera_sensor: Collect\n\tcamera location and sizes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 17 Aug 2019 16:22:08 -0000"}},{"id":2466,"web_url":"https://patchwork.libcamera.org/comment/2466/","msgid":"<20190819073323.a4j5ejuq7mu7bwnq@uno.localdomain>","date":"2019-08-19T07:33:23","subject":"Re: [libcamera-devel] [PATCH 0/5] libcamera: camera_sensor: Collect\n\tcamera location and sizes","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Sat, Aug 17, 2019 at 07:22:03PM +0300, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> Thank you for the patches.\n>\n> On Sat, Aug 17, 2019 at 12:59:32PM +0200, Jacopo Mondi wrote:\n> > Hello, this small series add to the CameraSensor class informations on the\n> > camera sensor location, the pixel array size and the active area sizes.\n> >\n> > The information are required to populate the Android static metadata:\n> > android.sensor.info.activeArraySize\n> > android.sensor.info.pixelArraySize\n> >\n> > and the 'struct camera_info.facing' flag.\n> >\n> > Now that information are collected in the CameraSensor class, a way to expose\n> > them through the Camera class is required. In example, adding the CameraSensor\n> > that a Camera uses to the Camera class and collects all its Property in a single\n> > properties vector might be the simplest way forward.\n> >\n> > The series depends on the following kernel patch series:\n> > https://patchwork.kernel.org/project/linux-media/list/?series=161169\n> > https://patchwork.kernel.org/project/linux-media/list/?series=160901\n> >\n> > Tested on IPU3 Soraka.\n> >\n> > Jacopo Mondi (5):\n> > [TEMP] include: linux: Update v4l2-controls.h\n> > libcamera: controls: Add camera location control\n> > libcamera: camera_sensor: Store the camera location\n> > libcamera: v4l2_subdevice: Add G_SELECTION ioctl support\n> > libcamera: camera_sensor: Retrieve sensor sizes\n>\n> It would be nice to add a test for the new camera_sensor public methods.\n> This would require adding the location control to the vimc driver, but\n> that shouldn't be a big deal.\n>\n\nWhere is the VIMC camera locatated ? :D\n\n> >\n> > include/libcamera/control_ids.h | 7 ++++\n> > include/linux/v4l2-controls.h | 5 +++\n> > src/libcamera/camera_sensor.cpp | 39 +++++++++++++++++++++\n> > src/libcamera/include/camera_sensor.h | 5 +++\n> > src/libcamera/include/v4l2_subdevice.h | 4 +++\n> > src/libcamera/v4l2_subdevice.cpp | 48 ++++++++++++++++++++++++++\n> > 6 files changed, 108 insertions(+)\n> >\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EAFC060E38\n\tfor ;\n\tMon, 19 Aug 2019 09:31:54 +0200 (CEST)","from uno.localdomain (unknown [87.18.63.98])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 466C040007;\n\tMon, 19 Aug 2019 07:31:54 +0000 (UTC)"],"X-Originating-IP":"87.18.63.98","Date":"Mon, 19 Aug 2019 09:33:23 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190819073323.a4j5ejuq7mu7bwnq@uno.localdomain>","References":"<20190817105937.29353-1-jacopo@jmondi.org>\n\t<20190817162203.GG15630@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"llijboseooe3f44p\"","Content-Disposition":"inline","In-Reply-To":"<20190817162203.GG15630@pendragon.ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 0/5] libcamera: camera_sensor: Collect\n\tcamera location and sizes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 19 Aug 2019 07:31:55 -0000"}},{"id":2481,"web_url":"https://patchwork.libcamera.org/comment/2481/","msgid":"<20190819122235.GA5011@pendragon.ideasonboard.com>","date":"2019-08-19T12:22:35","subject":"Re: [libcamera-devel] [PATCH 0/5] libcamera: camera_sensor: Collect\n\tcamera location and sizes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Aug 19, 2019 at 09:33:23AM +0200, Jacopo Mondi wrote:\n> On Sat, Aug 17, 2019 at 07:22:03PM +0300, Laurent Pinchart wrote:\n> > On Sat, Aug 17, 2019 at 12:59:32PM +0200, Jacopo Mondi wrote:\n> > > Hello, this small series add to the CameraSensor class informations on the\n> > > camera sensor location, the pixel array size and the active area sizes.\n> > >\n> > > The information are required to populate the Android static metadata:\n> > > android.sensor.info.activeArraySize\n> > > android.sensor.info.pixelArraySize\n> > >\n> > > and the 'struct camera_info.facing' flag.\n> > >\n> > > Now that information are collected in the CameraSensor class, a way to expose\n> > > them through the Camera class is required. In example, adding the CameraSensor\n> > > that a Camera uses to the Camera class and collects all its Property in a single\n> > > properties vector might be the simplest way forward.\n> > >\n> > > The series depends on the following kernel patch series:\n> > > https://patchwork.kernel.org/project/linux-media/list/?series=161169\n> > > https://patchwork.kernel.org/project/linux-media/list/?series=160901\n> > >\n> > > Tested on IPU3 Soraka.\n> > >\n> > > Jacopo Mondi (5):\n> > > [TEMP] include: linux: Update v4l2-controls.h\n> > > libcamera: controls: Add camera location control\n> > > libcamera: camera_sensor: Store the camera location\n> > > libcamera: v4l2_subdevice: Add G_SELECTION ioctl support\n> > > libcamera: camera_sensor: Retrieve sensor sizes\n> >\n> > It would be nice to add a test for the new camera_sensor public methods.\n> > This would require adding the location control to the vimc driver, but\n> > that shouldn't be a big deal.\n> \n> Where is the VIMC camera locatated ? :D\n\nLet's not add virtual locations ;-) There are two sensors, I would make\none front and the other one back. It's just for testing purpose.\n\n> > >\n> > > include/libcamera/control_ids.h | 7 ++++\n> > > include/linux/v4l2-controls.h | 5 +++\n> > > src/libcamera/camera_sensor.cpp | 39 +++++++++++++++++++++\n> > > src/libcamera/include/camera_sensor.h | 5 +++\n> > > src/libcamera/include/v4l2_subdevice.h | 4 +++\n> > > src/libcamera/v4l2_subdevice.cpp | 48 ++++++++++++++++++++++++++\n> > > 6 files changed, 108 insertions(+)\n> > >","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 419AD60C1E\n\tfor ;\n\tMon, 19 Aug 2019 14:22:41 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 96347510;\n\tMon, 19 Aug 2019 14:22:40 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1566217360;\n\tbh=Dy6bXInUVuJF6X/8dp7VMtqMMjqLHvs/ZsWCTbszPOE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fzS0i/rR2/ujoY/lAnKjqZB+TP9xs5uH2WVlgAGlsOGnjPaJmBJTdtRp44Ko2Jm6y\n\tx1A5Pu2+mZ0eSyQTv4fKK1EyBmfUDFS7YnklQXlWuqbb+9CmJINirS9X3aFsGbagPB\n\t1iVNFXgxpIliZublSiAK2AUyiYaMKlBWeuMFG4OI=","Date":"Mon, 19 Aug 2019 15:22:35 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190819122235.GA5011@pendragon.ideasonboard.com>","References":"<20190817105937.29353-1-jacopo@jmondi.org>\n\t<20190817162203.GG15630@pendragon.ideasonboard.com>\n\t<20190819073323.a4j5ejuq7mu7bwnq@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190819073323.a4j5ejuq7mu7bwnq@uno.localdomain>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 0/5] libcamera: camera_sensor: Collect\n\tcamera location and sizes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 19 Aug 2019 12:22:41 -0000"}}]