{"id":17980,"url":"https://patchwork.libcamera.org/api/covers/17980/?format=json","web_url":"https://patchwork.libcamera.org/cover/17980/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221212150256.69004-1-umang.jain@ideasonboard.com>","date":"2022-12-12T15:02:54","name":"[libcamera-devel,0/2] pipeline-handler: Consider in-flight max requests","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/17980/mbox/","series":[{"id":3667,"url":"https://patchwork.libcamera.org/api/series/3667/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3667","date":"2022-12-12T15:02:54","name":"pipeline-handler: Consider in-flight max requests","version":1,"mbox":"https://patchwork.libcamera.org/series/3667/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/17980/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4A6A1BDE6B\n\tfor ;\n\tMon, 12 Dec 2022 15:03:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AE43463354;\n\tMon, 12 Dec 2022 16:03:07 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2474B6333F\n\tfor ;\n\tMon, 12 Dec 2022 16:03:06 +0100 (CET)","from umang.jainideasonboard.com (unknown\n\t[IPv6:2401:4900:1f3e:7d24:3f0:3e81:fb16:ab4d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 727C96CF;\n\tMon, 12 Dec 2022 16:03:04 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670857387;\n\tbh=hnE+osVCc7GW+1sAuM+u74lOmJbiLyA9NUJddz+WdMc=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=CSe5wbPptsx9PImXGMvKM99VH5mvD2B6Ef+Vg4axmaun0Z8iAb6tFQ74IC7/dHkRt\n\tbGTDnr/xt997L2UKtXKh0u3PIJ4tS25Gyy/52pxbxkWPPajymfw+lYTy0qhZTK7IWa\n\tjFJ0C1LkH/y8LGZfG8PumrM9NwR13DJqPisPv0MYrdyh2KjoM5Ek996NOYuYNze5wr\n\tal3n2/PS46XyDYeJBosVL6cGxT+DOzrV6z0tKX3+TVNMzb07qxUB76jtK4Sv2LbnCW\n\t0pyu4oxfFFyuIez7LZjvSxTBe4WsoDLpA+V82AHUB8xM+4JagffrGBRo1hC1QdcoTk\n\tRzImwKcFn05XQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1670857385;\n\tbh=hnE+osVCc7GW+1sAuM+u74lOmJbiLyA9NUJddz+WdMc=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=PZxYR+ePvzm9a/4nZDISGKiNrOAJGly4Z3wvQ4smW17R8o5ro3hiFoqswxUPXLN0M\n\tNKN033bgbKd1mP0y20xUvmE8V0dRY2fV1Mtl0jJyr2wX44LyaFnJBuqumKTEiMXrIU\n\tFzlrhXzyLUISe0BidE3fRiJxSZX+49wwSUJNWUT4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"PZxYR+eP\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 12 Dec 2022 20:32:54 +0530","Message-Id":"<20221212150256.69004-1-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.38.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 0/2] pipeline-handler: Consider in-flight\n\tmax requests","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This series address the issue where over-queuing of FCQueue (or similar)\ncan happen by the pipeline-handler class if not taken care of.\n\nThe idea is each platform can define its max in-flight requests it can\nhandle at any given point. Set that as a constraint in pipeline-handler\nbase class. The pipeline-handler base class will enforce that constraint\nso that, over-queue of requests does not happen.\n\nPatch 1/2 moves kMaxframeContexts for IPU3 and RkISP1 to .mojom\ninterface (common ground between IPA/PH). This will help respective\npipeline-handlers to access the global variable. \n\nPatch 2/2 implements the constraint. It basically uses a counter to\nkeep track of how many requests are currently queued to the hardware\nbased on which - it decides whether to queue the next request or not.\n\nUmang Jain (2):\n ipa: Move kMaxFrameContexts to mojom interface\n libcamera: pipeline-handler: Consider max in-flight requests\n constraint\n\n include/libcamera/internal/pipeline_handler.h | 4 ++\n include/libcamera/ipa/ipu3.mojom | 3 ++\n include/libcamera/ipa/rkisp1.mojom | 3 ++\n src/ipa/ipu3/ipu3.cpp | 3 --\n src/ipa/rkisp1/rkisp1.cpp | 3 --\n src/libcamera/pipeline/ipu3/ipu3.cpp | 1 +\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 +\n src/libcamera/pipeline_handler.cpp | 51 ++++++++++++++++++-\n 8 files changed, 62 insertions(+), 7 deletions(-)"}