[{"id":26204,"web_url":"https://patchwork.libcamera.org/comment/26204/","msgid":"","date":"2023-01-10T09:01:37","subject":"Re: [libcamera-devel] [PATCH v4 00/12] Raspberry Pi: Platform\n\tconfiguration and buffer allocation improvements","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi all,\n\nJust a gentle ping to get some feedback on this series.\n\nMany thanks,\nNaush\n\n\nOn Fri, 9 Dec 2022 at 09:01, Naushir Patuck wrote:\n\n> Hi,\n>\n> As mentioned in another email, this version fixes a minor regression\n> introduced\n> in version 3 where the delayed stream on for the ISP nodes causes some\n> frame\n> drops. This comes at the expense of allocating an additional buffer for\n> the ISP\n> output when we have to drop frames for 3A convergence.\n>\n> Thanks,\n> Naush\n>\n> Naushir Patuck (12):\n> libcamera: stream: Add stream hints to StreamConfiguration\n> libcamera: pipeline: Add a platform configuration file helper\n> pipeline: raspberrypi: Add a pipeline config structure\n> pipeline: raspberrypi: Reorder startup drop frame initialisation\n> pipeline: raspberrypi: Handle MandatoryRequestBuffer hints for Unicam\n> Image\n> libcamera: pipeline: build: Add pipeline_data_dir variable\n> pipeline: raspberrypi: Read config parameters from a file\n> pipeline: raspberrypi: Handle MandatoryRequestBuffer hints for ISP\n> Output0\n> pipeline: raspberrypi: Validate MandatoryRequestBuffer in\n> queueRequestDevice()\n> pipeline: raspberrypi: Add a parameter to disable startup drop frames\n> pipeline: raspberrypi: Allow pipeline handler to always use the newest\n> frame\n> pipeline: raspberrypi: Add minimal memory usage config file\n>\n> include/libcamera/internal/pipeline_handler.h | 3 +\n> include/libcamera/stream.h | 8 +\n> src/libcamera/pipeline/meson.build | 3 +\n> .../pipeline/raspberrypi/data/example.yaml | 29 +++\n> .../pipeline/raspberrypi/data/meson.build | 9 +\n> .../raspberrypi/data/minimal_mem.yaml | 29 +++\n> .../pipeline/raspberrypi/meson.build | 2 +\n> .../pipeline/raspberrypi/raspberrypi.cpp | 216 +++++++++++++++---\n> src/libcamera/pipeline_handler.cpp | 60 +++++\n> src/libcamera/stream.cpp | 24 ++\n> 10 files changed, 352 insertions(+), 31 deletions(-)\n> create mode 100644 src/libcamera/pipeline/raspberrypi/data/example.yaml\n> create mode 100644 src/libcamera/pipeline/raspberrypi/data/meson.build\n> create mode 100644\n> src/libcamera/pipeline/raspberrypi/data/minimal_mem.yaml\n>\n> --\n> 2.25.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D5FDFC3237\n\tfor ;\n\tTue, 10 Jan 2023 09:01:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4236F625CF;\n\tTue, 10 Jan 2023 10:01:56 +0100 (CET)","from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com\n\t[IPv6:2607:f8b0:4864:20::1131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 87E5B61F05\n\tfor ;\n\tTue, 10 Jan 2023 10:01:54 +0100 (CET)","by mail-yw1-x1131.google.com with SMTP id\n\t00721157ae682-4d19b2686a9so18606547b3.6\n\tfor ;\n\tTue, 10 Jan 2023 01:01:54 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1673341316;\n\tbh=zECXh7AzaP0IXwiktFdfS6UJFoq0SRAm/L/W9eQAzTI=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=dfPIaPP9lztGxc0i0eA9OHGTKs7bQF1bky2Cj812c6pw9lsWlHhOevv6NwRTSOxb+\n\tfGV+V8Cw5+YytopMB0hR5CMVsnfA/0iypjyXU50pVZTyrb7D/lVYxL8K8HNJxYJW6O\n\tF9Kaxg+Q22C3JeGsuPCrxPIBhOqydcKqtZm4FRZL297Zuwe8uPwvZT/Nr/lf/Jh1ti\n\thvfhwsq42iOLrPpy64dGi99sZAjxUaMkgHbHHjkMsRYCYk0aIuzSNS3ZaU+4dPm9ah\n\tZCEOV9J1u9XIONBX49ftstL+i7qmXMO1samyKMcepMWyJVLn1ld15rSG0FjY8YP/xM\n\tOy08weSGTsy2g==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=/0IUPmIOIpUjkzkBh6MA+AZ4mgm/+6uK8ms/FinV360=;\n\tb=OpRwC9Ew2gADeIIc/npprhRWxvYMoE11Qrr5V4iVm4ZBcFt5/e1ivvy6NSmpoJPqGM\n\tyjAOUAWmkexapxd837RrJiczjy6dgAvDDt9DgpnbWQRgFDZRDzczF2db8TpGAZK6fxXh\n\t1G57IJYM46p2i47IHAwx9oSa6HruCZZNn69XvLYAmuLk0beQi5gevooTEgaeceV/0xnm\n\teRHHFOJE6pV6BORQlCxJPZesDos0cFr5LjnyYAG/KYvL2IRtRrQa2NqS9G4M6+7LWgJ1\n\tAQ99NDOMihaAwkLRyB7fDcH8FezD1U2QmWR9LQ272Oa3g8jq8AsGac3KKRLol0Eo5e/4\n\t96FQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"OpRwC9Ew\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=/0IUPmIOIpUjkzkBh6MA+AZ4mgm/+6uK8ms/FinV360=;\n\tb=hWjzFzoSAKHEIsdtOB9f7IU87cjcOv9xdWLTIdqB+oI8HP/YGy9daKcUZvm8NoVdPk\n\tNHKgn8j3v7Alxij0f/Nvjqw0d1xzgEnXuFdtuAKsb+inXt932TQEHcTFulwJpIXvRJ2p\n\tmKbfNnrVbZB/IQu34n3czFoXDqPYK7280dTPBDDhj1dD5gaIgeYbpUV1PIURzEvO/Fmd\n\teQPGpfUjPbADDZT71nYrUJJ8BTLQ7VxeLC4b8DLTs+UFTyadChu74/DdrqsB/7mClnGI\n\tC0xh8zviYtYZZJ/PbtONGEObX2LGDLlXt4myodNfob/to7e8anarrgJxWM93oVgS4zpF\n\tWU4w==","X-Gm-Message-State":"AFqh2koPnOKW2Aesyd0no+Zxf2BPqG27382zHDmDXz7d/PIo/8wtANxk\n\tQQGLHXh/MccNb4TMfAYpHUsur3fnwkX5Cg9bBjBxkU+FV0C3DQnC","X-Google-Smtp-Source":"AMrXdXun34VA0aiP/hBIw5Um5GG8W8kysFFkkNHLOq5DAt3CnUhSPn/u1xEWZ9SjwBWnuH3/qqEivnWaMe3GV8ipThY=","X-Received":"by 2002:a81:8101:0:b0:38e:b5bc:e996 with SMTP id\n\tr1-20020a818101000000b0038eb5bce996mr2057211ywf.493.1673341312939;\n\tTue, 10 Jan 2023 01:01:52 -0800 (PST)","MIME-Version":"1.0","References":"<20221209090050.19441-1-naush@raspberrypi.com>","In-Reply-To":"<20221209090050.19441-1-naush@raspberrypi.com>","Date":"Tue, 10 Jan 2023 09:01:37 +0000","Message-ID":"","To":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"0000000000008bd1e505f1e52275\"","Subject":"Re: [libcamera-devel] [PATCH v4 00/12] Raspberry Pi: Platform\n\tconfiguration and buffer allocation improvements","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26227,"web_url":"https://patchwork.libcamera.org/comment/26227/","msgid":"","date":"2023-01-16T09:10:16","subject":"Re: [libcamera-devel] [PATCH v4 00/12] Raspberry Pi: Platform\n\tconfiguration and buffer allocation improvements","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Another ping. Anyone have time to provide some feedback?\n\nThanks,\nNaush\n\nOn Tue, 10 Jan 2023 at 09:01, Naushir Patuck wrote:\n\n> Hi all,\n>\n> Just a gentle ping to get some feedback on this series.\n>\n> Many thanks,\n> Naush\n>\n>\n> On Fri, 9 Dec 2022 at 09:01, Naushir Patuck wrote:\n>\n>> Hi,\n>>\n>> As mentioned in another email, this version fixes a minor regression\n>> introduced\n>> in version 3 where the delayed stream on for the ISP nodes causes some\n>> frame\n>> drops. This comes at the expense of allocating an additional buffer for\n>> the ISP\n>> output when we have to drop frames for 3A convergence.\n>>\n>> Thanks,\n>> Naush\n>>\n>> Naushir Patuck (12):\n>> libcamera: stream: Add stream hints to StreamConfiguration\n>> libcamera: pipeline: Add a platform configuration file helper\n>> pipeline: raspberrypi: Add a pipeline config structure\n>> pipeline: raspberrypi: Reorder startup drop frame initialisation\n>> pipeline: raspberrypi: Handle MandatoryRequestBuffer hints for Unicam\n>> Image\n>> libcamera: pipeline: build: Add pipeline_data_dir variable\n>> pipeline: raspberrypi: Read config parameters from a file\n>> pipeline: raspberrypi: Handle MandatoryRequestBuffer hints for ISP\n>> Output0\n>> pipeline: raspberrypi: Validate MandatoryRequestBuffer in\n>> queueRequestDevice()\n>> pipeline: raspberrypi: Add a parameter to disable startup drop frames\n>> pipeline: raspberrypi: Allow pipeline handler to always use the newest\n>> frame\n>> pipeline: raspberrypi: Add minimal memory usage config file\n>>\n>> include/libcamera/internal/pipeline_handler.h | 3 +\n>> include/libcamera/stream.h | 8 +\n>> src/libcamera/pipeline/meson.build | 3 +\n>> .../pipeline/raspberrypi/data/example.yaml | 29 +++\n>> .../pipeline/raspberrypi/data/meson.build | 9 +\n>> .../raspberrypi/data/minimal_mem.yaml | 29 +++\n>> .../pipeline/raspberrypi/meson.build | 2 +\n>> .../pipeline/raspberrypi/raspberrypi.cpp | 216 +++++++++++++++---\n>> src/libcamera/pipeline_handler.cpp | 60 +++++\n>> src/libcamera/stream.cpp | 24 ++\n>> 10 files changed, 352 insertions(+), 31 deletions(-)\n>> create mode 100644 src/libcamera/pipeline/raspberrypi/data/example.yaml\n>> create mode 100644 src/libcamera/pipeline/raspberrypi/data/meson.build\n>> create mode 100644\n>> src/libcamera/pipeline/raspberrypi/data/minimal_mem.yaml\n>>\n>> --\n>> 2.25.1\n>>\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA245BD87C\n\tfor ;\n\tMon, 16 Jan 2023 09:10:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4623F625E4;\n\tMon, 16 Jan 2023 10:10:36 +0100 (CET)","from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com\n\t[IPv6:2607:f8b0:4864:20::112c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 49826625CC\n\tfor ;\n\tMon, 16 Jan 2023 10:10:33 +0100 (CET)","by mail-yw1-x112c.google.com with SMTP id\n\t00721157ae682-4e9adf3673aso36008837b3.10\n\tfor ;\n\tMon, 16 Jan 2023 01:10:33 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1673860236;\n\tbh=0GZ1HP8y0E3a31rEuPOaSSXsCwRhuHl+Mhn78d+XMDo=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=MID17dv1Bm1ifHNzn35KbjDeOFgHutZtlkMGuHfoqVjzrTwNA61yahlAvVZJIxpwl\n\tEhv9EvbPySadXt+/hS0jO2PH52AyOt4klUQxscI52GS9YbfM+rmY4fh+131Jvuqspy\n\t2UdPerUdhpSClD9PIFHYv4Ht7CV5Gw04Nj3uuYcBkQJ5CC5cAVFku3ShKnCKmcpLkh\n\t5aogySX4QoIRWO1uCbcSvQxar322eZqgUX668eUsyAohT/THeaMWcEM+GfDxCbii/1\n\tBVvuuIPx1VYKNpFOjIZ+bTOtwTzccVXEv2PmpJuMAI66tg/kPuJoBGLlRByLHdC3v3\n\tu76fhB4YV3hkg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=47bPer4YyzhvmGxb5FAuWVh9cAk5P60rU6QGh0Ha+eA=;\n\tb=YNpElxa5sDSbFRFN9nz6DoZRqB/8osY89+IHwPWnQHFCilj8w0ky6qI/KuwOofHhQb\n\tZXrRHWw/PfgEhMdgG+abSXLDJyUeR4bfRYO9eyq61BFTf/ik4pXy8aDkUw05RgTMuiD/\n\trFzT7FCOuDDTiYPUEDBBIduWEcABQ+PvnqGVP73mjp2F8aat2Id3K88HPmy8ul+UMkka\n\ton8er9OpiC6GB64VDwPcCdximDAqOEvWgLY0wbVErbOtQkoo77PnfgtNOj2G6V1av+KG\n\tLQhMEpvnNLl20R4moGlmVwxkdB/zSlyz5JeD04ozNqR8EQXQ931QZ4HYJTKaXLjbOKqg\n\teUIQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"YNpElxa5\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=47bPer4YyzhvmGxb5FAuWVh9cAk5P60rU6QGh0Ha+eA=;\n\tb=ZFk3Yy+yIXpnwcUrO9TMDb0CRRblWy3VwwEXO/r1oHL20n4+XTvzU80XU/CJTocNx8\n\tG/KHxRDbo4DmgW8GK39xq0RucqcT58+sKjWiHcBx+Kqyk2EB79duXWmJXv/ttTb8Rh6P\n\tQD616WQUXSGhADOIiZ2oTuV6dMQHGAfD4EVYFUeDPudrIoCkirzV1aAtUVIZdByBjpXO\n\tE2rnWgwLJYFfWr6QygA/RwtaIVfuAb1K/9vHXGHXpm3cXe6owhmPutIZoJigJzy6fNLH\n\tL1J600GjHWSebujvv3hyzu+c304ggbHUEv3NUMOuvgA2+SjhMVBZuKgLTs8dj7yvg0KM\n\t3hEg==","X-Gm-Message-State":"AFqh2kobdd0yGUc1NMjS4X7benGLlHEigq1dQ3ibk+sLftmjR1ck5fvG\n\tj88WR0bvkTRRQcFPKBoOp3e27HWnJ8x7XxgGDvmmDB4G2k+so2NJ","X-Google-Smtp-Source":"AMrXdXstMLnwy2RxOint++oALEOoY1hZ74W5YTMiwJmQ/m3PfjhyrbU972GXHbQviJwuyfwXs766tZR6bNSs/WTU30s=","X-Received":"by 2002:a81:cc8:0:b0:38d:c23a:c541 with SMTP id\n\t191-20020a810cc8000000b0038dc23ac541mr4339933ywm.109.1673860231681;\n\tMon, 16 Jan 2023 01:10:31 -0800 (PST)","MIME-Version":"1.0","References":"<20221209090050.19441-1-naush@raspberrypi.com>\n\t","In-Reply-To":"","Date":"Mon, 16 Jan 2023 09:10:16 +0000","Message-ID":"","To":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"00000000000083724f05f25df405\"","Subject":"Re: [libcamera-devel] [PATCH v4 00/12] Raspberry Pi: Platform\n\tconfiguration and buffer allocation improvements","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]