[{"id":26031,"web_url":"https://patchwork.libcamera.org/comment/26031/","msgid":"<87bfea86-bedc-091a-4311-7d753fc16312@yoseli.org>","date":"2022-12-08T18:13:35","subject":"Re: [libcamera-devel] [PATCH 0/5] ipa: rapsberrypi: Introduce\n\tauto-focus (auto-mode)","submitter":{"id":127,"url":"https://patchwork.libcamera.org/api/people/127/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@yoseli.org"},"content":"Hi Umang,\n\nOn 01/12/2022 15:51, Umang Jain via libcamera-devel wrote:\n> Introduce the auto-focus working in auto mode. This is a split-off from\n> https://patchwork.libcamera.org/project/libcamera/list/?series=3174\n> series.\n> \n> The patches have been tested by me on IMX519 module with ak7375 VCM,\n> with mainline v6.1 **kernel.\n> (I'll add T-b tags manually on the list)\n> \n> Only the auto mode is tested and the state machine hasn't been.\n> I believe that shouldn't be an issue provided there was not reviews on\n> the auto-focus series. If someone thinks that the state machine patches\n> (patch 5/10 to patch 10/10) of the parent should be bundled as well,\n> please speak up (it will need more testing on my end though). That\n> doesn't mean the state machine will not be posted / integrated - it's\n> just that I am not confident enough on those because I myself haven't\n> got a chance to try them inside out.\n\nGlad to see someone took it back :).\nI can understand why you wouldn't take it it might very well need a bit \nof rework.\n\nThanks !\n\n> \n> Samples are available at:\n> https://drive.google.com/drive/folders/14BKHXATZ_mZCrm27wCB5TxqTQnGmfGFq?usp=sharing\n> \n> ** The kernel branch comprised of unicam + bcm2835-isp driver(meant to\n> go upstream). Along with that IMX519 v3 patches [1] and ak7375 regulator\n> support [2] was cherry-pick manually. This is was the test setup to test\n> this series on RPi-4-Model-B.\n> \n> [1]: https://lore.kernel.org/linux-media/20221116091855.00007ebd@arducam.com/\n> [2]: https://lore.kernel.org/linux-media/20220711144039.232196-1-y.oudjana@protonmail.com/\n> \n> Jean-Michel Hautbois (4):\n> ipa: raspberrypi: Introduce an autofocus algorithm\n> libcamera: raspberrypi: Control the lens from pipeline\n> ipa: raspberrypi: Control the lens position\n> ipa: raspberrypi: Send the AF status back\n> \n> Umang Jain (1):\n> ipa: raspberrypi: imx519: Instantiate auto-focus algorithm\n> \n> include/libcamera/ipa/raspberrypi.mojom | 1 +\n> src/ipa/raspberrypi/controller/af_algorithm.h | 33 +++\n> src/ipa/raspberrypi/controller/af_status.h | 21 ++\n> src/ipa/raspberrypi/controller/iob/af.cpp | 212 ++++++++++++++++++\n> src/ipa/raspberrypi/controller/iob/af.h | 62 +++++\n> src/ipa/raspberrypi/data/imx519.json | 5 +-\n> src/ipa/raspberrypi/meson.build | 1 +\n> src/ipa/raspberrypi/raspberrypi.cpp | 45 +++-\n> .../pipeline/raspberrypi/raspberrypi.cpp | 17 ++\n> 9 files changed, 394 insertions(+), 3 deletions(-)\n> create mode 100644 src/ipa/raspberrypi/controller/af_algorithm.h\n> create mode 100644 src/ipa/raspberrypi/controller/af_status.h\n> create mode 100644 src/ipa/raspberrypi/controller/iob/af.cpp\n> create mode 100644 src/ipa/raspberrypi/controller/iob/af.h\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EEDDBBE08B\n\tfor ;\n\tThu, 8 Dec 2022 18:13:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6128063351;\n\tThu, 8 Dec 2022 19:13:38 +0100 (CET)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E7776333B\n\tfor ;\n\tThu, 8 Dec 2022 19:13:37 +0100 (CET)","(Authenticated sender: jeanmichel.hautbois@yoseli.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 7EFC060009;\n\tThu, 8 Dec 2022 18:13:36 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670523218;\n\tbh=qwuF3EFcN8DEk7YELZy5NYFSPwHzRIaZzAky4v/u2g8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=bwxw2UsJ9n+5V3IUA7eCBks3C8Ps3V6BnyU41ZEpfu8V6xAI9joRpvWQfs5qyqdut\n\tCURKmrdsYn416V/eldXYSE9J1LfOXD8ABpRkNEt5j/PcRcBhp+AIWLX9GzKjZPZgne\n\tz5zc7zdVKLhLemN+q13rxnBnPV0iTjOzmggIvC+9hNe8n2ROM4+jjrZDZjSyl5S/b8\n\tuT0UiWMdBAWuLFSTpm6ZELr50l6UJ73E0IJ94g8FMG7vfmlJuBqnVzYa3fmbLWFEKc\n\ttLYzSIwPu2md9IhAwZ40Ed8UblQ3J8/UXmlYLWoOAA3w0m5df60ginfBT8lv4aX0Hb\n\tYGM2oq1CxfAYA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=yoseli.org; s=gm1;\n\tt=1670523216;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=NzHxUDwfFa07h5FmjWal1Ca2CdfhgFK6x8vcqPrjQAU=;\n\tb=mUHmwI6+8pTVF6MzzMQWTITDaoQiSS3yVbkjQPAFh+vjyHqw6b8v1r7KFcFKKjEttNLq+7\n\t75LubJF3/SNUxwAqGcW1eV3OEZtHedDRFxr+zDYFNwgbw46ksBp3QnX8trtd30T0+/gkCh\n\tMmXK5p1X8iohHaHrW5/OaErrhoR6vz4Ad37wkp3cuCgIs9uuwG74Q9EfD4OHReVyWR6qxo\n\tuGF/OL09SqCtEsTvgsOql+sDuFo2BICz+y/JmRW0OxhkHR6uNvLHJrxb/kHiKTVEMgxY08\n\tFNB9CDb0PcJn6B42w5o1zhV82mfAfq5nOrLBHukRKtRIV/48GGEIgptYqxJ3Vg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=yoseli.org\n\theader.i=@yoseli.org header.b=\"mUHmwI6+\"; \n\tdkim-atps=neutral","Message-ID":"<87bfea86-bedc-091a-4311-7d753fc16312@yoseli.org>","Date":"Thu, 8 Dec 2022 19:13:35 +0100","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.4.2","Content-Language":"en-US","To":"Umang Jain ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20221201145133.479794-1-umang.jain@ideasonboard.com>","In-Reply-To":"<20221201145133.479794-1-umang.jain@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 0/5] ipa: rapsberrypi: Introduce\n\tauto-focus (auto-mode)","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jean-Michel Hautbois via libcamera-devel\n\t","Reply-To":"Jean-Michel Hautbois ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]