[{"id":25951,"web_url":"https://patchwork.libcamera.org/comment/25951/","msgid":"<166989032191.3691396.888467205021095347@Monstersaurus>","date":"2022-12-01T10:25:21","subject":"Re: [libcamera-devel] [PATCH v7 0/6] Add CrOS JEA implementation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Harvey,\n\nQuoting Harvey Yang via libcamera-devel (2022-12-01 09:27:27)\n> Rebased and fixed some merge conflicts on the master branch.\n> Please check if it's ready to merge.\n> Thanks!\n\nOne of our usual key requirements for merge are at least two reviewers\nhaving reviewed and provided reviewed-by tags (after working through any\nidentified issues and discussions).\n\nAs this component is greatly affecting the Android layer which is used\nextensively by ChromeOS ... could we have one of the required reviewers\nand testers being from Google or Chromium teams please?\n\nProviding a reference to results from running CTS would also be\nbeneficial here.\n\n--\nKieran\n\n\n> BR,\n> Harvey\n> \n> \n> Harvey Yang (6):\n> Allow inheritance of FrameBuffer\n> Add HALFrameBuffer and replace FrameBuffer in src/android\n> Add meson.build in src/android/jpeg\n> Move generateThumbnail from PostProcessorJpeg to Encoder\n> Pass StreamBuffer to Encoder::encoder\n> Add JEA implementation\n> \n> include/libcamera/framebuffer.h | 3 +-\n> src/android/camera_device.cpp | 3 +-\n> src/android/cros/camera3_hal.cpp | 2 +\n> src/android/cros_mojo_token.h | 12 ++\n> src/android/frame_buffer_allocator.h | 7 +-\n> src/android/hal_framebuffer.cpp | 22 +++\n> src/android/hal_framebuffer.h | 26 ++++\n> src/android/jpeg/encoder.h | 10 +-\n> src/android/jpeg/encoder_jea.cpp | 93 ++++++++++++\n> src/android/jpeg/encoder_jea.h | 35 +++++\n> src/android/jpeg/encoder_libjpeg.cpp | 133 ++++++++++++++----\n> src/android/jpeg/encoder_libjpeg.h | 33 ++++-\n> src/android/jpeg/meson.build | 16 +++\n> src/android/jpeg/post_processor_jpeg.cpp | 65 ++-------\n> src/android/jpeg/post_processor_jpeg.h | 11 +-\n> src/android/meson.build | 6 +-\n> .../mm/cros_frame_buffer_allocator.cpp | 9 +-\n> .../mm/generic_frame_buffer_allocator.cpp | 11 +-\n> 18 files changed, 385 insertions(+), 112 deletions(-)\n> create mode 100644 src/android/cros_mojo_token.h\n> create mode 100644 src/android/hal_framebuffer.cpp\n> create mode 100644 src/android/hal_framebuffer.h\n> create mode 100644 src/android/jpeg/encoder_jea.cpp\n> create mode 100644 src/android/jpeg/encoder_jea.h\n> create mode 100644 src/android/jpeg/meson.build\n> \n> -- \n> 2.38.1.584.g0f3c55d4c2-goog\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 29C39BDE6B\n\tfor ;\n\tThu, 1 Dec 2022 10:25:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B26B6333E;\n\tThu, 1 Dec 2022 11:25:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C8BC63326\n\tfor ;\n\tThu, 1 Dec 2022 11:25:25 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 08C1D33F;\n\tThu, 1 Dec 2022 11:25:24 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669890326;\n\tbh=LZn2LgW2mgPmMAXTj1R5CV0+tkzxlIUpUEXiDLJFNu8=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=M+tFZ0SDKWqvkmmB7/JW+UH5oNNRX369Wv0vuZUEqdMfuphQuqAT2V9hpQIbUBKbL\n\tX6ujVLqO+BxlDUZMzHJAcN/wrk/LtDBs4hhG0s6b4hTravbXfHoionR0LvBAGYse15\n\tR9O5ADLLDzl6lF8hm3h+a2ksiVB9J/E94MwIgftY0sGnF0Mt8I0BBI/H9fbLeooelX\n\tV6gBiJPn/3mp4Uh/w/YBSVm49a/aRfMHjhcZfpNhpLl2p+0vm3fFP5xCdZsOHOLhKi\n\tZdf140eJhLef8viiZ/fw08TCN5sZe7k4g3lAgiHOvZg30D028lE5qa5rS0/hxuUKrm\n\tXA+yh51rB5Hfw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1669890325;\n\tbh=LZn2LgW2mgPmMAXTj1R5CV0+tkzxlIUpUEXiDLJFNu8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=pMWF0hXTMRr2iMGDrtZw6+qj7VvsaMnlH1bj5f9SLVEk/k7oVtdU+IkcVkt/mBv3A\n\tWr4dvHYBz46yRZqqoeq9vlS9iSJ6qfi1VpKkGJaEn1EJLOkYjngp0LioF72D+Op9Sj\n\tnWp1AYano6C+gVZimNbuABI+zyK5o7VpBFbc4V4M="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"pMWF0hXT\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20221201092733.2042078-1-chenghaoyang@google.com>","References":"<20221201092733.2042078-1-chenghaoyang@google.com>","To":"Harvey Yang ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 01 Dec 2022 10:25:21 +0000","Message-ID":"<166989032191.3691396.888467205021095347@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v7 0/6] Add CrOS JEA implementation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Harvey Yang ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26016,"web_url":"https://patchwork.libcamera.org/comment/26016/","msgid":"","date":"2022-12-07T05:59:15","subject":"Re: [libcamera-devel] [PATCH v7 0/6] Add CrOS JEA implementation","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"content":"Hi Kieran,\n\nI see, while I actually found that the patch leads to a flaky crash in cros\ncamera service. I'm still debugging with Han-lin. After I find the root\ncause,\nI'll ask Tomasz to take a look. And I'll also provide the CTS result.\n\nOn Thu, Dec 1, 2022 at 6:25 PM Kieran Bingham <\nkieran.bingham@ideasonboard.com> wrote:\n\n> Hi Harvey,\n>\n> Quoting Harvey Yang via libcamera-devel (2022-12-01 09:27:27)\n> > Rebased and fixed some merge conflicts on the master branch.\n> > Please check if it's ready to merge.\n> > Thanks!\n>\n> One of our usual key requirements for merge are at least two reviewers\n> having reviewed and provided reviewed-by tags (after working through any\n> identified issues and discussions).\n>\n> As this component is greatly affecting the Android layer which is used\n> extensively by ChromeOS ... could we have one of the required reviewers\n> and testers being from Google or Chromium teams please?\n>\n> Providing a reference to results from running CTS would also be\n> beneficial here.\n>\n> --\n> Kieran\n>\n>\n> > BR,\n> > Harvey\n> >\n> >\n> > Harvey Yang (6):\n> > Allow inheritance of FrameBuffer\n> > Add HALFrameBuffer and replace FrameBuffer in src/android\n> > Add meson.build in src/android/jpeg\n> > Move generateThumbnail from PostProcessorJpeg to Encoder\n> > Pass StreamBuffer to Encoder::encoder\n> > Add JEA implementation\n> >\n> > include/libcamera/framebuffer.h | 3 +-\n> > src/android/camera_device.cpp | 3 +-\n> > src/android/cros/camera3_hal.cpp | 2 +\n> > src/android/cros_mojo_token.h | 12 ++\n> > src/android/frame_buffer_allocator.h | 7 +-\n> > src/android/hal_framebuffer.cpp | 22 +++\n> > src/android/hal_framebuffer.h | 26 ++++\n> > src/android/jpeg/encoder.h | 10 +-\n> > src/android/jpeg/encoder_jea.cpp | 93 ++++++++++++\n> > src/android/jpeg/encoder_jea.h | 35 +++++\n> > src/android/jpeg/encoder_libjpeg.cpp | 133 ++++++++++++++----\n> > src/android/jpeg/encoder_libjpeg.h | 33 ++++-\n> > src/android/jpeg/meson.build | 16 +++\n> > src/android/jpeg/post_processor_jpeg.cpp | 65 ++-------\n> > src/android/jpeg/post_processor_jpeg.h | 11 +-\n> > src/android/meson.build | 6 +-\n> > .../mm/cros_frame_buffer_allocator.cpp | 9 +-\n> > .../mm/generic_frame_buffer_allocator.cpp | 11 +-\n> > 18 files changed, 385 insertions(+), 112 deletions(-)\n> > create mode 100644 src/android/cros_mojo_token.h\n> > create mode 100644 src/android/hal_framebuffer.cpp\n> > create mode 100644 src/android/hal_framebuffer.h\n> > create mode 100644 src/android/jpeg/encoder_jea.cpp\n> > create mode 100644 src/android/jpeg/encoder_jea.h\n> > create mode 100644 src/android/jpeg/meson.build\n> >\n> > --\n> > 2.38.1.584.g0f3c55d4c2-goog\n> >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EA995BDE6B\n\tfor ;\n\tWed, 7 Dec 2022 05:59:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D9736333F;\n\tWed, 7 Dec 2022 06:59:29 +0100 (CET)","from mail-vs1-xe34.google.com (mail-vs1-xe34.google.com\n\t[IPv6:2607:f8b0:4864:20::e34])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB2E461F1C\n\tfor ;\n\tWed, 7 Dec 2022 06:59:27 +0100 (CET)","by mail-vs1-xe34.google.com with SMTP id q128so16280190vsa.13\n\tfor ;\n\tTue, 06 Dec 2022 21:59:27 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670392769;\n\tbh=qVXmxj+WTPb8BFO286cHK6kxSatOeX8YzUV6WAKCsuM=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=RGRr8XCTeYHkKvimgFRMkrDu3u9qp6lK5bHn3XB7wv8uiFFSIUhZAPDXozdI7lkdd\n\tfWe57uDh4sO1d67EagslmKZ5oq8Bb0AXPEju8Ut1uhuZet+f5PynHuG1p9QkcuG3Kq\n\tztOFCRul0EMOtn/itiLsCjCk2EgnPa9GqJ0nz0oH1JNtBUIYxZ/ClbO4SRMkPptct4\n\tVf119U7U5QusK1Tqm7XmTEofV6FPEdiZJaRTrj2nFxPiV66B934/4wJo97pjp1aPgX\n\tIx1d+81kQT/5w3v09xG6d0Qns7sziTVJ9+PwRlW2xhlmlNsJGZdF73x0uMT8OA65v7\n\t4INInQdhtgrUg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=ObDcy0ZNJaO/ZBgbJrXU7HQuChv5fwPa90IrnvINKuM=;\n\tb=AtqHDLaGPpaCQcN9DO+xZfJYh09grneUTdpAQTUn9kBb4n5LQNcW+CjjaYnhIGvIOK\n\t1Fibi0uF8fI8NI1VYW2fFHgnaU8YO3+RgVUlB6ORZaPzL76XxnUtyA1zTv7wkWPqW9m+\n\tOuvlA7ueGdCWhnmnkYAiJTDcaAljsmuqQQ5fA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"AtqHDLaG\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=ObDcy0ZNJaO/ZBgbJrXU7HQuChv5fwPa90IrnvINKuM=;\n\tb=thkJyo6Hacw6BXUPvA0C8K1yoOiE32kVm4inS+nSzqHvu4wVgpsNQYUFY5WxPdKJYt\n\tgUfR7NQzY0/aNu5B9kMHnK8a/6JcO8MvMLscg8pit3NDth4u5iUSYGX00kjbb6B9jrHz\n\t09WZM7Mn0k9aNVHjbF7cYLGBZmQ/+qG5LMDu75Uky180Nl8Kp+frGsn1cleAvc9mF7gR\n\tU+/6iVDtaBDYiJAUFSgIG67eoFd7MY2HHt71rk1zq62C3m6xWv8joh7Au7XrOAmOTcuC\n\tDm6nxgRvEVycCXrh69jOYkDxr3xRMiXstBqn9PE0wyaDqe0KcDyRzh/82C04ddp3MIMx\n\teu/g==","X-Gm-Message-State":"ANoB5pkbmbWm3mO38I2QOiz4J3OgyferfTkG215TavIg2foytgQQQxiQ\n\tQ4WPXJhm8/8mo0+Yu9nCno0wSppOuE6WRCJMmQUjKA==","X-Google-Smtp-Source":"AA0mqf7dfosw9fXVhb8lCSh2GQfwpXX/F7EhRle4cazM05uoL7CD9YRPyW/7uKwhI+mKJJ60n4SwFtlarSBH43T0zz8=","X-Received":"by 2002:a05:6102:370a:b0:3af:c63c:5536 with SMTP id\n\ts10-20020a056102370a00b003afc63c5536mr46987255vst.85.1670392766614;\n\tTue, 06 Dec 2022 21:59:26 -0800 (PST)","MIME-Version":"1.0","References":"<20221201092733.2042078-1-chenghaoyang@google.com>\n\t<166989032191.3691396.888467205021095347@Monstersaurus>","In-Reply-To":"<166989032191.3691396.888467205021095347@Monstersaurus>","Date":"Wed, 7 Dec 2022 13:59:15 +0800","Message-ID":"","To":"Kieran Bingham ","Content-Type":"multipart/alternative; boundary=\"0000000000007d664a05ef369f48\"","Subject":"Re: [libcamera-devel] [PATCH v7 0/6] Add CrOS JEA implementation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Cheng-Hao Yang via libcamera-devel\n\t","Reply-To":"Cheng-Hao Yang ","Cc":"Harvey Yang ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26062,"web_url":"https://patchwork.libcamera.org/comment/26062/","msgid":"","date":"2022-12-14T09:12:27","subject":"Re: [libcamera-devel] [PATCH v7 0/6] Add CrOS JEA implementation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Harvey,\n\nOn Wed, Dec 07, 2022 at 01:59:15PM +0800, Cheng-Hao Yang via libcamera-devel wrote:\n> Hi Kieran,\n> \n> I see, while I actually found that the patch leads to a flaky crash in cros\n> camera service. I'm still debugging with Han-lin. After I find the root cause,\n> I'll ask Tomasz to take a look. And I'll also provide the CTS result.\n\nThank you.\n\nI was wondering if you'd like any help with the review comments I've\nsent, in particular with the proposed refactoring of the libjpeg-based\nencoder.\n\n> On Thu, Dec 1, 2022 at 6:25 PM Kieran Bingham wrote:\n> > Quoting Harvey Yang via libcamera-devel (2022-12-01 09:27:27)\n> > > Rebased and fixed some merge conflicts on the master branch.\n> > > Please check if it's ready to merge.\n> > > Thanks!\n> >\n> > One of our usual key requirements for merge are at least two reviewers\n> > having reviewed and provided reviewed-by tags (after working through any\n> > identified issues and discussions).\n> >\n> > As this component is greatly affecting the Android layer which is used\n> > extensively by ChromeOS ... could we have one of the required reviewers\n> > and testers being from Google or Chromium teams please?\n> >\n> > Providing a reference to results from running CTS would also be\n> > beneficial here.\n> >\n> > > Harvey Yang (6):\n> > > Allow inheritance of FrameBuffer\n> > > Add HALFrameBuffer and replace FrameBuffer in src/android\n> > > Add meson.build in src/android/jpeg\n> > > Move generateThumbnail from PostProcessorJpeg to Encoder\n> > > Pass StreamBuffer to Encoder::encoder\n> > > Add JEA implementation\n> > >\n> > > include/libcamera/framebuffer.h | 3 +-\n> > > src/android/camera_device.cpp | 3 +-\n> > > src/android/cros/camera3_hal.cpp | 2 +\n> > > src/android/cros_mojo_token.h | 12 ++\n> > > src/android/frame_buffer_allocator.h | 7 +-\n> > > src/android/hal_framebuffer.cpp | 22 +++\n> > > src/android/hal_framebuffer.h | 26 ++++\n> > > src/android/jpeg/encoder.h | 10 +-\n> > > src/android/jpeg/encoder_jea.cpp | 93 ++++++++++++\n> > > src/android/jpeg/encoder_jea.h | 35 +++++\n> > > src/android/jpeg/encoder_libjpeg.cpp | 133 ++++++++++++++----\n> > > src/android/jpeg/encoder_libjpeg.h | 33 ++++-\n> > > src/android/jpeg/meson.build | 16 +++\n> > > src/android/jpeg/post_processor_jpeg.cpp | 65 ++-------\n> > > src/android/jpeg/post_processor_jpeg.h | 11 +-\n> > > src/android/meson.build | 6 +-\n> > > .../mm/cros_frame_buffer_allocator.cpp | 9 +-\n> > > .../mm/generic_frame_buffer_allocator.cpp | 11 +-\n> > > 18 files changed, 385 insertions(+), 112 deletions(-)\n> > > create mode 100644 src/android/cros_mojo_token.h\n> > > create mode 100644 src/android/hal_framebuffer.cpp\n> > > create mode 100644 src/android/hal_framebuffer.h\n> > > create mode 100644 src/android/jpeg/encoder_jea.cpp\n> > > create mode 100644 src/android/jpeg/encoder_jea.h\n> > > create mode 100644 src/android/jpeg/meson.build","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B851FBDE6B\n\tfor ;\n\tWed, 14 Dec 2022 09:12:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2112F63362;\n\tWed, 14 Dec 2022 10:12:33 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C08AC603D0\n\tfor ;\n\tWed, 14 Dec 2022 10:12:31 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EB9508B;\n\tWed, 14 Dec 2022 10:12:30 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671009153;\n\tbh=jIfRcoMIyVFG36XFA73jUrFxIzo2nx8PgIJJzFkj9lk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=dFzb9fqpazfvSp74HAUVJgX0evsZP3oofgpG6RCfxWR3qNL9JZ/KebnDm7t+QoMHV\n\tBqOJwchKQOAYcbcLl8tAeCpMXRgaJgXlWgUw8xIRUPYTfZKQK2M0ZJxNCGd2urj1Zu\n\tk9LUQPEG5x61o/GxI9sjKZc/frWiJXOMAD0XgdQTuHVJs1SIinteQ3YPbrVJ6maW3o\n\tlB0+RkK/ipA54Z324GJfAUjYQPLiEF82hgLQ4LdpzIjXm7p92CifzGgMTp2Ttwj61a\n\tST+Y10gi/lsdCjSEJsO5O9pujIKguv9BIJqKdJQEG0FngWOPcObzTS8Ia55K6X8KvF\n\tpwLNpALYKRxOA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1671009151;\n\tbh=jIfRcoMIyVFG36XFA73jUrFxIzo2nx8PgIJJzFkj9lk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HL+TAQ8oJBM+6TwjqHoWpdBQhQlchPy4g2XxuHwmR6ZQv5vDs0avSGYWUhjgGanc/\n\tsH26OGWSd/lpfYSpqN8l8mpGimQnvf7UhQta4xqWH+9vfFtVMHCHr3JoPbJMDWF7a6\n\tWaRx3A+RoFdWUAihmnqSV97gHSlTrVn+rfKHYspo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"HL+TAQ8o\"; dkim-atps=neutral","Date":"Wed, 14 Dec 2022 11:12:27 +0200","To":"Cheng-Hao Yang ","Message-ID":"","References":"<20221201092733.2042078-1-chenghaoyang@google.com>\n\t<166989032191.3691396.888467205021095347@Monstersaurus>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v7 0/6] Add CrOS JEA implementation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Harvey Yang ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26063,"web_url":"https://patchwork.libcamera.org/comment/26063/","msgid":"","date":"2022-12-14T09:13:29","subject":"Re: [libcamera-devel] [PATCH v7 0/6] Add CrOS JEA implementation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Dec 14, 2022 at 11:12:29AM +0200, Laurent Pinchart wrote:\n> Hi Harvey,\n\nSorry, I still need to wake up :-) The comment about help with\nrefactoring was for Harvey, but I of course meant Cheng-Hao here.\n\n> On Wed, Dec 07, 2022 at 01:59:15PM +0800, Cheng-Hao Yang via libcamera-devel wrote:\n> > Hi Kieran,\n> > \n> > I see, while I actually found that the patch leads to a flaky crash in cros\n> > camera service. I'm still debugging with Han-lin. After I find the root cause,\n> > I'll ask Tomasz to take a look. And I'll also provide the CTS result.\n> \n> Thank you.\n> \n> I was wondering if you'd like any help with the review comments I've\n> sent, in particular with the proposed refactoring of the libjpeg-based\n> encoder.\n> \n> > On Thu, Dec 1, 2022 at 6:25 PM Kieran Bingham wrote:\n> > > Quoting Harvey Yang via libcamera-devel (2022-12-01 09:27:27)\n> > > > Rebased and fixed some merge conflicts on the master branch.\n> > > > Please check if it's ready to merge.\n> > > > Thanks!\n> > >\n> > > One of our usual key requirements for merge are at least two reviewers\n> > > having reviewed and provided reviewed-by tags (after working through any\n> > > identified issues and discussions).\n> > >\n> > > As this component is greatly affecting the Android layer which is used\n> > > extensively by ChromeOS ... could we have one of the required reviewers\n> > > and testers being from Google or Chromium teams please?\n> > >\n> > > Providing a reference to results from running CTS would also be\n> > > beneficial here.\n> > >\n> > > > Harvey Yang (6):\n> > > > Allow inheritance of FrameBuffer\n> > > > Add HALFrameBuffer and replace FrameBuffer in src/android\n> > > > Add meson.build in src/android/jpeg\n> > > > Move generateThumbnail from PostProcessorJpeg to Encoder\n> > > > Pass StreamBuffer to Encoder::encoder\n> > > > Add JEA implementation\n> > > >\n> > > > include/libcamera/framebuffer.h | 3 +-\n> > > > src/android/camera_device.cpp | 3 +-\n> > > > src/android/cros/camera3_hal.cpp | 2 +\n> > > > src/android/cros_mojo_token.h | 12 ++\n> > > > src/android/frame_buffer_allocator.h | 7 +-\n> > > > src/android/hal_framebuffer.cpp | 22 +++\n> > > > src/android/hal_framebuffer.h | 26 ++++\n> > > > src/android/jpeg/encoder.h | 10 +-\n> > > > src/android/jpeg/encoder_jea.cpp | 93 ++++++++++++\n> > > > src/android/jpeg/encoder_jea.h | 35 +++++\n> > > > src/android/jpeg/encoder_libjpeg.cpp | 133 ++++++++++++++----\n> > > > src/android/jpeg/encoder_libjpeg.h | 33 ++++-\n> > > > src/android/jpeg/meson.build | 16 +++\n> > > > src/android/jpeg/post_processor_jpeg.cpp | 65 ++-------\n> > > > src/android/jpeg/post_processor_jpeg.h | 11 +-\n> > > > src/android/meson.build | 6 +-\n> > > > .../mm/cros_frame_buffer_allocator.cpp | 9 +-\n> > > > .../mm/generic_frame_buffer_allocator.cpp | 11 +-\n> > > > 18 files changed, 385 insertions(+), 112 deletions(-)\n> > > > create mode 100644 src/android/cros_mojo_token.h\n> > > > create mode 100644 src/android/hal_framebuffer.cpp\n> > > > create mode 100644 src/android/hal_framebuffer.h\n> > > > create mode 100644 src/android/jpeg/encoder_jea.cpp\n> > > > create mode 100644 src/android/jpeg/encoder_jea.h\n> > > > create mode 100644 src/android/jpeg/meson.build","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E2C93BDE6B\n\tfor ;\n\tWed, 14 Dec 2022 09:13:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9EDF363362;\n\tWed, 14 Dec 2022 10:13:35 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5776603D0\n\tfor ;\n\tWed, 14 Dec 2022 10:13:33 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 36D0F499;\n\tWed, 14 Dec 2022 10:13:33 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671009215;\n\tbh=iCN3vzlGjnaQSx41BGgBPevnNjI97CtxAbLKud7nyns=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=fews7/xg6uPf5bUvdpStvCU9Iv/2jaIJq4WJTqhnK5pAInyZksScvy+uaC8okt0Tx\n\tWsF4ILAD19K4c09BoFPgfI46iTE7MSvaz3kWtdFoOAB1Fyzln5HX5+UYyKFJBGWzm9\n\tK1utG3pLc9elVKi8uqluwLZKjbgGo9iJtiRc8iZBn+bD+t5BJsxMkj0lLte2Jo6F/o\n\tT1xVmDhhQTGkB0tXyrkqxypERA8q95YOVNC9UiwxyLI5rEzmQgIOFZU4L4YbDKJbE4\n\tncX7O/k0XI4cECpHppy6/Ibeb0VHOaT7dWoGBRgquOFTM42DBPlK2quQj4j0xYUR0r\n\tthnyEXinjPdIQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1671009213;\n\tbh=iCN3vzlGjnaQSx41BGgBPevnNjI97CtxAbLKud7nyns=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Cos/gbOfBoEOpFiLz440vYdnO3YwLBUc6NHWJMgF/6WZrFWZyWO1PyVKlvaGLbCpG\n\tR0t1hRTyGZlyEnRwVSwIAeC9lF24P+IzDTrppfCziwEYmhJQ54z65TVeGi2pNRMutj\n\tnieFJNTtnIIorvZ3aMlqGsl75P0ksxNIzb+Aaq2w="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Cos/gbOf\"; dkim-atps=neutral","Date":"Wed, 14 Dec 2022 11:13:29 +0200","To":"Cheng-Hao Yang ","Message-ID":"","References":"<20221201092733.2042078-1-chenghaoyang@google.com>\n\t<166989032191.3691396.888467205021095347@Monstersaurus>\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v7 0/6] Add CrOS JEA implementation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Harvey Yang ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26065,"web_url":"https://patchwork.libcamera.org/comment/26065/","msgid":"","date":"2022-12-14T09:34:32","subject":"Re: [libcamera-devel] [PATCH v7 0/6] Add CrOS JEA implementation","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"content":"Hi Laurent,\n\n\n\nOn Wed, Dec 14, 2022 at 5:13 PM Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> On Wed, Dec 14, 2022 at 11:12:29AM +0200, Laurent Pinchart wrote:\n> > Hi Harvey,\n>\n> Sorry, I still need to wake up :-) The comment about help with\n> refactoring was for Harvey, but I of course meant Cheng-Hao here.\n>\n> > On Wed, Dec 07, 2022 at 01:59:15PM +0800, Cheng-Hao Yang via\n> libcamera-devel wrote:\n> > > Hi Kieran,\n> > >\n> > > I see, while I actually found that the patch leads to a flaky crash in\n> cros\n> > > camera service. I'm still debugging with Han-lin. After I find the\n> root cause,\n> > > I'll ask Tomasz to take a look. And I'll also provide the CTS result.\n> >\n> > Thank you.\n> >\n> > I was wondering if you'd like any help with the review comments I've\n> > sent, in particular with the proposed refactoring of the libjpeg-based\n> > encoder.\n> >\n\n\nDefinitely. Sorry for the belated reply. I wanted to solve the flaky issue\naltogether\nbefore sending the new version of patches.\nSorry for the delay!\n\n\n>\n> > > On Thu, Dec 1, 2022 at 6:25 PM Kieran Bingham wrote:\n> > > > Quoting Harvey Yang via libcamera-devel (2022-12-01 09:27:27)\n> > > > > Rebased and fixed some merge conflicts on the master branch.\n> > > > > Please check if it's ready to merge.\n> > > > > Thanks!\n> > > >\n> > > > One of our usual key requirements for merge are at least two\n> reviewers\n> > > > having reviewed and provided reviewed-by tags (after working through\n> any\n> > > > identified issues and discussions).\n> > > >\n> > > > As this component is greatly affecting the Android layer which is\n> used\n> > > > extensively by ChromeOS ... could we have one of the required\n> reviewers\n> > > > and testers being from Google or Chromium teams please?\n> > > >\n> > > > Providing a reference to results from running CTS would also be\n> > > > beneficial here.\n> > > >\n> > > > > Harvey Yang (6):\n> > > > > Allow inheritance of Fra\n\nHarvey Yang \nThu, Dec 1, 5:27 PM (13 days ago)\n\nto libcamera-devel, Harvey\n\nRebased and fixed some merge conflicts on the master branch.\nPlease check if it's ready to merge.\nThanks!\n\n> meBuffer\n> > > > > Add HALFrameBuffer and replace FrameBuffer in src/android\n> > > > > Add meson.build in src/android/jpeg\n> > > > > Move generateThumbnail from PostProcessorJpeg to Encoder\n> > > > > Pass StreamBuffer to Encoder::encoder\n> > > > > Add JEA implementation\n> > > > >\n> > > > > include/libcamera/framebuffer.h | 3 +-\n> > > > > src/android/camera_device.cpp | 3 +-\n> > > > > src/android/cros/camera3_hal.cpp | 2 +\n> > > > > src/android/cros_mojo_token.h | 12 ++\n> > > > > src/android/frame_buffer_allocator.h | 7 +-\n> > > > > src/android/hal_framebuffer.cpp | 22 +++\n> > > > > src/android/hal_framebuffer.h | 26 ++++\n> > > > > src/android/jpeg/encoder.h | 10 +-\n> > > > > src/android/jpeg/encoder_jea.cpp | 93 ++++++++++++\n> > > > > src/android/jpeg/encoder_jea.h | 35 +++++\n> > > > > src/android/jpeg/encoder_libjpeg.cpp | 133\n> ++++++++++++++----\n> > > > > src/android/jpeg/encoder_libjpeg.h | 33 ++++-\n> > > > > src/android/jpeg/meson.build | 16 +++\n> > > > > src/android/jpeg/post_processor_jpeg.cpp | 65 ++-------\n> > > > > src/android/jpeg/post_processor_jpeg.h | 11 +-\n> > > > > src/android/meson.build | 6 +-\n> > > > > .../mm/cros_frame_buffer_allocator.cpp | 9 +-\n> > > > > .../mm/generic_frame_buffer_allocator.cpp | 11 +-\n> > > > > 18 files changed, 385 insertions(+), 112 deletions(-)\n> > > > > create mode 100644 src/android/cros_mojo_token.h\n> > > > > create mode 100644 src/android/hal_framebuffer.cpp\n> > > > > create mode 100644 src/android/hal_framebuffer.h\n> > > > > create mode 100644 src/android/jpeg/encoder_jea.cpp\n> > > > > create mode 100644 src/android/jpeg/encoder_jea.h\n> > > > > create mode 100644 src/android/jpeg/meson.build\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1CD80BDE6B\n\tfor ;\n\tWed, 14 Dec 2022 09:34:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D1C7463362;\n\tWed, 14 Dec 2022 10:34:44 +0100 (CET)","from mail-vs1-xe32.google.com (mail-vs1-xe32.google.com\n\t[IPv6:2607:f8b0:4864:20::e32])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 542C3603D0\n\tfor ;\n\tWed, 14 Dec 2022 10:34:44 +0100 (CET)","by mail-vs1-xe32.google.com with SMTP id t5so17272244vsh.8\n\tfor ;\n\tWed, 14 Dec 2022 01:34:44 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671010484;\n\tbh=q7dNAN2fceHtSsygay1usYt8qEnWOItmA/N/2CCHCsY=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=o4VWdqIxgOZj2ESA78RVNLfGZvkZUMLGtfytEJYvOR1uu6M2gyR4R5D9Qc1tfNHN2\n\tH48kJ3xui9HYX7VA6BqxUkd+AylGTeW1Yjikf1OHCFm93qyNbIIambT47o0/PnzYKt\n\t8gDgp01BJdzUvtdgJ0DvT/GhHmcUl3znOCgYytGuw59CKG8HIoDvuYjYcGEKExsQuc\n\tXjb8YpPKJfy+ZCq2OSkLXJIQd7zxe6ggTH1r6iCBch1V0GQWgk7RFOxURN1ahOkBWe\n\tPihxrb7vD8fii84AN4JbNBVw0wFwSmZB/EnvxBg7kYKgRlsdzy0L/40mhI1CZp8gP9\n\tG6IqMILZcb9eQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=u+P0bj+crQo3zpGd+nV0Pv+NB7YGPliLJtQMkR8Ugsg=;\n\tb=YWIshXNi9boyIo+Q79mPr34H+ROm6hV6mkJeCDAwp2/+ng4C7bbJ4Zlc8WXz0ioniD\n\tpuqSib5Hj7xiickQSQkamVqidP9mo82/ptR/HVvulz802qhq6gewts84o5deDPZ65raW\n\tTkBa3SnInBpAf2qRTeB7plGKWmYvhlcHzCFd8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"YWIshXNi\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=u+P0bj+crQo3zpGd+nV0Pv+NB7YGPliLJtQMkR8Ugsg=;\n\tb=T9PhSXuT+uLeT87Q3cIRyGjrXZdJBonKh5Zzy9D+oFy+zqDbCEVrhQcjrm+RjNL7/j\n\tDjnS/kZOztqoM3fOHQKgbsInTcB7du9fpvPs8bGMzaVVD0tPnDFJYzuCkaHUEFSwN6kw\n\t+khoOHKr2eoFf92jzNf9PwTv10/4b0Gfi/jqqyUzlUfBQRsMucJhARDls1KfLzwLxcjc\n\tHQTYohuhOgd9ILwo2G8CXvlMt6lgWRaTROf0MVVZzAzjT1v0EPIQTWZYaT+Yy4Yo4Yzs\n\t4zSQN3Dm0DFYxmFCyIbB2quu7ZEawzeqRRH4D4PMQxow8r9q+FpYPD/TVDZ16TlVshie\n\tGWWg==","X-Gm-Message-State":"ANoB5plpw1RTMXCBekpAKdSSdxk9pngJIZWRGORnAmXe1/we3x0iuYfM\n\t1pEqMX1SXGMuFGZ6rxPZGHhJlg+CE7SPxKx+6HM3Sw==","X-Google-Smtp-Source":"AA0mqf665HFJkb9NuT6mOG2GMjI/Kt5XzOaorwlByXgOcBIObka+/MdTxNVk9py0ksmMIv62H995hAUW7wTPBYCRiPg=","X-Received":"by 2002:a05:6102:1622:b0:3b3:55e6:203f with SMTP id\n\tcu34-20020a056102162200b003b355e6203fmr2777602vsb.4.1671010483182;\n\tWed, 14 Dec 2022 01:34:43 -0800 (PST)","MIME-Version":"1.0","References":"<20221201092733.2042078-1-chenghaoyang@google.com>\n\t<166989032191.3691396.888467205021095347@Monstersaurus>\n\t\n\t\n\t","In-Reply-To":"","Date":"Wed, 14 Dec 2022 17:34:32 +0800","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"00000000000044322a05efc672c8\"","Subject":"Re: [libcamera-devel] [PATCH v7 0/6] Add CrOS JEA implementation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Cheng-Hao Yang via libcamera-devel\n\t","Reply-To":"Cheng-Hao Yang ","Cc":"Harvey Yang ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26070,"web_url":"https://patchwork.libcamera.org/comment/26070/","msgid":"","date":"2022-12-14T09:38:23","subject":"Re: [libcamera-devel] [PATCH v7 0/6] Add CrOS JEA implementation","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"content":"Hi Kieran,\n\nOn Wed, Dec 14, 2022 at 5:34 PM Cheng-Hao Yang \nwrote:\n\n> Hi Laurent,\n>\n>\n>\n> On Wed, Dec 14, 2022 at 5:13 PM Laurent Pinchart <\n> laurent.pinchart@ideasonboard.com> wrote:\n>\n>> On Wed, Dec 14, 2022 at 11:12:29AM +0200, Laurent Pinchart wrote:\n>> > Hi Harvey,\n>>\n>> Sorry, I still need to wake up :-) The comment about help with\n>> refactoring was for Harvey, but I of course meant Cheng-Hao here.\n>>\n>> > On Wed, Dec 07, 2022 at 01:59:15PM +0800, Cheng-Hao Yang via\n>> libcamera-devel wrote:\n>> > > Hi Kieran,\n>> > >\n>> > > I see, while I actually found that the patch leads to a flaky crash\n>> in cros\n>> > > camera service. I'm still debugging with Han-lin. After I find the\n>> root cause,\n>> > > I'll ask Tomasz to take a look. And I'll also provide the CTS result.\n>> >\n>> > Thank you.\n>> >\n>> > I was wondering if you'd like any help with the review comments I've\n>> > sent, in particular with the proposed refactoring of the libjpeg-based\n>> > encoder.\n>> >\n>\n>\n> Definitely. Sorry for the belated reply. I wanted to solve the flaky issue\n> altogether\n> before sending the new version of patches.\n> Sorry for the delay!\n>\n>\n>>\n>> > > On Thu, Dec 1, 2022 at 6:25 PM Kieran Bingham wrote:\n>> > > > Quoting Harvey Yang via libcamera-devel (2022-12-01 09:27:27)\n>> > > > > Rebased and fixed some merge conflicts on the master branch.\n>> > > > > Please check if it's ready to merge.\n>> > > > > Thanks!\n>> > > >\n>> > > > One of our usual key requirements for merge are at least two\n>> reviewers\n>> > > > having reviewed and provided reviewed-by tags (after working\n>> through any\n>> > > > identified issues and discussions).\n>> > > >\n>> > > > As this component is greatly affecting the Android layer which is\n>> used\n>> > > > extensively by ChromeOS ... could we have one of the required\n>> reviewers\n>> > > > and testers being from Google or Chromium teams please?\n>> > > >\n>>\n>\nAs Laurent has reviewed the patches, and Han-lin from CrOS also took a\nlook, I guess\nI don't need to ask Tomasz to review anymore, right?\n\n\n> > > > Providing a reference to results from running CTS would also be\n>> > > > beneficial here.\n>> > > >\n>> > > > > Harvey Yang (6):\n>> > > > > Allow inheritance of Fra\n>\n> Harvey Yang \n> Thu, Dec 1, 5:27 PM (13 days ago)\n> \n> to libcamera-devel, Harvey\n> \n> Rebased and fixed some merge conflicts on the master branch.\n> Please check if it's ready to merge.\n> Thanks!\n>\n>> meBuffer\n>> > > > > Add HALFrameBuffer and replace FrameBuffer in src/android\n>> > > > > Add meson.build in src/android/jpeg\n>> > > > > Move generateThumbnail from PostProcessorJpeg to Encoder\n>> > > > > Pass StreamBuffer to Encoder::encoder\n>> > > > > Add JEA implementation\n>> > > > >\n>> > > > > include/libcamera/framebuffer.h | 3 +-\n>> > > > > src/android/camera_device.cpp | 3 +-\n>> > > > > src/android/cros/camera3_hal.cpp | 2 +\n>> > > > > src/android/cros_mojo_token.h | 12 ++\n>> > > > > src/android/frame_buffer_allocator.h | 7 +-\n>> > > > > src/android/hal_framebuffer.cpp | 22 +++\n>> > > > > src/android/hal_framebuffer.h | 26 ++++\n>> > > > > src/android/jpeg/encoder.h | 10 +-\n>> > > > > src/android/jpeg/encoder_jea.cpp | 93 ++++++++++++\n>> > > > > src/android/jpeg/encoder_jea.h | 35 +++++\n>> > > > > src/android/jpeg/encoder_libjpeg.cpp | 133\n>> ++++++++++++++----\n>> > > > > src/android/jpeg/encoder_libjpeg.h | 33 ++++-\n>> > > > > src/android/jpeg/meson.build | 16 +++\n>> > > > > src/android/jpeg/post_processor_jpeg.cpp | 65 ++-------\n>> > > > > src/android/jpeg/post_processor_jpeg.h | 11 +-\n>> > > > > src/android/meson.build | 6 +-\n>> > > > > .../mm/cros_frame_buffer_allocator.cpp | 9 +-\n>> > > > > .../mm/generic_frame_buffer_allocator.cpp | 11 +-\n>> > > > > 18 files changed, 385 insertions(+), 112 deletions(-)\n>> > > > > create mode 100644 src/android/cros_mojo_token.h\n>> > > > > create mode 100644 src/android/hal_framebuffer.cpp\n>> > > > > create mode 100644 src/android/hal_framebuffer.h\n>> > > > > create mode 100644 src/android/jpeg/encoder_jea.cpp\n>> > > > > create mode 100644 src/android/jpeg/encoder_jea.h\n>> > > > > create mode 100644 src/android/jpeg/meson.build\n>>\n>> --\n>> Regards,\n>>\n>> Laurent Pinchart\n>>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BA8BFC31E9\n\tfor ;\n\tWed, 14 Dec 2022 09:38:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3203163354;\n\tWed, 14 Dec 2022 10:38:37 +0100 (CET)","from mail-vk1-xa2a.google.com (mail-vk1-xa2a.google.com\n\t[IPv6:2607:f8b0:4864:20::a2a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F961603D0\n\tfor ;\n\tWed, 14 Dec 2022 10:38:35 +0100 (CET)","by mail-vk1-xa2a.google.com with SMTP id r204so2032634vkf.8\n\tfor ;\n\tWed, 14 Dec 2022 01:38:35 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671010717;\n\tbh=wjwnuvrRX6xbOMZpN/xvGuH+2l6gRDLrktEW+CHfoxw=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=rfbdRNTh/nRt6xuOpkQXRCa52vRig7L88ghMSt8JG7Mm6VNbFOjDfYBxZ9lyyAaB3\n\tTv+svPNcSmD/oVhytjRIwduQ944aCHzgKOeXCTCgL5kZPyYAnbojm3YgjRFf4Mlj5m\n\tVoMYaur6D1Oo2jHJuq9gebnq1fGelVhCUBj0MKDkTW/zG3F+56qe9mrhQfhoIRMnUK\n\tSpVyV5OacPq7sLrJ4kJPfY+1DEVugj+lQWEXkFpBch6GspNXxXRtyIxGHEnxc7pyZQ\n\tTzbug/BpLDfpjk4hz/cl4oyqZQZeD+0UhjSAyy2AKOy7oUbq+nm9AvDnin8Tmn1OEp\n\tQlh54bzbeoakw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=8tWdqyuSD4rCcDt+JeKP4cO/UXnJq+4OUhkWdE3CDcc=;\n\tb=R6BA1EPumQEJI+AWDabC44P1IUbGZoTdD6qQfwSHc0Ckl4mBl4QKdnV2pWV4CRrino\n\tkz7dYvdukmNIwyg1n4MqfGJgPr1zUF/IJrvZnyHiYJZa0/uRgUX6sGZDB721fQAQ9Jdt\n\t500EH4OaM0U6XdPkdA2yLgMYFKyKae3WRz+4s="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"R6BA1EPu\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=8tWdqyuSD4rCcDt+JeKP4cO/UXnJq+4OUhkWdE3CDcc=;\n\tb=GbVbl31CVxqmjZ/7tWFrM8asU9lSOu3VUBsIZVssgroygF63V+oyixvQHPZfj8a7rE\n\tCNHFuCwnO/dQXdun8Q+hL/7aLUjv8L2zKEauGMPiK+fzOxVO7G3w3bTgT3acgurRzd/x\n\t22700opL/D/L2f24jWl1RN6KwM5HSbIeKOYIjiuQvSj1agpLF6iRXKbNVXiVvVEB/aEk\n\td6XVIVba7c3VKARQHuwhEbPuaaWXmbvYvxFOp010IbZFUqCG5Is5ffC1fx5OHDk9kw9c\n\tcsdDDKhA0y8gydmnBcqimbofwh3jiAKDA+hGP8MShYVT2SItyVk/liCDKD+UHqK11+oo\n\tp+Uw==","X-Gm-Message-State":"ANoB5pl20sgqPWaaM3ytGW8KqcSTBxu7Zl4lREA4JOd+Dcn4pBVxfUus\n\tCYqFyHK0nlEUwk3ty5xRakNnYbAF2BJPiUO1MVp+Ig==","X-Google-Smtp-Source":"AA0mqf61n4y90DsgByn0GtKyK+DBn2CyyJASd9OS2o4wH7IfyDAoE6PtBocLnsKMlgu7qNFGksgRrJJReRAD15DObpw=","X-Received":"by 2002:a1f:2d8b:0:b0:3b8:615e:f0a with SMTP id\n\tt133-20020a1f2d8b000000b003b8615e0f0amr49667508vkt.34.1671010714390;\n\tWed, 14 Dec 2022 01:38:34 -0800 (PST)","MIME-Version":"1.0","References":"<20221201092733.2042078-1-chenghaoyang@google.com>\n\t<166989032191.3691396.888467205021095347@Monstersaurus>\n\t\n\t\n\t\n\t","In-Reply-To":"","Date":"Wed, 14 Dec 2022 17:38:23 +0800","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"0000000000000c2b8b05efc6808e\"","Subject":"Re: [libcamera-devel] [PATCH v7 0/6] Add CrOS JEA implementation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Cheng-Hao Yang via libcamera-devel\n\t","Reply-To":"Cheng-Hao Yang ","Cc":"Harvey Yang ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]