[{"id":25997,"web_url":"https://patchwork.libcamera.org/comment/25997/","msgid":"","date":"2022-12-02T21:43:11","subject":"Re: [libcamera-devel] [PATCH v2 00/10]\tRaspberry Pi: Platform\n\tconfiguration and buffer allocation improvements","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patches.\n\nCC'ing Han-Lin.\n\nHan-Lin has submitted a patch series that introduces a pipeline\nconfiguration file for the IPU3 ([1]). As this series does something\nsimilar for the Raspberry Pi pipeline handler, could I ask you both for\ncross-reviews of the two series ? I would like to avoid having two\nseparate and very different implementations for the common parts.\n\n[1] https://patchwork.libcamera.org/project/libcamera/list/?series=2923\n\nOn Tue, Nov 29, 2022 at 01:45:24PM +0000, Naushir Patuck via libcamera-devel wrote:\n> Hi,\n> \n> Version 2 of this series addresses all of David's suggestions/fixes. The only\n> other changes is in patch 1, we explicitly provide a subdir as well as a filename\n> into PipelineHandler::configurationFile().\n> \n> Thanks,\n> Naush\n> \n> Naushir Patuck (10):\n> libcamera: pipeline: Add a platform configuration file helper\n> pipeline: raspberrypi: Add a pipeline config structure\n> pipeline: raspberrypi: Split out ISP Output0 buffer allocation\n> pipeline: raspberrypi: Read config parameters from a file\n> pipeline: raspberrypi: Disable StreamOn for ISP Output0/1 when\n> dropping frames\n> pipeline: raspberrypi: Reorder startup drop frame initialisation\n> pipeline: raspberrypi: Add a parameter to disable startup drop frames\n> pipeline: raspberrypi: Allow pipeline handler to always use the newest\n> frame\n> pipeline: raspberrypi: Add minimal memory usage config file\n> pipeline: raspberrypi: Add libcamera-apps and picamera2 config file\n> \n> include/libcamera/internal/pipeline_handler.h | 3 +\n> .../pipeline/raspberrypi/data/default.json | 28 ++\n> .../pipeline/raspberrypi/data/meson.build | 10 +\n> .../raspberrypi/data/minimal_mem.json | 28 ++\n> .../pipeline/raspberrypi/data/rpi_apps.json | 28 ++\n> .../pipeline/raspberrypi/meson.build | 2 +\n> .../pipeline/raspberrypi/raspberrypi.cpp | 239 +++++++++++++++---\n> src/libcamera/pipeline_handler.cpp | 60 +++++\n> 8 files changed, 367 insertions(+), 31 deletions(-)\n> create mode 100644 src/libcamera/pipeline/raspberrypi/data/default.json\n> create mode 100644 src/libcamera/pipeline/raspberrypi/data/meson.build\n> create mode 100644 src/libcamera/pipeline/raspberrypi/data/minimal_mem.json\n> create mode 100644 src/libcamera/pipeline/raspberrypi/data/rpi_apps.json","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A1C33BDE6B\n\tfor ;\n\tFri, 2 Dec 2022 21:43:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1FF146333F;\n\tFri, 2 Dec 2022 22:43:16 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0657360483\n\tfor ;\n\tFri, 2 Dec 2022 22:43:14 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 56E6C6E0;\n\tFri, 2 Dec 2022 22:43:13 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670017396;\n\tbh=brLTAooUGVG6MMMK6bMo9eYHK8zkz6TqRznoC1IepRE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=QrGmdwXpFB0aoVGOCXvOjo5AD8jOJywop+rDp9IIIalibtxwWjSU+tH6hFOOLG+4o\n\tgsKvuGw1fFWRGmo40gr0YE3f+IwduNjdOwsgoXB51APw/CQfOfOVkYg9f8GxLDbtFM\n\tIkupODeTAhUvqirnZCG/IXyTovt72Nthjlp+TQQFNqibIBapdD07h/UrRKQo/WfABE\n\tINh/SyvQnrur/KgYxosg21o/JWcuPzH620AOIy+PTyu8lhW+v0AF4poUvgo483W7VT\n\ti7jWHyZ23abx/43yM/LX7ZJyoeV6GEHjNJp4JzwsjR1/PC2m7WNmzkHChIdPveu6y9\n\tP4lrlQsl+q/Pg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1670017393;\n\tbh=brLTAooUGVG6MMMK6bMo9eYHK8zkz6TqRznoC1IepRE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bEV7fTnjZIiKfZldw8rYjPefFY6ZHiYobHMSGAEjujIoybWG2FvXWDFMAuGOO4wkc\n\tuDw5HN6T7u6uJv0II19+TBNTCyzb0WwHxrCJ8Z/bMzy08qI/I/Em/B79SMH8b085/6\n\t7lmzMLKFHiSzWxErN+T4jSaOQ9r4js89nclJ2H8Y="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"bEV7fTnj\"; dkim-atps=neutral","Date":"Fri, 2 Dec 2022 23:43:11 +0200","To":"Naushir Patuck ","Message-ID":"","References":"<20221129134534.2933-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221129134534.2933-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v2 00/10]\tRaspberry Pi: Platform\n\tconfiguration and buffer allocation improvements","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]