{"id":17838,"url":"https://patchwork.libcamera.org/api/covers/17838/?format=json","web_url":"https://patchwork.libcamera.org/cover/17838/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221122120343.4825-1-david.plowman@raspberrypi.com>","date":"2022-11-22T12:03:40","name":"[libcamera-devel,0/3] Resolve invalid attempt to set sensor HBLANK control","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"mbox":"https://patchwork.libcamera.org/cover/17838/mbox/","series":[{"id":3629,"url":"https://patchwork.libcamera.org/api/series/3629/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3629","date":"2022-11-22T12:03:40","name":"Resolve invalid attempt to set sensor HBLANK control","version":1,"mbox":"https://patchwork.libcamera.org/series/3629/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/17838/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 309A1BE08B\n\tfor ;\n\tTue, 22 Nov 2022 12:03:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9305A6331A;\n\tTue, 22 Nov 2022 13:03:50 +0100 (CET)","from mail-wr1-x434.google.com (mail-wr1-x434.google.com\n\t[IPv6:2a00:1450:4864:20::434])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7146D603CE\n\tfor ;\n\tTue, 22 Nov 2022 13:03:49 +0100 (CET)","by mail-wr1-x434.google.com with SMTP id v1so24329211wrt.11\n\tfor ;\n\tTue, 22 Nov 2022 04:03:49 -0800 (PST)","from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:e4a2:3070:eea4:e434])\n\tby smtp.gmail.com with ESMTPSA id\n\tp18-20020adfe612000000b002366a624bd4sm12119141wrm.28.2022.11.22.04.03.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 22 Nov 2022 04:03:48 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669118630;\n\tbh=+4t5GW42hwunTKg5AVNSx4qlf/brTzE+53ccYzxcwOk=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=S1j2FnhUPaJnxhaJH8vEBdMNbLaVaHzjSv3MHDCdAt1XAuBW2N0oDdePMbb/RXLLg\n\t9pyuw/k5N1qIpemol/LjJo2HjhiD6sqgjcAgE1wEKN5cEyDdZmDOIFQJDaJA4hCWDr\n\tbta6BQN9eZauHCxCRLTFt552dUgO1grkebFm139FXZ4K1WwJi0gBUCRu1hGcgkWNbq\n\tA0VkjfPAij+qqaRAOwj/GxLVil4BPtWB4WQYKh/6Ws6H8C92c30abQHVY0L4HVG7Du\n\tMVgaAA6iIF1KVULkWvSV35IL31lLHJyEIAzrDkQ+5ONoyGLQKk1Pd7RNqlW55ds4lo\n\tql9EQAqZSEkow==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=zV0YnxPQk4XeqcnwW0qx32+hGcVdhE3+MawGWqd2KOo=;\n\tb=nqbU6NX9t5P8+e04pFGeec/b1ZcMaS5RdokiRSGrdYoy9iX/RRa6x+LSnOVb4aYZBB\n\tPHnHnjy1ovIqsJvyS95W8NWhGKSIhdSRuwBc+9Yu+WKB8FXldKQfR+Y1M7mElTPMzAyi\n\tC7uvRDnJqMb3qEhYj2culWGIK64DbCI1MpDJ+hWubvlcEw+GvxMZP1QifivIoilfYfpR\n\tLXtbGkIzb0813vPZey0ATWcnGjiHgDjy13xrT9V54tx5F9uvJAt5it+/0jLDw2RK/RWM\n\t7ul7LoHo9ZvGY46ylgVjX2gameUGXRWxsmcpXECVavGL2TtFVn8/gzvPoDwvY69sthHi\n\tLJVw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"nqbU6NX9\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=zV0YnxPQk4XeqcnwW0qx32+hGcVdhE3+MawGWqd2KOo=;\n\tb=jSeXQHUbqPj2+T0ZYz1xtekwl42BndxEnPnSEFkgMlLPfwcDnK6OQ/eP6AdmgkfkMk\n\tH5HbcgvEB7gn5FkvFEtgj07HCTnAVB2df2N8z5LT90FdlQPY1NmddvhuhGvVCCt9uBDZ\n\tKRuFKpvad6bXsfd7z8sk468E5zrOiIvr7e/5eCrYXSi8h51MYxCVwQzFfu4bw6PCtrOP\n\tx2psHMCqWjf00Bu0IYj7vn4Dm4Se2V4g3XJ4svpq7+FB+uzWGNunPuNv9/V4Yn29nSv7\n\tM0olfqqokuZAx0YGuGpV4GJbwJBMWhUbcChSeNkICOfNcOBl8QcP/I6fYPO2y/5KdKbN\n\tNq0g==","X-Gm-Message-State":"ANoB5pkjTaisXcgbFxaE6JZPezB2BA/7o3YUzsXHc+83N3UgnnBxMR4U\n\ttKmbiJnth5nxRzN6tg9U1EN6xyEOK4TE4A==","X-Google-Smtp-Source":"AA0mqf6qg9+I9pdJLwXMVIydyxxknNJZrud0Ng69pwUgHhrLWx5p8ekj32SVtIqYzj4wOrpWhIR+mA==","X-Received":"by 2002:a05:6000:235:b0:241:bd2b:f718 with SMTP id\n\tl21-20020a056000023500b00241bd2bf718mr12514856wrz.89.1669118628739; \n\tTue, 22 Nov 2022 04:03:48 -0800 (PST)","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 22 Nov 2022 12:03:40 +0000","Message-Id":"<20221122120343.4825-1-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.30.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 0/3] Resolve invalid attempt to set sensor\n\tHBLANK control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi\n\nSlightly in the same vein as recent sensor flip patches...\n\nWe have the same problem with the HBLANK control, in that we're\nsetting it at a moment (in CameraSensor::init) when we might not be\nallowed to. So there are three patches here:\n\n1. The first moves that code into a helper function.\n2 and 3. Pipeline handlers call the helper function.\n\nThe background here is that when we (Raspberry Pi) added control of\nHBLANK in order to get longer exposure times, that control was updated\nto expose a min and max value. Other pipeline handlers however, might\nthen assume that the minimum value was the current one, and so a\nworkaround was suggested where we ensure HBLANK is forced to the\nminimum. These changes merely move where that happens.\n\nThanks!\nDavid\n\nDavid Plowman (3):\n libcamera: camera_sensor: Add a function to reset the HBLANK interval\n libcamera: pipeline: rkisp1: Reset sensor HBLANK control\n libcamera: pipeline: ipu3: Reset sensor HBLANK control\n\n include/libcamera/internal/camera_sensor.h | 2 ++\n src/libcamera/camera_sensor.cpp | 10 +++++++---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +++\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 +++\n 4 files changed, 15 insertions(+), 3 deletions(-)"}