{"id":17822,"url":"https://patchwork.libcamera.org/api/covers/17822/?format=json","web_url":"https://patchwork.libcamera.org/cover/17822/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221121154421.11732-1-david.plowman@raspberrypi.com>","date":"2022-11-21T15:44:16","name":"[libcamera-devel,v2,0/5] Resolve invalid attempts to set sensor flip controls","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"mbox":"https://patchwork.libcamera.org/cover/17822/mbox/","series":[{"id":3625,"url":"https://patchwork.libcamera.org/api/series/3625/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3625","date":"2022-11-21T15:44:16","name":"Resolve invalid attempts to set sensor flip controls","version":2,"mbox":"https://patchwork.libcamera.org/series/3625/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/17822/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 59AE5BE08B\n\tfor ;\n\tMon, 21 Nov 2022 15:44:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 91B0B6331A;\n\tMon, 21 Nov 2022 16:44:27 +0100 (CET)","from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n\t[IPv6:2a00:1450:4864:20::335])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 949CF63097\n\tfor ;\n\tMon, 21 Nov 2022 16:44:26 +0100 (CET)","by mail-wm1-x335.google.com with SMTP id\n\tr10-20020a1c440a000000b003d0283bf132so314354wma.4\n\tfor ;\n\tMon, 21 Nov 2022 07:44:26 -0800 (PST)","from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:e4a2:3070:eea4:e434])\n\tby smtp.gmail.com with ESMTPSA id\n\tt11-20020adff60b000000b0022e035a4e93sm11742257wrp.87.2022.11.21.07.44.24\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 21 Nov 2022 07:44:25 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669045467;\n\tbh=3io9YxQA6OYhaa5dGqDUqSJRc1BS09HOrYcLhIS2b0A=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=G0tEtG6abmPQRXjOKY6+AAjKDSFXNwynzOAnCDEWsvc2wUbMP68SuYEQxxg+cSV6x\n\tQPV91qYny4N3lnWY9WmkhPE7DSI+99h/S0qvsw+s0iA0DCjmltZK7Mp1mVsbCxpEp8\n\tEFGOJQePQLt9WhmOA0Ld263BfEylX8iBZEdwtpRbVKJF00OZVVpX3PxazmMRWBb/AA\n\tbNLGA2+ZkDjnXgS3qJXpstKLgzmM3fQpuJwAa6Us8mt2dL17yE5Fa7a8S8nE2MVtJI\n\twLhsWxwfBhCpCkQIMnSTU6DvTJhT9FF+9XXsNYpizqf1C0KpOTDKh7Nh6YUQ7EMX+F\n\tT1kQg2SpgKh0g==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=NH9T7Pow8akWZ5KOP2d/i2ppu9Goxe7jwp6V7wcwY6c=;\n\tb=XAmheHZTn+2hahsanqR8TDYc8w+kU0rbewUfVbooE81v48DWECFrsckdLOKCcNSc/Y\n\tWFCR1adMW4XeQx2YDsMId7F8OhKrzQdVrU5h3Yj5C7bWZD9sK/OScgY3ivJO3NlJmkQu\n\tRjSlt4FTZRBK78CGrL+uTp5GCElYCVXjL0x5cPxsgs7MnkVxFaDZ4xLcD2APRUppJG6K\n\twOByRgD9XS1tuxoTEBAwhgN3jhusznaOUjKf7C6Ko/wh5ExsIPKm65Uh0Zz+feoaHYHm\n\txVEvf9abauCOMPlmBTcGYJ361AhjGAaWecRh9swg2PrdZE4FB1RELKFyFfA7vSG+vC29\n\t6aNQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"XAmheHZT\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=NH9T7Pow8akWZ5KOP2d/i2ppu9Goxe7jwp6V7wcwY6c=;\n\tb=282vkYHe7v41fmpE5P1mo6MuIGTD3ZiWqJ1pC6stTVHD+N6IMQLcdaPcgRbl9A0HDW\n\tpvnCA7Jq3PPPgLqxoCopXb8CLhpOgWl57ojEhVNU6agEFHJHplWMSbcti9c1w5cP/fgq\n\tlDwEuxVC1LLnVZO8KLRw6qT9Y/4yw9RNF7Z+vwU6ESLZvwhTLlJyM8GGBbjK1ZI7PSuX\n\t7I9ffEEQEAsslIlkBxpQqtczK70tem6sGRRwV/wxxw4G/gvf9w2bEP/uGevoRFSoM9qi\n\tul3fjoyyNf25f7HBCacrUJlgMKaIjYdi6omRTsd0SW3nvaxF3UvivbnXSbM2a0ro5q+Z\n\tMxMg==","X-Gm-Message-State":"ANoB5pl70AeBA1jR1Wrf83Kbny1ndYwheS7hI10Jz92RXf3PrKNBSx/w\n\tgVLR1OjXf2SdthcTay8HKv+lCPZ7qNdzNQ==","X-Google-Smtp-Source":"AA0mqf5su4C7DSkGXW5QSBe0zOF1gtbCn+bBRDbfUDmbUVuhfDKWYxLRkzatg3GANar2UP+VhqBbCA==","X-Received":"by 2002:a05:600c:601f:b0:3c6:f1fa:d677 with SMTP id\n\taz31-20020a05600c601f00b003c6f1fad677mr5376850wmb.59.1669045465756; \n\tMon, 21 Nov 2022 07:44:25 -0800 (PST)","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 21 Nov 2022 15:44:16 +0000","Message-Id":"<20221121154421.11732-1-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.30.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 0/5] Resolve invalid attempts to set\n\tsensor flip controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi again\n\nIn v2 of this set, the first 3 patches are unchanged, so thanks for\nsome of the reviews there.\n\nIn the light of the various discussions, I've updated the changes to\nthose other PHs (uvcvideo, simple and rkisp1). In all cases I'm being\nmore explicit that I want to preserve the previous behaviour before\nthis patch set was introduced. This may or may not (probably may not)\nbe the actual correct behaviour that people would want. So:\n\nuvcvideo: I've deleted the patch that updated this. These are\nunaffected by CameraSensor changes so I think I'm better off just\nleaving them alone.\n\nsimple and rkisp1: Both of these, AIUI, use the CameraSensor class so\npreviously the flips were getting cleared. Therefore I've added\nexactly this into the PHs so that the behaviour is unchanged.\n\nAs we had discussed, I think there are concerns that the simple and\nrkisp1 PHs implement incorrect behaviours in at least some respects,\nbut I think it's probably a separate job for someone working on those\nplatforms to investigate.\n\nDoes that make sense?\n\nThanks!\n\nDavid\n\nDavid Plowman (5):\n libcamera: bayer_format: Add toMbusCode method\n libcamera: camera_sensor: Do not clear camera flips when listing\n formats\n libcamera: v4l2_device: Add setTransform method to set a device's flip\n controls\n libcamera: pipeline: simple: Set device's flip controls as previously\n libcamera: pipeline: rkisp1: Set device's flip controls as previously\n\n include/libcamera/internal/bayer_format.h | 1 +\n include/libcamera/internal/v4l2_device.h | 3 ++\n src/libcamera/bayer_format.cpp | 11 +++++\n src/libcamera/camera_sensor.cpp | 49 ++++++++++++++++++-----\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 ++\n src/libcamera/pipeline/simple/simple.cpp | 3 ++\n src/libcamera/v4l2_device.cpp | 37 +++++++++++++++++\n 7 files changed, 97 insertions(+), 10 deletions(-)"}