[{"id":25836,"web_url":"https://patchwork.libcamera.org/comment/25836/","msgid":"","date":"2022-11-21T13:56:51","subject":"Re: [libcamera-devel] [PATCH v6 0/8] Raspberry Pi AGC digital gain\n\tfixes","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi,\n\nWould I be able to get another review on this series please?\n\nThanks,\nNaush\n\n\nOn Tue, 15 Nov 2022 at 09:07, Naushir Patuck wrote:\n\n> Hi,\n>\n> Version 6 of this series forks DelayedControls into the Raspberry Pi\n> pipeline\n> handler namespace, patches 1 and 2 cover this. Patches 3 and 4 update the\n> forked DelayedControls class to add the user cookie with the same set of\n> changes\n> as were in DelayedControls in version 5 of this series. I've removed all\n> the\n> existing review tags from these two patches to give folks another chance to\n> validate the changes.\n>\n> Thanks,\n> Naush\n>\n> Naushir Patuck (8):\n> pipeline: raspberrypi: Fork DelayedControls\n> pipeline: raspberrypi: Switch to RPi::DelayedControls\n> pipeline: raspberrypi: delayed_controls: Template the\n> ControlRingBuffer class\n> pipeline: raspberrypi: delayed_controls: Add user cookie to\n> DelayedControls\n> ipa: raspberrypi: Add RPiController::Metadata::mergeCopy\n> ipa: raspberrypi: Use an array of RPiController::Metadata objects\n> pipeline: ipa: raspberrypi: Use IPA cookies\n> ipa: raspberrypi: agc: Fix digital gain calculation for manual mode\n>\n> include/libcamera/ipa/raspberrypi.mojom | 6 +-\n> src/ipa/raspberrypi/controller/metadata.h | 10 +\n> src/ipa/raspberrypi/controller/rpi/agc.cpp | 10 +-\n> src/ipa/raspberrypi/raspberrypi.cpp | 104 ++++---\n> .../pipeline/raspberrypi/delayed_controls.cpp | 293 ++++++++++++++++++\n> .../pipeline/raspberrypi/delayed_controls.h | 87 ++++++\n> .../pipeline/raspberrypi/meson.build | 1 +\n> .../pipeline/raspberrypi/raspberrypi.cpp | 26 +-\n> 8 files changed, 481 insertions(+), 56 deletions(-)\n> create mode 100644 src/libcamera/pipeline/raspberrypi/delayed_controls.cpp\n> create mode 100644 src/libcamera/pipeline/raspberrypi/delayed_controls.h\n>\n> --\n> 2.25.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5AAA0BE08B\n\tfor ;\n\tMon, 21 Nov 2022 13:56:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A8D7463311;\n\tMon, 21 Nov 2022 14:56:41 +0100 (CET)","from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com\n\t[IPv6:2607:f8b0:4864:20::d2b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8965363097\n\tfor ;\n\tMon, 21 Nov 2022 14:56:39 +0100 (CET)","by mail-io1-xd2b.google.com with SMTP id c7so8603402iof.13\n\tfor ;\n\tMon, 21 Nov 2022 05:56:39 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669039001;\n\tbh=WxR9SoQPLd4xbZzfWUTMw/i7POxLoxsqmduYkoRLzCQ=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=csBlD2AQQpzsPON3o2D0lFupFfsKF4HzfkRDaNB4V6sk+WcLuksBOEREie+nmiRMc\n\tLxvLneHpreFhL4Ylh5pKJmPaObo68rdmRGrlklJ6EJu9QLFxlg4O4lnpQVb6bW0tao\n\tZuKBkh1cJyNdQzAKiAy3QCV0gfmwcjRlt6SbPueqPuaN+y297RJ4n3dcTwCXFPOWAO\n\tTGePGdBWeZg6tX8M8SjyqPozitXQxY9lC9QDPSdPgLEepNQH0MoPCusSx78WiybQ+K\n\tnL9/KJh4+j4hn4OxuMYkA67PV/FXgGjOD27gUEwr0aAnYH2DUYrZ21ZencSZzqhcQU\n\tbW+3TuBui7JVQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=8EqbHSsEE8QNE9dA2cO/k1P7trVgzAyJCDaKaWV91rc=;\n\tb=ce4VbkqA7uAMCAi/e2b1tS34MQOzSXWvjEyVN2ZCIaz2IbcBLabgp3X+8ozAZ3AlO+\n\tTqNasaHQy78S/1BbAUdVZXS571qagcSp+DC3sqdufh5KRMRV7MxBpF3nEUmlUt94LvNf\n\tqV45GzP95nNKsF3hwRrUmHNjVYt+LHNhFg3XyLaw4RHJuG7dayxCGKHAAKUcMDqHbAhD\n\t3QPuQExmLJjWpoOkguZDOZ0l1T6rnmrbDfSP1dabNlZ1NdxQPJrSrRjoyPFoUWCdu0U1\n\tcRj58W06+3wh1zXiUdRyUI452LVl4CT0jD486hjUIx8/4j27LRpPtPXVjIZ2LRypQ9KR\n\tcG2g=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"ce4VbkqA\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=8EqbHSsEE8QNE9dA2cO/k1P7trVgzAyJCDaKaWV91rc=;\n\tb=Y4sCtxPSCpD62h+FJasfwCV9Pj1//P1QKimsCTD5S3JnfbdzfkYjxeszD1C3djDjxU\n\trfOvJfsPY94Dx2CgXk6KTe5AXHu/SkWipq2UYVkuC0D0vG/NaLfkfDeCV8+OQmzYBQ4z\n\txow+T/7nMqkG2NdEzNjHVIqG9oVKk1bSAktX6IVvyEC8Gz6keaXYCv5ez4vWeByTvnv0\n\t4UkxY+7sEEKsjrnsSJn6Ou9O2M4sVcLvPs5GBxnT3opzQQeQ2pc1QpjiStLAWLimHLYo\n\thq3M3p/QADJrcJ6vMoqUcQCdgQzF2vc1W3Wbnk5hhSwkvy6Di92MSuVVxPuTO7xN8DDp\n\tNA/w==","X-Gm-Message-State":"ANoB5pms+d2GPTzFzK0rGVf/XGEzr3FTtnraK8/OEYiPO2I+gHQ3jSK/\n\toAxGZi+l7jE27puhRdoUtBbEIoTQj/EXlXnqmBpsrvLNa2w=","X-Google-Smtp-Source":"AA0mqf7snYA+iYgwjGCJS5yCCFqJzpFXVJr+bRQP21Ck6Jcms2BYqDs1G3rY7hKL7cP6sADte3hezTOH/tZ2FIS4YJU=","X-Received":"by 2002:a05:6638:4308:b0:376:246:e637 with SMTP id\n\tbt8-20020a056638430800b003760246e637mr8532785jab.260.1669038997880;\n\tMon, 21 Nov 2022 05:56:37 -0800 (PST)","MIME-Version":"1.0","References":"<20221115090755.2921-1-naush@raspberrypi.com>","In-Reply-To":"<20221115090755.2921-1-naush@raspberrypi.com>","Date":"Mon, 21 Nov 2022 13:56:51 +0000","Message-ID":"","To":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"00000000000095ff5605edfb6c7f\"","Subject":"Re: [libcamera-devel] [PATCH v6 0/8] Raspberry Pi AGC digital gain\n\tfixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25911,"web_url":"https://patchwork.libcamera.org/comment/25911/","msgid":"","date":"2022-11-25T08:04:53","subject":"Re: [libcamera-devel] [PATCH v6 0/8] Raspberry Pi AGC digital gain\n\tfixes","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi,\n\nSorry to be nagging on this, but could I get another review for this series\nplease?\nThis fix needs to be in our up-coming libcamera release.\n\nThe changes to the forked version of DelayedControls are identical to what\nwas\nin version 5.\n\nMany thanks,\nNaush\n\n\nOn Mon, 21 Nov 2022 at 13:56, Naushir Patuck wrote:\n\n> Hi,\n>\n> Would I be able to get another review on this series please?\n>\n> Thanks,\n> Naush\n>\n>\n> On Tue, 15 Nov 2022 at 09:07, Naushir Patuck \n> wrote:\n>\n>> Hi,\n>>\n>> Version 6 of this series forks DelayedControls into the Raspberry Pi\n>> pipeline\n>> handler namespace, patches 1 and 2 cover this. Patches 3 and 4 update the\n>> forked DelayedControls class to add the user cookie with the same set of\n>> changes\n>> as were in DelayedControls in version 5 of this series. I've removed all\n>> the\n>> existing review tags from these two patches to give folks another chance\n>> to\n>> validate the changes.\n>>\n>> Thanks,\n>> Naush\n>>\n>> Naushir Patuck (8):\n>> pipeline: raspberrypi: Fork DelayedControls\n>> pipeline: raspberrypi: Switch to RPi::DelayedControls\n>> pipeline: raspberrypi: delayed_controls: Template the\n>> ControlRingBuffer class\n>> pipeline: raspberrypi: delayed_controls: Add user cookie to\n>> DelayedControls\n>> ipa: raspberrypi: Add RPiController::Metadata::mergeCopy\n>> ipa: raspberrypi: Use an array of RPiController::Metadata objects\n>> pipeline: ipa: raspberrypi: Use IPA cookies\n>> ipa: raspberrypi: agc: Fix digital gain calculation for manual mode\n>>\n>> include/libcamera/ipa/raspberrypi.mojom | 6 +-\n>> src/ipa/raspberrypi/controller/metadata.h | 10 +\n>> src/ipa/raspberrypi/controller/rpi/agc.cpp | 10 +-\n>> src/ipa/raspberrypi/raspberrypi.cpp | 104 ++++---\n>> .../pipeline/raspberrypi/delayed_controls.cpp | 293 ++++++++++++++++++\n>> .../pipeline/raspberrypi/delayed_controls.h | 87 ++++++\n>> .../pipeline/raspberrypi/meson.build | 1 +\n>> .../pipeline/raspberrypi/raspberrypi.cpp | 26 +-\n>> 8 files changed, 481 insertions(+), 56 deletions(-)\n>> create mode 100644\n>> src/libcamera/pipeline/raspberrypi/delayed_controls.cpp\n>> create mode 100644 src/libcamera/pipeline/raspberrypi/delayed_controls.h\n>>\n>> --\n>> 2.25.1\n>>\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B0FEBDE6B\n\tfor ;\n\tFri, 25 Nov 2022 08:05:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9D61663326;\n\tFri, 25 Nov 2022 09:05:12 +0100 (CET)","from mail-il1-x131.google.com (mail-il1-x131.google.com\n\t[IPv6:2607:f8b0:4864:20::131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2A01E632F8\n\tfor ;\n\tFri, 25 Nov 2022 09:05:11 +0100 (CET)","by mail-il1-x131.google.com with SMTP id h2so1669348ile.11\n\tfor ;\n\tFri, 25 Nov 2022 00:05:11 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669363512;\n\tbh=I4iU0Q5nhdLW5JxyyY6a++HPxt8RxwY8ncHf/l/OO0g=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=P+fb7lnIs8v6GwwQJlHvl7R80Z4jfMnKHqu4q2QDqoktQJOSp0vJeAYe3EWwrS+hP\n\t9EokOMIU7dWIufO7MrumOdKjPkffOo+VSlZUAlM99rzniLZ84dMJet3ZzJeqHBa7a8\n\taAj3hoyB7bF+UD9P3jFUGDrVf1JzpD7l6yiJzVkVGVgibYRLhaNvkgdtHKB5UA25MO\n\t8MB0xfsMDQG7rnLROhTUEu+Uq3grM2iYeX91mVzAuO21lKx3iIM6wORawPWWGSZ8Iq\n\tdeID5Yb3vwdH2BpdiQOb0CDsDjTYW6XMfW8Q0leBIwYW1dHJ/vgEbov0evA8x7xS21\n\tP1UfMU4aGOHcQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=d+ZEE/PA6pv5g+ipeeD/W7jpC0+/eT6gjZHqYP71FWM=;\n\tb=XGZfxNfpYU4pWwie6zTVuOOmnIkGEQFxEqohRFBiOQssDxFHadycAhDwzWEQGJPyZ8\n\tTP49yN5zZy/arqFXXbu4fGSEUUh4j7YJrnn4yq3GkzKh+HFKfhKRS/jUZs/I1LK3HAMb\n\tVmhdbRQdyL+oXTKPTSEFrWo0ap1+bMcHEblDNUk6PS9WeBNApPBDfJP5YNR8adu4CQkr\n\tXLYtLtfLRKMczhvHEc/7aHp8wDKnvm0drHXNxbwnMuqI946vHE2vEhBZnkmhiHD03PWE\n\tTfTZpQoe+rMjpYz220NUruo14wYPS9g0DPWJjWI6SbpkdhanTRZUoz846DtW7wp3LM8h\n\tDuyA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"XGZfxNfp\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=d+ZEE/PA6pv5g+ipeeD/W7jpC0+/eT6gjZHqYP71FWM=;\n\tb=tCp9VJiVYRNLKzvZMtZQiyVzPWHjVs9UlXsSymgIuuyEBmh0273WT9vRoaZl/x6CpX\n\tW54seo9ZsdJZkfr3S22xpsCU0BdVOIZtvcACv0q8EVwbz1F61Ec/R6twXyBihc48vVwv\n\tCr/d8bkyh3sZkC/BpCE7LtAdYVBMA7h6CXuJRmcSDCb5F96g0+AxjaX8ESYVoCMheE6h\n\tm+8QaLiM9xnxIZnAYPhKi1Td/2ulA+m2INwSZw5zG85Z/4QU/wwr4gyp72vWfz+8klZU\n\tx91FKCxH4UxxTjC8jGuDmzkQkfl4KZPIaJXuRvoR27ChtjoItX3AuZk0WvN3D5FJvi+1\n\tKLnA==","X-Gm-Message-State":"ANoB5pmwODROCl0G3UpDkIuiV2fDhRriaUCPmJgLDcurh6hA3Sm7Oc0Y\n\tR0O5MrST+xu28mex5L0bIlHSl96QaCqUAheBZml4voDzKo0=","X-Google-Smtp-Source":"AA0mqf7y/1025+1HWRHIvE01yUCaDwvBkaAMYMtqqy8qitU4BWmSwtFuxiKgOUMADtX+IjGofvlsz4bQaN5dI7W9ySI=","X-Received":"by 2002:a92:8748:0:b0:2f9:b1d0:2f24 with SMTP id\n\td8-20020a928748000000b002f9b1d02f24mr16231298ilm.181.1669363509499;\n\tFri, 25 Nov 2022 00:05:09 -0800 (PST)","MIME-Version":"1.0","References":"<20221115090755.2921-1-naush@raspberrypi.com>\n\t","In-Reply-To":"","Date":"Fri, 25 Nov 2022 08:04:53 +0000","Message-ID":"","To":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"000000000000fc345d05ee46fa06\"","Subject":"Re: [libcamera-devel] [PATCH v6 0/8] Raspberry Pi AGC digital gain\n\tfixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]