{"id":17792,"url":"https://patchwork.libcamera.org/api/covers/17792/?format=json","web_url":"https://patchwork.libcamera.org/cover/17792/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221115090755.2921-1-naush@raspberrypi.com>","date":"2022-11-15T09:07:47","name":"[libcamera-devel,v6,0/8] Raspberry Pi AGC digital gain fixes","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"mbox":"https://patchwork.libcamera.org/cover/17792/mbox/","series":[{"id":3609,"url":"https://patchwork.libcamera.org/api/series/3609/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3609","date":"2022-11-15T09:07:47","name":"Raspberry Pi AGC digital gain fixes","version":6,"mbox":"https://patchwork.libcamera.org/series/3609/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/17792/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 94F47BE08B\n\tfor ;\n\tTue, 15 Nov 2022 09:08:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BB1A663088;\n\tTue, 15 Nov 2022 10:08:01 +0100 (CET)","from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com\n\t[IPv6:2a00:1450:4864:20::42c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BCEC063079\n\tfor ;\n\tTue, 15 Nov 2022 10:08:00 +0100 (CET)","by mail-wr1-x42c.google.com with SMTP id j15so23120577wrq.3\n\tfor ;\n\tTue, 15 Nov 2022 01:08:00 -0800 (PST)","from naush-laptop.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tp25-20020a05600c1d9900b003c64c186206sm15143696wms.16.2022.11.15.01.07.59\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 15 Nov 2022 01:07:59 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1668503281;\n\tbh=OLMaFQ9BekaHJLLNAwlwYs0Lx8QkzgcXA7eZGrB3SH4=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=dWbOQ3Jmtw9fpAN+ZpnvUJ0iLlv9sFZlrNQSoPzgrV7ynXAKd+2pTUhvVxB64A3sL\n\tD7QJTM9BRPbk6RPJU3zn5GqFZ5hXuL+hk3LRWSB6EGq1sdHQN7IO2ziKrrHxxKZsjw\n\tGVXMR4Yxj+c5ZLI95zlQX47+jgpsd+yPRGUnpssHT4qhetRui4RsZUPELkbMjjYf0i\n\tj6ObV4oQgO8uMjJerC8xyqo6/fZtZEiq8QZvmjyGixZR2y0D7xvLwp44dlGm1LfARi\n\trOykTHiAiUEk2XfV869IBq/Ab6jHFKhHamYcmJTjDvBErjaSzd5szo/BipRLuwOqRq\n\tifDTEnxDdD61w==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=t9eHv1Ek4X8ed5Lh3uRN5n10+5re6sS15Jxza6TdNbQ=;\n\tb=MqLD7W3SbPg/uTyJUmWgP445JB8DCV1VkhojREBKigZQmtpCb2N8c5dU0pzwhmIph8\n\tFkEm+jDZJmo+G2X8BaTQctR1rC49FsSdYqXF44phUzGRJFpvggHLLeMBY+zvMY0tYks+\n\tdyhe63Hbr0+oy0kY0eB4mIppjm68+/uDBkKsD62n36R6RsauU2mXemJz351Dn9dOcs0I\n\tcPP3n1aPZbZSstpbKOuB7WPpSmSv2r9JvLgJxmQjcusSfaCjaNLwG3K2FSqSpGI0Vre3\n\tdkMhH7MZ5/JiZPkR2wthTS7RMb+lQZbvhKwsHsfWjjLvzaDLqPRHSmiQzKYa5EDIoZtU\n\tT4Sg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"MqLD7W3S\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=t9eHv1Ek4X8ed5Lh3uRN5n10+5re6sS15Jxza6TdNbQ=;\n\tb=sZ3AEWUGRY1Kwx9fR9ktT4VCF1hqXdxgS4IXymL2sVpzDAvrVPEVtEOqkDpg3fPF4E\n\tcczARRZz6dazLga/RIRv6g/OXfFvhoeFD8rXsaMAx5SoHHYzvNyf55LSUsACwbm5WFi/\n\tcY8smd0Sldd6IKBX8KNsov/LOMYhhOIkCr3XFbDG1j+rZir1517kRb9xU8/JL8ZIDKmP\n\tQlabedGuhQyTkCEffG58cMWDtWz4LCQEtQ7bGaEhtAQdfMhtfQKWgNA0vNwQn9+jU2j2\n\t51Q+1YcMI5RWB4jFs5YtQ+LCSLvHuLbZpsARkA4bj6D5lbc0xlt6bvrdtcwlB2/AO/TZ\n\tAJGA==","X-Gm-Message-State":"ANoB5plADqx9mtNSEtBebCctY9TPlW9zYCuu+XNcS3EeOEyI/wDF6n7N\n\tlVqprwONW7DM75K/rhq+F/YLexlufDVU1Q==","X-Google-Smtp-Source":"AA0mqf5+fAMIHIfQj+jGNoNMrtmDznSDmoGJtlesg85UBbJiT5AS9NNphga9+XTbchXsPGU/bEGfJQ==","X-Received":"by 2002:adf:dcca:0:b0:22c:95bc:c70e with SMTP id\n\tx10-20020adfdcca000000b0022c95bcc70emr9669541wrm.248.1668503280106; \n\tTue, 15 Nov 2022 01:08:00 -0800 (PST)","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 15 Nov 2022 09:07:47 +0000","Message-Id":"<20221115090755.2921-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v6 0/8] Raspberry Pi AGC digital gain fixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi,\n\nVersion 6 of this series forks DelayedControls into the Raspberry Pi pipeline\nhandler namespace, patches 1 and 2 cover this. Patches 3 and 4 update the\nforked DelayedControls class to add the user cookie with the same set of changes \nas were in DelayedControls in version 5 of this series. I've removed all the\nexisting review tags from these two patches to give folks another chance to\nvalidate the changes.\n\nThanks,\nNaush\n\nNaushir Patuck (8):\n pipeline: raspberrypi: Fork DelayedControls\n pipeline: raspberrypi: Switch to RPi::DelayedControls\n pipeline: raspberrypi: delayed_controls: Template the\n ControlRingBuffer class\n pipeline: raspberrypi: delayed_controls: Add user cookie to\n DelayedControls\n ipa: raspberrypi: Add RPiController::Metadata::mergeCopy\n ipa: raspberrypi: Use an array of RPiController::Metadata objects\n pipeline: ipa: raspberrypi: Use IPA cookies\n ipa: raspberrypi: agc: Fix digital gain calculation for manual mode\n\n include/libcamera/ipa/raspberrypi.mojom | 6 +-\n src/ipa/raspberrypi/controller/metadata.h | 10 +\n src/ipa/raspberrypi/controller/rpi/agc.cpp | 10 +-\n src/ipa/raspberrypi/raspberrypi.cpp | 104 ++++---\n .../pipeline/raspberrypi/delayed_controls.cpp | 293 ++++++++++++++++++\n .../pipeline/raspberrypi/delayed_controls.h | 87 ++++++\n .../pipeline/raspberrypi/meson.build | 1 +\n .../pipeline/raspberrypi/raspberrypi.cpp | 26 +-\n 8 files changed, 481 insertions(+), 56 deletions(-)\n create mode 100644 src/libcamera/pipeline/raspberrypi/delayed_controls.cpp\n create mode 100644 src/libcamera/pipeline/raspberrypi/delayed_controls.h"}