[{"id":2376,"web_url":"https://patchwork.libcamera.org/comment/2376/","msgid":"<20190811001913.GG28494@bigcity.dyn.berto.se>","date":"2019-08-11T00:19:13","subject":"Re: [libcamera-devel] [PATCH v4 0/4] libcamera: Fix issues with\n\tvimc and Linux v5.2","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi,\n\nI have now pushed this series.\n\nOn 2019-08-10 03:13:29 +0200, Niklas Söderlund wrote:\n> Hi,\n> \n> The recently release Linux v5.2 changes the vimc drivers behavior in a\n> way which breaks libcameras vimc pipeline and some of our tests. This\n> small series aims to solve this and keep libcamera functioning on both\n> v5.1 (and earlier) and v5.2.\n> \n> Patch 1/4 is a small preparation patch. While 2/4 switches the vimc\n> pipeline to use the RGB/YUV capture video node instead of a raw capture\n> node. Patch 3/4 fixes issues introduced by [1] and finally 4/4 fixes an\n> issue introduced by [2]. The whole series is tested on v5.1 and v5.2 on\n> top of libcamera master branch and all tests pass again.\n> \n> 1. 85ab1aa1fac17bcd (\"media: vimc: deb: fix default sink bayer format\")\n> 2. b6c61a6c37317efd (\"media: vimc: propagate pixel format in the stream\")\n> \n> * Changes since v3\n> - Change minimum resolution of a vimc camera from 16x16 to 48x48 to \n> satisfy scaler requirement.\n> - Declare link variable where it's first used.\n> - Fold PipelineHandlerVimc::initLinks() into VimcCameraData::init().\n> - Mention test change in commit message in 2/4.\n> - Update comments.\n> \n> * Changes since v2\n> - Switch to vimc RGB/YUV capture video node.\n> \n> Niklas Söderlund (4):\n> libcamera: pipeline: vimc: Initialize device pointers\n> libcamera: pipeline: vimc: Switch to using the RGB/YUV Capture video\n> node\n> tests: v4l2_videodevice: Set media bus and pixel formats for vimc\n> tests: camera-sensor: Test using invalid media bus format\n> \n> src/libcamera/pipeline/vimc.cpp | 93 +++++++++++++++++--\n> test/camera-sensor.cpp | 3 +-\n> test/camera/buffer_import.cpp | 10 +-\n> .../v4l2_videodevice_test.cpp | 26 ++++++\n> test/v4l2_videodevice/v4l2_videodevice_test.h | 7 +-\n> 5 files changed, 123 insertions(+), 16 deletions(-)\n> \n> -- \n> 2.22.0\n>","headers":{"Return-Path":"","Received":["from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2A27A60C03\n\tfor ;\n\tSun, 11 Aug 2019 02:19:15 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id 15so3540212ljr.9\n\tfor ;\n\tSat, 10 Aug 2019 17:19:15 -0700 (PDT)","from localhost (h-177-236.A463.priv.bahnhof.se. [217.31.177.236])\n\tby smtp.gmail.com with ESMTPSA id\n\tp9sm20406804lji.107.2019.08.10.17.19.13\n\tfor \n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tSat, 10 Aug 2019 17:19:13 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=t2JEGVzggitg2niM4sFDGg8Ebfd43NvFhJ8DApAeLpo=;\n\tb=oDQ8G0eNqGniiJpzLNtkGJABLZlir4CAocOm55Wcu2mRqgjL6Q+2m7lw8f2lv2x2i5\n\tkcBHgtV22BUORpWJCkCi0KJpArOvDuHn1uLqgVelvO2zXwkiyNoJY1LKHWbfc8thaUZD\n\tMyzelnjSRrSWmfN/+f8sUgEp7vASRY/KsDPD6x0pb/srNt2XPvVwL3/hrK5tWqDV4k2c\n\t2W9WT7MGfjN7N3rXdSylS+piQHKIWCQodnrm38tFoskJ0v02wLeQ20ZF0otFyheHYbAe\n\tK0fev5jZEnfQOcaw6FlcpqVCWyi5BFIks4HosckcyyVFgPtA54hQcbDogJcPHJBdOwLW\n\t45ag==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=t2JEGVzggitg2niM4sFDGg8Ebfd43NvFhJ8DApAeLpo=;\n\tb=Edl7eI1vqn64lhkM2Wi4bDeq/6P6eqs7O0fyBiiJ8LYja1DvDDhS9lWBiF4tKzhIly\n\tYYJtOMzpxMaEteH21oYAQGwtqp7HPbVgQL8/AUY6nN8MKj2uU0wAu89JnABcqV3JrEh1\n\tIMEuInOX5o3SybNKrG7CVQxS9W52G17gdKXA5Eqt0CbO2gyX6IrByNiNgmXGpU+ya5es\n\tqXQWOoyaepSY8fvTDg2D+9Bm3GBUrguq0lallGBQCThENJZ9Z9qTbMtwhCheaXkEMo7Q\n\tMOu5dFk9IagEybAaKcnWfdktynxZsaOCGzWl3pIhQgWPxgAdonqh8DcPUOwj3oViY+ha\n\tRb4Q==","X-Gm-Message-State":"APjAAAVTsUGMTiD3iQQOjhN1v1PVwVNRVq2WrYE1NLoH8VELYD8NsmXc\n\tOixCEDEtvgaCoR0yJh6whS+1uT8BcLc=","X-Google-Smtp-Source":"APXvYqzpqlTiA74354Ppw0SUHxN6x8ikVsvsw9EvrO8QLrHrdSIad9lGpxlkevU1TdpAP9NkK0TiUw==","X-Received":"by 2002:a2e:9045:: with SMTP id n5mr15528363ljg.66.1565482754046;\n\tSat, 10 Aug 2019 17:19:14 -0700 (PDT)","Date":"Sun, 11 Aug 2019 02:19:13 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190811001913.GG28494@bigcity.dyn.berto.se>","References":"<20190810011333.8731-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190810011333.8731-1-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH v4 0/4] libcamera: Fix issues with\n\tvimc and Linux v5.2","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 11 Aug 2019 00:19:15 -0000"}}]