[{"id":25530,"web_url":"https://patchwork.libcamera.org/comment/25530/","msgid":"","date":"2022-10-24T07:43:53","subject":"Re: [libcamera-devel] [PATCH v4 0/7] Raspberry Pi AGC digital gain\n\tfixes","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi all,\n\nAny chance I could get somebody to have a review on this series please?\n\nWould it possibly help move this further if I were to revert my changes to\nDelayedControls,\nand add a Raspberry Pi specific implementation?\n\nRegards,\nNaush\n\nOn Wed, 19 Oct 2022 at 10:01, Naushir Patuck wrote:\n\n> Hi,\n>\n> Version 4 of this series only has one change from the previous versions:\n>\n> In patch 6/7, the IPA cookie (index into the RPiMetadata array) is passed\n> from\n> the pipeline handler into the IPA rather than the other way around. This\n> helps\n> simplify some of our future work on per-frame-control.\n>\n> There is still lots of discussion on this series to be had, particularly\n> for\n> patch 1/7 where we add a cookie to DelayedControls, so feel free to\n> provide some\n> feedback.\n>\n> Regards,\n> Naush\n>\n> Naushir Patuck (7):\n> delayed_controls: Template the ControlRingBuffer class\n> delayed_controls: Add user cookie to DelayedControls\n> tests: delayed_controls: Add cookie value test\n> ipa: raspberrypi: Add RPiController::Metadata::mergeCopy\n> ipa: raspberrypi: Use an array of RPiController::Metadata objects\n> pipeline: ipa: raspberrypi: Use IPA cookies\n> ipa: raspberrypi: agc: Fix digital gain calculation for manual mode\n>\n> include/libcamera/internal/delayed_controls.h | 21 +++--\n> include/libcamera/ipa/raspberrypi.mojom | 4 +-\n> src/ipa/raspberrypi/controller/metadata.h | 10 +++\n> src/ipa/raspberrypi/controller/rpi/agc.cpp | 10 ++-\n> src/ipa/raspberrypi/raspberrypi.cpp | 82 ++++++++++++-------\n> src/libcamera/delayed_controls.cpp | 20 +++--\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +-\n> .../pipeline/raspberrypi/raspberrypi.cpp | 19 +++--\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 +-\n> test/delayed_controls.cpp | 52 +++++++++++-\n> 10 files changed, 163 insertions(+), 61 deletions(-)\n>\n> --\n> 2.25.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E02D1BDB16\n\tfor ;\n\tMon, 24 Oct 2022 07:44:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2F35262EED;\n\tMon, 24 Oct 2022 09:44:11 +0200 (CEST)","from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com\n\t[IPv6:2607:f8b0:4864:20::72d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E2EA62EBC\n\tfor ;\n\tMon, 24 Oct 2022 09:44:09 +0200 (CEST)","by mail-qk1-x72d.google.com with SMTP id z30so5597358qkz.13\n\tfor ;\n\tMon, 24 Oct 2022 00:44:09 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666597451;\n\tbh=WM0n+Gj56/HsXLwSARUagPvwIgkbYAf93ktcwkObewU=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=iI3kjR9J2OPWKMkDXdbJ4EbndyJ8d1dCuqvtCgHmuaRnE4GHNGPgaB3OQ9OOX9NWf\n\tAaXVR3Iw1ALHx1JrU1h7T4d2XqG+SSxBKN9+r04OOLpgKsv6PiKy4K4MMW+D1ieg03\n\trvRi0/97I53UxQ1ojMeld09xhntq356JeK1Td2H/DEyJWwidUQ8HSa9RLJyXC1nheL\n\tdGehXqIb6Dd6YnQU2nnkE4Br8IhsinTM79yZLrnNfQDET1CDOEbH1HjDuwS21JOv/D\n\t4h3UyGMmkB0o0mnrcRUwE+zJ55+bNmCyoAmql8vzKOEm+jVCeRpLV3P1CkHHe8xvnY\n\t9jK8py+HD3p+Q==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=sS8Qywf4nL2WD3+K+1sxcSFdYgUgHBcjVzifQWhg/o4=;\n\tb=MYZcX3zbbh0nPAy/73pf1CmjcbUn9ArchSYT3AzmYy6YeRTpn/1MXAZOXRV77FmCiX\n\tk3hFg9UX/49S75IxplzbllQkIWitddl3CjJbLFCbUiFgHYS5fXZg6U1gtW9iBta2f3x3\n\tzyAgXup2VXHuNZxYKLZMvxUhKLF9P6+hA0NFgmaiOf8t0XPugxej80VE9OzRBw5WHN9q\n\tQnN750ja9RYsO/scU6YREnVBJOL1rtLxuqfDnOrdBCkjpWixF/+5dspmRVdiEka1VVqm\n\tB5RH4HJynpY+mHPKCH80g2MsJskyWj+7LDdpaElp54WpAAQMc77+DOCyzsP3mcpWtwro\n\tJ3nA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"MYZcX3zb\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=sS8Qywf4nL2WD3+K+1sxcSFdYgUgHBcjVzifQWhg/o4=;\n\tb=bKaGzKGxozhM6fT3Zz4SsV0vyFCSrNh/bKYxGZsqasYkQSQamtxdDuDTXkSdBDuUny\n\thrtaL6UmDLChrDxYHzR7PIGmGzCZM1rnB73/hat04RxoA2TR2vQVv5A0S1zTyDrNPwGr\n\t4MZM0VqfTybQ+AjmjyjA1sY96cL+FgZBkmbiCiTG7KBgmBnOmmyTVYweK60erCsogfFu\n\tfYvr1zRfcz3pPCVUenjM6ONHfBYtN9MlaBLEuV5TDf+ihy5hDxh08hDr8Z8vl5xqaPnk\n\t1wbG4hB235kHkiU7TZ1cTp+A5lkRjs8wAS/TH+PkKSyDsEP0Iq7TxqyLIGNkB+LY9/Cr\n\tqJRg==","X-Gm-Message-State":"ACrzQf3ngl8gdmjWBXp7+n805SNRRXoIxDzYxBFr90fDJePfIgPbiKTx\n\t6z8ZvNJxJVcr25ZFgTRtC2kGmKnusvd1EtJqw8tEPiTKhvI=","X-Google-Smtp-Source":"AMsMyM7lzZ/3x2toulhl24kNaZjc/6IvQLwThxX7yEr0OjJ1cEC8bF3qS+1RZX4OMHzt9F+h49pbsTfgBuusEssPzfE=","X-Received":"by 2002:a05:620a:215e:b0:6e7:dafb:a71a with SMTP id\n\tm30-20020a05620a215e00b006e7dafba71amr22327397qkm.61.1666597448016;\n\tMon, 24 Oct 2022 00:44:08 -0700 (PDT)","MIME-Version":"1.0","References":"<20221019090107.19975-1-naush@raspberrypi.com>","In-Reply-To":"<20221019090107.19975-1-naush@raspberrypi.com>","Date":"Mon, 24 Oct 2022 08:43:53 +0100","Message-ID":"","To":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"000000000000df7a4c05ebc2f404\"","Subject":"Re: [libcamera-devel] [PATCH v4 0/7] Raspberry Pi AGC digital gain\n\tfixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]