[{"id":25363,"web_url":"https://patchwork.libcamera.org/comment/25363/","msgid":"<20221010083649.ip4hdklmt27iwq6r@uno.localdomain>","date":"2022-10-10T08:36:49","subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Fix compilation with\n\tgcc 8.3.0","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent\n\nOn Sun, Oct 09, 2022 at 07:44:38AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> Hello,\n>\n> It is with great sadness that I have to announce the removal of\n> utils::defopt. This feature causes compilation failures with gcc 8.0.0\n> to 8.3.0 due to (I believe) a gcc bug ([1]), and I haven't been able to\n> find a suitable workaround. Debian 10 ships gcc 8.3.0, and it has LTS\n> support until June 2024, making it an important target.\n>\n> I'm sure nobody but me will miss utils::defopt, so I'll get over it.\n\nI'm sorry :(\nBut happy gcc8.3 gets fixed\n\nRafael, would you be able to test this and provide a tag ?\n\nFor the series\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86521\n>\n> Laurent Pinchart (2):\n> ipa: rkisp1: Drop use of utils::defopt\n> libcamera: base: utils: Drop defopt\n>\n> include/libcamera/base/utils.h | 14 --------\n> src/ipa/rkisp1/algorithms/dpf.cpp | 6 ++--\n> src/ipa/rkisp1/algorithms/gsl.cpp | 8 ++---\n> src/ipa/rkisp1/algorithms/lsc.cpp | 4 +--\n> src/libcamera/base/utils.cpp | 21 ------------\n> test/utils.cpp | 53 -------------------------------\n> 6 files changed, 9 insertions(+), 97 deletions(-)\n>\n>\n> base-commit: 4bf68fdbe1493e57118dad4e94c2a46c50a9c402\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6BC14C0DA4\n\tfor ;\n\tMon, 10 Oct 2022 08:37:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E70B62D53;\n\tMon, 10 Oct 2022 10:36:54 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1AE3C60485\n\tfor ;\n\tMon, 10 Oct 2022 10:36:52 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 1AA0AC001A;\n\tMon, 10 Oct 2022 08:36:50 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1665391014;\n\tbh=pUIB40KWrU7VRQuqBrAx/IoPxAdA/fH4gaufZk5K00w=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=SUc9hf7bto7542OR4ZuU/mt5AspAbnx0wnk/b/K5Dh7rvKnG+eKaXXWuyJEM0qH6y\n\tsq1i8HICw4fzQ/9RoV/bW8GCgGhCZG3dfptwZAoIUedvq42QcJ8C2bIZQQup0jomJ2\n\t82Z94dEBQvY0I9GXl12q72r3Fvfslvp7fI1x98AskR8SlXI2WN9vK1kfX182TOdgWH\n\tayILbfDKt7X60b0n4UYFUYAZNuo9CCV4uJz5wvpbHPixjfA/3kMBf4fJ5RQCYU3Mgo\n\tS/cqMZDecp5IFKuhJTsGCeLrC4+rKpR5WwtwnSn9HmPEx5T+6UR97fI0se6WyB0QVz\n\tkv/KJxkbG1WJw==","Date":"Mon, 10 Oct 2022 10:36:49 +0200","To":"Laurent Pinchart ","Message-ID":"<20221010083649.ip4hdklmt27iwq6r@uno.localdomain>","References":"<20221009044440.21499-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221009044440.21499-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Fix compilation with\n\tgcc 8.3.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25364,"web_url":"https://patchwork.libcamera.org/comment/25364/","msgid":"<835a5cb7-0920-9764-1dbe-495cf7098b5f@riseup.net>","date":"2022-10-10T08:54:57","subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Fix compilation with\n\tgcc 8.3.0","submitter":{"id":128,"url":"https://patchwork.libcamera.org/api/people/128/","name":"Rafael Diniz","email":"rafael@riseup.net"},"content":"Sure. I will test asap.\n\nThanks for the fix!\n\nRafael\n\nOn 10/10/22 11:36, Jacopo Mondi wrote:\n> Hi Laurent\n> \n> On Sun, Oct 09, 2022 at 07:44:38AM +0300, Laurent Pinchart via libcamera-devel wrote:\n>> Hello,\n>>\n>> It is with great sadness that I have to announce the removal of\n>> utils::defopt. This feature causes compilation failures with gcc 8.0.0\n>> to 8.3.0 due to (I believe) a gcc bug ([1]), and I haven't been able to\n>> find a suitable workaround. Debian 10 ships gcc 8.3.0, and it has LTS\n>> support until June 2024, making it an important target.\n>>\n>> I'm sure nobody but me will miss utils::defopt, so I'll get over it.\n> \n> I'm sorry :(\n> But happy gcc8.3 gets fixed\n> \n> Rafael, would you be able to test this and provide a tag ?\n> \n> For the series\n> Reviewed-by: Jacopo Mondi \n> \n> Thanks\n> j\n> \n>>\n>> [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86521\n>>\n>> Laurent Pinchart (2):\n>> ipa: rkisp1: Drop use of utils::defopt\n>> libcamera: base: utils: Drop defopt\n>>\n>> include/libcamera/base/utils.h | 14 --------\n>> src/ipa/rkisp1/algorithms/dpf.cpp | 6 ++--\n>> src/ipa/rkisp1/algorithms/gsl.cpp | 8 ++---\n>> src/ipa/rkisp1/algorithms/lsc.cpp | 4 +--\n>> src/libcamera/base/utils.cpp | 21 ------------\n>> test/utils.cpp | 53 -------------------------------\n>> 6 files changed, 9 insertions(+), 97 deletions(-)\n>>\n>>\n>> base-commit: 4bf68fdbe1493e57118dad4e94c2a46c50a9c402\n>> --\n>> Regards,\n>>\n>> Laurent Pinchart\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 096CEBD16B\n\tfor ;\n\tMon, 10 Oct 2022 08:55:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 50D2262D54;\n\tMon, 10 Oct 2022 10:55:09 +0200 (CEST)","from mx0.riseup.net (mx0.riseup.net [198.252.153.6])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8AD9C60485\n\tfor ;\n\tMon, 10 Oct 2022 10:55:07 +0200 (CEST)","from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256\n\tclient-signature RSA-PSS (2048 bits) client-digest SHA256)\n\t(Client CN \"mail.riseup.net\", Issuer \"R3\" (not verified))\n\tby mx0.riseup.net (Postfix) with ESMTPS id 4MmCRF5DbGz9s1T;\n\tMon, 10 Oct 2022 08:55:05 +0000 (UTC)","from [127.0.0.1] (localhost [127.0.0.1])\n\tby fews1.riseup.net (Postfix) with ESMTPSA id 4MmCRD4pm3z5vMx;\n\tMon, 10 Oct 2022 08:55:04 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1665392109;\n\tbh=yVXAbCV5nIfxSSzD5RkWimTWRCHQUndIXDUnYfb8pj4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=a7fSHa+mjsl8Ln3dvdSM6zCxnNH21EAIKsfPVok57tlCDaDgLsuJ8Mu9Dwb/PBG0D\n\t70jLazUtZNqPvE9iz9LOzraR0X/llHXlE9qWYDv5/9T6Ddn1Ux3F3AKDX5xyNQQese\n\t2RSQH98GYbwCN/IavVUF8UW/WjQxVlGC9wRQzprG4xOQf44G6ILkw6OlZsyQQJnd8r\n\t2bST8TrlavdrfVKrGnyRBI+LTKR0jskzc5FzzG1kMvsYtiB/o3EE+n87Vnp6+nKRxB\n\tFyIgGbsqaj8q9v3GyXakJeW2wpdbO7ewxl4jNzSci1/mt885orBtA8rtojDGcmuz7g\n\tLSAPLrSaEIplg==","v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; \n\tt=1665392105; bh=yVXAbCV5nIfxSSzD5RkWimTWRCHQUndIXDUnYfb8pj4=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=pn+9ivB2559/osDgceibghlKvN2hCpd6lu4IK4CwXglNiMPQFSmFZy9iXaxRrOfif\n\td/I5gkfh5+yuOejO9jRB7Ko2csicx6jy1VSDnQ6X7+cArMtwvwYXCe/ocf+N+mKsBf\n\t6Ca/+NPy/S/nf2fLnmhLukpwoHQ0VCWPeYE+C590="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=riseup.net\n\theader.i=@riseup.net header.b=\"pn+9ivB2\"; \n\tdkim-atps=neutral","X-Riseup-User-ID":"F8B5C43FABA5BAC385CF1FF7C56BBBA1C61585290818BAA7034A413D41EB4EA1","Message-ID":"<835a5cb7-0920-9764-1dbe-495cf7098b5f@riseup.net>","Date":"Mon, 10 Oct 2022 11:54:57 +0300","MIME-Version":"1.0","Content-Language":"en-US","To":"Jacopo Mondi ,\n\tLaurent Pinchart ","References":"<20221009044440.21499-1-laurent.pinchart@ideasonboard.com>\n\t<20221010083649.ip4hdklmt27iwq6r@uno.localdomain>","In-Reply-To":"<20221010083649.ip4hdklmt27iwq6r@uno.localdomain>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"------------f78GLTpJmolcoqRwgSwcZtFU\"","Subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Fix compilation with\n\tgcc 8.3.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Rafael Diniz via libcamera-devel ","Reply-To":"Rafael Diniz ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25365,"web_url":"https://patchwork.libcamera.org/comment/25365/","msgid":"","date":"2022-10-10T09:04:51","subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Fix compilation with\n\tgcc 8.3.0","submitter":{"id":128,"url":"https://patchwork.libcamera.org/api/people/128/","name":"Rafael Diniz","email":"rafael@riseup.net"},"content":"Btw, this was not committed to master yet, right? Last commit I see is 3 \ndays old.\n\nRafael\n\nOn 10/10/22 11:36, Jacopo Mondi wrote:\n> Hi Laurent\n> \n> On Sun, Oct 09, 2022 at 07:44:38AM +0300, Laurent Pinchart via libcamera-devel wrote:\n>> Hello,\n>>\n>> It is with great sadness that I have to announce the removal of\n>> utils::defopt. This feature causes compilation failures with gcc 8.0.0\n>> to 8.3.0 due to (I believe) a gcc bug ([1]), and I haven't been able to\n>> find a suitable workaround. Debian 10 ships gcc 8.3.0, and it has LTS\n>> support until June 2024, making it an important target.\n>>\n>> I'm sure nobody but me will miss utils::defopt, so I'll get over it.\n> \n> I'm sorry :(\n> But happy gcc8.3 gets fixed\n> \n> Rafael, would you be able to test this and provide a tag ?\n> \n> For the series\n> Reviewed-by: Jacopo Mondi \n> \n> Thanks\n> j\n> \n>>\n>> [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86521\n>>\n>> Laurent Pinchart (2):\n>> ipa: rkisp1: Drop use of utils::defopt\n>> libcamera: base: utils: Drop defopt\n>>\n>> include/libcamera/base/utils.h | 14 --------\n>> src/ipa/rkisp1/algorithms/dpf.cpp | 6 ++--\n>> src/ipa/rkisp1/algorithms/gsl.cpp | 8 ++---\n>> src/ipa/rkisp1/algorithms/lsc.cpp | 4 +--\n>> src/libcamera/base/utils.cpp | 21 ------------\n>> test/utils.cpp | 53 -------------------------------\n>> 6 files changed, 9 insertions(+), 97 deletions(-)\n>>\n>>\n>> base-commit: 4bf68fdbe1493e57118dad4e94c2a46c50a9c402\n>> --\n>> Regards,\n>>\n>> Laurent Pinchart\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5DC45C0DA4\n\tfor ;\n\tMon, 10 Oct 2022 09:05:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B27E662D54;\n\tMon, 10 Oct 2022 11:05:02 +0200 (CEST)","from mx1.riseup.net (mx1.riseup.net [198.252.153.129])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 953D660485\n\tfor ;\n\tMon, 10 Oct 2022 11:05:01 +0200 (CEST)","from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256\n\tclient-signature RSA-PSS (2048 bits) client-digest SHA256)\n\t(Client CN \"mail.riseup.net\", Issuer \"R3\" (not verified))\n\tby mx1.riseup.net (Postfix) with ESMTPS id 4MmCfg6wnjzDqJt;\n\tMon, 10 Oct 2022 09:04:59 +0000 (UTC)","from [127.0.0.1] (localhost [127.0.0.1])\n\tby fews1.riseup.net (Postfix) with ESMTPSA id 4MmCff6mWtz5vNH;\n\tMon, 10 Oct 2022 09:04:58 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1665392702;\n\tbh=O7dox5ANuS9zMoSYRLaaJmjuUgzw06iBS58eU5T3v5g=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Y5xumebfKMAU7ZkOFWzee+d7vJ5scTFR0L5yX2LOGwOzz3/PKU+yJv+MWKEpbcNzM\n\tS7vW56CROr+PJvtgG38SX/RSDDZBMe8i8Itdg0BAt2jX/LWSIxWO0+n9jWq5i581CI\n\tR5aGOrEDobl3c8i3Qp6HYjYVjAV4QIpbta67KMonUEyMOQNDgyhhXSG2x4PbserFSB\n\tR+1CzeqlSDQTG9Z1S3WlFfBXuTP4AMGCINYtZlHT5EGOrLDIEU+TIfapF9zAweSiD8\n\t4lg2IZecM9HCVUcfB7x60p5Lbc2pty41CyOWXr2zfUENyuCyI7TBWa2Jh0hmy0hlbv\n\tsJFp7AOJtq6GA==","v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; \n\tt=1665392700; bh=O7dox5ANuS9zMoSYRLaaJmjuUgzw06iBS58eU5T3v5g=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=ax3SvBB7PrPZpSIRGrb7e2ijEsBDqDasjyirTUdeq0XeubGueNF/6d2EW6D3gn4rk\n\t4RJbZCyyJz1doP/iFRPXVVE3OG9W2EFw4wc5xS6VjHYYmbhrOOzvAX7CSWeM5FbanX\n\tGumF4Pe5228t7ZzcrgPzJwtj4NobaAqA81xgAekk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=riseup.net\n\theader.i=@riseup.net header.b=\"ax3SvBB7\"; \n\tdkim-atps=neutral","X-Riseup-User-ID":"0CAB7C5C1BC4CE6B95E4E9DFC8879FB6E861A8272B67BD2D63D8723FE1C6057C","Message-ID":"","Date":"Mon, 10 Oct 2022 12:04:51 +0300","MIME-Version":"1.0","Content-Language":"en-US","To":"Jacopo Mondi ,\n\tLaurent Pinchart ","References":"<20221009044440.21499-1-laurent.pinchart@ideasonboard.com>\n\t<20221010083649.ip4hdklmt27iwq6r@uno.localdomain>","In-Reply-To":"<20221010083649.ip4hdklmt27iwq6r@uno.localdomain>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"------------Y6M2aPnb8tJhXWJqvC6m3PGC\"","Subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Fix compilation with\n\tgcc 8.3.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Rafael Diniz via libcamera-devel ","Reply-To":"Rafael Diniz ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25366,"web_url":"https://patchwork.libcamera.org/comment/25366/","msgid":"<20221010092717.m76yhaz2l2caba6j@uno.localdomain>","date":"2022-10-10T09:27:17","subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Fix compilation with\n\tgcc 8.3.0","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Rafal\n\nOn Mon, Oct 10, 2022 at 12:04:51PM +0300, Rafael Diniz wrote:\n> Btw, this was not committed to master yet, right? Last commit I see is 3\n> days old.\n\nNo it's not, it's still in active review/testing.\nThat's why I asked if you can give it a go ;)\n\n>\n> Rafael\n>\n> On 10/10/22 11:36, Jacopo Mondi wrote:\n> > Hi Laurent\n> >\n> > On Sun, Oct 09, 2022 at 07:44:38AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> > > Hello,\n> > >\n> > > It is with great sadness that I have to announce the removal of\n> > > utils::defopt. This feature causes compilation failures with gcc 8.0.0\n> > > to 8.3.0 due to (I believe) a gcc bug ([1]), and I haven't been able to\n> > > find a suitable workaround. Debian 10 ships gcc 8.3.0, and it has LTS\n> > > support until June 2024, making it an important target.\n> > >\n> > > I'm sure nobody but me will miss utils::defopt, so I'll get over it.\n> >\n> > I'm sorry :(\n> > But happy gcc8.3 gets fixed\n> >\n> > Rafael, would you be able to test this and provide a tag ?\n> >\n> > For the series\n> > Reviewed-by: Jacopo Mondi \n> >\n> > Thanks\n> > j\n> >\n> > >\n> > > [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86521\n> > >\n> > > Laurent Pinchart (2):\n> > > ipa: rkisp1: Drop use of utils::defopt\n> > > libcamera: base: utils: Drop defopt\n> > >\n> > > include/libcamera/base/utils.h | 14 --------\n> > > src/ipa/rkisp1/algorithms/dpf.cpp | 6 ++--\n> > > src/ipa/rkisp1/algorithms/gsl.cpp | 8 ++---\n> > > src/ipa/rkisp1/algorithms/lsc.cpp | 4 +--\n> > > src/libcamera/base/utils.cpp | 21 ------------\n> > > test/utils.cpp | 53 -------------------------------\n> > > 6 files changed, 9 insertions(+), 97 deletions(-)\n> > >\n> > >\n> > > base-commit: 4bf68fdbe1493e57118dad4e94c2a46c50a9c402\n> > > --\n> > > Regards,\n> > >\n> > > Laurent Pinchart\n> > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1999FC0DA4\n\tfor ;\n\tMon, 10 Oct 2022 09:27:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 56AD162D57;\n\tMon, 10 Oct 2022 11:27:21 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::224])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9469D60485\n\tfor ;\n\tMon, 10 Oct 2022 11:27:20 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 798E3E0014;\n\tMon, 10 Oct 2022 09:27:18 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1665394041;\n\tbh=JliVrGJ/vb5Rt0RQ9/lnBTQIWFVedcYNF0nxV5RS9yE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=0bYKdNIEEgI/cCN/khKKsYq/Et848un13Bvt5sXnJzbD8khNbs0/wsylmjF4vcZOg\n\txJVbj84uG3IGpRGp6r7IXUvsC4Mw5291TvaARPKdB53DGKJU6fhoZ+lKc3o8UnQ9oP\n\tBOnhx2eeB8bEqA7gBsaE7cVFswyJA51zLjsVZZLdSmSnm7mpXservoVtQIKWiB0HpZ\n\t8kRWVsglwgAez5jAcMlybS8KtJMMiMv0gBZA6L+1x/N20WiP2ZPyQVGz2uYcvg7WYc\n\tRNyuGtF+Y1EQ/ZZZGrlB8/4nDJEZYSo8TEvAdtxkewXtfHyR7/w853016DPWZH9LYZ\n\tv8YOtpWpIyLTA==","Date":"Mon, 10 Oct 2022 11:27:17 +0200","To":"Rafael Diniz ","Message-ID":"<20221010092717.m76yhaz2l2caba6j@uno.localdomain>","References":"<20221009044440.21499-1-laurent.pinchart@ideasonboard.com>\n\t<20221010083649.ip4hdklmt27iwq6r@uno.localdomain>\n\t","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"pwceghojlqfcro77\"","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Fix compilation with\n\tgcc 8.3.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25373,"web_url":"https://patchwork.libcamera.org/comment/25373/","msgid":"<166540852682.3760285.14930245249590934841@Monstersaurus>","date":"2022-10-10T13:28:46","subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Fix compilation with\n\tgcc 8.3.0","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi via libcamera-devel (2022-10-10 09:36:49)\n> Hi Laurent\n> \n> On Sun, Oct 09, 2022 at 07:44:38AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> > Hello,\n> >\n> > It is with great sadness that I have to announce the removal of\n> > utils::defopt. This feature causes compilation failures with gcc 8.0.0\n> > to 8.3.0 due to (I believe) a gcc bug ([1]), and I haven't been able to\n> > find a suitable workaround. Debian 10 ships gcc 8.3.0, and it has LTS\n> > support until June 2024, making it an important target.\n> >\n> > I'm sure nobody but me will miss utils::defopt, so I'll get over it.\n> \n> I'm sorry :(\n> But happy gcc8.3 gets fixed\n\nSeeing it go, I can see some of it's benefits. ... but I agree removing\nit will help fix things for now.\n\nSeems like we should note somewhere that we might want to re-introduce\nthis when we bump our minimum gcc version - but I'm not sure of where\nwould be suitable.\n\n\n> Rafael, would you be able to test this and provide a tag ?\n> \n\nWorth waiting for this still but:\n\n\nReviewed-by: Kieran Bingham \n\n> For the series\n> Reviewed-by: Jacopo Mondi \n> \n> Thanks\n> j\n> \n> >\n> > [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86521\n> >\n> > Laurent Pinchart (2):\n> > ipa: rkisp1: Drop use of utils::defopt\n> > libcamera: base: utils: Drop defopt\n> >\n> > include/libcamera/base/utils.h | 14 --------\n> > src/ipa/rkisp1/algorithms/dpf.cpp | 6 ++--\n> > src/ipa/rkisp1/algorithms/gsl.cpp | 8 ++---\n> > src/ipa/rkisp1/algorithms/lsc.cpp | 4 +--\n> > src/libcamera/base/utils.cpp | 21 ------------\n> > test/utils.cpp | 53 -------------------------------\n> > 6 files changed, 9 insertions(+), 97 deletions(-)\n> >\n> >\n> > base-commit: 4bf68fdbe1493e57118dad4e94c2a46c50a9c402\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DF466BD16B\n\tfor ;\n\tMon, 10 Oct 2022 13:28:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3F18962D63;\n\tMon, 10 Oct 2022 15:28:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 89C1A62272\n\tfor ;\n\tMon, 10 Oct 2022 15:28:49 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E47C6BB0;\n\tMon, 10 Oct 2022 15:28:48 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1665408531;\n\tbh=E/gQSUJspJNQUzWqy8tteNq3+dCch05sQRJPFzufLWc=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=H9rTZwDdZHHU9T/F/otgwA2bcoP/6AQgujE4PBFJ4f5jM8nYpfuAKD+qqqaqvjA/h\n\tdxu3jfIylp1QACXKJxB65Cz3cUbByMwrp4fG702xO00142X82P38lbMxHHaVDwL47L\n\toZPUF8kUTPjF78aT/VuZr0Quk56XwrK/u4UsRsuHdmjNU3N9T5A6FwGm2foJ8yroLU\n\te7Sph6dIbcEAg+DZCMa/jtJhWf90YlPmF44nv4ce9ZF0tse4k0HDuxcgbkrJVVcaA2\n\tf3nwfUfym30ORbEPxPeUIdNcAhAn8p/eoFgWbp88pLjclEUNo+fIMpgZT+7hPYT3eX\n\tzo611qS4ZBVhQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1665408529;\n\tbh=E/gQSUJspJNQUzWqy8tteNq3+dCch05sQRJPFzufLWc=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=gWwJM5ZS5xThJWy9y02GUNCnV63cu1Cn4Y0iWlU7HKe7y+zaL/Q/p/QSxfeK2f1kl\n\tmtboKyShE9qxFEwVhWlENZtJ168TQD87edbtuRcd9yzfOUmtJxOH1rUtdel0GtfVBq\n\tjbVzwdmEXqpJGN/YNUDKmmI3OY94M16IrQdtzmJM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"gWwJM5ZS\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20221010083649.ip4hdklmt27iwq6r@uno.localdomain>","References":"<20221009044440.21499-1-laurent.pinchart@ideasonboard.com>\n\t<20221010083649.ip4hdklmt27iwq6r@uno.localdomain>","To":"Jacopo Mondi , Jacopo Mondi via libcamera-devel\n\t, \n\tLaurent Pinchart ","Date":"Mon, 10 Oct 2022 14:28:46 +0100","Message-ID":"<166540852682.3760285.14930245249590934841@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Fix compilation with\n\tgcc 8.3.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25375,"web_url":"https://patchwork.libcamera.org/comment/25375/","msgid":"","date":"2022-10-10T13:47:14","subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Fix compilation with\n\tgcc 8.3.0","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, Oct 10, 2022 at 02:28:46PM +0100, Kieran Bingham wrote:\n> Quoting Jacopo Mondi via libcamera-devel (2022-10-10 09:36:49)\n> > On Sun, Oct 09, 2022 at 07:44:38AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> > > Hello,\n> > >\n> > > It is with great sadness that I have to announce the removal of\n> > > utils::defopt. This feature causes compilation failures with gcc 8.0.0\n> > > to 8.3.0 due to (I believe) a gcc bug ([1]), and I haven't been able to\n> > > find a suitable workaround. Debian 10 ships gcc 8.3.0, and it has LTS\n> > > support until June 2024, making it an important target.\n> > >\n> > > I'm sure nobody but me will miss utils::defopt, so I'll get over it.\n> > \n> > I'm sorry :(\n> > But happy gcc8.3 gets fixed\n> \n> Seeing it go, I can see some of it's benefits. ... but I agree removing\n> it will help fix things for now.\n> \n> Seems like we should note somewhere that we might want to re-introduce\n> this when we bump our minimum gcc version - but I'm not sure of where\n> would be suitable.\n\nMaybe in a bugzilla entry ?\n\nI considered keeping the implementation of defopt in utils.h and\nutils.cpp, with a comment to tell it shouldn't be used for now, but I\ndon't really like carrying dead code.\n\n> > Rafael, would you be able to test this and provide a tag ?\n> \n> Worth waiting for this still but:\n> \n> \n> Reviewed-by: Kieran Bingham \n> \n> > For the series\n> > Reviewed-by: Jacopo Mondi \n> > \n> > Thanks\n> > j\n> > \n> > >\n> > > [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86521\n> > >\n> > > Laurent Pinchart (2):\n> > > ipa: rkisp1: Drop use of utils::defopt\n> > > libcamera: base: utils: Drop defopt\n> > >\n> > > include/libcamera/base/utils.h | 14 --------\n> > > src/ipa/rkisp1/algorithms/dpf.cpp | 6 ++--\n> > > src/ipa/rkisp1/algorithms/gsl.cpp | 8 ++---\n> > > src/ipa/rkisp1/algorithms/lsc.cpp | 4 +--\n> > > src/libcamera/base/utils.cpp | 21 ------------\n> > > test/utils.cpp | 53 -------------------------------\n> > > 6 files changed, 9 insertions(+), 97 deletions(-)\n> > >\n> > >\n> > > base-commit: 4bf68fdbe1493e57118dad4e94c2a46c50a9c402","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 76677C0DA4\n\tfor ;\n\tMon, 10 Oct 2022 13:47:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C714D62D65;\n\tMon, 10 Oct 2022 15:47:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5063E62D5F\n\tfor ;\n\tMon, 10 Oct 2022 15:47:21 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F4F5BB0;\n\tMon, 10 Oct 2022 15:47:20 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1665409642;\n\tbh=SpfYdvKzqYRbdb47EgOH4FV4HuB9hLayH51lj9lzCMU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=RNDMjLF4YwPBre2ltdTZLTffQy/RCEFVTjDVUyE1ybeImKA71Myeka4f1BMC9BCTa\n\tgKF5qEpv6pvewekZMkT2IRIh55MVPRG2HNj9bJ5bBKzH2Ic5GRzEJqfLwBnCq68Dv6\n\tPgpjJYyVmDrUjE2Ev0/xjS+uWDHYDKFcdHfTtmSa/42DqHFYQidVEEls2KY2xwvP37\n\twSLkVV3P7lX5AQXWFUTHYPXBW407r6ZNNpjcKDfoWoz5q4NTiswebkx9KhixSQ8Jm3\n\tJBKAJKX1wZM5wkzLhFu8tbAF/bTnog/fpYAZs1dJVONNf1CkBkWEBuHAgJwTWI9vok\n\tNyWysypThAJ+w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1665409640;\n\tbh=SpfYdvKzqYRbdb47EgOH4FV4HuB9hLayH51lj9lzCMU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WTPLCvCZbPYXzDpxF5snZV8JqQedSmp7CslseOQbHjZ81TjyRAm26+PaSWi58B1q4\n\taU781QE0pjeHAZ44fjKAsVYWXXgd2Uzcm1mg+UQt/KUO5i/Buc6cM1azmVLtHyYxI+\n\tO/8RIKDSO8s03eNzEyI5gYjfReC3tRgRq7uW3mGo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"WTPLCvCZ\"; dkim-atps=neutral","Date":"Mon, 10 Oct 2022 16:47:14 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20221009044440.21499-1-laurent.pinchart@ideasonboard.com>\n\t<20221010083649.ip4hdklmt27iwq6r@uno.localdomain>\n\t<166540852682.3760285.14930245249590934841@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<166540852682.3760285.14930245249590934841@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Fix compilation with\n\tgcc 8.3.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Jacopo Mondi via libcamera-devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25378,"web_url":"https://patchwork.libcamera.org/comment/25378/","msgid":"<166541688420.3760285.15873495816724021929@Monstersaurus>","date":"2022-10-10T15:48:04","subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Fix compilation with\n\tgcc 8.3.0","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2022-10-10 14:47:14)\n> Hi Kieran,\n> \n> On Mon, Oct 10, 2022 at 02:28:46PM +0100, Kieran Bingham wrote:\n> > Quoting Jacopo Mondi via libcamera-devel (2022-10-10 09:36:49)\n> > > On Sun, Oct 09, 2022 at 07:44:38AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> > > > Hello,\n> > > >\n> > > > It is with great sadness that I have to announce the removal of\n> > > > utils::defopt. This feature causes compilation failures with gcc 8.0.0\n> > > > to 8.3.0 due to (I believe) a gcc bug ([1]), and I haven't been able to\n> > > > find a suitable workaround. Debian 10 ships gcc 8.3.0, and it has LTS\n> > > > support until June 2024, making it an important target.\n> > > >\n> > > > I'm sure nobody but me will miss utils::defopt, so I'll get over it.\n> > > \n> > > I'm sorry :(\n> > > But happy gcc8.3 gets fixed\n> > \n> > Seeing it go, I can see some of it's benefits. ... but I agree removing\n> > it will help fix things for now.\n> > \n> > Seems like we should note somewhere that we might want to re-introduce\n> > this when we bump our minimum gcc version - but I'm not sure of where\n> > would be suitable.\n> \n> Maybe in a bugzilla entry ?\n> \n> I considered keeping the implementation of defopt in utils.h and\n> utils.cpp, with a comment to tell it shouldn't be used for now, but I\n> don't really like carrying dead code.\n> \n> > > Rafael, would you be able to test this and provide a tag ?\n> > \n> > Worth waiting for this still but:\n\nI'm afraid I have inadvertently merged this... though I intended to wait\nfor tested by tags here.\n\nStill, that makes it easy to test, just update to the latest!\n\n--\nKieran\n\n\n> > \n> > \n> > Reviewed-by: Kieran Bingham \n> > \n> > > For the series\n> > > Reviewed-by: Jacopo Mondi \n> > > \n> > > Thanks\n> > > j\n> > > \n> > > >\n> > > > [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86521\n> > > >\n> > > > Laurent Pinchart (2):\n> > > > ipa: rkisp1: Drop use of utils::defopt\n> > > > libcamera: base: utils: Drop defopt\n> > > >\n> > > > include/libcamera/base/utils.h | 14 --------\n> > > > src/ipa/rkisp1/algorithms/dpf.cpp | 6 ++--\n> > > > src/ipa/rkisp1/algorithms/gsl.cpp | 8 ++---\n> > > > src/ipa/rkisp1/algorithms/lsc.cpp | 4 +--\n> > > > src/libcamera/base/utils.cpp | 21 ------------\n> > > > test/utils.cpp | 53 -------------------------------\n> > > > 6 files changed, 9 insertions(+), 97 deletions(-)\n> > > >\n> > > >\n> > > > base-commit: 4bf68fdbe1493e57118dad4e94c2a46c50a9c402\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA5F6BD16B\n\tfor ;\n\tMon, 10 Oct 2022 15:48:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 304D862D69;\n\tMon, 10 Oct 2022 17:48:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 65A8862272\n\tfor ;\n\tMon, 10 Oct 2022 17:48:06 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D7D75BB0;\n\tMon, 10 Oct 2022 17:48:05 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1665416888;\n\tbh=kbsryyk7rNnzU/5VF3gNbUCm43H5g6U6E8tbVioE+V8=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=CJVz+kurXVoEELLCZC3Kq1jdyh/au6Czynt+Xgrd5S3vh0WpfkJmPxwrkguAT5ZbH\n\tfHwOM+VgqCAi+i9H3D2TIabqOVG1iHu+lNk3YhA1oxoidoRwMyBqm3nYY1bGiefk4/\n\tXZ3pX2LLNXXogShxWiWDSf/1qE2NyWLkAP/a+BkTF9hhaerIq9NOUp94oZqu+Kqh4y\n\tdSVZK/RqCkwIbItXfohI/7+xiaq6LsDgveqOZZTEgi5EqFN1conMYNB3BsQktzDwjp\n\tEIeC349RAdDtcdeN9+XJFlYFXNxlQXsFQWlEAGeBq3K6jQuWZCD/iMSd/AVxSoRtgN\n\tkk8sxjQFL0w1A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1665416886;\n\tbh=kbsryyk7rNnzU/5VF3gNbUCm43H5g6U6E8tbVioE+V8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=VX4YMWYFQ2T1I54SjK14F7NKMj3LSdsAUG7X4ziUfWpaX1fxwdLYURwo/8nmETyB7\n\tiBiisHzKN69XB8qcYmtlejhNFUtheQHfProx/ok4M/BnBxgRkKIXCSQBhzcl7wmA6V\n\t9PttVUi3E9NLm3rOzZFG09qh5DHBwCO2U6sR6jeE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VX4YMWYF\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20221009044440.21499-1-laurent.pinchart@ideasonboard.com>\n\t<20221010083649.ip4hdklmt27iwq6r@uno.localdomain>\n\t<166540852682.3760285.14930245249590934841@Monstersaurus>\n\t","To":"Laurent Pinchart ","Date":"Mon, 10 Oct 2022 16:48:04 +0100","Message-ID":"<166541688420.3760285.15873495816724021929@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Fix compilation with\n\tgcc 8.3.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Jacopo Mondi via libcamera-devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25379,"web_url":"https://patchwork.libcamera.org/comment/25379/","msgid":"<1cf35c77-3611-23ed-ea92-13c93a70fc07@riseup.net>","date":"2022-10-11T07:42:03","subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Fix compilation with\n\tgcc 8.3.0","submitter":{"id":128,"url":"https://patchwork.libcamera.org/api/people/128/","name":"Rafael Diniz","email":"rafael@riseup.net"},"content":"All good. Compilation works again on Debian 10.\n\ntks!\n\nRafael\n\nOn 10/10/22 18:48, Kieran Bingham via libcamera-devel wrote:\n> Quoting Laurent Pinchart (2022-10-10 14:47:14)\n>> Hi Kieran,\n>>\n>> On Mon, Oct 10, 2022 at 02:28:46PM +0100, Kieran Bingham wrote:\n>>> Quoting Jacopo Mondi via libcamera-devel (2022-10-10 09:36:49)\n>>>> On Sun, Oct 09, 2022 at 07:44:38AM +0300, Laurent Pinchart via libcamera-devel wrote:\n>>>>> Hello,\n>>>>>\n>>>>> It is with great sadness that I have to announce the removal of\n>>>>> utils::defopt. This feature causes compilation failures with gcc 8.0.0\n>>>>> to 8.3.0 due to (I believe) a gcc bug ([1]), and I haven't been able to\n>>>>> find a suitable workaround. Debian 10 ships gcc 8.3.0, and it has LTS\n>>>>> support until June 2024, making it an important target.\n>>>>>\n>>>>> I'm sure nobody but me will miss utils::defopt, so I'll get over it.\n>>>>\n>>>> I'm sorry :(\n>>>> But happy gcc8.3 gets fixed\n>>>\n>>> Seeing it go, I can see some of it's benefits. ... but I agree removing\n>>> it will help fix things for now.\n>>>\n>>> Seems like we should note somewhere that we might want to re-introduce\n>>> this when we bump our minimum gcc version - but I'm not sure of where\n>>> would be suitable.\n>>\n>> Maybe in a bugzilla entry ?\n>>\n>> I considered keeping the implementation of defopt in utils.h and\n>> utils.cpp, with a comment to tell it shouldn't be used for now, but I\n>> don't really like carrying dead code.\n>>\n>>>> Rafael, would you be able to test this and provide a tag ?\n>>>\n>>> Worth waiting for this still but:\n> \n> I'm afraid I have inadvertently merged this... though I intended to wait\n> for tested by tags here.\n> \n> Still, that makes it easy to test, just update to the latest!\n> \n> --\n> Kieran\n> \n> \n>>>\n>>>\n>>> Reviewed-by: Kieran Bingham \n>>>\n>>>> For the series\n>>>> Reviewed-by: Jacopo Mondi \n>>>>\n>>>> Thanks\n>>>> j\n>>>>\n>>>>>\n>>>>> [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86521\n>>>>>\n>>>>> Laurent Pinchart (2):\n>>>>> ipa: rkisp1: Drop use of utils::defopt\n>>>>> libcamera: base: utils: Drop defopt\n>>>>>\n>>>>> include/libcamera/base/utils.h | 14 --------\n>>>>> src/ipa/rkisp1/algorithms/dpf.cpp | 6 ++--\n>>>>> src/ipa/rkisp1/algorithms/gsl.cpp | 8 ++---\n>>>>> src/ipa/rkisp1/algorithms/lsc.cpp | 4 +--\n>>>>> src/libcamera/base/utils.cpp | 21 ------------\n>>>>> test/utils.cpp | 53 -------------------------------\n>>>>> 6 files changed, 9 insertions(+), 97 deletions(-)\n>>>>>\n>>>>>\n>>>>> base-commit: 4bf68fdbe1493e57118dad4e94c2a46c50a9c402\n>>\n>> -- \n>> Regards,\n>>\n>> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 014CFBD16B\n\tfor ;\n\tTue, 11 Oct 2022 07:42:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4DC0862D6E;\n\tTue, 11 Oct 2022 09:42:17 +0200 (CEST)","from mx0.riseup.net (mx0.riseup.net [198.252.153.6])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BD1FC603D7\n\tfor ;\n\tTue, 11 Oct 2022 09:42:14 +0200 (CEST)","from fews2.riseup.net (fews2-pn.riseup.net [10.0.1.84])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256\n\tclient-signature RSA-PSS (2048 bits) client-digest SHA256)\n\t(Client CN \"mail.riseup.net\", Issuer \"R3\" (not verified))\n\tby mx0.riseup.net (Postfix) with ESMTPS id 4Mmnmh5MM1z9s2H;\n\tTue, 11 Oct 2022 07:42:12 +0000 (UTC)","from [127.0.0.1] (localhost [127.0.0.1])\n\tby fews2.riseup.net (Postfix) with ESMTPSA id 4Mmnmg2L0Kz1yQc;\n\tTue, 11 Oct 2022 07:42:10 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1665474137;\n\tbh=96t+wrOMezZtfDI5npGcEPMb+fJp6fR/n4LxCAEgowE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=qMRr9t0/F7nQmWrEcY4Zq1qFIgvUbgwNoEatTZb2JksL4SU5/kZIlGVCXbB6L9vWP\n\tW0hb5I0gihr5hzcSwGzIUyGNRaGa+zxrD8w7gBE5cJRCSz+dduX8Cr7sHiiSgLL9bD\n\tbIX+8CSQj0AdvB6RYll1NU6DfBewRYo85tgQnMkI9Ci4W+YASynQQVTTgW+Vnxz228\n\twKSNc5Q2bL8Zp/VTs0A0pZ6amFPIKSjN975Gqqdie1Osgk5Gbzpau+c1xDkhTlvy/7\n\tqQy+hu6HaDDap9lBsL9ISPqNA7DWVz0OxbkzQAtYu9kdyTqJ1AKQfM75gf4UhjL7zN\n\tkuKXhNWqWXKbA==","v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; \n\tt=1665474132; bh=96t+wrOMezZtfDI5npGcEPMb+fJp6fR/n4LxCAEgowE=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=nakHx1xhT5/lY3OECxUL12O7zHsHWv+1XQBiHQe/Wc3/0LGgd4QrbeJ9Eu7n4HEuc\n\ti5/ZDtIaXo/ogQnV5LoMFAa3I9JzLnHiVTofNREL50Y1s1MtfUoFMuWDDp8UyDHbHk\n\tlav5WaCZVDxIMo+V3k5AWy+V2LdrrqXhfaBLLT+Y="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=riseup.net\n\theader.i=@riseup.net header.b=\"nakHx1xh\"; \n\tdkim-atps=neutral","X-Riseup-User-ID":"2233D7CFB3999CAD3EC01F3A2B2C10B964C4CFAB95ECC7775B810E6373854880","Message-ID":"<1cf35c77-3611-23ed-ea92-13c93a70fc07@riseup.net>","Date":"Tue, 11 Oct 2022 10:42:03 +0300","MIME-Version":"1.0","Content-Language":"en-US","To":"Kieran Bingham ,\n\tLaurent Pinchart ","References":"<20221009044440.21499-1-laurent.pinchart@ideasonboard.com>\n\t<20221010083649.ip4hdklmt27iwq6r@uno.localdomain>\n\t<166540852682.3760285.14930245249590934841@Monstersaurus>\n\t\n\t<166541688420.3760285.15873495816724021929@Monstersaurus>","In-Reply-To":"<166541688420.3760285.15873495816724021929@Monstersaurus>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"------------TB02dUzs5QU0Dn9peuPwAMnz\"","Subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: Fix compilation with\n\tgcc 8.3.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Rafael Diniz via libcamera-devel ","Reply-To":"Rafael Diniz ","Cc":"Jacopo Mondi via libcamera-devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]