[{"id":25239,"web_url":"https://patchwork.libcamera.org/comment/25239/","msgid":"","date":"2022-10-03T13:41:35","subject":"Re: [libcamera-devel] [PATCH v1 0/9] Raspberry Pi: Horizontal\n\tblanking control","submitter":{"id":27,"url":"https://patchwork.libcamera.org/api/people/27/","name":"Dave Stevenson","email":"dave.stevenson@raspberrypi.com"},"content":"On Mon, 3 Oct 2022 at 09:40, Naushir Patuck via libcamera-devel\n wrote:\n>\n> Hi,\n>\n> This series adds full automatic sensor horizontal blanking control (to compliment\n> the existing vertical blanking control) for exposure and/or frame duration calculations.\n>\n> In the new calculations, we always prioritise extending vblank until it reaches its\n> limits, then extend hblank to make up the shortfall. This is to minimise the \"wobble\"\n> effect of the rolling shutter in the sensor. The rkisp1 and ipu3 IPAs are updated\n> to use the minimum reported hblank value in their calculations for the same reason.\n>\n> Patches 1-2 adds a max line length field to the IPACameraSensorInfo and CameraMode structures.\n> Patchs 3-6 update the IPA and pipeline handler to pass around a current line length value.\n> Patches 7-8 update the calculations to return a hblank number to program in the sensor.\n> Patch 9 updates the embedded data parsers to extract current line length values.\n\nFor the series:\nTested-by: Dave Stevenson \n\n(on OV9281 using mainline ov9282 driver plus a set of patches I'm\nabout to send to linux-media)\n\n> Regards,\n> Naush\n>\n> Naushir Patuck (9):\n> camera_sensor: Add minimum and maximum line length to\n> IPACameraSensorInfo\n> ipa: raspberrypi: Add minimum and maximum line length fields to\n> CameraMode\n> ipa: raspberrypi: Pass lineLength into the CamHelper API\n> pipeline: ipa: raspberrypi: Add HBLANK control to DelayedControls\n> ipa: raspberrypi: Add pixel clock rate to the CameraMode structure\n> ipa: raspberrypi: Add line length to DeviceStatus\n> ipa: raspberrypi: Add line length calculations helper functions\n> ipa: raspberrypi: Allow full line length control\n> ipa: raspberrypi: Extract line length from the embedded data parser\n>\n> include/libcamera/ipa/core.mojom | 21 +++--\n> include/libcamera/ipa/raspberrypi.mojom | 1 +\n> src/ipa/ipu3/ipu3.cpp | 2 +-\n> src/ipa/raspberrypi/cam_helper.cpp | 81 ++++++++++++++-----\n> src/ipa/raspberrypi/cam_helper.h | 18 +++--\n> src/ipa/raspberrypi/cam_helper_imx219.cpp | 10 ++-\n> src/ipa/raspberrypi/cam_helper_imx290.cpp | 5 +-\n> src/ipa/raspberrypi/cam_helper_imx296.cpp | 10 ++-\n> src/ipa/raspberrypi/cam_helper_imx477.cpp | 39 +++++----\n> src/ipa/raspberrypi/cam_helper_imx519.cpp | 39 +++++----\n> src/ipa/raspberrypi/cam_helper_ov5647.cpp | 5 +-\n> src/ipa/raspberrypi/cam_helper_ov9281.cpp | 5 +-\n> src/ipa/raspberrypi/controller/camera_mode.h | 6 +-\n> .../raspberrypi/controller/device_status.cpp | 1 +\n> .../raspberrypi/controller/device_status.h | 4 +-\n> src/ipa/raspberrypi/raspberrypi.cpp | 61 ++++++++------\n> src/ipa/rkisp1/rkisp1.cpp | 2 +-\n> src/libcamera/camera_sensor.cpp | 6 +-\n> .../pipeline/raspberrypi/raspberrypi.cpp | 1 +\n> 19 files changed, 216 insertions(+), 101 deletions(-)\n>\n> --\n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6844FC0DA4\n\tfor ;\n\tMon, 3 Oct 2022 13:41:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BEEDE601BE;\n\tMon, 3 Oct 2022 15:41:52 +0200 (CEST)","from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com\n\t[IPv6:2a00:1450:4864:20::62f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8CFD6600E9\n\tfor ;\n\tMon, 3 Oct 2022 15:41:51 +0200 (CEST)","by mail-ej1-x62f.google.com with SMTP id nb11so22240307ejc.5\n\tfor ;\n\tMon, 03 Oct 2022 06:41:51 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664804512;\n\tbh=GYd72AjilLlbeyFv6zDyp0UcXkUhdqHIuyNwLK+SXG0=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=fe0Twyt4hfTr+6WUFzLEtVBnNv2lBa8KgIERhipmk2GHu7V2XOHjLEBdvMUa08+/W\n\tvC8qP9QguqkGFEwFmR8gXW+FR+3ENrxYfRvnIhnDrz98onJO4hpC0eTnXPt2f2YbbY\n\tZ0oQEdZ8qtuT4D9ae6G4I4Y24nSe4mnygfOH93apBIm7DfWJgsP1ck/eJfw/UxAiaf\n\tMTR3AOTkGErDS8xajOP6y9CuB8dz7gYJFV7/TRXsJG7IoDpQzDC+87GxDQUJYL2ADJ\n\tQriOQM3G6W1m92NxRB65UwD1fagtUkqUa14A0RWHqQAlP98gdAtGandPvs7XJrKwoj\n\t6tRIBfp/GroIA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date;\n\tbh=NxrgICWmlnHkBqclXI1a4MM8RenDIhwJZoxQ+yjD6ro=;\n\tb=IU9jCgXY6KpZzlQzx8NHkhDr4tKtL1yiMB5i9A1LNHWP4Pf2KnpTwg2HFnD31bW8Ok\n\tj1wra3A/c2eMqfxtbS++AjloR9JtflXtdIDeuIXqRNIFnES9wuwiUQxOoNWthAALC/Jp\n\tjZUXh40GJjBmJSqZzrudhAtqLZnTMl/4dCWjgQP8Z69X9/m5YYsoZOqaOVvQGIHoivHG\n\tOdHgtyPAbYnfzRSa+gTtm4AADnVhOiXNZLRGLqPCXYfe/6XQsgnCMUOxQMW4mgZpaV/n\n\tKhSqaTYRdl7wl4PPqJ6saYya9kl59iD/ev5rXkn80DjGM6CtJ6sUrYodmRB2NpDlXYZn\n\tHvAg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"IU9jCgXY\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date;\n\tbh=NxrgICWmlnHkBqclXI1a4MM8RenDIhwJZoxQ+yjD6ro=;\n\tb=BQZ83Nq5UsREVuGIauPuTAcX2D5nXMt/Pel+sRA6NXH6rrt7HE86hngsk9wOJcHZHS\n\tKOZvhcresG6Hc2CLiIYhiIg+WqbYHHp9FUEO/DVd91BmxVEqhqQY6ATB4PZkj8IDMGML\n\t0pEoq5man0iXb7UsgR/dMr2VwrF1FNvrYWSMY7KkJbhBQeAIv7m0FyF8uaH8bG1l4ymy\n\txPFpiHOW23hQI9Hfl/s80JVz9058uNG13H764Az5Y815NnRnGxEwyCuSotvVuJgQ2+f2\n\t7CiyzeNWT7lhybxDMMbqwDZ5V15WYbnNP7RLNOdp+GISnYz3+OaHounCUiyxtiQ83sH/\n\teiow==","X-Gm-Message-State":"ACrzQf086vuYDZu6/wmGM5ORcAowY+xsaFPOWi4o8WiQg4HYq42lZbGy\n\thvzxLaAmx0nqe7yLoxOYV1k+G5yFGl1Kl9rI2JNhKvCDv9A=","X-Google-Smtp-Source":"AMsMyM6AQObBMVk19rHIVWuJHPNbE2WspvUXL725WXZztFiIqFCfOq6SfhuTBSpRAeELVizrD2B8yHv1PM+GQkc5+AA=","X-Received":"by 2002:a17:907:d15:b0:781:e347:723 with SMTP id\n\tgn21-20020a1709070d1500b00781e3470723mr14930514ejc.723.1664804511166;\n\tMon, 03 Oct 2022 06:41:51 -0700 (PDT)","MIME-Version":"1.0","References":"<20221003083934.31629-1-naush@raspberrypi.com>","In-Reply-To":"<20221003083934.31629-1-naush@raspberrypi.com>","Date":"Mon, 3 Oct 2022 14:41:35 +0100","Message-ID":"","To":"Naushir Patuck ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v1 0/9] Raspberry Pi: Horizontal\n\tblanking control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Dave Stevenson via libcamera-devel\n\t","Reply-To":"Dave Stevenson ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]